firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,180 Commits 1 Branch 0 Tags
Commit Graph

19869 Commits

Author SHA1 Message Date
hangyu
0e57147db1
nav drawer (#115668) 2022-11-18 15:10:05 -08:00
chunhtai
01c1e8e587
Allows pushing page based route as pageless route (#114362) 
* Allows pushing page based route as pageless route

* update
 2022-11-18 14:38:50 -08:00
Bernardo Ferrari
d2e6dfefa5
Fix formatting in BottomAppBar test (#115520) 
This PR made a few mistakes on formatting: https://github.com/flutter/flutter/pull/115175
 2022-11-18 21:15:26 +00:00
Bruno Leroux
2cb2e84a39
Add more InkWell tests (#115634) 
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
 2022-11-18 20:12:19 +00:00
fzyzcjy
98077617bb
Tiny improvement of RouteSettings display (#114481) 
* impl

* Update packages/flutter/lib/src/widgets/navigator.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

* Update navigator_test.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
 2022-11-18 19:38:10 +00:00
Christopher Fujino
459391708e
[flutter_tools] Pin package:archive and manual roll (#115662) 
* add package:archive to pins

* roll
 2022-11-18 19:28:10 +00:00
Taha Tesser
ca78327402
Fix NavigationBar ripple (#115499) 
* Fix `NavigationBar` ripple

* remove unused import
 2022-11-18 18:47:17 +00:00
chunhtai
3a3a0db13e
Disallow dispose during listener callback (#114530) 
* Disallow dispose during listener callback

* addressing comment

* add comments to code

* Addressing comments

* fix test
 2022-11-18 09:29:59 -08:00
Bruno Leroux
87cb150c20
InkResponse highlights can be updated (#115635) 
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
 2022-11-18 15:14:53 +00:00
Martin Kustermann
de4c0b19a2
Use double.isNaN instead of ... == double.nan (which is always false) (#115424) 2022-11-18 11:06:27 +01:00
hangyu
f261c2f71a
update comments (#115603) 2022-11-17 19:51:22 -08:00
Bruno Leroux
710e708cce
Improve showSnackBar documentation (#114612) 
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
 2022-11-18 00:48:04 +00:00
chunhtai
4ff7fc6413
Fixes a bug where dragging a collapsed handle in TextField does not vibrate (#115586) 2022-11-17 20:29:18 +00:00
Taha Tesser
ac06523b74
Add Material 3 support for Slider - Part 2 (#114624) 
* Add Material 3 support for Slider - Part 2

* Kick tests

* Update drawing order to fix html renderer bug

* Update test
 2022-11-17 18:33:16 +00:00
Devon Carew
0344407614
Rev package:pub_semver to the latest version (#115570) 
* rev package:pub_semver to the latest version

* revert update_packages.dart changes
 2022-11-17 18:29:37 +00:00
chunhtai
c2b29501f4
Add selection feedback for both selection area and text field (#115373) 
* Add selection feedback for both selection area and text field

* Addressing comment

* Fixes more test
 2022-11-17 18:27:56 +00:00
Qun Cheng
a1ea383fa5
Label should always be aligned with text in filled input decoration (#115540) 
Co-authored-by: Qun Cheng <quncheng@google.com>
 2022-11-17 18:27:53 +00:00
Hans Muller
70b7445cba
Reland Added Badge.count constructor (#115566) 2022-11-17 17:15:52 +00:00
Hans Muller
537f89ca0e
Revert "Added Badge.count constructor (#115297)" (#115564) 
This reverts commit e9622ce93a45b6e1e5a45c7729de4fc41381dc0b.

Landing before presubmits have completed to unblock the build.
 2022-11-17 08:06:24 -08:00
Hans Muller
e9622ce93a
Added Badge.count constructor (#115297) 2022-11-17 06:05:06 -08:00
Hans Muller
e8cbd444e4
Added Badge.isLabelVisible flag (#115292) 2022-11-17 06:02:42 -08:00
Ahmed Ashour
59f389db78
Remove unneeded comparison to double.nan (#115470) 
Fixes #115468
 2022-11-17 03:53:05 +00:00
Sam Rawlins
f255390f4d
Remove redundant arguments passed to redirecting factory constructors (#115497) 2022-11-17 00:47:14 +00:00
Jonah Williams
d01874d71e
[framework] re-rasterize page transition when layout size changes (#115371) 
* [framework] autoresize on snapshot widget

* ++

* ++

* ++

* use layout to resize
 2022-11-16 23:05:15 +00:00
Qun Cheng
829e44db92
Fixed label alignment (#115409) 
Co-authored-by: Qun Cheng <quncheng@google.com>
 2022-11-16 22:04:48 +00:00
Srujan Gaddam
f205471a69
Use concrete factory constructor for DomXMLHttpRequest (#115094) 
This code should be calling the factory method, not the synthetic
constructor.
 2022-11-16 13:15:29 -08:00
harperl-lgtm
490fe2835d
Updated instructions for adding new localized messages. (#115390) 2022-11-16 15:44:14 -05:00
hellohuanlin
dcae424783
[tools]build ipa validate template icon files (#114841) 
* [tools]build ipa validate template icon files

* use the same box for both validations, and added some unit test, and some nits

* add unit test for templateImageDirectory

* use fs.path.join intead of raw path

* use the correct filesystem

* lint

* use absolute path for flutter_template_images

* fix rebase

* update indentation
 2022-11-16 19:29:17 +00:00
Christopher Fujino
a2233eabed
[flutter_tools] remove all body_might_complete_normally_catch_error ignores (#115184) 
* remove all body_might_complete_normally_catch_error ignores

* add a test
 2022-11-16 18:20:45 +00:00
Elias Yishak
d7454d552a
removing default values for [reporter] and [timeout] in flutter test (#115160) 
* removing default values for [reporter] and [timeout]]

* passing reporter arg to see tests pass

* added test to confirm TestCommand is not passing defaults

* add'l helper message for [reporter] arg

* default behavior for github actions + fixed tests

* removing github conditional for reporter + related test

* removing unused import
 2022-11-16 18:20:42 +00:00
Jakub Fijałkowski
4301731eb2
Make Flutter Driver actively wait for runnable isolate (#113969) 
* Test the case when main Isolate is in `None` state for long time

* Wait for isolate to become runnable

* Handle `PausePostRequest` as a normal "paused" event

* Use `-= 1` instead of `--`
 2022-11-16 17:01:22 +00:00
godofredoc
2c1536a2d9
Create a main alias for master channel. (#115388) 
* Create a main alias for master channel.

To slowly migrate away from master branch in the flutter repository we
created a main branch that is mirroring master branch. This PR is also
adding a channel alias that will allow to use master/main interchangeably.

Bug: https://github.com/flutter/flutter/issues/95041

* Fix channel tests.

* Remove additional space.
 2022-11-16 02:49:00 +00:00
Greg Spencer
93c4b09e62
Add RestorableEnumN<T> and RestorableEnum<T> to restorable primitive types (#115050) 
* Add RestorableEnumN and RestorableEnum to restorable primitive types

* Review Changes

* Change to assert if not part of the valid set.

* Assert if default value isn't in the enum
 2022-11-16 02:07:50 +00:00
fzyzcjy
7d2b01132d
Fix logic error in markNeedsPaint (#112735) 
* Update object.dart

* Update object.dart

* Update object.dart

* Update object.dart

* Update object.dart
 2022-11-16 00:06:51 +00:00
hangyu
d0e5b2fbaa
Add a way to customize padding in BottomAppBar (#115175) 
* squash 5 into 1

fix

Update packages/flutter/lib/src/material/bottom_app_bar.dart

lint

update tests

Co-Authored-By: Hans Muller <hansmuller@chromium.org>

* lint

Co-authored-by: Hans Muller <hansmuller@chromium.org>
 2022-11-15 15:54:52 -08:00
Jenn Magder
2c44f4a68b
Remove dev branch reference from build ios-frameworks error (#115166) 2022-11-15 21:35:29 +00:00
Tae Hyung Kim
700de09fd5
Change button and label text to sentence case for Material 3 (#115187) 
* init

* upper case only when material 2

* fix test

* fix test

* fix tests again

* Add all tests

* analyze"

* fix stepper
 2022-11-15 20:57:09 +00:00
hangyu
136b46ba91
Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (#115010) 
* update hint semantics

* Update input_date_picker_form_field_test.dart
 2022-11-15 12:32:32 -08:00
Darren Austin
39a9ed5721
Updated tokens to v0.141 (#115298) 2022-11-15 10:33:19 -08:00
Maurice Parrish
95ace11afa
Include initial offset when using PlatformViewSurface (#114103) 
* add position to layout creation

* make position nullable

* fix tests

* test

* clear test size

* clear device pixel ratio

* add more documentaiton

* add comment about localToGlobal
 2022-11-15 18:21:37 +00:00
Daco Harkes
c37f255e8b
[tools] Fix plugin_ffi template lint violation (#115356) 
Closes: https://github.com/flutter/flutter/issues/115347
 2022-11-15 11:50:49 +00:00
Brandon DeRosier
e9c6212da0
[Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (#114214) 2022-11-14 21:38:46 -08:00
Jonah Williams
59ecc75748
[flutter_tools] add uint compilation test (#115317) 
* [flutter_tools] add uint compilation test

* Update shader_compiler_test.dart
 2022-11-15 01:39:59 +00:00
fzyzcjy
8e3ea14787
Incorrect rendering of SnapshotWidget (#114400) 
* add tests

* try to fix

* fix compile error

* refactor code

* rename

* doc

* refactor test

* simple rename
 2022-11-15 01:39:57 +00:00
Jenn Magder
2e51077d19
Do not strip architecture suffixes from host local-engine (#115320) 
* Do not strip suffices from host local-engine

* suffixes
 2022-11-15 01:36:49 +00:00
Siva
ea4e11dd9b
Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (#115176) 
* Fix test in preparation of the Dart VM switching to being null safe by
default.

* Fix analyze error.

* Format.

* Remove print.

* Fix analyzer lint.

* Fix warnings.
 2022-11-14 14:47:35 -08:00
Qun Cheng
244990775a
Fixed the color curve issue (#115188) 2022-11-14 11:31:03 -08:00
Jonah Williams
8230ef5e85
Revert "[web] Add --local-web-sdk flag and use precompiled platform kernels for dart2js and ddc (#114639)" (#115242) 
This reverts commit 0e9ee3679cf30a1022b1ed062019d4f7312cef92.
 2022-11-13 20:23:26 +00:00
Darren Austin
6ec2bd0a80
M3 Segmented Button widget (#113723) 2022-11-11 22:13:57 -08:00
Dan Field
9e314ff749
Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (#115173) 
* Make FutureBuilder handle SynchronousFuture correctly

* Reland  "Load assets in flutter_test without turning event loop. (#115123)" (#115156)"

This reverts commit 3895786f9854a73c92406f7f8ccf8db06d3581b7.
 2022-11-12 01:36:05 +00:00