6135 Commits

Author SHA1 Message Date
Ian Hickson
c713aa0020 BoxFit documentation (#10397) 2017-05-31 10:48:36 -07:00
Jason Simmons
2ab60e93ef Scroll text fields when the caret moves outside the viewport (#10323)
Fixes https://github.com/flutter/flutter/issues/9923
2017-05-31 10:33:23 -07:00
Todd Volkert
0809a4fcdc Don't enforce library_prefixes lint in users' projects. (#10392)
The lint ensures that the prefix you use in your "import ... as"
directive conforms to lowercase_with_underscores style. However,
generated code often doesn't, since it may use preceding underscores
for collision avoidance, or directly use locale codes in the
prefixes.
2017-05-31 09:00:04 -07:00
Michael Goderbauer
87c5b24e87 Exclude ModalBarrier from Semantics Tree if it is not dismissible (#10395) 2017-05-30 16:45:54 -07:00
Fahad
4a1e660a0d Documentation fix in StatefulWidget class (#10373)
Replace a misplaced StatelessWidget class with StatefulWidget class
2017-05-28 21:30:36 -07:00
Ian Hickson
f437d025b8 Minor documentation fixes (Material, Column) (#10365) 2017-05-27 16:59:45 -07:00
Ian Hickson
e548d46562 Document GridPaper (#10357) 2017-05-27 16:59:01 -07:00
Ian Hickson
767ab66c25 Fix dartdocs (#10361)
You can't have a newline between the `]` and the `(` in an image in markdown it turns out.
2017-05-27 00:45:25 -07:00
Ian Hickson
f50caddfbd Much work on the documentation (#10331)
Minor fixes throughout, e.g. removing trailing commas from the end of sample code expressions, changing headings to "sample code" more consistently, removing stale todos, fix typos in a private method name, minor grammar fixes, added some clarifications to CircularProgressIndicator, LinearProgressIndicator, CrossAxisAlignment, added some cross-references to various members, made it slightly clearer that layout algorithms are implementation details.

Clarified "elevation" throughout.

Added docs to InkResponse and InkWell.

Added sample code for: SliverAppBar, Card, ListTile, EdgeInsets, Row, Column, CustomScrollView, ListView, SliverFixedExtentList, and SliverGrid.

Fixes #10317.
Fixes #10316.
Fixes #10267. (sort of, see comment therein)
Fixes #9331. (sort of, see comment therein)
Fixes #9407. (sort of, see comment therein)
2017-05-26 17:15:09 -07:00
Chris Bracken
4743a806cb Minor flutter_tools test reorganization (#10356)
Relocates two tests alongside other related tests:
* moved code_signing_test.dart alongside other lib/src/ios tests
* moved terminal_test.dart alongside other lib/src/base tests
2017-05-26 16:12:42 -07:00
Jacob Richman
56a556e69f Add more tests of toStringDeep. (#10346)
* Add more tests of toStringDeep.

These tests will help ensure toStringDeep behavior is not regressed
by refactoring toStringDeep to support structured data.
2017-05-26 12:42:29 -07:00
Mikkel Nygaard Ravn
c06dce4718 Add more docs for MethodChannel.invokeMethod (#10345) 2017-05-26 19:39:52 +02:00
Mikkel Nygaard Ravn
c11d1318f8 Fix error in sample code (#10339) 2017-05-26 19:32:29 +02:00
Robert Felker
e9d50f8aeb Typo to associated (#10340) 2017-05-26 10:32:06 -07:00
Mary
f375b5acee Remove duplicated word "space" from docstrings (#10328) 2017-05-26 09:44:46 -07:00
Michael Goderbauer
307f3569a2 Include Semantics Node in debugDumpRenderTree, if available (#10338)
Makes debugging semantics easier (e.g. which RenderObject has semantics, where is a SemanticNode seen in the semantic tree comming from, etc).

It's only printed if accessibility is turned on.
2017-05-26 09:31:39 -07:00
Hans Muller
f68c6fb814 Fix package_test flakiness, init ensure terminal context entry is set (#10333) 2017-05-25 16:35:38 -07:00
Chris Bracken
9452a3448c Support inactive, suspending AppLifecycleStates (#10306)
* Rolls the engine to 75c74dc463d56e17be10315cfde409010fd8f90b.
* Adds framework support for the `AppLifecycleState.inactive` and `AppLifecycleState.suspending` states.

What are the new states?
------------------------
* `AppLifecycleState.inactive` is emitted on iOS only and corresponds to iOS's foreground inactive state. Current iOS state transitions are:
`resumed` <--> `inactive` <--> `paused`

* `AppLifecycleState.suspending` is currently emitted on Android only and corresponds to the
transition to Android's stopped state. Current Android state transitions are:
`resumed` <--> `paused` --> `suspending` --> `resumed`

These transitions may change in future.

This is a breaking change on iOS
--------------------------------

This changes the semantics of the `AppLifecycleState.paused` state on
iOS. The behaviour associated with this state is unchanged on Android.

For background on iOS application states see the state transition
diagram in the [App Programming Guide for iOS](https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/TheAppLifeCycle/TheAppLifeCycle.html#//apple_ref/doc/uid/TP40007072-CH2-SW6).

On iOS, prior to this change, `AppLifecycleState.paused` corresponded to
a transition to the _foreground inactive_ state. It now corresponds to a
transition to the _background state_. The newly-added
`AppLifecycleState.inactive` state now corresponds to entering the
_foreground inactive_ state, which (currently) has no exact analogue on
Android.

Briefly, the _foreground inactive_ state is the state entered when
switching from an app to the app switcher, receiving a phone call, or
responding to a TouchID request. Apps are permitted to continue
animating/updating views in this state if desired. From the _foreground
inactive_ state, the app may transition back to _active_ (e.g., entering
the app switcher then resuming the app), or to the _background_ state
(e.g., switching to the home screen or another app).

What to change
--------------
If your app does not handle the `AppLifecycleState.paused` state in a
`WidgetsBindingObserver.didChangeAppLifecycleState` implementation, no
changes are required.

If you do handle `AppLifecycleState.paused`, you may additionally wish
to also handle `AppLifecycleState.inactive`. For example, games should
probably pause on entering the app switcher rather than wait to be
backgrounded.

More details
------------
For background on Android application states see the state transition
diagram in the [Android Activity Lifecycle docs](https://developer.android.com/guide/components/activities/activity-lifecycle.html#alc).
2017-05-25 10:52:21 -07:00
Chris Bracken
7566f73d0d Simplify MemoryPressureObserver test (#10308) 2017-05-24 18:18:53 -07:00
Hans Muller
07e8a62cc5 Updated removeRoute doc (#10300) 2017-05-24 16:14:09 -07:00
Hans Muller
0cadbce490 Added Navigator.removeRoute() (#10298) 2017-05-24 15:16:03 -07:00
xster
69c2542458 CupertinoTabBar (#10264)
Move some Cupertino colors to a common file. 

Create a CupertinoTabBar widget to mimic iOS looks
2017-05-24 12:23:15 -07:00
Ian Hickson
f53d0fece2 Add some documentation for RenderSliver. (#10272) 2017-05-24 11:02:04 -07:00
Ian Hickson
51ba6b377b Fix DecorationImage.centerSlice (#10257)
...and rearrange a bunch of code so that all these arguments/members
are always in the same order.
2017-05-24 10:45:28 -07:00
Jason Simmons
61e938aa1e Avoid divide by zero in scroll thumb rectangle calculations (#10271) 2017-05-24 09:52:09 -07:00
Mikkel Nygaard Ravn
251d83a4b5 Add org option to flutter create (#10290) 2017-05-24 16:19:16 +02:00
Mikkel Nygaard Ravn
6762e86953 Change template indentation to 2 spaces (#10289) 2017-05-24 12:37:23 +02:00
Mikkel Nygaard Ravn
10f6483003 Add Swift and Kotlin templates (#10259) 2017-05-24 08:22:50 +02:00
Devon Carew
230f108156 expose debugPaintBaselinesEnabled (#10276)
* expose debugPaintBaselinesEnabled

* Update binding.dart

review comments
2017-05-23 21:39:37 -07:00
Ian Hickson
d4828986a6 More docs about keys. (#10282)
I added a bunch of sample code to the core Widget subclasses so that
people would see that you are supposed to always include the `key`
argument.
2017-05-23 20:09:13 -07:00
Ian Hickson
f9d24f652b More docs. (#10214) 2017-05-23 19:19:00 -07:00
xster
04aeef84db Let iOS flutter run auto-sign default to first profile (#10181)
* Let run default to first profile

* fix

* review notes
2017-05-23 18:05:47 -07:00
Ian Hickson
59025702db AppBar: fix bugs, add docs, add samples (#10223)
I added some tests for the bug that I fixed.
I added docs for IconButton and AppBar.
I added some new constructors for FractionalOffset.
2017-05-23 17:48:54 -07:00
Hans Muller
04d418beac Correct the initial rendering of non-scrollable dropdown menus (#10255) 2017-05-23 16:55:57 -07:00
Chris Bracken
49cec4593a Apply minor formatting fixes (#10261) 2017-05-22 17:08:49 -07:00
Chris Bracken
dd1456ffbc Make most ios_workflow host tool calls async (#10260)
Does not yet migrate hasIdeviceId since that results in a cascade of
breaking interface changes that's significant enough for a separate
patch.
2017-05-22 16:09:48 -07:00
Michael Goderbauer
9a908f7558 Revert "Partial rollback of #10204" (#10258)
* Revert "Test installation status when ideviceid is not installed (#10254)"

This reverts commit 0e5d4a87715100076c17a5bfcace8c8b583ec85b.

* Revert "Partial rollback of #10204 (#10256)"

This reverts commit b291bf5d6a9bf5a15717763d2b95a2c283f2fc5e.
2017-05-22 16:06:22 -07:00
Chris Bracken
0e5d4a8771 Test installation status when ideviceid is not installed (#10254)
Ensure that flutter doctor returns a partial installation status when
ideviceid is not installed.
2017-05-22 14:09:37 -07:00
Michael Goderbauer
b291bf5d6a Partial rollback of #10204 (#10256)
This broke Fuchsia as they haven't updated to Dart 1.24 yet :(
2017-05-22 13:28:59 -07:00
Todd Volkert
aa9c782693 Add initial list of known Android hardware (#10249)
Our emulator detection was based on a simple heuristic that was
failing for the Samsung Galaxy S8. Any heuristic is flawed since
Android devices can report whatever they want to adb, but this
change attempts to tighten the detection by listing known models
(by their ro.hardware property). Again, these values could be
spoofed by emulator system images, but it's less likely to be
an issue than with our previous (and fall-back) heuristic.

Fixes #10203
Related: #10248
2017-05-22 10:47:02 -07:00
Michael Goderbauer
d33fd923bf Print locale in flutter doctor (#10204)
This helps to debug encoding issues that are believed to only happen for certain locales (see https://github.com/flutter/flutter/issues/10198 fo example).

DO NOT SUBMIT until Dart SDK has been bumped (https://github.com/flutter/flutter/pull/10110) as this depends on new API.
2017-05-22 10:21:10 -07:00
Rafal Wachol
ee34516491 Moved FLUTTER_HOME to FLUTTER_ROOT in gradle plugin (#10100) 2017-05-22 07:50:31 -07:00
xster
40b67bb187 Move icons stuff from material to widget (#10192)
Moved everything icons related except the material icon button and the materialicon font list to widget
2017-05-21 16:57:31 -07:00
Alexander Aprelev
5b1e972948 Filter out '\n' from terminal input. (#10220)
* Remove '\n' from terminal input.

* Use trim instead of replaceAll

* Add unit test

* Cleanup the test

* Fixed lint

* Style adjustments

* Forgotten @override

* Revert "Forgotten @override"

Accidently added extra files.

This reverts commit 0aba24fc8ea321b3a4d0cd8aed7f589378393d96.

* Just @override change
2017-05-21 15:15:44 -07:00
Adam Barth
81b76c2bb8 Make CircularProgressIndicator's stroke width configurable (#9794)
Fixes #9062
2017-05-19 21:56:07 -07:00
xster
95e9e7e9e7 Theme inserts IconTheme into tree (#10179)
* Let Theme insert an IconTheme into the widget tree

* flip the order, no real reason

* Let icon theme use its own fallback

* review notes

* more review notes
2017-05-19 18:36:50 -07:00
Chris Bracken
48237d54c1 Small doc clarification to HapticFeedback.vibrate (#10217)
Eliminate the implementation detail of which function is called to
trigger vibration on iOS, instead report the vibration constant.

Also note that not all iOS devices support haptic feedback (e.g., older
iPod touch devices).
2017-05-19 14:50:11 -07:00
Chris Bracken
c9d21ecd24 Add FlutterLogoDecoration tests (#10209)
Covers FlutterLogoDecoration.lerp()

Disabling const constructor lint for the test values pending resolution of
https://github.com/dart-lang/sdk/issues/26980
2017-05-19 13:40:59 -07:00
Brian Slesinsky
922c2d1213 rename Android module file to include project name (#10163)
IDEA users sometimes want to create multiple Flutter modules
in the same IDEA project. See discussion:
https://github.com/flutter/flutter-intellij/issues/1014

In this case, we will actually have pairs of modules,
one for Flutter and one for Android. Renaming the
android module to make the relationship obvious.

But, don't delete the old file yet to avoid breaking
existing users. We can do that after the next
Flutter plugin release.
2017-05-19 13:36:53 -07:00
Todd Volkert
a88379399e Don't fail assert when we send an error to the plugin. (#10207) 2017-05-19 12:34:41 -07:00