14847 Commits

Author SHA1 Message Date
Anurag Roy
cd690f9559
[flutter_tools] Add --verify-only flag to flutter upgrade (#68866)
* Add --verify-only flag for flutter upgrade
2020-10-27 14:06:39 -07:00
Jonah Williams
18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067)
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Dan Field
36f9af3f55
reland driver vm_service migration (#69126)
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2c8889e6e45bf18ac1439dd1522aa5c.

* pub run test
2020-10-27 11:30:24 -07:00
Justin McCandless
09dc5599dd
Selecting spaces (#68227)
When attempting to select a space on mobile, Flutter will try to select the word before the space too, if one exists.
2020-10-27 11:30:07 -07:00
Yuqian Li
891bd95e1a
Add clipBehavior to BoxFit doc (#68662) 2020-10-27 11:07:04 -07:00
Jonah Williams
8c3d564ded
[flutter_tools] fix test expectation in resident_runner.dart (#69121) 2020-10-27 10:11:02 -07:00
Justin McCandless
c12d9b9c19
IME private command docs improvement (#68630)
Just a docs-only improvement in EditableText and text input.
2020-10-27 09:22:47 -07:00
Jonah Williams
3300a1bd68
[flutter_tools] eagerly set asset directory path, cache flutter views, simplify error handling (#68978)
Performs some small cleanup on the hot reload code path.

- Combines nested try/catch into single try catch, update on clause now that package:vm_service is used and Map does not need to be caught.
- Cache FlutterViews for the lifetime of the hot reload method handler
- Set asset directory path once during startup and remove conditional set during hot reload
2020-10-27 09:20:05 -07:00
Michael Goderbauer
95563ff197
Make WidgetsLocalizations.of non-nullable (#69055) 2020-10-27 09:16:41 -07:00
Justin McCandless
291ee94506
AutocompleteCore (#62927)
A new widget that chooses an item from a list based on text input. Just the core widget, with Material and Cupertino versions to come.
2020-10-27 08:58:52 -07:00
Jonah Williams
4b017b6220
remove unnecessary null aware operator (#69107) 2020-10-27 07:24:27 -07:00
Michael Goderbauer
9fb1c521b1
InheritedTheme updates (#69050) 2020-10-27 06:57:03 -07:00
Shi-Hao Hong
d50bfd5f66
Fix null issue with dynamically updating from zero tabs for TabBar (#69005) 2020-10-27 06:52:04 -07:00
Michel Feinstein
60a58ab780
Update form.dart (#68968) 2020-10-27 06:47:04 -07:00
xubaolin
b99443c7ff
Apply Desktop specs for Tooltip (#68681) 2020-10-27 06:42:03 -07:00
Daniel Edrisian
e818c47059
Added CupertinoSearchTextField (#68074) 2020-10-27 06:37:03 -07:00
Dan Field
e5814756a2
Revert "Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)
This reverts commit 05ab0eba19530c89a9a1d210eddb0ea59f7236e5.
2020-10-27 01:47:03 -07:00
Dan Field
05ab0eba19
Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)
This reverts commit 19ce7a86af88df155cc2b09fad448bf6e5781ffb.
2020-10-26 19:22:25 -07:00
Jonah Williams
19ce7a86af
Revert "Driver vm service (#68654)" (#69074)
This reverts commit 3ecac303b43588d796afe3e14c889d18bcae023d.

Co-authored-by: Dan Field <dfield@gmail.com>
2020-10-26 18:56:34 -07:00
Jonah Williams
6cd847c767
[flutter_tools] update test platform to use buildInfo instead of mode + additional params (#69033) 2020-10-26 18:50:17 -07:00
Dan Field
3ecac303b4
Driver vm service (#68654)
Migrate flutter_driver to use package:vm_service
2020-10-26 17:09:14 -07:00
Michel Feinstein
e949ff54af
Error on FocusTraversalGroup or Focus docs (#68981) 2020-10-26 16:56:12 -07:00
Jonah Williams
e0ec9a06dc
[flutter_tools] Make ApplicationPackageFactory inject dependencies for Android Builds (#67827)
* [flutter_tools] simplication of application store logic

* maybe return null

* fix install tests

* Clean up imports

* revert windows test

* remove unused import
2020-10-26 16:51:32 -07:00
chunhtai
6cfb86fbcb
Fix crash if update pages right after a navigator pop (#68923) 2020-10-26 16:50:54 -07:00
Michael Goderbauer
27e1efc159
Delay Route disposal until OverlayEntries are unmounted (#68913) 2020-10-26 16:22:37 -07:00
Jonah Williams
e7b66ac7ad
[flutter_tools] do not include AS validator if android is not enabled (#69047) 2020-10-26 15:59:00 -07:00
Yegor
7a10b46ee0
Print errors in all build modes (#69046) 2020-10-26 15:57:02 -07:00
Jonah Williams
2e54c4a8ea
[flutter_tools] implement safe file copy with multiple fallbacks (#69000)
The tool observes a large number of unhandled exceptions during the file copy portion of flutter create. it is difficult to tell whether the permission issue is caused by the source/destination, or whether it is due to a bug in dart:io.

To work around this, implement a permission check for both the source and dest files. If either fails, the tool can exit with a more specific message.

If these checks pass, then perform the actual copy. If the copy fails, fallback to manually copying the bytes
2020-10-26 15:49:07 -07:00
Jonah Williams
8b973f01c4
[flutter_tools] add package_config.json to analyze_once_test.dart (#69059)
* [flutter_tools] add package_config.json to analyze_once_test.dart
2020-10-26 15:46:51 -07:00
MH Johnson
70aa1227c2
[Material] Fix BottomNavTheme.showSelectedLabels bug (#67342) 2020-10-26 14:47:02 -07:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041)
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
2020-10-26 14:31:13 -07:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025) 2020-10-26 12:42:05 -07:00
Jonah Williams
183fe75d58
[flutter_tools] reland: drive service (#68887)
Overhaul of flutter drive in order to deliver a better experience, namely:

* flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
* Removes web-initialize-platform as this is no longer used
* flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
* VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)

Web changes

* Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-26 10:11:30 -07:00
Justin McCandless
b76253b60a
minScale docs reference the need for a larger boundaryMargin when scaling below 1.0 (#68494) 2020-10-26 08:42:04 -07:00
Justin McCandless
c2bb928981
Proper light/dark colors, and test that text is not color of background (#67679) 2020-10-26 08:37:03 -07:00
Justin McCandless
b9195d807c
Revert "change TextEditingController.clear() behavior (#68775)" (#68920)
This reverts commit 95909c2a04ef62cc72aab61ac26157b8a8ad7a20.
2020-10-26 08:03:09 -07:00
Dan Field
9951638f3b
retry getting the main isolate (#68894) 2020-10-23 15:55:32 -07:00
Jonah Williams
0f28edac65
[flutter_tools] null safety mode is used for dill naming (#68898)
* [flutter_tools] null safety mode is used for dill naming

* add bad test case
2020-10-23 15:39:58 -07:00
Roc Boronat
8d6ba3ebe9
Fix a typo: "Its weight" instead of "It's weight" (#68883) 2020-10-23 14:17:04 -07:00
Jenn Magder
832d776b15
Stop debugger when iOS app crashes (#68844) 2020-10-23 14:12:04 -07:00
Yash Johri
f3562c6f1d
[SwitchListTile and CheckboxListTile] Adds selectedTileColor property (#68358) 2020-10-23 14:07:05 -07:00
Justin McCandless
0c63d63b1f
InteractiveViewer constrained docs (#68327) 2020-10-23 14:02:03 -07:00
Jenn Magder
59544e377d
Apple silicon arch -arm64 -> -arm64e (#68855) 2020-10-23 13:48:38 -07:00
Jonah Williams
424ea0958b
[flutter_tools] make android deps no longer required for flutter doctor (#68533) 2020-10-23 12:37:04 -07:00
Jonah Williams
cb67513f29
[flutter_tools] Reland: simplify pub cache logic (#67589)
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.

Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.

Fixes #66777
Fixes #65723
2020-10-23 10:00:56 -07:00
Michael Goderbauer
6cb6eef615
Make Material/CupertinoLocalizations non-nullable (#68807) 2020-10-23 09:12:42 -07:00
Jenn Magder
351ccf7eaf
Better error message when export options plist does not a fix (#68826) 2020-10-22 23:28:51 -07:00
Jenn Magder
aea070790f
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets (#68817) 2020-10-22 22:02:04 -07:00
Cyp
45e02daf22
Correctly handle centerSlice with resoultion-aware assets. (#68325) 2020-10-22 21:57:03 -07:00
Jonah Williams
1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845)
This reverts commit 2e75f52ae4fe22128a2d4274a01bc19bdc13507f.
2020-10-22 19:39:33 -07:00