6634 Commits

Author SHA1 Message Date
Sarah Zakarias
ff90ba5b3a Add schema for plugin (#12013) 2017-09-11 16:24:41 +02:00
Ian Hickson
e7fbee6624 Fix clip debugPaint (TextPainter RTL fallout) (#12026) 2017-09-10 22:59:26 -07:00
Hans Muller
4262c1e9d3 Make an app's supported locales configurable (#11946)
* Make an app's supported locales configurable

* Added an supportedLocales.isNotEmpty assert

* WidgetsApp no longer const because supportedLocales.isNotEmpty

* updated per review feedback

* tweaked dartdoc to restart the build

* updated per review feedback

* Updated per review feedback
2017-09-08 16:47:40 -07:00
Michael Goderbauer
3bf3df33ea Add SemanticsEvents and send them for scrolling (#11909)
* ++

* ++

* ++

* ++

* ++

* dart docs

* test fix

* undo unintended change

* fix test

* fix test

* review feedback
2017-09-08 16:08:40 -07:00
Ian Hickson
fad36baa6f Fix WidgetsApp to wrap its contents in a Directionality (#12018)
...rather than only wrapping the children.

Also, improvements to Banner to better support RTL, and mock_canvas to
make debugging things easier.
2017-09-08 14:29:35 -07:00
Adam Barth
c46347b6df Add RTL support to Stack (#11973)
Notice that the default alignment for Stack needs to know the
directionality.
2017-09-07 22:52:36 -07:00
Adam Barth
1792766a88 Rename BannerLocation enum values (#11960)
* Rename BannerLocation enum values

 * topLeft -> topStart
 * topRight -> topEnd
 * bottomLeft -> bottomStart
 * bottomRight -> bottomEnd

These names will make it easier for us to adjust the location of the
banner in right-to-left mode.

See the discussion on flutter-dev.

* Add RTL support for Banner

Fixes #11905
2017-09-07 21:12:28 -07:00
Mehmet Fidanboylu
d868044e50 Selectively apply margin between middle and leading (#11964)
* Selectively apply margin between middle and leading

If ToolbarLayout does not have a leading widget, we should not put a margin between leading and middle areas since it ends up being blank space that looks odd. Fixes https://github.com/flutter/flutter/issues/11963

* Fix the failing test which is a good test case for missing leading widget
2017-09-07 17:40:58 -07:00
Hans Muller
60c4ff9360 More localizations for Material (#11989) 2017-09-07 16:58:12 -07:00
Ian Hickson
ca7d2d23cf TextPainter RTL (#11888) 2017-09-07 16:57:38 -07:00
xster
038981bed9 Mini doc addition to mention that slivers must be filled with RenderSlivers (#11972) 2017-09-07 10:56:17 -07:00
Chris Bracken
8c61116c00 Eliminate iOS log blacklist (#11981)
This was introduced to suppress libMobileGestalt noise originating from
libsystem_asl.dylib. Commit 39680ebfbdf787f81b5765236af0bdce9b64c9c7
suppresses all application log messages not originating from the
app/engine iteself on iOS 10 and above. Since the log message in
question is only emitted on devices running iOS >= 10.3.0, this
blacklist no longer necessary.
2017-09-07 10:25:41 -07:00
Mikkel Nygaard Ravn
14016523ed Ensure snapshot rebuild logic takes main path into account (#11924) 2017-09-07 14:45:42 +02:00
Chris Bracken
39680ebfbd Suppress non-Flutter log messages in terminal (#11969)
On iOS 10 and above, suppress engine log messages from system components
other than Flutter. This eliminates a large amount of keyboard/plugin
related noise during edit-refresh development.
2017-09-06 19:46:40 -07:00
Michael Goderbauer
a67d648742 Roll engine to 883f81c8448e483c51cf1d978dffb332bf47603d (#11966) 2017-09-06 16:30:13 -07:00
Adam Barth
0d454724d3 Improve DatePicker RTL (#11922)
This patch just fixes the next and previous buttons to be in the proper
place. There might be other issues with the DatePicker, but this one was
obvious.

See #11377
2017-09-06 15:35:19 -07:00
Collin Jackson
020029acfd Increment version after rolling alpha (#11893) 2017-09-06 15:18:15 -07:00
Chris Bracken
0244f5dd6a Revert "Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446 (#11933)" (#11959)
This roll caused performance regressions in benchmarks:
* complex_layout_scroll_perf
* flutter_gallery_transition_perf

This reverts commit f430a45a5bd6080e7247e0ae4d4250460875dcf7.
2017-09-06 11:39:10 -07:00
Mikkel Nygaard Ravn
de6488f5f1 Fix dartdoc typo (#11950) 2017-09-06 14:52:12 +02:00
Mikkel Nygaard Ravn
8303fff8f9 Run pub in interactive mode in flutter packages pub (#11700) 2017-09-06 11:53:39 +02:00
Michael Goderbauer
f430a45a5b Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446 (#11933)
* Roll engien to 79332e5c42555875c7070c33810dab3f0012ace1

* Remove deprecated @proxy

* Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446
2017-09-05 21:12:46 -07:00
Chris Bracken
ce08bf9a21 Log checksum validation errors at trace level (#11944)
Checksum validation is intended only as a performance improvement.
Checksum de-serialization errors (typically framework version mismatch) are
expected on framework updates and shouldn't be user-visible except for
informational purposes when --verbose is set.
2017-09-05 17:03:56 -07:00
Chris Bracken
de736f0d43 Update minimum ios-deploy version to 1.9.2 (#11936)
ios-deploy 1.9.2 includes fixes for a common source of Xcode breakage
(flutter/flutter#4326) with Xcode 8.3.3 + iOS 10.3.3, and is required to
to support Xcode 9 (flutter/flutter#11875).
2017-09-05 16:26:36 -07:00
Chris Bracken
93438245f0 Update DevToolsSecurity doctor message (#11935)
Opening Xcode is no longer sufficient to enable develop mode in Xcode 9.
Update the message to run the command-line tool. Alternatively users can
launch an app in the Xcode debugger to do this.
2017-09-05 13:28:13 -07:00
Michael Goderbauer
30fd06f787 getOffsetToReveal deals with pinned slivers (#11878)
* getOffsetToReveal deals with pinned slivers

If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver.

This is important for accessibility scrolling with app bars.

Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent.

* name fixes

* review feedback

* typos

* renaming

* fix analyzer

* fix test

* analyzer fixes
2017-09-05 12:42:28 -07:00
Adam Barth
8eb6ad2776 Add RTL support to GridView (#11921)
Fixes #11855
2017-09-05 11:29:20 -07:00
Chris Bracken
c896fe2f6e Invalidate snapshot when entrypoint changes (#11913)
Adds the app entrypoint as a key in the checksum file.

This change eliminates the assumption that checksummed files change when
the main entrypoint changes. In the case where there are two
entrypoints, a.dart and b.dart and a.dart imports b.dart and b.dart
imports a.dart, building the app with entrypoint a.dart followed by a
build of the app with entrypoint b.dart would result in the same
files list and checksums, but should invalidate the build.
2017-09-05 11:19:09 -07:00
Alexander Aprelev
59bc0a0fce Move host build check until it's actually used. (#11926)
* Move host build check until it's actually used

* Elaborate diagnostic message
2017-09-05 11:12:15 -07:00
Michael Goderbauer
7ee0b6a574 Clear tags on SemanticsNode.reset() (#11903) 2017-09-05 10:37:53 -07:00
Adam Barth
5f29abe2d2 Add RTL support to Switch and CupertinoSwitch (#11928)
Fixes #11868
2017-09-05 09:46:02 -07:00
Adam Barth
9fc9f40263 Add RTL support for AnimatedCrossFade and AnimatedSize (#11920)
Fixes #11848
2017-09-05 09:45:26 -07:00
Mikkel Nygaard Ravn
9be9a40948 Avoid running pub get and analyze on every project during create_test (#11932) 2017-09-05 13:17:14 +02:00
Sarah Zakarias
02c10b78d2 Bundle assets used in packages (#11751) 2017-09-05 09:42:24 +02:00
Adam Barth
baf3b45e0d Add RTL support to AnimatedContainer (#11910)
Also, fix the interpolation between visual and directional fractional
offsets. The interpolation now works visually in whatever direction the
result eventually gets resolved into.

Fixes #11847
Fixes #11357
2017-09-02 22:27:17 -07:00
German Saprykin
74b0bf6480 Fix tracking scroll controller (#11914)
* Fixed TrackingScrollController cleaning stored offset on position's detach

* Fixed format.

* Fixed format.

* Fixed test with Directionality support.
2017-09-02 21:15:59 -07:00
Adam Barth
ea8da05f25 Add RTL support to Stepper (#11873)
Fixes #11379
2017-09-01 22:01:17 -07:00
Chris Bracken
4670c9266c Bugfix in build test: ensure prev snapshot exists (#11912)
Fix a test for build invalidation due to a change in main entry point.
Previously this test's build was always invalidated to the the lack of a
previous snapshot (as well as the change in checksums). This change
ensures that the build is invalidated only due to the change in
checksums.
2017-09-01 18:06:35 -07:00
Chris Bracken
b29680cccf Improve readability of build_test JSON (#11911) 2017-09-01 18:06:13 -07:00
Adam Barth
10130fc551 Spam EdgeInsetsGeometry to improve RTL support (#11849)
Most of the framework widgets should work in terms of EdgeInsetsGeometry
rather than EdgeInsets so that their clients can supply directional
insets.
2017-09-01 16:05:38 -07:00
Alexandre Ardhuin
0783ec906b Enable lints (#11891)
* enable lint prefer_final_fields

* enable lint recursive_getters

* enable lint unnecessary_overrides
2017-09-01 22:18:51 +02:00
Adam Barth
9b5599a4a7 Add RTL support to Drawer (#11872)
Fixes #5215
2017-09-01 12:55:46 -07:00
Adam Barth
9cdfb95b1f Add RTL support to AppBar (#11834)
Fixes #11381
2017-09-01 12:55:31 -07:00
Hans Muller
7ae4de70be Added material string translations for the 6 additional RTL locales we recognize (#11876) 2017-09-01 12:15:05 -07:00
Hans Muller
f3fe875714 Added missing Localizations API doc (#11896) 2017-09-01 11:26:42 -07:00
Ian Hickson
7b33efb620 Revert "Fixed TrackingScrollController cleaning offset on position's detach (#11798)" (#11897)
This reverts commit ec25f6bd5142d9c3b70d81a7ccf7c77f27dc63f7.
2017-09-01 10:48:05 -07:00
German Saprykin
ec25f6bd51 Fixed TrackingScrollController cleaning offset on position's detach (#11798)
* Fixed TrackingScrollController cleaning stored offset on position's detach

* Fixed format.

* Fixed format.
2017-09-01 10:37:33 -07:00
Mehmet Fidanboylu
eae9e053e3 Fix localizations so that extract_messages is happy. (#11894)
extract_messages script currently fails to parse this file because of its use of static asserts, super and a ctr body. Since we already have an assert in the body, I think it is also more readable to put all of them together. _LocalizationScope follows the same pattern above.
2017-09-01 10:15:29 -07:00
Chris Bracken
eba6ceb85d Use idevice_id, ideviceinfo for iOS device listing (#11883)
This patch migrates iOS device listing from using Xcode instruments to
using the libimobiledevice tools idevice_id and ideviceinfo.

ideviceinfo was previously incompatible with iOS 11 physical devices;
this has now been fixed.

In 37bb5f1300e67fe590c44bb9ecda653b2967e347 flutter_tools migrated from
libimobiledevice-based device listing on iOS to using Xcode instruments
to work around the lack of support for iOS 11. Using instruments entails
several downsides, including a significantly higher performance hit, and
leaking hung DTServiceHub processes in certain cases when a simulator is
running, necessitating workarounds in which we watched for, and cleaned
up leaked DTServiceHub processes. This patch returns reverts the move to
instruments now that it's no longer necessary.
2017-09-01 10:10:49 -07:00
Yegor
0793add818 rename Element.visitChildrenForSemantics to visitOnstageChildren; fix DropdownButton (#11744)
* rename Element.visitChildrenForSemantics to debugVisitOnstageChildren

* address comments
2017-09-01 09:48:12 -07:00
Andrew Wilson
aaa9d18024 Handle negative and zero sizes. (#11827) 2017-09-01 09:27:15 -07:00