firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,702 Commits 1 Branch 0 Tags
Commit Graph

3702 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Seth Ladd
139e98a12e add explicit doc to override default from parent 
tweak from review
 2016-01-26 20:14:57 -08:00
Adam Barth
27a73a589c Merge pull request #1400 from abarth/reorder_update_children 
updateChildren() needs to walk the list forward
 2016-01-26 20:08:36 -08:00
Adam Barth
5cfccb9170 Merge pull request #1397 from abarth/route_focus 
Keyboard doesn't dismiss when the drawer comes up
 2016-01-26 20:08:17 -08:00
Adam Barth
05839e51ca updateChildren() needs to walk the list forward 
This patch changes the framework to walk the child list forwards so that build
functions with global side effects do sensible things. Specifically, if you
have a number of autofocusable children, the first one the list will acquire
the focus because it gets built first now.

Fixes #182
 2016-01-26 20:02:46 -08:00
Adam Barth
a535164357 Keyboard doesn't dismiss when the drawer comes up 
When introducing Focus widgets for the Drawer (and ModalRoutes), we weren't
actually giving them the focus. Now we move the focus scope when pushing modal
routes.

Fixes #184
 2016-01-26 19:57:37 -08:00
Chinmay Garde
594e7000a9 Merge pull request #1396 from chinmaygarde/master 
iOS: Make the error message on `flutter ios --init` more descriptive
 2016-01-26 14:08:23 -08:00
Chinmay Garde
c66e00f4a7 iOS: Make the error message on flutter ios --init more descriptive 2016-01-26 14:07:39 -08:00
Chinmay Garde
95ac9b3e05 Merge pull request #1393 from chinmaygarde/master 
iOS: Update log prefix for device logs. We don't use SkyShell anymore
 2016-01-26 13:50:16 -08:00
Chinmay Garde
bf3594c3ee iOS: Update log prefix for device logs. We don't use SkyShell anymore 2016-01-26 13:49:54 -08:00
Chinmay Garde
37b57816c6 Merge pull request #1388 from chinmaygarde/master 
Minor update to the message logged when multiple devices are connected with no device ID specified
 2016-01-26 13:11:26 -08:00
Collin Jackson
d48a469f8a Merge pull request #1389 from collinjackson/contentType 
Example of setting the content type of a POST request
 2016-01-26 13:05:16 -08:00
Collin Jackson
cd95d51c70 Example of setting the content type of a POST request 2016-01-26 12:24:33 -08:00
Adam Barth
340f6fd486 Merge pull request #1387 from abarth/stub_assert 
Input asserts while keyboard is dismissed
 2016-01-26 12:15:54 -08:00
Chinmay Garde
4bd35cdbe9 Minor update to the message logged when multiple devices are connected with no device ID specified 2016-01-26 12:10:46 -08:00
Adam Barth
2ba9687766 Input asserts while keyboard is dismissed 
Now we recreate the stub every time we try to connect to the keyboard. The
underlying message pipe in the stub cannot be re-used, which is why we
previously asserted.

Fixes #776
 2016-01-26 12:03:33 -08:00
Chinmay Garde
6e2f133e21 Merge pull request #1386 from chinmaygarde/master 
Avoid launching Xcode after "flutter ios --init"
 2016-01-26 11:58:22 -08:00
Chinmay Garde
9e089f237f Avoid launching Xcode after "flutter ios --init" 2016-01-26 11:56:29 -08:00
Adam Barth
dc7451d642 Merge pull request #1380 from abarth/raw_keyboard_listener 
Add RawKeyboardListener
 2016-01-25 20:48:46 -08:00
Adam Barth
58c7fdef36 Add RawKeyboardListener 
RawKeyboardListener makes it easier to listen for raw keyboard events.

Fixes #787
 2016-01-25 20:37:22 -08:00
Adam Barth
19ae1e783b Merge pull request #1371 from abarth/silence_xcodebuild 
flutter start shouldn't log xcodebuild output
 2016-01-25 18:59:37 -08:00
Adam Barth
b7396ba13e Merge pull request #1379 from abarth/protect_editable_string 
Hide EditableString implementation details
 2016-01-25 16:43:04 -08:00
Adam Barth
f0ea0eafbb Hide EditableString implementation details 
Previously, EditableString had many public members because it needed to
implement the KeyboardClient interface. However, that's confusing
because these methods cannot be called directly.

Now EditableString holds a private implementation of the KeyboardClient,
which hides the implementation details.

Fixes #208
Fixes #209
 2016-01-25 16:10:51 -08:00
Adam Barth
4a01299827 flutter start shouldn't log xcodebuild output 
Xcodebuild produces a lot of output that isn't relevant to developers. We
should hide it by default.
 2016-01-25 14:09:11 -08:00
Devon Carew
7737117a20 Merge pull request #1369 from devoncarew/improve_device_support 
improve device notification support
 2016-01-25 13:59:36 -08:00
Devon Carew
080896a305 improve device notification support 2016-01-25 13:50:59 -08:00
Adam Barth
a46fb2c4db Merge pull request #1370 from abarth/commit_on_release 
Keyboard service doesn't commit the last edit when it's dismissed
 2016-01-25 13:48:30 -08:00
Adam Barth
008af64cce Keyboard service doesn't commit the last edit when it's dismissed 
We were getting the proper values, but we thought we were still composing, so
the text was still underlined.

Fixes #115
 2016-01-25 13:29:17 -08:00
Matt Perry
b43bd0b1ec Merge pull request #1365 from mpcomplete/apk2 
Support local paths to third-party jars in flutter apk.
 2016-01-25 16:10:30 -05:00
Adam Barth
9862605f8c Merge pull request #1367 from abarth/better_errors 
Improve error messages for iOS workflow
 2016-01-25 13:05:28 -08:00
Collin Jackson
dbd39523ce Re-land update to engine 
This reverts commit b240cda819627024d5fd54a886b503ed339baed7.
 2016-01-25 12:36:44 -08:00
Adam Barth
91e6b21ea6 Improve error messages for iOS workflow 
We now check that you've got an "ios" directory and that you have the proper
version of Xcode.
 2016-01-25 12:21:13 -08:00
Matt Perry
6610b7ea04 Support local paths to third-party jars in flutter apk. 
Also improve the error message a bit if a download fails.
 2016-01-25 15:05:06 -05:00
Seth Ladd
dc74fe3d6c Merge pull request #1362 from sethladd/listenhelptext 
get a bug fix for multi-line command descriptions
 2016-01-25 10:58:10 -08:00
Seth Ladd
fa91b3ff75 get a bug fix for multi-line command descriptions 2016-01-25 09:28:42 -08:00
Ian Hickson
2d6dd63e37 Merge pull request #1361 from Hixie/getPadding 
_getPadding was ignoring its argument
 2016-01-23 22:05:27 -08:00
Ian Hickson
fae41c223d _getPadding was ignoring its argument 2016-01-23 20:20:44 -08:00
Ian Hickson
63962d2cea Merge pull request #1299 from Hixie/inherited-perf 
Reimplement Inherited.notifyDescendants to use a registration list
 2016-01-23 18:31:11 -08:00
Ian Hickson
0903cb5fef Refactor Inherited to avoid all the tree walks during build. 2016-01-23 18:21:02 -08:00
Ian Hickson
5494323db9 Move us to HashSet to avoid the overhead of tracking the order 2016-01-23 18:13:13 -08:00
Ian Hickson
b9716b84db Reimplement Inherited.notifyDescendants to use a registration list 
...instead of a deep walk.
 2016-01-23 18:13:13 -08:00
Adam Barth
0911e5d368 Merge pull request #1352 from abarth/input_features 
Add material design features to Input
 2016-01-23 17:57:39 -08:00
Adam Barth
5f3b2d4835 Add errorColor to ThemeData 
That way folks can customize it if they want (and it makes the code a
bit more self-documenting).
 2016-01-23 17:47:09 -08:00
Adam Barth
7faee3e18e Add implicit animations to Input 
Now the label animates from its inline position to above the text and
the focus highlight grows into place.
 2016-01-23 12:22:15 -08:00
Adam Barth
61f82ee18c Improve the factoring between Input and RawEditableLine 
RawEditableLine is now responsible for the scrolling behavior, which
removes the need for callbacks between RawEditableLine and Input. It
also fixes a bug whereby the whole Input widget (including its icon)
would scroll when the text got long.
 2016-01-23 01:09:22 -08:00
Adam Barth
432bfb4729 Add material design features to Input 
Properly support labels, hints, icons, and custom typography.
 2016-01-23 00:21:18 -08:00
Collin Jackson
b240cda819 Revert "Update engine" 
This reverts commit ab3006345823b1ef8f25046e0a2b054ea4123e12.
 2016-01-22 19:31:14 -08:00
Collin Jackson
ab30063458 Update engine 2016-01-22 19:07:59 -08:00
Eric Seidel
4eb4dab543 Merge pull request #1350 from eseidelGoogle/list_linux 
Make `flutter list` not crash on linux.
 2016-01-22 15:21:28 -08:00
Eric Seidel
7f3ae43b7f Make flutter list not crash on linux. 
Turns out linux does have an ideviceinstaller package
however it doesn't contain idevice_id or any of the
other tools we use.  Furthermore we don't have
xcrun or the rest of xcode on linux so we can't
manipulate simulators either.

No sense in printing out a warning that ios isn't supported
every time on linux, so I wrapped that block in osx only.

@chinmaygarde @devoncarew
 2016-01-22 14:58:13 -08:00
Adam Barth
ed34622214 Merge pull request #1348 from abarth/focus_blur 
Add the ability to lose focus
 2016-01-22 14:13:22 -08:00