2393 Commits

Author SHA1 Message Date
stuartmorgan
58d6c425e4
Check for desktop project files before building (#48350)
Moves the checks that projects have been configured for desktop to a lower level, where they will cover more codepaths (e.g., 'run'), and improves them to check for native build projects, rather than just directories, to catch cases where the directory exists (e.g., due to accidental creation of generated files).

Also adds links to the error messages pointing to instructions on adding desktop support to a project.

Fixes #47145
2020-01-08 12:39:49 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context (#47269) 2020-01-08 12:35:12 -08:00
Dan Field
4552724f0e
Don't use local file system in devfs test (#48367) 2020-01-07 22:49:09 -08:00
Alexander Aprelev
b4c79239da
Cleanup accidental use of global fs in test. (#48358)
This is follow-up to ee7a37f1d3.
2020-01-07 22:35:03 -08:00
Zachary Anderson
a1bf03f87a
Revert "Esarbanis flutter run help (#48314)" (#48351)
This reverts commit 866fa64dceab567750fb669f3a8f05b22e7e9342.
2020-01-07 15:06:40 -08:00
Dan Field
134c2ff076 analytics ordering issue (#48278) 2020-01-07 12:23:02 -08:00
Jonah Williams
bf6c4c4a41
[flutter_tools]web]Add support for --csp mode to build web (#48319) 2020-01-07 12:20:03 -08:00
Zachary Anderson
866fa64dce
Esarbanis flutter run help (#48314)
* Reword flutter run help screen.

* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file

* fix test

Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
2020-01-07 12:10:08 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Dan Field
d73b3682c9
Fix state in test (#48269) 2020-01-06 16:33:31 -08:00
Dan Field
79c4c38cc9 Make analyze once test not depend on test order or flutter create command (#48003) 2020-01-06 16:33:01 -08:00
Jonah Williams
2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250)
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
2020-01-06 13:57:13 -08:00
Dan Field
ea799d97f4
.. (#48263) 2020-01-06 13:30:21 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Dan Field
19c7550540 fix mockStopWatch creation (#48098) 2020-01-06 11:03:01 -08:00
Jenn Magder
0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Dan Field
7b69d137c8 reset state between runs of devFS tests (#48101) 2020-01-03 08:18:02 -08:00
Dan Field
d7c347f027 make pub get test shufflable (#48095) 2020-01-03 08:13:03 -08:00
Dan Field
5ff7225450 fix io_test (#48097) 2020-01-02 19:53:02 -08:00
Angjie Li
9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
Jenn Magder
a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce67c62def5852a5c2615e38188195ca.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc6cf8bf4e1814ef950a6092bbb6f658.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4d97793829aafbb768e73c6e4805302.
2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Jenn Magder
85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568)
This reverts commit 648a5d8a1ebbe95a6f0fa1c41ed34195c11c4d64.
2019-12-20 17:45:16 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Jenn Magder
648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Jonah Williams
3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field
0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45835dc438fe0120521c01c8b055b41e.
2019-12-18 17:02:31 -08:00
Dan Field
b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
Lau Ching Jun
7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Emmanuel Garcia
9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Jenn Magder
65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264)
This reverts commit e54e301d5001efce7c6aa0ff17c028263cfcc38c.
2019-12-17 17:20:57 -08:00
Jenn Magder
e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Emmanuel Garcia
a15a81be21
Fix androidSdk NPE (#47187) 2019-12-17 14:10:36 -08:00
Jenn Magder
1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Alek Åström
853c8c569f [flutter_tools] Add violating plugin name to validation errors (#46601) 2019-12-17 14:08:03 -08:00
Michael Goderbauer
862289fa79 fix imports to unawaited (#47181) 2019-12-17 13:29:26 -08:00
Jonah Williams
0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
Jonah Williams
a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context (#45739) 2019-12-16 18:12:04 -08:00
Zachary Anderson
a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures (#47157) 2019-12-16 14:57:29 -08:00
Todd Volkert
fc9b30a4f1
Revert "flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917)" (#46999)
This reverts commit f28592018de81665704c95776e9c4a1918d3cd47.

It broke forbidden_imports_test, which uses a custom ignore directive.
2019-12-13 12:23:12 -08:00
Sam Rawlins
f28592018d flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917) 2019-12-13 12:03:02 -08:00
Jonah Williams
0497235c20
[flutter_tool] experimental resident web runner is not debuggable (#46916) 2019-12-12 19:05:48 -08:00
Jenn Magder
dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder
7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00