36 Commits

Author SHA1 Message Date
Michael Goderbauer
435c25bfc4 Add note to .analysis_options about .analysis_options in flutter/plugins (#10588)
* Add note to .analysis_options about .analysis_options in flutter/plugins

* review comments
2017-06-08 17:17:48 -07:00
Alexandre Ardhuin
45cef3cbcc try use_to_and_as_if_applicable lint (#10078)
* try use_to_and_as_if_applicable lint

* address review comments
2017-05-15 09:44:39 +02:00
Alexandre Ardhuin
f7502c854c enable avoid_null_checks_in_equality_operators lint (#10079) 2017-05-15 08:41:17 +02:00
Alexandre Ardhuin
26eedb8acf enable use_rethrow_when_possible lint (#10049) 2017-05-13 15:16:30 +02:00
Alexandre Ardhuin
5bce52d6be try use_string_buffers lint (#10034) 2017-05-12 19:00:55 +02:00
Alexandre Ardhuin
1a2d9b0030 try unnecessary_overrides (#9982) 2017-05-11 03:32:10 +02:00
Alexandre Ardhuin
9b56c1c58c enable always_put_control_body_on_new_line lint (#9950) 2017-05-10 09:41:55 +02:00
Alexandre Ardhuin
e4546584d1 enable always_require_non_null_named_parameters lint (#9948)
* enable always_require_non_null_named_parameters lint

* Update home.dart
2017-05-10 08:45:36 +02:00
Alexandre Ardhuin
1f0b2d8a68 bump to linter-0.1.31 (#9947) 2017-05-10 08:20:13 +02:00
Alexandre Ardhuin
ad496e142b enable lint overridden_fields (#9527)
* enable lint overridden_fields

* address review comment
2017-04-22 10:27:03 +02:00
Alexandre Ardhuin
10099db4e2 try lint prefer_expression_function_bodies (#9494) 2017-04-21 23:10:37 +02:00
Alexandre Ardhuin
c794221f96 enable lint prefer_adjacent_string_concatenation (#9493) 2017-04-21 08:52:07 +02:00
Alexandre Ardhuin
35803c2297 comprehensive list of lints (#9330)
* comprehensive list of lints
* add comments to commented out lint
* fix unnecessary_this lints
* exclude prefer_final_fields
2017-04-20 09:38:57 +02:00
Kasper Lund
cbb49179c9 Remove unnecessary ignoring of (removed) strong mode warning (#9463) 2017-04-20 08:20:26 +02:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
2017-04-08 08:43:19 +02:00
Ian Hickson
a52c7b470d Update the examples/ README and associated fixes. (#9090)
This yak shave went as follows:

Fix https://github.com/flutter/flutter/issues/8795 by adding stocks to
the examples README.

Notice the layers entry in that README isn't quite right either.
Update that.

Check the layers/README file is worth pointing at.

Update the layers/README.

Let's run some of the layer tests to see if they still work.

Oops, need to update them to gradle.

Ok let's try running them again.

Oops, sector is broken.

Add a test for sector.

Fix sector. Find you need to add an assert to a const constructor.

Notice we need to turn const asserts on for the analyzer.

Notice the analysis_options files are out of sync with each other and
with the full list of lints.

Turn on the lints that should be on.

Fix the bugs that finds.
2017-04-05 11:28:33 -07:00
Phil Quitslund
3af9ce884d Stop ignoring strong_mode_down_cast_composites (#8783) (#8853)
Fixes: #8783
2017-03-17 09:49:43 -07:00
Phil Quitslund
41d996851b Escalate missing_return hints to warnings (#8825)
Fixes: https://github.com/flutter/flutter-intellij/issues/808
2017-03-16 14:28:18 -07:00
Chris Bracken
ca0201d8ae Enable prefer_final_locals lint (#8575) 2017-03-03 18:47:00 -08:00
Todd Volkert
7b8705f5d9 Update analysis options (#8203)
Fixes #7166

Also cleans up from an aborted attempt at #5793
2017-02-15 14:41:54 -08:00
Phil Quitslund
39f7d58b74 Escalate missing_required_param hints to warnings (#8087). (#8096)
Fixes: #8087.
2017-02-13 14:56:56 -08:00
Dan Rubel
ea74e07689 move flutter user analysis options file (#8091)
* move flutter user analysis options file
* add comments referencing each of the analysis options files
2017-02-13 16:39:35 -05:00
Ian Hickson
63aa1397a3 Increase the strictness of our requiring explicit types (#7585)
...now that we have generic methods, their types need to be specified too.
2017-01-23 01:04:31 -08:00
Ian Hickson
cbda208b4b Reduce the amount of spam from analyze watch. (#7582)
See https://github.com/dart-lang/sdk/issues/28463, which I think is a
regression.

This also fixes the regression introduced by
https://codereview.chromium.org/2559773002 whereby we were no longer
checking any of the lints.
2017-01-22 16:43:24 -08:00
Adam Barth
113fd6cb52 Don't analyze dev/missing_dependency_test (#7478)
That test intentionally has analysis errors to check how the tools react
to that situation.
2017-01-13 15:04:43 -08:00
John McCutchan
2546259a64 DependencyChecker with tests (#7268)
- [x] Introduce DependencyChecker which can determine if any dependencies have been modified.
- [x] Move the DartDependencyBuilder into a separate file.
- [x] Add unit tests for DartDependencyBuilder.
- [x] Add unit tets for DependencyChecker

Part of #7014
2016-12-15 15:05:15 -08:00
Devon Carew
5274ffa537 update .analysis_options (#6984) 2016-11-22 09:31:55 -08:00
Devon Carew
f1b3523baa adjust an analysis exclude (#6739) 2016-11-07 14:47:53 -08:00
Adam Barth
2c21d795a4 Deploy @checked (#6244)
This patch adds `@checked` everywhere is needed to remove the
`strong_mode_invalid_method_override` strong mode error.
2016-10-07 11:27:54 -07:00
Dan Rubel
678da3ac2b cancel open subscription (#5824)
fixes https://github.com/flutter/flutter/issues/5788
2016-09-12 16:32:08 -04:00
Dan Rubel
7cf47ca41f new flutter repo level analysis options (#5786)
This adds and enables a raft of new analysis options for the flutter repository, many of which are commented out until we clean up our code and/or address any linter false positives.
2016-09-09 15:18:18 -04:00
Dan Rubel
5784385aa5 update analysis option comments (#5785)
This aligns the comments and fixes some misspellings in the three related analysis options files.
There will be a follow on PR with more controversial changes to the repo level analysis options.
2016-09-09 13:37:56 -04:00
Dan Rubel
3ed3390d0c flutter analyze repo analysis options (#5707)
This updates the flutter analyze command to use the .analysis_options_flutter_analyze in the repo root when either the --flutter-repo flag is supplied or the sources being analyzed reside in the flutter repo.
2016-09-07 22:41:59 -04:00
Devon Carew
207451f270 exclude //bin from analysis (#5494) 2016-08-18 19:11:39 -07:00
Ian Hickson
94636bd206 Cleanup based on new lints (#4052) 2016-05-20 14:08:46 -07:00
krisgiesing
01978d98a8 Move global analysis options file to the repo root (#3750)
* Move global analysis options file to the repo root

Also restore the analysis options file for stocks example, since
the global options trigger warnings on generated intl files.

* Remove obsolete analysis options file for Material Gallery example
2016-05-05 16:30:38 -07:00