Zachary Anderson
c4e19962bb
Fix Linux_android_emu tests late initialization errors ( #152932 )
...
This does not fix the issue underlying
https://github.com/flutter/flutter/issues/152684 , but may prevent `adb
logcat` from ending before we've captured the logs that explain why the
app or emulator are potentially crashing.
Fixes Fixes https://github.com/flutter/flutter/issues/152899
2024-08-06 14:48:50 -07:00
Michael Goderbauer
b13f50a918
docimports for flutter_driver ( #151267 )
...
Part of https://github.com/flutter/flutter/issues/150800
2024-07-11 11:30:26 -07:00
Jonah Williams
61326afdae
[flutter_driver] add allocator mtl to memory event allowlist. ( #151153 )
...
Flutter driver side changes for https://github.com/flutter/engine/pull/53618
2024-07-02 15:34:04 +00:00
Parker Lougheed
d802df49d8
Switch to Iterable.cast instance method ( #150185 )
...
Switch away from the `Iterable.castFrom` static method to the `Iterable.cast` instance method which is more readable and more consistent with other iterable usages.
2024-06-14 01:05:24 +00:00
Nate
73ecc8a9b2
Reland "if chains → switch expressions" ( #148634 )
...
I did a goof a while back:
Now that [the bug is fixed](e9d403541fhttps://github.com/flutter/flutter/pull/147793
- https://github.com/flutter/flutter/pull/148556
- https://github.com/flutter/flutter/issues/148548
2024-05-20 17:43:00 +00:00
Zachary Anderson
597462a3c4
Revert "if chains → switch expressions" ( #148556 )
...
Reverts flutter/flutter#147793
Introduced https://github.com/flutter/flutter/issues/148548 .
2024-05-17 10:27:02 -07:00
Nate
fa9992eff6
switch statement cleanup (#148382 )
...
This PR is step 12 in the journey to solve issue #136139 and make the
entire Flutter repo more readable.
Most of it involves implementing switch expressions, and there's also a
few other random things that I wanted to clean up a bit.
2024-05-16 17:16:06 -07:00
Nate
4734d80f22
if chains → switch expressions (#147793 )
...
Previous "if-chains" pull requests:
- https://github.com/flutter/flutter/pull/144905
- https://github.com/flutter/flutter/pull/144977
- https://github.com/flutter/flutter/pull/145194
- https://github.com/flutter/flutter/pull/146293
- https://github.com/flutter/flutter/pull/147472
<br>
I think this one should be enough to wrap things up!
fixes https://github.com/flutter/flutter/issues/144903
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2024-05-10 00:55:48 -06:00
Pierre-Louis
4a65a76279
Reland: Update link branches to main ( #146882 )
...
Reland https://github.com/flutter/flutter/pull/146558 , reverted in https://github.com/flutter/flutter/pull/146880 due to an outdated test result
## Original description
- Update CS and googlesource.com link branches
- Update GitHub /blob/ and /tree/ links
Tested links manually and fixes a few broken or deprecated links
Added a test that validates that `master` isn't used, except for specified repos.
Part of https://github.com/flutter/flutter/issues/121564
2024-04-17 13:16:33 +00:00
Pierre-Louis
33a9643b5d
Revert "Update link branches to main" ( #146880 )
...
Reverts flutter/flutter#146558
Causes failure
2024-04-17 13:25:18 +02:00
Pierre-Louis
072b8874a0
Update link branches to main ( #146558 )
...
- Update CS and googlesource.com link branches
- Update GitHub /blob/ and /tree/ links
Tested links manually and fixes a few broken or deprecated links
Added a test that validates that `master` isn't used, except for
specified repos.
Part of https://github.com/flutter/flutter/issues/121564
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-17 09:44:23 +02:00
Jonah Williams
2ebd7f0d55
[Impeller] measure GPU memory usage. ( #144575 )
...
Framework side to https://github.com/flutter/engine/pull/51187
Part of https://github.com/flutter/flutter/issues/144617
2024-03-06 20:17:31 +00:00
Nate
1a0dc8f1e1
Add missing parameter to TableBorder.symmetric, and improve class constructors ( #144279 )
...
Originally, my aim was just to refactor (as per usual), but while messing around with the `TableBorder.symmetric` constructor, I realized that `borderRadius` was missing!
This pull request makes a few class constructors more efficient, and it fixes #144277 by adding the missing parameter.
<br>
2024-03-04 20:20:19 +00:00
Kate Lovett
20078f89bc
Remove deprecated TimelineSummary.writeSummaryToFile ( #143983 )
...
https://github.com/flutter/flutter/issues/143956
2024-02-23 01:55:20 +00:00
Kate Lovett
cbab555dbb
Remove deprecated FlutterDriver.enableAccessibility ( #143979 )
...
https://github.com/flutter/flutter/issues/143956
2024-02-22 23:24:32 +00:00
Jonah Williams
ec12ba2875
[Impeller] GPU frame timings summarization. ( #136408 )
...
Allow processing GPU start and end events to get processed by flutter driver. To figure out whether or not this works we'll ship in on CI :)
2023-10-13 22:18:37 +00:00
Callum Moffat
b097d24022
Add "Frame Request Pending" lag to collected metrics ( #135279 )
...
This measures the wall clock time between a new frame being scheduled in dart code to the Vsync callback in the engine
It's an important source of lag which isn't shown in the top-level UI / Build time graphs, and can correlate with "invisible" missed/non-scheduled frames
I had to change a few unrelated timings in the test, it was only passing based on luck of sort order, and broke when I added more entries to the timeline.
Part of #129150
2023-09-26 00:35:57 +00:00
Michael Goderbauer
32aa3128ee
Analyze code snippets in flutter_driver docs ( #132337 )
2023-08-15 18:02:30 +00:00
Ian Hickson
b29069ec0b
Document that missed_frame_build_budget_count is misleading ( #132137 )
...
Fixes https://github.com/flutter/flutter/issues/109745
2023-08-08 22:08:30 +00:00
gaaclarke
947367aaa2
Added standard deviation to rasterizer results. ( #131781 )
...
This calculation is important if you want to calculate the probability that one thing is better than another.
2023-08-02 16:40:07 +00:00
Phil Quitslund
5bf6318688
Update collection-fors to prefer final (as per updated prefer_final_in_for_each) ( #127511 )
...
The newly updated lint will soon flag for-each in collections.
See discussion: https://github.com/dart-lang/linter/pull/4383
/cc @goderbauer
2023-05-26 23:34:36 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Nabeel Parkar
6d01ae1377
Bug report 2 issue template ( #122385 )
...
Bug report 2 issue template
2023-04-12 11:06:16 +00:00
Yegor
091104f8bc
[web] stop using deprecated jsonwire web-driver protocol ( #122560 )
...
[web] stop using deprecated jsonwire web-driver protocol
2023-03-14 18:25:23 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Michael Goderbauer
288a7733e5
Remove unnecessary null checks in flutter_driver ( #118864 )
2023-01-20 22:02:49 +00:00
Jakub Fijałkowski
4301731eb2
Make Flutter Driver actively wait for runnable isolate ( #113969 )
...
* Test the case when main Isolate is in `None` state for long time
* Wait for isolate to become runnable
* Handle `PausePostRequest` as a normal "paused" event
* Use `-= 1` instead of `--`
2022-11-16 17:01:22 +00:00
Jonah Williams
0053b089a6
[flutter_driver] make empty duration messages more helpful ( #110441 )
2022-08-28 19:54:08 +00:00
Yegor
e505529344
[web] define $flutterDriverResult variable early in driver test initalization ( #107337 )
2022-07-23 00:48:06 +00:00
Alexandre Ardhuin
ccd33631e3
enable combinators_ordering ( #107847 )
2022-07-18 22:04:07 +00:00
Nguyen Phuc Loi
0cf9d41fc9
[flutter_driver] support send text input action ( #106561 )
...
* Support receive input action
* Fix error syntax
* Fix compile
* Add documents
* Add unit-test
* Update import
* Fixed unit-test and lint
* Add authors for me
* Fixed lint
* Fixed lint
* Add example
* Fixed lint
* Fix gen docs
* Revert code
* Remove flutter_dev
* Update packages/flutter_driver/lib/src/driver/driver.dart
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
* Update packages/flutter_driver/lib/src/common/action.dart
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
* Update packages/flutter_driver/lib/src/common/action.dart
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
* Rename ReceiveAction to SendTextInputAction
* Rename DriverTextInputAction to TextInputAction and fix unit-test
* Reorder import
* Remove space
* Reorder import
* Update text_input.dart
* Update flutter_driver_test.dart
* Update comment to normal comment after dart doc
* Update example
* Update AUTHORS
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
* Fix analyze
* Add type dart for example
* Add unit-test to check the same entries
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2022-07-14 17:21:11 -07:00
Pierre-Louis
74cfc3db67
Use curly_braces_in_flow_control_structures for non-flutter packages ( #104629 )
...
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`
* fix comments
* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`
* fix indentation
2022-05-25 20:01:11 +02:00
Yegor
21b975041f
[web] do not swallow WebDriver errors ( #103754 )
2022-05-16 13:44:24 -07:00
Phil Quitslund
a03f59cdc4
[flutter_driver] rename local functions with _s ( #102689 )
2022-04-27 16:14:10 -07:00
Chris Yang
e6bd208196
Reland "Add the refresh rate fields to perf_test #99710 " ( #99854 )
2022-03-21 15:55:13 -07:00
Zachary Anderson
5f76ac35bc
Revert "Add the refresh rate fields to perf_test ( #99710 )" ( #99801 )
...
This reverts commit a7c85996b8adb3c5b2557e2f08f9de5277c08768.
2022-03-08 23:04:49 -08:00
Chris Yang
a7c85996b8
Add the refresh rate fields to perf_test ( #99710 )
2022-03-08 17:25:15 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint ( #98753 )
2022-02-22 14:39:20 -08:00
Chris Yang
0ce527eb91
[flutter_driver] show refresh rate status in timeline summary ( #95699 )
2022-02-09 15:05:03 -08:00
Yegor
99a09be203
[web] validate WebDriver responses ( #96884 )
...
Validate WebDriver responses
2022-01-20 17:18:40 -08:00
Kaushik Iska
8e9bca802f
Compute the total time spent on UI thread for GC ( #95692 )
2021-12-22 17:04:35 -05:00
Ian Hickson
299d484903
Enable more lints ( #91642 )
2021-10-14 22:03:03 -07:00
Ian Hickson
9421627324
Enable only_throw_errors ( #91567 )
2021-10-11 14:13:03 -07:00
Ian Hickson
7b01346c5c
Enable no_default_cases lint ( #91530 )
2021-10-11 10:23:04 -07:00
Ian Hickson
b3f63d38ac
Document why some lints aren't enabled and fix some minor issues. ( #91527 )
2021-10-09 04:03:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e8dbcb451cc6e969161032cc08da52a.
2021-10-07 16:16:17 -04:00
