37998 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ce933dae9a Roll Skia from 0a9bfc90496e to 1e269594df9d (1 revision) (flutter/engine#55801)
https://skia.googlesource.com/skia.git/+log/0a9bfc90496e..1e269594df9d

2024-10-10 qjw@chromium.org ssci: canonicalize / backfill dependencies managed by DEPS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-10 14:57:19 +00:00
skia-flutter-autoroll
1dcf56dc4b Roll Skia from 6e4a2f266a17 to 0a9bfc90496e (2 revisions) (flutter/engine#55799)
https://skia.googlesource.com/skia.git/+log/6e4a2f266a17..0a9bfc90496e

2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d0e2141a997c to ae5c3b969e66 (10 revisions)
2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 09baf58309a3 to bf6353777f11 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-10 08:26:35 +00:00
skia-flutter-autoroll
43e15ff3ec Roll Skia from 3a9e6b6a4721 to 6e4a2f266a17 (1 revision) (flutter/engine#55797)
https://skia.googlesource.com/skia.git/+log/3a9e6b6a4721..6e4a2f266a17

2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 458c840c3ccf to 4480c8e9e59c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-10 04:50:32 +00:00
Alexander Aprelev
2fd5e6cc09 Roll buildroot to pick up change to --time executions (flutter/engine#55792)
Pick up the change that repeats failed gn_run_binary.py execution
2024-10-10 03:06:35 +00:00
skia-flutter-autoroll
0ef69389f0 Roll Skia from 8c95b719bf05 to 3a9e6b6a4721 (1 revision) (flutter/engine#55793)
https://skia.googlesource.com/skia.git/+log/8c95b719bf05..3a9e6b6a4721

2024-10-10 michaelludwig@google.com [graphite] Clean up legacy dstCopy from KeyContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-10 02:31:23 +00:00
Matan Lurey
4f6d8c462d Move some et tests around and delete unused files. (flutter/engine#55764)
Just general cleanup with no behavioral changes.
2024-10-09 23:03:14 +00:00
Yegor
e478ea9bad [web:a11y] make header a proper <header> (flutter/engine#55747)
Now that we have [proper headings](https://github.com/flutter/engine/blob/main/lib/web_ui/lib/src/engine/semantics/heading.dart), headers should become proper headers.

Fixes https://github.com/flutter/flutter/issues/152268
2024-10-09 22:21:51 +00:00
skia-flutter-autoroll
2295cc1053 Roll Skia from cf9a558b3abb to 8c95b719bf05 (1 revision) (flutter/engine#55788)
https://skia.googlesource.com/skia.git/+log/cf9a558b3abb..8c95b719bf05

2024-10-09 vigneshv@google.com Reland "Enable CrabbyAvif for Android framework"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 22:20:19 +00:00
auto-submit[bot]
eae94cf3df Reverts "Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (#55787)" (flutter/engine#55789)
Reverts: flutter/engine#55787
Initiated by: matanlurey
Reason for reverting: We determined this was an expected failure.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
2024-10-09 21:31:46 +00:00
auto-submit[bot]
93d9a4e1ed Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787)
Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
2024-10-09 21:18:46 +00:00
skia-flutter-autoroll
180e57bf6f Roll Skia from 1349ddc074ad to cf9a558b3abb (2 revisions) (flutter/engine#55785)
https://skia.googlesource.com/skia.git/+log/1349ddc074ad..cf9a558b3abb

2024-10-09 jlavrova@google.com Revert "Adding Fontations to FontConfig manager"
2024-10-09 jlavrova@google.com Adding Fontations to FontConfig manager

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 20:53:38 +00:00
Alexander Aprelev
de3410f8f4 Run gen_snapshot under /usr/bin/time (flutter/engine#55777)
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
2024-10-09 20:47:36 +00:00
Chinmay Garde
9910c947f6 [Impeller] libImpeller: Publish SDK artifacts. (flutter/engine#55783)
Fixes https://github.com/flutter/flutter/issues/156358
2024-10-09 20:35:28 +00:00
Chinmay Garde
57e4161fd8 [Impeller] libImpeller: Allow creating image color sources. (flutter/engine#55754)
Fixes https://github.com/flutter/flutter/issues/156360

This was missed in the earlier bringup.

cc @lyceel I did not expose the solid color source since (as @jonahwilliams [pointed out](https://github.com/flutter/flutter/issues/156360#issuecomment-2398005436)) all it does it [clear the current color source and set the color on the paint](a01daf5555/display_list/dl_builder.cc (L206)).
2024-10-09 20:11:49 +00:00
skia-flutter-autoroll
5c2733f600 Roll Skia from 80191e69c97a to 1349ddc074ad (4 revisions) (flutter/engine#55779)
https://skia.googlesource.com/skia.git/+log/80191e69c97a..1349ddc074ad

2024-10-09 michaelludwig@google.com [graphite] Reset fDstCopy in resetCommandBuffer()
2024-10-09 egdaniel@google.com [Ganesh] Add support for VK_EXT_frame_boundary.
2024-10-09 nscobie@google.com Punt CTS enforcement of VkProtectedContext_Xyz_Graphite tests to API 36
2024-10-09 egdaniel@google.com [Ganesh] Add GrSubmitInfo struct to GrDirectContext::submit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 18:38:23 +00:00
skia-flutter-autoroll
7d44c0e306 Roll Skia from e0bb55353b27 to 80191e69c97a (4 revisions) (flutter/engine#55775)
https://skia.googlesource.com/skia.git/+log/e0bb55353b27..80191e69c97a

2024-10-09 bungeman@google.com [pdf] Emit `/Tabs /S` on each page
2024-10-09 cwallez@chromium.org DawnErrorChecker: Prepare for Dawn StringView callback change.
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dbcb4e8a0f0c to 458c840c3ccf (1 revision)
2024-10-09 fmalita@google.com [skjson] Non-recursive Json writer impl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 16:28:08 +00:00
skia-flutter-autoroll
131f9896ae Manual roll Dart SDK to 3.6.0-334.2.beta (flutter/engine#55772)
Manual roll requested by zra@google.com

This is a Dart roll for branch alignment to the 3.6.0-334.2.beta version
of Dart. It includes the two dev versions below in addition to two CPs
listed at the top of
https://dart.googlesource.com/sdk/+log/d916a5f69a486de98316900f19ef0ff46834b03d.

https://dart.googlesource.com/sdk.git/+log/85a7e014bea8..115a3c609bf2

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.6.0-334.0.dev
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.6.0-333.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC
dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-10-09 09:17:48 -07:00
Matan Lurey
d62fed45f7 Rename GetTargetRenderPassDescriptor to GetRenderTarget. (flutter/engine#55765)
Closes https://github.com/flutter/flutter/issues/154799.
2024-10-09 15:44:41 +00:00
skia-flutter-autoroll
9123b89cc0 Roll Fuchsia Linux SDK from TlU-It6X_ZLrNqMjW... to xGr5ZkxX3CajAY1xu... (flutter/engine#55770)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 10:57:30 +00:00
skia-flutter-autoroll
b6b1210f99 Roll Skia from a077e78e531f to e0bb55353b27 (3 revisions) (flutter/engine#55768)
https://skia.googlesource.com/skia.git/+log/a077e78e531f..e0bb55353b27

2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 878e1c92af0b to d0e2141a997c (1 revision)
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f00ae00fd775 to 09baf58309a3 (10 revisions)
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2574827cf13b to 68d8508758f2 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 08:40:26 +00:00
Chinmay Garde
511ee36f3f [Impeller] libImpeller: Allow fetching OpenGL texture handle. (flutter/engine#55753)
Fixes https://github.com/flutter/flutter/issues/156359

cc @lyceel
2024-10-09 07:44:37 +00:00
skia-flutter-autoroll
b1c6343be2 Roll Fuchsia Test Scripts from jCde9sMKJ3YAdG2DH... to _fkA2GjLQH4bc_n2p... (flutter/engine#55762)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 03:01:19 +00:00
skia-flutter-autoroll
93d88f899d Roll Skia from 701b6e4b4bc4 to a077e78e531f (3 revisions) (flutter/engine#55761)
https://skia.googlesource.com/skia.git/+log/701b6e4b4bc4..a077e78e531f

2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 657296f55449 to dbcb4e8a0f0c (2 revisions)
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 0f7371ae347d to 878e1c92af0b (7 revisions)
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 4103ee393de2 to 2574827cf13b (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 02:18:14 +00:00
Matan Lurey
8e3b58f166 ReleaseonTrimMemoryListener after ImageReaderSurfaceProducer released. (flutter/engine#55760)
Fixes https://github.com/flutter/flutter/issues/156434.

A better fix for the workaround in https://github.com/flutter/flutter/issues/156158.

This should likely be cherrypicked, as it's a memory leak, safe, and avoids workaround code in plugins.
2024-10-09 01:35:17 +00:00
Brandon DeRosier
e118869e40 [Flutter GPU] Get the GLES backend/Windows working. (flutter/engine#55694)
Resolves https://github.com/flutter/flutter/issues/156305.

* Resolve pipelines and submit command buffers on the raster thread.
* Don't use desktop GL shader variation on Windows.
* Fix interpretation of `array_elements`.
* Fix texture binding metadata.

Gets Flutter GPU working on Windows!
![image](https://github.com/user-attachments/assets/9eecb67f-a980-4556-8060-b0c947713534)
![image](https://github.com/user-attachments/assets/c8e2071f-e7c0-411c-8f37-e1f3037916f4)
2024-10-09 00:04:39 +00:00
Harry Terkelsen
0ed39374df [canvaskit] Fix incorrect clipping with Opacity scene layer (flutter/engine#55751)
Fixes opacity layer incorrectly clipping its children when there are complex transforms applied to them. Since the opacity saveLayer only applies to children which actually draw, it doesn't need to have tight bounds anyways.

Pre-requisite for re-enabling tests here: https://github.com/flutter/flutter/issues/110785

BEFORE:
![Screenshot 2024-10-08 at 11 00 14 AM](https://github.com/user-attachments/assets/cf4c6296-7730-4db6-96f6-e22f32e28d94)

AFTER:
![Screenshot 2024-10-08 at 11 06 22 AM](https://github.com/user-attachments/assets/6a680e2c-23d0-41e2-9de5-1c9667a785ab)

BEFORE:
![failing_opacity](https://github.com/user-attachments/assets/d8acf075-c92d-4f8a-aa1a-476f46f1c931)

AFTER:
![working_opacity](https://github.com/user-attachments/assets/3e589deb-d8b6-4466-9e19-95daff870bfb)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-08 23:49:09 +00:00
Matan Lurey
173af3d95f Refactor multi-file build parsing into a single BuildPlan class. (flutter/engine#55720)
Closes https://github.com/flutter/flutter/issues/148444 (code de-duplicated).
Closes https://github.com/flutter/flutter/issues/150877 (`--build-strategy=local`).
Closes https://github.com/flutter/flutter/issues/150884 (`--build-strategy=remote`).

Replaces duplicate code across ~3 commands (query, test, build) with a class called `BuildPlan`, which encapsulates (a) concurrency, (b) build configuration, (c) RBE, (d) LTO, and (e) build strategy. I also moved all of the validation of the build plan into `build_plan_test`, which gives us better coverage at a lower cost (less things to think about in that suite of tests).

I know the diff looks scary, but 1K of the 1.4K is tests.

/cc @gaaclarke @flar
2024-10-08 23:45:20 +00:00
gaaclarke
90cea20d09 fixes mask blurs on stoked gradient geometry (flutter/engine#55717)
fixes https://github.com/flutter/flutter/issues/155930

This starts taking into account the translation of the entity that is
snapshotted when performing the gaussian blur. I'm uncertain under what
conditions, but sometimes the snapshot logic would need this offset. The
linked issue and added tests demonstrate those cases.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 15:20:50 -07:00
Jason Simmons
d8d3d6ac4b [Impeller] Do not scale the miter limit applied to stroked text (flutter/engine#55745)
Fixes https://github.com/flutter/flutter/issues/156224
2024-10-08 22:07:19 +00:00
AthulJoseph
a01daf5555 Added support to set primitive type (flutter/engine#55514)
Added a way to specify the PrimitiveType when encoding commands in the RenderPass.

This partially fixes the issue #142732
2024-10-08 21:57:10 +00:00
skia-flutter-autoroll
f15530a2e9 Roll Skia from 8a2fe88d31e3 to 701b6e4b4bc4 (1 revision) (flutter/engine#55752)
https://skia.googlesource.com/skia.git/+log/8a2fe88d31e3..701b6e4b4bc4

2024-10-08 robertphillips@google.com [ganesh] Disable stencilBuffers and MSAA for Protected GL Contexts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 21:51:23 +00:00
Chinmay Garde
50366d309d [Impeller] libImpeller: Fix typo in public API. (flutter/engine#55750)
cc @lyceel
2024-10-08 20:50:13 +00:00
Chinmay Garde
7af6ae84e6 [Impeller] libImpeller: Allow wrapping external texture handles. (flutter/engine#55664)
Fixes https://github.com/flutter/flutter/issues/156013
2024-10-08 20:33:26 +00:00
gaaclarke
d2e73aef5b Added mutex to the pending gpu tasks deque. (flutter/engine#55748)
b/371513051

The tasks are already capturing their target thread. I had just missed
guarding the deque that is storing the tasks. This has been seen in the
flaking of the newly added `ShellTest.EncodeImageRetryOverflows`.

Example:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734621687934134433/+/u/test:_Host_Tests_for_host_debug_unopt/stdout

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 13:19:42 -07:00
skia-flutter-autoroll
d75cffe14f Roll Skia from 857248fe0a9a to 8a2fe88d31e3 (7 revisions) (flutter/engine#55749)
https://skia.googlesource.com/skia.git/+log/857248fe0a9a..8a2fe88d31e3

2024-10-08 michaelludwig@google.com [skif] Adjust test tolerances for some GPUs
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from aacbf041f6cd to 0f7371ae347d (14 revisions)
2024-10-08 nicolettep@google.com [graphite] Migrate Vulkan pipeline to consulting immutable sampler descriptions populated at graphite level
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b0d038d01ff9 to 4103ee393de2 (10 revisions)
2024-10-08 michaelludwig@google.com [skif] Fix rescale bounds analysis, consolidate draw codepaths
2024-10-08 michaelludwig@google.com [graphite] Update PaintParams key generation and SkSL generation to use dstCopy intrinsics
2024-10-08 nscobie@google.com [graphite] Fix VulkanCaps::fSupportsMemorylessAttachments init when fProtectedSupport

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 20:04:04 +00:00
Jonah Williams
32aa60630b [Impeller] remove heap allocation of most geometry objects. (flutter/engine#55677)
Almost all geometry objects can now be stack allocated while rendering, instead of heap allocated - due to the removal of the EntityPass compositor. Clip geometries must still be heap allocated as the geometry objects are not yet stored in the display list, and the clips must be recorded for backdrop filter clip replay.

The canvas stores unique_ptrs to these geometries in a vector that it clears at the end of the frame. The Geometry factory methods were adjusted to return unique ptrs, and the Geometry class given a virtual dtor since we no longer rely on the special property of std::shared_ptr for memorizing the right dtor.

The ColorSourceContents and ClipContents class now hold onto a const ptr to the geometry object.

At some point in the future, we can rework the geometry object to be stored inline in the display list which will further simplify this code.

Part of https://github.com/flutter/flutter/issues/142054
2024-10-08 19:55:21 +00:00
gaaclarke
96134c85e4 added shell_unittests and ui_unittests to the testing menu (flutter/engine#55711)
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 11:17:01 -07:00
John McDole
35d7b1b8f3 Record notes on hashing artifacts in a monorepo (flutter/engine#55703)
aka "dude, where's my engine?"
2024-10-08 17:01:07 +00:00
skia-flutter-autoroll
e583fecd59 Roll Skia from 38e2598c487b to 857248fe0a9a (3 revisions) (flutter/engine#55741)
https://skia.googlesource.com/skia.git/+log/38e2598c487b..857248fe0a9a

2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 90b955a8bf93 to b0d038d01ff9 (25 revisions)
2024-10-08 danieldilan@google.com Add SubIFD to exif data when using WriteExif.
2024-10-08 kjlubick@google.com Replace/rename Gr* functions in SkMathPriv with Sk* naming convention

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 16:27:21 +00:00
skia-flutter-autoroll
8a01448768 Roll Skia from 1e9afcd7dda6 to 38e2598c487b (1 revision) (flutter/engine#55737)
https://skia.googlesource.com/skia.git/+log/1e9afcd7dda6..38e2598c487b

2024-10-08 kjlubick@google.com Revert "Enable CrabbyAvif for Android framework"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 13:52:23 +00:00
skia-flutter-autoroll
c7cd711296 Roll Skia from d639ed5e570a to 1e9afcd7dda6 (1 revision) (flutter/engine#55736)
https://skia.googlesource.com/skia.git/+log/d639ed5e570a..1e9afcd7dda6

2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a07eac9c2613 to 657296f55449 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 12:09:26 +00:00
skia-flutter-autoroll
8c4e6c531c Roll Dart SDK from 7b965fbaa954 to 85a7e014bea8 (2 revisions) (flutter/engine#55735)
https://dart.googlesource.com/sdk.git/+log/7b965fbaa954..85a7e014bea8

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-332.0.dev
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-331.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 10:50:41 +00:00
skia-flutter-autoroll
06d7a97aa2 Roll Fuchsia Linux SDK from TTSSw-kHM8_h_tdX0... to TlU-It6X_ZLrNqMjW... (flutter/engine#55733)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 08:39:12 +00:00
skia-flutter-autoroll
543d1c9f12 Roll Skia from 3866c52c4aa0 to d639ed5e570a (4 revisions) (flutter/engine#55732)
https://skia.googlesource.com/skia.git/+log/3866c52c4aa0..d639ed5e570a

2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73d05ecd42e4 to f00ae00fd775 (7 revisions)
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 38bd0b71717f to 034839b9814b
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b1e534c0b156 to 6a07fae851d7
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from c48a419da832 to 931df19ec335

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 06:51:58 +00:00
skia-flutter-autoroll
119fcc0d19 Roll Fuchsia Test Scripts from ckCnIfKM2nOtYiVvK... to jCde9sMKJ3YAdG2DH... (flutter/engine#55731)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 06:07:47 +00:00
dependabot[bot]
088fecfaf1 Bump google/osv-scanner-action from 1.8.4 to 1.9.0 (flutter/engine#55730)
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action) from 1.8.4 to 1.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.9.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot"><code>@​renovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/40">google/osv-scanner-action#40</a></li>
<li>chore(deps): update github/codeql-action action to v3.26.7 by <a href="https://github.com/renovate-bot"><code>@​renovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/43">google/osv-scanner-action#43</a></li>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot"><code>@​renovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/44">google/osv-scanner-action#44</a></li>
<li>chore(deps): update github/codeql-action action to v3.26.10 by <a href="https://github.com/renovate-bot"><code>@​renovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/45">google/osv-scanner-action#45</a></li>
<li>Update to v1.9.0 by <a href="https://github.com/michaelkedar"><code>@​michaelkedar</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/46">google/osv-scanner-action#46</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/michaelkedar"><code>@​michaelkedar</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/46">google/osv-scanner-action#46</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.8.5...v1.9.0">https://github.com/google/osv-scanner-action/compare/v1.8.5...v1.9.0</a></p>
<h2>v1.8.5</h2>
<p>This updates OSV-Scanner to v1.8.5.</p>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot"><code>@​renovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/34">google/osv-scanner-action#34</a></li>
<li>fix: Use force checkout on second checkout for PR scanning by <a href="https://github.com/another-rex"><code>@​another-rex</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/41">google/osv-scanner-action#41</a></li>
<li>chore: update to v1.8.5 by <a href="https://github.com/cuixq"><code>@​cuixq</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/42">google/osv-scanner-action#42</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/cuixq"><code>@​cuixq</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/42">google/osv-scanner-action#42</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.8.5">https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.8.5</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="19ec111656"><code>19ec111</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/46">#46</a> from google/update-to-v1.9.0</li>
<li><a href="305dc322e6"><code>305dc32</code></a> Update unified workflow example to point to v1.9.0 reusable workflows</li>
<li><a href="1748759ebf"><code>1748759</code></a> Update reusable workflows to point to v1.9.0 actions</li>
<li><a href="c80d3cb8d7"><code>c80d3cb</code></a> Update actions to use v1.9.0 osv-scanner image</li>
<li><a href="d2af9baafc"><code>d2af9ba</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/45">#45</a> from renovate-bot/renovate/workflows</li>
<li><a href="0f80bc47d7"><code>0f80bc4</code></a> chore(deps): update github/codeql-action action to v3.26.10</li>
<li><a href="eb1b88d88a"><code>eb1b88d</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/44">#44</a> from renovate-bot/renovate/workflows</li>
<li><a href="fc1c0fda72"><code>fc1c0fd</code></a> chore(deps): update workflows</li>
<li><a href="32affcbc50"><code>32affcb</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/43">#43</a> from renovate-bot/renovate/workflows</li>
<li><a href="5319a0e003"><code>5319a0e</code></a> chore(deps): update github/codeql-action action to v3.26.7</li>
<li>Additional commits viewable in <a href="https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.9.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/osv-scanner-action&package-manager=github_actions&previous-version=1.8.4&new-version=1.9.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-10-08 05:53:58 +00:00
dependabot[bot]
3e7a61880d Bump actions/upload-artifact from 4.3.6 to 4.4.1 (flutter/engine#55728)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.4.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Add a section about hidden files by <a href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/607">actions/upload-artifact#607</a></li>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/621">actions/upload-artifact#621</a></li>
<li>Update <code>@​actions/artifact</code> to latest version, includes symlink and timeout fixes by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/625">actions/upload-artifact#625</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/621">actions/upload-artifact#621</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.4.0...v4.4.1">https://github.com/actions/upload-artifact/compare/v4.4.0...v4.4.1</a></p>
<h2>v4.4.0</h2>
<h2>Notice: Breaking Changes ⚠️</h2>
<p>We will no longer include hidden files and folders by default in the <code>upload-artifact</code> action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, <code>include-hidden-files</code>, to continue to do so.</p>
<p>See <a href="https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/">&quot;Notice of upcoming deprecations and breaking changes in GitHub Actions runners&quot;</a> changelog and <a href="https://redirect.github.com/actions/upload-artifact/issues/602">this issue</a> for more details.</p>
<h2>What's Changed</h2>
<ul>
<li>Exclude hidden files by default by <a href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/598">actions/upload-artifact#598</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.6...v4.4.0">https://github.com/actions/upload-artifact/compare/v4.3.6...v4.4.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="604373da63"><code>604373d</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/625">#625</a> from actions/robherley/artifact-2.1.10</li>
<li><a href="0150148bdf"><code>0150148</code></a> paste right core version</li>
<li><a href="a009b25faa"><code>a009b25</code></a> update licenses</li>
<li><a href="9f6f6f402e"><code>9f6f6f4</code></a> update <code>@​actions/core</code> and <code>@​actions/artifact</code> to latest versions</li>
<li><a href="3eadd8b791"><code>3eadd8b</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/621">#621</a> from actions/Jcambass-patch-1</li>
<li><a href="aeba9f7961"><code>aeba9f7</code></a> Add workflow file for publishing releases to immutable action package</li>
<li><a href="b18b1d32f3"><code>b18b1d3</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/607">#607</a> from actions/joshmgross/hidden-files-readme</li>
<li><a href="d7c12077c4"><code>d7c1207</code></a> Add a section about hidden files</li>
<li><a href="50769540e7"><code>5076954</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/598">#598</a> from actions/joshmgross/exclude-hidden-files</li>
<li><a href="d52396ac5d"><code>d52396a</code></a> Add a warning about enabling <code>include-hidden-files</code></li>
<li>Additional commits viewable in <a href="834a144ee9...604373da63">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.6&new-version=4.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-10-08 05:53:57 +00:00
dependabot[bot]
29cb62cdca Bump actions/checkout from 4.2.0 to 4.2.1 (flutter/engine#55729)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1919">actions/checkout#1919</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.0...v4.2.1">https://github.com/actions/checkout/compare/v4.2.0...v4.2.1</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@​dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@​peterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eef61447b9"><code>eef6144</code></a> Prepare 4.2.1 release (<a href="https://redirect.github.com/actions/checkout/issues/1925">#1925</a>)</li>
<li><a href="6b42224f41"><code>6b42224</code></a> Add workflow file for publishing releases to immutable action package (<a href="https://redirect.github.com/actions/checkout/issues/1919">#1919</a>)</li>
<li><a href="de5a000abf"><code>de5a000</code></a> Check out other refs/* by commit if provided, fall back to ref (<a href="https://redirect.github.com/actions/checkout/issues/1924">#1924</a>)</li>
<li>See full diff in <a href="d632683dd7...eef61447b9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.2.0&new-version=4.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-10-08 05:48:00 +00:00
skia-flutter-autoroll
541053436b Roll Dart SDK from 3c4726445ba5 to 7b965fbaa954 (1 revision) (flutter/engine#55726)
https://dart.googlesource.com/sdk.git/+log/3c4726445ba5..7b965fbaa954

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-330.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 05:38:49 +00:00
skia-flutter-autoroll
c1cca0ed5e Roll Skia from d0e49fde3765 to 3866c52c4aa0 (3 revisions) (flutter/engine#55723)
https://skia.googlesource.com/skia.git/+log/d0e49fde3765..3866c52c4aa0

2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 50fae2cd87dc to 99b73d05cdae
2024-10-08 kjlubick@google.com Add tests for SkNextPow2
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd729cf1f807 to a07eac9c2613 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 04:33:48 +00:00