7254 Commits

Author SHA1 Message Date
Jason Simmons
e0e291011e
Delete test/data/asset_test/main/.packages (#14252)
(this will be generated by flutter update-packages)
2018-01-25 09:39:54 -08:00
Chris Bracken
d3705f3ea9
Add android workflow test (#14260)
Adds unit tests for AndroidWorkflow.runLicenseManager().
2018-01-24 22:27:24 -08:00
Chris Bracken
74478d186c
Extract MockAndroidSdk and static utility method (#14258)
AndroidSdk and AndroidStudio depends relatively heavily on filesystem
access to locate installed tools. Testing code that relies on either of
these classes benefits from a utility method to generate a
legitimate-looking Android SDK directory layout for testing.
2018-01-24 20:40:25 -08:00
Chris Bracken
1058cff395
Add version check for doctor --android-licenses (#14249)
flutter doctor --android-licenses requires Android sdkmanager version 26
or later. When sdkmanager is not available (SDKs earlier than v25),
direct users to SDK upgrade instructions. When it's installed but not
v26 or later, emit instructions to run sdkmanager --update.
2018-01-24 20:01:11 -08:00
Chris Bracken
538ba522ee
Move common process/IO-related mocks to mocks.dart (#14255)
Moves MockProcess, MockStdio and a few other useful mocks from
packages_test.dart to common/mocks.dart. These are useful for testing
code with interactive IO.

This adds a new constructor to MockProcess to provide additional flexibility.
2018-01-24 17:16:30 -08:00
Vyacheslav Egorov
a5b3139126 Use void as type argument instead of Null where appropriate 2018-01-24 15:25:29 -08:00
Michael Goderbauer
84580b545a
Make Assets more robust across platforms (#14246) 2018-01-24 13:16:23 -08:00
Chris Bracken
9654659c72
Add AndroidSdk.sdkManagerPath, sdkManagerVersion (#14247)
Convenience getters for the the path to the Android SDK manager and the
currently installed version of the tool.

Pre-factoring to support better checks around the --android-licenses
command, which uses a feature of the SDK manager that is unsupported in
older versions of the tool.
2018-01-24 12:38:08 -08:00
Sam Rawlins
5ae770345a Self-execute closure passed to assert (#14235) 2018-01-23 13:46:14 -08:00
Michael Goderbauer
8059aea365
TextFields should only have one SemanticsNode (#14219)
* scrolling node eleminated

* remove second node

* fix ids
2018-01-22 18:12:39 -08:00
Hans Muller
773902c59d
Fix _RenderDecoration.debugDescribeChildren() (#14217) 2018-01-22 17:14:44 -08:00
xster
e64d44ca78
CupertinoPicker part 1 - create a generic ListWheelScrollView (#13783)
* Create ListWheelScrollView

* fix missing doc

* tweak docs a bit

* fix imports

* Add some tests

* review

* review and transform tests

* fix test

* repatch lost 977701cf69

* review

* Review
2018-01-22 12:02:32 -08:00
Tan Jay Jun
de023bc6f4 Improve SystemChrome documentation (#14181) 2018-01-22 11:08:17 -08:00
Alexander Aprelev
7c2fe34fbb
Run 'flutter test --preview-dart-2' in strong mode (#14188)
* Default to strong for 'flutter test --preview-dart-2' mode

* Remove empty line

* Dont init to null

* Break up line to make it more readable

* Add missing type annotation
2018-01-22 10:26:01 -08:00
Michael Goderbauer
733bd04904
Fix custom fonts on Windows (#14191)
Fixes https://github.com/flutter/flutter/issues/13870.
2018-01-22 10:00:27 -08:00
Devon Carew
159db5ca44
pass through preview-dart-2, strong, ipv6 in daemon mode (#14200)
* pass through preview-dart-2, strong, ipv6 in daemon mode

* ws change to kick the windows bot
2018-01-20 14:43:23 -08:00
Alexander Aprelev
a92110a265
Clean up build directory before copying freshly produced build artifacts over. (#14081) 2018-01-20 11:11:44 -08:00
Ian Hickson
a29d723c59
[H] Move the splitting of licenses to an isolate (#14160)
* Move the splitting of licenses to an isolate

This improves (from horrific to terrible) the performance of the
license screen. It also introduces a feature in the foundation layer
to make using isolates for one-off computations easier.

The real problem that remains with this, though, is that transfering
data between isolates is a stop-the-world operation and can take an
absurd amount of time (far more than a few milliseconds), so we still
skip frames.

More work thus remains to be done.

* - Add profile instrumentation to the isolate compute() method
- Add profile instrumentation to the LicensePage
- Add profile instrumentation to the scheduleTask method
- Make scheduleTask support returning a value
- Make the license page builder logic use scheduled tasks so that it doesn't blow the frame budget
2018-01-20 01:42:55 -08:00
Hans Muller
677f218ef6
Added InputDecorationTheme (#14177) 2018-01-19 22:53:29 -08:00
Ian Hickson
38ce59f039 [G] Revert "Exclude flutter doctor IDE validators in CI environments" (#14196)
* Revert "Bump async, http, and vm_service_client packages (#14136)"

This reverts commit 7ffcce84a2037376afe2614d6789c30a57bdb0a8.

* Revert "Exclude flutter doctor IDE validators in CI environments (#13816)"

This reverts commit 3258c546185502c8dff04e8cbf4f4352f2d3600d.
2018-01-19 20:47:23 -08:00
Sam Rawlins
7ffcce84a2 Bump async, http, and vm_service_client packages (#14136) 2018-01-19 14:59:16 -08:00
Ali Bitek
3258c54618 Exclude flutter doctor IDE validators in CI environments (#13816) 2018-01-19 14:45:10 -08:00
Alexander Aprelev
e910ce7ece
Fix local import paths. (#14183)
This is in attempt to resolve build failure on Windows.
2018-01-19 07:05:28 -08:00
Alexander Aprelev
a50b465c99
Add --preview-dart-2 to 'flutter test' (#14135) 2018-01-19 06:17:28 -08:00
Ian Hickson
bed71b9a15
Make FadeTransition more efficient (#14155)
* Make FadeTransition more efficient

* Update fade_transition_test.dart

* Update proxy_box.dart
2018-01-18 20:22:22 -08:00
Ian Hickson
3ac9449ad4
Fix the confusing-zero case with NestedScrollView. (#14133)
* Fix the confusing-zero case with NestedScrollView.

* Update mock_canvas.dart

* Update tabs_demo.dart

* more tweaks
2018-01-18 20:21:15 -08:00
Hans Muller
629d325284
Fix: InputDecorator fails with null border, non-null labelText (#14166) 2018-01-18 17:15:43 -08:00
Jacob Richman
2e4522f7ec
Inspector robustness fixes. (#14154)
* Inspector robustness fixes.
Avoid cases where setState was called on disposed object.
Avoid cases where the inspector wouldn't render as it was called
after the first frame rendered and no other frames were rendered.
2018-01-18 16:19:31 -08:00
jcollins-g
460dd00b72
Make automated_tests mostly ignore extraneous error messages (#14170)
* Ignore extraneous error messages outside of one skipped test

* Fix analysis error
2018-01-18 14:06:35 -08:00
Ian Hickson
9e42e4b88f
New release process (#14061)
Generate the "version" file from git tags.
Remove the old VERSION file and mentions of versions in pubspec.yaml files.
Replace the old update_versions.dart script with a new roll_dev.dart script.
Update "flutter channel".
Update "flutter upgrade", including making it transition from alpha to dev.
Update "flutter --version" and "flutter doctor".
2018-01-18 07:59:06 -08:00
Mikkel Nygaard Ravn
4353297079
Change default organization name to example.com in project templates (#14116) 2018-01-18 09:21:24 +01:00
xster
0efc06ca45
Disable cocoapods stats in Podfile template (#13945) 2018-01-17 18:17:04 -08:00
Ian Hickson
521bdaea05
Specify what image formats are supported in the API docs. (#13717)
Depends on https://github.com/flutter/engine/pull/4483
2018-01-17 17:47:47 -08:00
Jason Simmons
0434ae22ec
Do not apply the canvas bounds as a cull rectangle when recording a Skia picture (#14027)
The picture may need to draw outside the bounds (specifically for shadows)

Fixes https://github.com/flutter/flutter/issues/12618
2018-01-17 16:30:17 -08:00
Michael Goderbauer
a67df9e1d1
Fix crash during artifact download (#14147) 2018-01-17 16:08:19 -08:00
Michael Goderbauer
bf7cc09625
Moar tests on Windows (#14148) 2018-01-17 16:08:07 -08:00
Ian Hickson
6da8ec6bd0
Skip a test that fails on Windows for weird reasons (#14145)
Trying to get the build green. We will have to go through skipped tests as a more long-term task.
2018-01-17 15:39:51 -08:00
Michael Goderbauer
15af86459d
Identify CheckBox and RadioButton as such (#14087)
* Identify CHeckBox and RadioButton as such

* review feedback
2018-01-17 10:23:36 -08:00
Ian Hickson
18c60d3301
Fix import statements in flutter_tools (#13911) 2018-01-17 10:17:52 -08:00
Hans Muller
7b6af52c92
Improve TextField splash management: cancel() ... confirm() (#14130) 2018-01-17 09:27:22 -08:00
Hans Muller
b94f757d77
Small simplification in RenderEditable (#14119) 2018-01-17 09:14:30 -08:00
Ian Hickson
b0d5d2d928
Escape path separator in regexps (#14122)
* Escape path separator in regexps

* Update platform_helper.dart

* Update stack_trace_test.dart

* Update stack_trace_test.dart
2018-01-17 09:09:00 -08:00
Ian Hickson
2908997b0e
Dump exceptions live when they happen when testing tests with flutter run (#14102)
* Dump exceptions live when they happen when testing tests with flutter run.

* Update binding.dart
2018-01-17 09:06:43 -08:00
Hans Muller
e63a63784c
Fix dartdoc errors in generated localization code and RenderEditable (#14132) 2018-01-17 08:37:02 -08:00
Michael Goderbauer
37e1684825
Document Android's SemanticsAction.tap behavior (#14031)
* Document Android's SemanticsAction.tap behavior

Fixes https://github.com/flutter/flutter/issues/13219.

* review comment
2018-01-16 23:19:40 -08:00
Ian Hickson
f98b4863a7
Make debugCheckHasMaterial more useful (#14101)
Fixes https://github.com/flutter/flutter/issues/2877
2018-01-16 20:31:21 -08:00
Vyacheslav Egorov
b1248de5e3
Strong mode fix for datePatterns in material localizations (#14117)
Code that uses dataPatterns[loc] expects it to contain Map<String, String>, not Map<String, dynamic>.

Change gen_date_localizations.dart to generate datePatterns with a more precise type and regenerate date_localizations.dart.
2018-01-16 21:23:19 +01:00
Dwayne Slater
4488f58acf Set _imageInfo to null BEFORE adding listener to new ImageStream (#13825)
* Set _imageInfo to null before adding listener to new ImageStream

Fixes an edge case where switching the ImageStream to an already completed ImageStream caused the Image widget to show nothing. ImageStreamCompleter calls the listener during addListener if their image is already loaded.

* Fix whitespace

* Add test to verify correct behavior

* Added test from mravn-google's PR
2018-01-16 10:14:01 -08:00
Ian Hickson
c5050bc8a9
Prepare for running tests on Windows (#14112)
Seems like we don't yet run the flutter tests on Windows, but we're
close to being able to. This makes some minor changes to make that
more possible:

 - fix the stack parsing code to support Windows paths
 - fix the tests for the stack error handling code to handle Windows paths
 - skip some tests that rely on Ahem font metrics
2018-01-16 10:11:13 -08:00
Michael Goderbauer
0efc8cde1f
Fix SemanticsData hashode and equals (#14079) 2018-01-16 09:44:56 -08:00