9936 Commits

Author SHA1 Message Date
Hans Muller
7b6af52c92
Improve TextField splash management: cancel() ... confirm() (#14130) 2018-01-17 09:27:22 -08:00
Hans Muller
b94f757d77
Small simplification in RenderEditable (#14119) 2018-01-17 09:14:30 -08:00
Ian Hickson
b0d5d2d928
Escape path separator in regexps (#14122)
* Escape path separator in regexps

* Update platform_helper.dart

* Update stack_trace_test.dart

* Update stack_trace_test.dart
2018-01-17 09:09:00 -08:00
Ian Hickson
2908997b0e
Dump exceptions live when they happen when testing tests with flutter run (#14102)
* Dump exceptions live when they happen when testing tests with flutter run.

* Update binding.dart
2018-01-17 09:06:43 -08:00
Hans Muller
e63a63784c
Fix dartdoc errors in generated localization code and RenderEditable (#14132) 2018-01-17 08:37:02 -08:00
jcollins-g
bc10fce46e
Update dartdoc version to 0.15.1. (#14123) 2018-01-17 08:09:31 -08:00
Michael Goderbauer
37e1684825
Document Android's SemanticsAction.tap behavior (#14031)
* Document Android's SemanticsAction.tap behavior

Fixes https://github.com/flutter/flutter/issues/13219.

* review comment
2018-01-16 23:19:40 -08:00
Ian Hickson
f98b4863a7
Make debugCheckHasMaterial more useful (#14101)
Fixes https://github.com/flutter/flutter/issues/2877
2018-01-16 20:31:21 -08:00
Vyacheslav Egorov
b1248de5e3
Strong mode fix for datePatterns in material localizations (#14117)
Code that uses dataPatterns[loc] expects it to contain Map<String, String>, not Map<String, dynamic>.

Change gen_date_localizations.dart to generate datePatterns with a more precise type and regenerate date_localizations.dart.
2018-01-16 21:23:19 +01:00
Dwayne Slater
4488f58acf Set _imageInfo to null BEFORE adding listener to new ImageStream (#13825)
* Set _imageInfo to null before adding listener to new ImageStream

Fixes an edge case where switching the ImageStream to an already completed ImageStream caused the Image widget to show nothing. ImageStreamCompleter calls the listener during addListener if their image is already loaded.

* Fix whitespace

* Add test to verify correct behavior

* Added test from mravn-google's PR
2018-01-16 10:14:01 -08:00
Ian Hickson
c5050bc8a9
Prepare for running tests on Windows (#14112)
Seems like we don't yet run the flutter tests on Windows, but we're
close to being able to. This makes some minor changes to make that
more possible:

 - fix the stack parsing code to support Windows paths
 - fix the tests for the stack error handling code to handle Windows paths
 - skip some tests that rely on Ahem font metrics
2018-01-16 10:11:13 -08:00
Michael Goderbauer
0efc8cde1f
Fix SemanticsData hashode and equals (#14079) 2018-01-16 09:44:56 -08:00
jcollins-g
a6e5de2176
Make artifact downloading more robust for flaky networks, take two (#14084)
* Revert "Revert "Make artifact downloading more robust for flaky networks" (#13995)"

This reverts commit 33d8a03545ebacd821aa9cd688156e792c9c6fff.

* Use subdirectories to organize cached files

* Fix unauthorized import
2018-01-16 08:07:37 -08:00
Vyacheslav Egorov
b47a25cea7
Strong mode fix in Table._updateRenderObjectChildren (#14108)
renderObject.setFlatChildren expects List<RenderBox>, not List<RenderObject>.
2018-01-16 16:46:32 +01:00
Vyacheslav Egorov
d9fd4d6f49
Make sure to pass strong mode options down to gen_snapshot (#14118) 2018-01-16 15:38:29 +01:00
Ian Hickson
299ddb4320
Add some color to the ShapeDecoration.shape docs (#14100)
...especially about TextDirection.
2018-01-15 12:43:43 -08:00
Alexander Aprelev
09a6df7461
Clean up output directory before copying over new files (#14085)
* Clean up output directory before copying over new files

* Use standard clean task command
2018-01-14 18:24:07 -08:00
Vyacheslav Egorov
6e38b42919
Fix a couple of strong mode issues. (#14070)
* JSON.decode produces Map<String, dynamic> and List<dynamic>
objects. If a more tight type is required then object needs to
be converted explicitly (see dart-lang/sdk#31876);
* Completer<dynamic> produces Future<dynamic>. In Dart 2 it is
runtime error to assign Future<dynamic> to variable of type Future<T>;
2018-01-13 09:18:12 +01:00
Jason Simmons
e11cf5c94c
Use a safe codec to read Skia SKP screenshot files when checking for errors (#14086)
If the downloaded file is an actual SKP and not an error report, then the
default UTF-8 codec will fail to decode the SKP content
2018-01-12 17:54:49 -08:00
Hans Muller
27eeb9722f
TextField splash integration (#14055) 2018-01-12 17:40:53 -08:00
Yegor
c09736bb58
flutter_view_ios__start_up: move all test logic into TaskFunction (#14088) 2018-01-12 16:56:54 -08:00
Sam Rawlins
ce939564fa Bump json_rpc_2 dependency (#14051) 2018-01-12 16:23:51 -08:00
amirh
0230a87476
Add a PhysicalShape widget and a render object for it. (#13682)
This CL also refactors common logic for RenderPhysicalModel and
RenderPhysicalShape into a base class _RenderPhysicalModelBase.
2018-01-12 15:56:01 -08:00
Chris Bracken
6a42ed3f55
Decode syslog-encoded iOS logs (#14075)
Apple encodes syslog entries using a 7-bit encoding where input UTF-8 bytes
are encoded as follows:
1. 0x00 to 0x19: non-printing range. Some ignored, some encoded as <...>.
2. 0x20 to 0x7f: as-is, with the exception of 0x5c (backslash).
3. 0x5c (backslash): octal representation \134.
4. 0x80 to 0x9f: \M^x (using control-character notation for range 0x00 to 0x40).
5. 0xa0: octal representation \240.
6. 0xa1 to 0xf7: \M-x (where x is the input byte stripped of its high-order bit).
7. 0xf8 to 0xff: unused in 4-byte UTF-8.

As there doesn't appear to be a system tool to decode these strings, we
implement here in Dart. If we're unable to decode a string (e.g.
decoding results in an invalid UTF-8 string), we fall back to emitting
the log line as-is.
2018-01-12 15:12:26 -08:00
Michael Goderbauer
1b91582d2e
Add Flutter Console for Windows (#14030)
Just download a Flutter ZIP bundle, unzip, and double-click on `flutter_console.bat` to get started. No PATH modifications required.
2018-01-12 15:09:55 -08:00
Ian Hickson
80d6095d98
Fix ShapeDecoration (#14009)
And add a test that catches these problems.
2018-01-12 15:03:51 -08:00
Sam Rawlins
e8b666249a Bump collection dependency to 1.14.5 (#14048) 2018-01-12 14:33:26 -08:00
Yegor
6028fe85bb
mark complex_layout_scroll_perf_ios__timeline_summary as flaky\ (#14080) 2018-01-12 13:33:54 -08:00
Ian Hickson
8cf109d20f
Reland #14054 after having landed all the engine commits in between (#14064)
This gets us back to where we were a few minutes ago.
2018-01-11 23:21:53 -08:00
Ian Hickson
e859995d11
Update engine.version 2018-01-11 22:29:07 -08:00
Ian Hickson
2ff39d88a6
Update engine.version 2018-01-11 22:28:57 -08:00
Ian Hickson
cafc5dc5f0
Update engine.version 2018-01-11 22:28:46 -08:00
Ian Hickson
6fd5f265a0
Update engine.version 2018-01-11 22:28:34 -08:00
Ian Hickson
34bbc58a1d
Update engine.version 2018-01-11 22:28:19 -08:00
Ian Hickson
5c3ca9f625
Update engine.version 2018-01-11 22:28:05 -08:00
Ian Hickson
908db567c9
Update engine.version 2018-01-11 22:27:49 -08:00
Ian Hickson
78dcc0e685
Revert "Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)" (#14063)
This reverts commit 592f297922270c0c338b0048d37a510c9c16db14.
2018-01-11 22:27:11 -08:00
amirh
592f297922
Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)
* Revive "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)"

That commit was reverted due to a performance problem which has now been
fixed.

* Roll engine 05fe72d068e19c7886e8d27f9b004201d5ad1300
2018-01-11 18:54:12 -08:00
Alexander Aprelev
a48185a6ad
When targeting iOS sim in preview-dart-2, always compile. (#14059)
Fixes https://github.com/flutter/flutter/issues/14058.
2018-01-11 18:19:28 -08:00
Alexander Aprelev
e2e3c5df05
Reland 9534082fc097dadf075c1eda7938af48df59ce3e with fix for incremen… (#14040)
* Reland 9534082fc097dadf075c1eda7938af48df59ce3e with fix for incremental compilation.

When in incremental mode, awaiting exitCode won't work because compiler is not expected to exit after compilation.
Instead listen for stdout stream closing and report error if outputFilename has not been received.

* Fix lints
2018-01-11 14:33:50 -08:00
Alexander Aprelev
bedf987fc8
Pipe strong mode option for iOS simulator. (#14002) 2018-01-11 14:08:28 -08:00
Alexander Aprelev
991765780b
Fix handling --preview-dart-2 for ios (#14016)
* Fix handling --preview-dart-2 for ios

* final var
2018-01-11 13:24:51 -08:00
Devon Carew
ccc0d29454
send 'reloadRecommended' info to IDEs (#13996)
* send 'reloadRecommended' info to IDEs

* rename hint ==> hintMessage
2018-01-11 12:55:00 -08:00
Sebastiano Poggi
2a07f3f211 Fix typo in framework.dart private method name (#14046) 2018-01-11 21:15:34 +01:00
Leaf Petersen
1dca1b22e8
Remove use of "--assert-initializer" flag from CONTRIBUTING.md (#14032)
* Remove mention of --assert-initializer from CONTRIBUTING.md
* Remove options variable as well
2018-01-11 08:55:14 -08:00
Michael Thomsen
62ea62a729
Remove enableAssertInitializer from analysis options as it's not needed in Dart 2 (#14042) 2018-01-11 16:52:34 +01:00
Mikkel Nygaard Ravn
aad36ab7dd
Remove large int support in standard message codec (#14011) 2018-01-11 08:47:16 +01:00
Alexandre Ardhuin
0fe1e5bf5b
apply upcoming lint prefer_const_literals_to_create_immutables (#14029) 2018-01-11 08:38:55 +01:00
Alexander Aprelev
5dc4ce85d9
Revert "Handle abnormal termination of frontend compiler. (#13982)" (#14037)
This reverts commit 9534082fc097dadf075c1eda7938af48df59ce3e.

Causes hot_mode_dev_cycle__preview_dart_2_benchmark test timeout.
2018-01-10 19:54:08 -08:00
Alexander Aprelev
9534082fc0
Handle abnormal termination of frontend compiler. (#13982)
* Check frontend_server exit code.

When frontend_server completes abnormally, flutter tools has to stop and let user know.

* Add tests
2018-01-10 17:51:08 -08:00