firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,762 Commits 1 Branch 0 Tags
Commit Graph

28873 Commits

Author SHA1 Message Date
auto-submit[bot]
e1889cda13 Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (#55896)" (flutter/engine#55914) 
Reverts: flutter/engine#55896
Initiated by: zanderso
Reason for reverting: b/373907578
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/2bf0f2b8d391..7fce3544047c

2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-27.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-26.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-25.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-24.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 21:05:47 +00:00
auto-submit[bot]
cdd0c3aef0 Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (#55903)" (flutter/engine#55913) 
Reverts: flutter/engine#55903
Initiated by: zanderso
Reason for reverting: b/373907578
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/7fce3544047c..148b7c530657

2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-30.0.dev
2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-29.0.dev
2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-28.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 21:00:47 +00:00
Devon Carew
ff569a9bdc update the repo references for package:file (flutter/engine#55906) 
The SoT repository for `package:file` has changed from google/file.dart
to dart-lang/tools; this PR updates the DEPS file and the hard-coded
paths in the two pubspec.yaml files.

- https://github.com/dart-lang/tools/issues/674

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-10-16 13:23:03 -07:00
Harlen Batagelo
8737cce879 Handle out-of-order add/remove pointer events (flutter/engine#55740) 
Fixes [#146251](https://github.com/flutter/flutter/issues/146251).

On Windows, a "pointer add" event to a new view is sometimes sent before the "pointer remove" event from the old view. When `PointerDataPacketConverter` handles the add event, it asserts that the device's pointer state has been cleared. Since the pointer state is cleared only when the remove event is processed, the assertion fails if the events arrive out of order.

The solution proposed here is to synthesize a remove event if an add event is received while the pointer state hasn't been cleared (i.e., if the pointer is added without being removed from the previous view).

To avoid duplicate remove events, the view ID is now tracked in `PointerState`. If the original "remove" arrives after the synthesized one, the state's view ID will differ from the pointer data's view ID, allowing it to be safely ignored.

When synthesizing the remove event, it's possible that the old view has already been destroyed, meaning no remove event will be received later. For example, this occurs when a window is destroyed while the pointer is inside it. However, the framework expects an "add" event to always follow a "remove" event, and "remove" events with invalid views are ignored. To meet the framework's expectations, the view ID of the "add" event will be used for the "remove" event if the old view has been destroyed.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-16 20:19:49 +00:00
gaaclarke
b69edd9e6a Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890) 
fixes https://github.com/flutter/flutter/issues/156871

testing: performance change covered by existing benchmarks.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-16 20:13:25 +00:00
skia-flutter-autoroll
4182d5c6a4 Roll Skia from 69d9d593a095 to 09917e06158b (1 revision) (flutter/engine#55907) 
https://skia.googlesource.com/skia.git/+log/69d9d593a095..09917e06158b

2024-10-16 robertphillips@google.com [graphite] Address Precompile thread-safety by creating extra ResourceProviders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 19:39:05 +00:00
zijiehe@
ccea3b80cc [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55832) 
This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk.

Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed.
https://github.com/flutter/engine/pull/55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC).

Bug: http://b/353729557, http://b/368608542

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-16 17:55:12 +00:00
skia-flutter-autoroll
04df92beb2 Roll Skia from 68f21f903bd9 to 69d9d593a095 (2 revisions) (flutter/engine#55904) 
https://skia.googlesource.com/skia.git/+log/68f21f903bd9..69d9d593a095

2024-10-16 fmalita@google.com Roll Dawn from f3c7cc5c580e to 0b31a6ca843a (62 revisions)
2024-10-16 jvanverth@google.com Revert "[graphite] Adjust rrect clipping to better match Ganesh."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 17:44:11 +00:00
skia-flutter-autoroll
0c7599c5f0 Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (flutter/engine#55903) 
https://dart.googlesource.com/sdk.git/+log/7fce3544047c..148b7c530657

2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-30.0.dev
2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-29.0.dev
2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-28.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 17:03:05 +00:00
skia-flutter-autoroll
6f745dee63 Roll Skia from 1b0702f842d4 to 68f21f903bd9 (2 revisions) (flutter/engine#55902) 
https://skia.googlesource.com/skia.git/+log/1b0702f842d4..68f21f903bd9

2024-10-16 jvanverth@google.com [graphite] Disable use of Shape for arcs in Chrome.
2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d04c1f676c96 to ad31dd1cb898 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 15:50:13 +00:00
skia-flutter-autoroll
8978675824 Roll Skia from 09cdacf52bad to 1b0702f842d4 (2 revisions) (flutter/engine#55900) 
https://skia.googlesource.com/skia.git/+log/09cdacf52bad..1b0702f842d4

2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 576b5ef40a9b to 0dbe85f31776 (8 revisions)
2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5a6102d3459e to 78ae0bf49048 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 09:15:37 +00:00
skia-flutter-autoroll
e4dd49ad4c Roll Skia from 8073f7b8bc89 to 09cdacf52bad (2 revisions) (flutter/engine#55898) 
https://skia.googlesource.com/skia.git/+log/8073f7b8bc89..09cdacf52bad

2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a9a492a38b7 to 74b783dffb9b (1 revision)
2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from f96615e73170 to 2c7a7bff0512 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 06:19:39 +00:00
skia-flutter-autoroll
b981c42f6c Roll Skia from 539ab9d39812 to 8073f7b8bc89 (2 revisions) (flutter/engine#55895) 
https://skia.googlesource.com/skia.git/+log/539ab9d39812..8073f7b8bc89

2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a993e01ad888 to d04c1f676c96 (3 revisions)
2024-10-15 aperez@igalia.com Avoid usage of the clang::musttail attribute on ppc64le

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 02:58:20 +00:00
skia-flutter-autoroll
cce28372be Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter/engine#55896) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/2bf0f2b8d391..7fce3544047c

2024-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-27.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-26.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-25.0.dev
2024-10-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-24.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 02:48:12 +00:00
skia-flutter-autoroll
f65e1b24f2 Roll Fuchsia Linux SDK from T2Cq00sVabK2fCW9r... to OTfEfbaoT9c0HcprI... (flutter/engine#55894) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-16 01:53:52 +00:00
Robert Ancell
2ccc210029 Remove obsolete fl_keyboard_view_delegate_get_messenger (flutter/engine#54857) 
This is unnecessary - we already have the messenger.
 2024-10-16 14:53:27 +13:00
Siva
f19aaeb32d Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter/engine#55884) 
Manual roll requested by [asiva@google.com](mailto:asiva@google.com)

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..2bf0f2b8d391

2024-10-15
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-23.0.dev
2024-10-14
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-22.0.dev
2024-10-14
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-21.0.dev
2024-10-14
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-20.0.dev
2024-10-12
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-19.0.dev
2024-10-12
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-18.0.dev
2024-10-12
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-17.0.dev
2024-10-12
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-16.0.dev
2024-10-11
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-15.0.dev
2024-10-11
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-14.0.dev
2024-10-11
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-13.0.dev
2024-10-11
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-12.0.dev
2024-10-10
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-11.0.dev
2024-10-10
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-10.0.dev
2024-10-10
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-9.0.dev
2024-10-10
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-8.0.dev
2024-10-10
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-7.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-6.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-5.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-4.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-3.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-2.0.dev
2024-10-09
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-1.0.dev
2024-10-08
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.7.0-0.0.dev

---------

Co-authored-by: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
 2024-10-15 18:37:05 -07:00
Chinmay Garde
0157e502c4 [Impeller] libImpeller: Initialize the base paragraph style lazily. (flutter/engine#55891) 
Thanks to the @lyceel for the failing test case.
<img width="1136" alt="Screenshot 2024-10-15 at 4 01 27 PM" src="https://github.com/user-attachments/assets/eeecba1d-eecb-4f29-878f-caf4c674a836">
 2024-10-16 00:35:12 +00:00
Robert Ancell
6203c3e0f3 Split FlKeyboardManager out of FlKeyboardHandler (flutter/engine#55892) 
They continue to share a FlKeyboardViewDelegate, but this will be split
too in a later change as part of moving these classes from FlView to
FlEngine.
 2024-10-16 13:26:42 +13:00
hellohuanlin
9a685756f9 Revert "[ios][platform_view] Fix Platform view gesture recognizer wit… (flutter/engine#55889) 
…h iPad pencil getting stuck (#55724)"

This reverts commit 21eb44914c22761f3c8bdb39b1d36b2fc15bde3b.

Revert since a customer reported the platform view touch is broken after the change. 

*List which issues are fixed by this PR. You must list at least one issue.*
Reopens https://github.com/flutter/engine/pull/55724

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-16 00:04:32 +00:00
Robert Ancell
db1e63b948 Simplify code for dispatching events (flutter/engine#55871) 2024-10-16 10:00:34 +13:00
Chinmay Garde
6be577d05a [Impeller] Ignore opt-outs on iOS devices. (flutter/engine#55808) 
Addresses https://github.com/flutter/flutter/issues/155541

This does **not** remove Skia itself from the build. I'll stage that in a followup. Want to keep the scope of this patch small.

This is the new behavior:

* Impeller is the default on iOS devices **and** simulators.
* On iOS devices **only**, all flags and plist options are ignored.
* On iOS simulators **only**, Flutter will used Impeller's Metal backend by default and fallback to the Null backend if Metal device access is not available.
* On iOS simulators **only**, Flutter can pick Skia using the command line flags or plist flags. This is to allow users one more month to migrate as communicated by @zanderso.

The settings objects `enable_impeller` field is now `static constexpr` to avoid accidentally disabling the flag while it still exists.
 2024-10-15 19:14:23 +00:00
skia-flutter-autoroll
7bcd07c4df Roll Skia from baf314b72924 to 539ab9d39812 (3 revisions) (flutter/engine#55879) 
https://skia.googlesource.com/skia.git/+log/baf314b72924..539ab9d39812

2024-10-15 robertphillips@google.com Add More Mac *SAN Graphite testing jobs
2024-10-15 danieldilan@google.com Add a way to set filter mode in SkAnimatedImage.
2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8f346c5caf5a to a993e01ad888 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 17:37:25 +00:00
Jonah Williams
0077bfe80a [Impeller] remove extra copy from drawPoints. (flutter/engine#55872) 
Remove the extra host -> host copy performed by the VertexBufferBuilder. Instead, write the drawPoint geometry right into the transients buffer.

https://github.com/flutter/flutter/issues/152702
 2024-10-15 15:45:20 +00:00
skia-flutter-autoroll
c469426d71 Roll Skia from 39bd1d3f242a to baf314b72924 (4 revisions) (flutter/engine#55876) 
https://skia.googlesource.com/skia.git/+log/39bd1d3f242a..baf314b72924

2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 78a694a1b82a to 576b5ef40a9b (6 revisions)
2024-10-15 sharaks@google.com Merge 2 release notes into RELEASE_NOTES.md
2024-10-15 sharaks@google.com Update Skia milestone to 132
2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2a35388fb5f0 to 5a6102d3459e (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 10:26:22 +00:00
skia-flutter-autoroll
4cc9b727a4 Roll Skia from 7d16e5cd642c to 39bd1d3f242a (1 revision) (flutter/engine#55870) 
https://skia.googlesource.com/skia.git/+log/7d16e5cd642c..39bd1d3f242a

2024-10-15 jie.a.chen@intel.com [graphite] Use uint instead of int for divides

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 03:18:21 +00:00
Brandon DeRosier
50b5307332 [Impeller] Allow binding multiple vertex buffer views. (flutter/engine#55856) 
Resolves https://github.com/flutter/flutter/issues/116168.
(Continuation of https://github.com/flutter/engine/pull/49670)

Makes it possible for us to use arbitrary vertex layouts, including SoA layouts with attributes stored in different DeviceBuffers. CanRenderPerspectiveCube was converted to an SoA attribute layout with two separate buffers as an example.

Works on all the backends!

OpenGLES:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/e2398fde-532f-402d-899a-39aaa556f24f">

Vulkan:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/1c1bf664-bec1-43cb-ab2e-eb2a74718bfd">

Metal:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/bf59da17-cf52-4913-88e4-ab6f0bd6fc96">
 2024-10-15 01:13:52 +00:00
Brandon DeRosier
778e32ec0d [Flutter GPU] Remove unused fixture. (flutter/engine#55869) 
I used this fixture data early on to bootstrap testing for Flutter GPU before shader bundles were finished. But today we have the build system compile shader bundles for us, so this is no longer used.
 2024-10-15 00:10:21 +00:00
skia-flutter-autoroll
b03c459fab Roll Skia from de6e47f0f17b to 7d16e5cd642c (2 revisions) (flutter/engine#55868) 
https://skia.googlesource.com/skia.git/+log/de6e47f0f17b..7d16e5cd642c

2024-10-14 lukasza@chromium.org [rust png] Initial support for Bazel build.
2024-10-14 kjlubick@google.com Add JSON error when presubmit fails

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 22:20:08 +00:00
skia-flutter-autoroll
2cc59a7940 Roll Skia from d6d3c4f624a3 to de6e47f0f17b (9 revisions) (flutter/engine#55867) 
https://skia.googlesource.com/skia.git/+log/d6d3c4f624a3..de6e47f0f17b

2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e0070499f409 to 8f346c5caf5a (1 revision)
2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e7f0d107f258 to 78a694a1b82a (1 revision)
2024-10-14 robertphillips@google.com [ganesh] Remove last use of SK_IGNORE_ANGLE_VULKAN flag
2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 462486a81e05 to 2a35388fb5f0 (5 revisions)
2024-10-14 jvanverth@google.com [graphite] Add Arc support to Shape.
2024-10-14 lukasza@chromium.org [rust png] Populate `fFrameHolder` with all animation frames.
2024-10-14 kjlubick@google.com Remove unavailable jobs from CQ
2024-10-14 kjlubick@google.com Update Bazel's rules_rust to v0.52.2
2024-10-14 kjlubick@google.com Update Swarming dimensions for IntelXe tasks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 20:55:17 +00:00
skia-flutter-autoroll
91abbe23c7 Roll Fuchsia Linux SDK from 2cTD8TkGBMX2IssGl... to T2Cq00sVabK2fCW9r... (flutter/engine#55865) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 20:01:37 +00:00
Parker Lougheed
7876f9fc41 Disable non-functional and deprecated package_api_docs lint (flutter/engine#55833) 
Reference: https://github.com/dart-lang/linter/issues/5107
 2024-10-14 18:49:18 +00:00
David Iglesias
0d39b59999 [web] Ensure Flutter adds a generator meta-tag. (flutter/engine#55714) 
Adds a `meta name="generator" content="Flutter"` tag when the engine UI initializes.

## Issues

Fixes https://github.com/flutter/flutter/issues/156262

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-14 18:41:51 +00:00
Jonah Williams
61460afe48 [Impeller] remove STB backend. (flutter/engine#55842) 
Delete the STB typographer backend.

Fixes https://github.com/flutter/flutter/issues/156429
 2024-10-14 18:16:20 +00:00
Brandon DeRosier
dd68ebf2fb [Impeller] Add miplevel to Buffer->Texture blit. (flutter/engine#55848) 
Part of https://github.com/flutter/flutter/issues/156641
 2024-10-14 16:53:19 +00:00
Robert Ancell
0388529ef9 Use GWeakRef API (flutter/engine#55795) 
For consistency with other code.
 2024-10-14 14:36:37 +13:00
Robert Ancell
e0daa80cb2 Remove unnecessary use of std::vector (flutter/engine#55796) 2024-10-14 13:57:12 +13:00
Robert Ancell
7790182059 Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817) 
A step on the way to get FlKeyboardHandler out of FlView and into
FlEngine.
 2024-10-14 13:54:05 +13:00
Robert Ancell
24ceeac432 Split out FlKeyboardLayout into its own class (flutter/engine#55816) 2024-10-14 12:07:26 +13:00
Robert Ancell
b9db87f8ac When rendering into secondary views, copy the pixel contents between contexts (flutter/engine#55639) 
This is because GTK3 can't share contexts between GtkGLAreas.

We may be able to avoid the copy using the GL_OES_EGL_image or
GL_OES_EGL_image_external extensions.

Note that keyboard input doesn't work on the secondary view, this
requires moving the keyboard handling from FlView to FlEngine. Proposing
this now as a step forwards, but not yet useful for real applications.
 2024-10-14 12:05:12 +13:00
Robert Ancell
b857ade17e Make FlRenderable interface (flutter/engine#55763) 
Added to make testing of FlRenderer easier.
 2024-10-14 10:30:41 +13:00
Robert Ancell
e5ecdd9c94 Fix dispose methods that didn't chain the parent. (flutter/engine#55794) 
Remove empty dispose methods and convert finalize methods to dispose for
consistency.
 2024-10-14 09:40:47 +13:00
skia-flutter-autoroll
c750e8e56f Roll Fuchsia Linux SDK from tNuwSyjjbdU9HjOwQ... to 2cTD8TkGBMX2IssGl... (flutter/engine#55862) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-13 18:38:23 +00:00
skia-flutter-autoroll
0af03c79c7 Roll Skia from 88cb2bff3842 to d6d3c4f624a3 (1 revision) (flutter/engine#55861) 
https://skia.googlesource.com/skia.git/+log/88cb2bff3842..d6d3c4f624a3

2024-10-13 michaelludwig@google.com [graphite] Rebind textures on pipeline changes w/ dst-copy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-13 15:45:38 +00:00
auto-submit[bot]
65114d1bfb Reverts "Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (#55838)" (flutter/engine#55850) 
Reverts: flutter/engine#55838
Initiated by: zanderso
Reason for reverting: Blocking roll to the framework due to https://github.com/flutter/flutter/issues/156654
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..75bf9e183a33

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-12 17:17:46 +00:00
Jim Graham
9e747c2eb6 Delete last usages of MockCanvas test mechanism (flutter/engine#55840) 
The MockCanvas API was originally used to test the output of rendering methods to match them against a reference set of "MockData" structures. This API has been superseded by just using a DisplayListBuilder to record reference operations and then to compare the resulting DisplayList objects.

This PR deletes the last remaining uses of MockCanvas as well as the mechanism itself.
 2024-10-12 05:15:17 +00:00
skia-flutter-autoroll
8da20b0a97 Roll Skia from 97cebfb06139 to d2833b68c8c7 (9 revisions) (flutter/engine#55846) 
https://skia.googlesource.com/skia.git/+log/97cebfb06139..d2833b68c8c7

2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 73fd75175922 to ab901eb0f984 (7 revisions)
2024-10-11 bungeman@google.com Clean up references to SkDevice::createDevice
2024-10-11 fmalita@google.com [skottie] Fix Viewer crash on invalid json inputs
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f58427c0db47 to 73fd75175922 (3 revisions)
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ae5c3b969e66 to 3ef8d1714d61 (6 revisions)
2024-10-11 cwallez@chromium.org DawnCaps: Prepare for Dawn's output stuct StringView change.
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from bf6353777f11 to 462486a81e05 (6 revisions)
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 68d8508758f2 to f3c7cc5c580e (31 revisions)
2024-10-10 jreck@google.com Fix SkRRect::dumpToString

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-12 03:21:05 +00:00
Jonah Williams
c9f0e8a458 [Impeller] delete a bunch of dead filter code. (flutter/engine#55841) 
All of these filter graph methods are not used or only used to test themselves in a limited unit test. Delete!
 2024-10-12 02:15:23 +00:00
AthulJoseph
3214f65fa3 [Impeller] Added support to set polygon mode in Flutter GPU. (flutter/engine#55804) 
Added support to set polygon mode in Flutter GPU. This fixes the issue [#142732](https://github.com/flutter/flutter/issues/142732).
 2024-10-12 01:07:36 +00:00
skia-flutter-autoroll
96ab9b9e30 Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (flutter/engine#55838) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..75bf9e183a33

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-11 23:42:53 +00:00