11633 Commits

Author SHA1 Message Date
Jonah Williams
ffdd6e1bf1
Toggle whether label or hint contribute to text field semantics when unfocused/focused (#19790) 2018-08-01 21:02:40 -07:00
Greg Spencer
6dc18525c2
Fix docs.sh to be more idomatic Bash, runnable from any dir (#19922) 2018-08-01 21:00:48 -07:00
amirh
ed533e9033
Split GoldensClient out of flutter_goldens.dart (#20102)
This enables using GoldensClient from the flutter driver file for the
embedded Android views test.

flutter_goldens.dart has a transitive dependency on dart:ui so it cannot
be included in non Flutter apps. Splitting it out allows us to use it
from driver tests.

This also removes the visibleForTesting annotation from GoldensClient.
2018-08-01 17:03:47 -07:00
Natalie Sampsell
506cf3cb88
Added ability to use custom colors for SegmentedControl (#20005) 2018-08-01 15:26:30 -07:00
Ryan Macnak
091da9c7d3 Revert "mark flaky benchmarks as flaky (#19492)"
This reverts commit 7a9dd709c6235153dd7500da65fb30dfbe76e560.

Bug: https://github.com/flutter/flutter/issues/19490
2018-08-01 14:15:22 -07:00
Danny Tuppeny
766982ae3c
Add spaces to path for macOS too (#20088) 2018-08-01 21:32:06 +01:00
Devon Carew
1393c73077
use the best of four results for flutter analyze --benchmark (#20058) 2018-08-01 11:24:41 -07:00
jslavitz
d2ab29d25e
Drawer fix (#20015)
* Drawer fix

* fixed nits

* fixed nits

* fixed nits

* final change

* Drawer fix final
2018-08-01 10:14:25 -07:00
Danny Tuppeny
93705691a4
Skip tests that are expected to fail with timeouts (#20074)
* Skip tests instead of expecting failure, because expected failure = timeout which is slow

Some of these tests are known to fail and were coded to expect it; however because the failure is a timeout it's just dragging out test runs (shortening timeouts will make the tests flakier).

* Make it easier to find skipped tests

* Change SKIP to TODO
2018-08-01 17:50:38 +01:00
Danny Tuppeny
c3248b79fc
Merge the two Windows and two Mac sections into one with matrix (#20077) 2018-08-01 17:34:36 +01:00
Ryan Macnak
6d92151f61 [gn] Be explicit about Dart sources. 2018-08-01 09:33:03 -07:00
Greg Spencer
2a66fd34a3
Fix the whitespace check. (#20059)
I switched to just checking for spaces and tabs, since otherwise it expresses a preference for line endings that I think should be taken care of at the git level (and I think they are).

I also fixed a bug where I was looking for ".yml" instead of "*.yml" files, and clarified an output message.
2018-07-31 20:54:37 -07:00
Devon Carew
e816f64bf2
remove the option to pass in the --no-preview-dart-2 flag to analysis (#20041)
remove the option to pass in the --no-preview-dart-2 flag to analysis
2018-07-31 19:15:11 -07:00
Jonah Williams
7ba2a84af1
roll engine to 91ff524e63298a2d0e15c2a0d47e0a005524c51c (#20055) 2018-07-31 18:15:37 -07:00
Natalie Sampsell
4fd6188d48
Fix SegmentedControl accessibility (#19994) 2018-07-31 16:56:20 -07:00
Greg Spencer
ab9f17cbbe
Adding curve animations to documentation. (#19681)
Enables animated curve diagrams in the documentation, replacing the static images.
2018-07-31 16:32:42 -07:00
xster
35b55d51a8
Add image stream error handling mechanism (#18424) 2018-07-31 14:17:44 -07:00
Jonah Williams
e9c8e36bde
When dispatching a semantic event, check if the node has been merged with parent (#20020) 2018-07-31 10:43:56 -07:00
sir-boformer
63098f2bc8 Apply curved animation in AnimatedOpacity (#19620)
Fixes #19617
2018-07-31 09:58:50 -07:00
Danny Tuppeny
12eff1d5da
Change from .first to .single to ensure this (#19981) 2018-07-31 08:05:24 +01:00
xster
cb03ca1d9a
Semantics for CupertinoTabBar (#19924) 2018-07-30 23:37:54 -07:00
Jonah Williams
5b30b393a8
make sure bottom nav bar always contributes labels (#19934) 2018-07-30 21:06:31 -07:00
Ian Hickson
3a6228bead
Fix commands_test (#20017)
I changed the wording that it was depending on in my last commit. Oops.
2018-07-30 18:07:23 -07:00
Ian Hickson
acf4b6c1aa
Clean up startProgress logic. (#19695) (#20009)
Disallow calling stop() or cancel() multiple times. This means that
when you use startProgress you have to more carefully think about what
exactly is going on.

Properly cancel startProgress in non-ANSI situations, so that
back-to-back startProgress calls all render to the console.
2018-07-30 16:58:07 -07:00
Jonah Williams
ee396272d3
Fix dropdown button semantics (#19932) 2018-07-30 15:36:26 -07:00
Ian Hickson
a7595e535c
Delete .coveralls.yml (#19782)
This was added for https://github.com/lemurheavy/coveralls-public/issues/1103 but that didn't help.
2018-07-30 15:30:25 -07:00
David Shuckerow
f844fadaf3
Reorderable list widget and Material demo (#18374) 2018-07-30 15:21:00 -07:00
Greg Spencer
711ecf7f58
Revert "Move docs and gallery deployment to Cirrus (#19925)" (#20003)
This reverts commit c36032c65f0d94b5fcd5de7f65b70b03990cadef, because
we're missing some credentials for pushing the gallery.

Submitting TBR to unbreak the build.

TBR=tvolkert
2018-07-30 12:35:15 -07:00
xster
cded7efbd0
Fix CupertinoSwitch accessibility (#19927) 2018-07-30 11:18:32 -07:00
Jonah Williams
dfe5b591a6
Increase time picker clock touch targets to 48 by 48 (#19936) 2018-07-30 10:46:16 -07:00
Jonah Williams
5819008320
increase checkbox size and fix header area (#19966) 2018-07-30 10:45:24 -07:00
Jonah Williams
7e2434c8ff
move semantics inside of opacity animation (#19960) 2018-07-30 10:44:15 -07:00
Jonah Williams
b2eed9a6da
add export of TextCapitalization to text_field.dart (#19955) 2018-07-30 10:42:46 -07:00
Stanislav Baranov
d6bfda6c10
Change 'flutter ide-config' to optionally create root Intellij module (#19920) 2018-07-30 10:33:43 -07:00
Greg Spencer
c36032c65f
Move docs and gallery deployment to Cirrus (#19925)
This moves the docs generation and gallery upload to Cirrus CI, which is another step in turning off
Travis.
2018-07-30 10:29:57 -07:00
Stanislav Baranov
30f1fbd0b4
Change 'flutter ide-config' to optionally create root Intellij module (#19920) 2018-07-30 10:16:30 -07:00
Stanislav Baranov
c49ece0fd0
Change 'flutter ide-config' to optionally create root Intellij module (#19920) 2018-07-30 10:15:50 -07:00
Stanislav Baranov
51d3daadfb
Change 'flutter ide-config' to optionally create root Intellij module (#19920) 2018-07-30 10:15:26 -07:00
Michael Goderbauer
4509ad5978
Do not implicitly scroll a PageView when showOnScreen is called (#19735)
Fixes #19523
2018-07-30 10:05:42 -07:00
Ben Konyi
1b5dd718d8
Dart SDK Roll 2018-07-27 (#19931) 2018-07-30 09:52:29 -07:00
Michael Goderbauer
3156c28882
Improve semantics for Drawer-Demo (#19911) 2018-07-30 09:28:24 -07:00
Jonah Williams
82415e6400
add semantic label to image icon and exclude semantics from image widget (#19970) 2018-07-30 09:10:25 -07:00
jcollins-g
a201980223
Upgrade dartdoc to 0.20.2. (#19781) 2018-07-30 08:37:14 -07:00
Mehmet Fidanboylu
29410abbe7
Update the documentation on BinaryCodec (#19887)
Two clients have run into this in the past so adding a bit of documentation to make it clear. See https://github.com/flutter/flutter/issues/19849 for one example.
2018-07-27 22:10:39 -07:00
liyuqian
f2a983fc21
Roll engine to 72a38a6b1343ec09a8d884fff655bfbc8cb01674 (#19923)
72a38a6b1 Build Android engine in presubmit using Cirrus and GCE (#5882)
f9f40badd Log uncaught exceptions from JNI calls at a higher priority (#5891)
723b2784d Update license script README (#5890)
9420da1e2 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888)
27c9de59b Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887)
8b8c52ed7 Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886)
89602cc64 [scenic] Expose compositor context from rasterizer. (#5739)
9baeb9c1a Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)
2018-07-27 21:33:14 -07:00
amirh
d62aa96ab5
Fix onPlatformViewCreated comment wording (#19933) 2018-07-27 21:02:55 -07:00
Greg Spencer
e262817ac2
Fix the gradle templates so that they default to values rather than throw build exceptions. (#19916)
When creating a new project, the build fails with an error similar to:

"versionCode not found. Define flutter.versionCode in the local.properties file."

This puts developers in the untenable situation of having to edit a file with local paths, but being unable to check it in.

This changes the templates to default to using versionCode 1 and version "1.0" if they are not defined in the local.properties file.

Fixes #18983.
2018-07-27 18:24:13 -07:00
liyuqian
a4cc34dee6
Add tiles_scroll_perf test (#19833) 2018-07-27 14:59:38 -07:00
David Shuckerow
0b1ef6bb1c
Reduce the haptic feedback on the draggable widget. (#19585) 2018-07-27 14:53:51 -07:00
Niklas Schulze
154dbc5975 update_dart_sdk.ps1: Fall back to Invoke-WebRequest if BITS fails (#19873) 2018-07-27 14:29:20 -07:00