Qun Cheng
9fa351807f
SearchBar should not be impacted by overall InputDecorationTheme (#127465 )
2023-05-25 12:28:26 -07:00
engine-flutter-autoroll
f71075db2e
Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) ( #127601 )
...
195009b91a...515a4bfc4bdnfield@google.com Implement PlatformDispatcher.displays on web (flutter/engine#42297 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319 )
2023-05-25 bdero@google.com [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314 )
2023-05-25 bdero@google.com [Impeller] Add generic path for mask blurring (flutter/engine#42308 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 18:43:08 +00:00
engine-flutter-autoroll
e583ba4cf0
Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) ( #127591 )
...
fb463217d1...195009b91askia-flutter-autoroll@skia.org Roll Skia from fbba25f66405 to b80e74dc4cda (2 revisions) (flutter/engine#42316 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 16:21:03 +00:00
Dan Field
a21f33e7ad
avoid incorrect usage of TimelineTask ( #127527 )
...
This code was added based on a misunderstanding of the API surface.
2023-05-25 09:17:02 -07:00
Taha Tesser
c05a05e6fc
Add ScrollNotificationObserver sample ( #127023 )
...
fixes https://github.com/flutter/flutter/issues/126702
### Preview
https://github.com/flutter/flutter/assets/48603081/4c529a0d-b8a5-4950-9095-429f1c5eccbb
2023-05-25 15:58:52 +00:00
engine-flutter-autoroll
3e610f7333
Roll Packages from fba97fa4cc86 to 995bfc5f9857 (3 revisions) ( #127590 )
...
fba97fa4cc...995bfc5f98engine-flutter-autoroll@skia.org Roll Flutter from f86c529b2cd2 to 216605b60f67 (18 revisions) (flutter/packages#4071 )
2023-05-24 stuartmorgan@google.com [various] Fixes `unawaited_futures` violations (flutter/packages#4067 )
2023-05-24 48731731+phcs971@users.noreply.github.com [quick_actions] Fix iOS home screen quick actions documentation hyperlink (flutter/packages#4059 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 15:53:15 +00:00
engine-flutter-autoroll
60a64a5a5c
Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) ( #127577 )
...
a74d9d1f47...fb463217d1skia-flutter-autoroll@skia.org Roll Dart SDK from be01f9fdac37 to 0e78305875a4 (1 revision) (flutter/engine#42313 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 15:16:16 +00:00
engine-flutter-autoroll
20e164e60c
Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) ( #127565 )
...
a7f026b03e...a74d9d1f47skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RSSC61ubl9JXmn4JO... to X4uS4T6_J-VUh9M4A... (flutter/engine#42311 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from RSSC61ubl9JX to X4uS4T6_J-VU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 10:33:41 +00:00
engine-flutter-autoroll
1a17ba0e5e
Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) ( #127563 )
...
fb38bb6b1b...a7f026b03eskia-flutter-autoroll@skia.org Roll Dart SDK from 96e29af6e0c6 to be01f9fdac37 (2 revisions) (flutter/engine#42310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 09:38:20 +00:00
engine-flutter-autoroll
54d001d442
Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) ( #127560 )
...
2be736c390...fb38bb6b1bskia-flutter-autoroll@skia.org Roll Skia from 7ec172b433f1 to fbba25f66405 (2 revisions) (flutter/engine#42309 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 08:37:39 +00:00
LongCatIsLooong
1b800fd496
Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation ( #119199 )
...
Fixes https://github.com/flutter/flutter/issues/117627
### Behavior changes:
1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`.
2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones.
3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.
2023-05-25 07:24:45 +00:00
engine-flutter-autoroll
9da1d98ae9
Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) ( #127554 )
...
37ebad2d5c...2be736c390skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UYN_Tk7M6_5d2aGIj... to nLnQzTesaABpgroOl... (flutter/engine#42307 )
2023-05-25 bdero@google.com [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UYN_Tk7M6_5d to nLnQzTesaABp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 06:03:29 +00:00
engine-flutter-autoroll
b49830b339
Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) ( #127551 )
...
62a83490ee...37ebad2d5cskia-flutter-autoroll@skia.org Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 05:17:28 +00:00
engine-flutter-autoroll
9e4104b094
Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) ( #127546 )
...
1bed04a437...62a83490ee54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bea16a7dcbd to 96e29af6e0c6 (1 revision) (flutter/engine#42303 )
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) (flutter/engine#42301 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 03:09:20 +00:00
engine-flutter-autoroll
5eacfe62bd
Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) ( #127544 )
...
6a361090a3...1bed04a43730870216+gaaclarke@users.noreply.github.com [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225 )
2023-05-24 jonahwilliams@google.com [Impeller] fix UV and color blending. (flutter/engine#42293 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 01:47:08 +00:00
engine-flutter-autoroll
9516368e06
Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) ( #127542 )
...
9ba461efd3...6a361090a3godofredoc@google.com Use engine_v2 builds on recipe testing. (flutter/engine#42298 )
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Golden test for text with a shader and a transform (flutter/engine#42291 )
2023-05-24 skia-flutter-autoroll@skia.org Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) (flutter/engine#42295 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 00:33:07 +00:00
Casey Hillers
20eb5adff4
Revert "Update labeler action wildcards" ( #127541 )
...
Reverts flutter/flutter#127524
Bad YAML format is blocking presubmit PRs.
2023-05-24 16:40:53 -07:00
Mouad Debbar
2d142c5ba2
[web] ui.platformViewRegistry => ui_web.platformViewRegistry ( #127493 )
...
Now that `platformViewRegistry` is [exposed](https://github.com/flutter/engine/pull/41877 ) through `dart:ui_web`, we can do some cleanup here.
Part of https://github.com/flutter/flutter/issues/126831
2023-05-24 23:31:28 +00:00
engine-flutter-autoroll
ef54879b48
Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) ( #127536 )
...
c641f6307f...9ba461efd3mdebbar@google.com [web] Remove comment about dart:html migration (flutter/engine#42290 )
2023-05-24 mdebbar@google.com [web] Hide JS types from dart:ui_web (flutter/engine#42252 )
2023-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287 )
2023-05-24 marcianx@gmail.com [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258 )
2023-05-24 jonahwilliams@google.com [Impeller] fix Xcode frame capture. (flutter/engine#42289 )
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qoLy9E5PjnAl to RSSC61ubl9JX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 23:18:49 +00:00
lsaudon
7827a24207
Add missing parameters in TextFormField ( #127020 )
...
`TextFormField` does not have all the parameters of `TextField`.
Added:
```dart
UndoHistoryController? undoController,
AppPrivateCommandCallback? onAppPrivateCommand,
bool? cursorOpacityAnimates,
ui.BoxHeightStyle selectionHeightStyle = ui.BoxHeightStyle.tight,
ui.BoxWidthStyle selectionWidthStyle = ui.BoxWidthStyle.tight,
DragStartBehavior dragStartBehavior = DragStartBehavior.start,
ContentInsertionConfiguration? contentInsertionConfiguration,
Clip clipBehavior = Clip.hardEdge,
bool scribbleEnabled = true,
bool canRequestFocus = true,
```
2023-05-24 23:06:52 +00:00
Casey Hillers
99f792e085
Update labeler action wildcards ( #127524 )
...
https://github.com/flutter/flutter/issues/126002
2023-05-24 23:06:50 +00:00
LongCatIsLooong
62e78bf143
Improve TextPainter.layout caching ( #118128 )
...
Improves `TextPainter.layout` caching when only the input constraints change:
- removes the double layout calls in `TextPainter._layoutParagraph`: now double layout is only needed when `TextAlign` is not left, and the input `maxWidth == double.infinity`.
- skip calls to `ui.Paragraph.layout` when it's guaranteed that there's no soft line breaks before/after the layout call.
This doesn't introduce new APIs but may slightly shift text rendered on screen.
This reduces the number of `layout` calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible.
528 scuba failures but all of them seem reasonable.
2023-05-24 22:38:52 +00:00
dependabot[bot]
4d1c6a4346
Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 ( #127533 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327.
<details>
<summary>Commits</summary>
<ul>
<li><a href="0776a67936https://redirect.github.com/actions/labeler/issues/571 ">#571</a> from akv-platform/remove-implicit-dependencies</li>
<li><a href="08382d15cbd1dd326ccc91076827ed2713f7303c...0776a67936
2023-05-24 22:36:58 +00:00
Bruno Leroux
2b105ac6dd
Fix ScrollPosition overscroll precision error ( #127321 )
...
## Description
This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`).
~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`) breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~
## Related Issue
Fixes https://github.com/flutter/flutter/issues/126561
## Tests
Adds 1 test.
2023-05-24 22:34:06 +00:00
Devin
5451ea6e8f
Slider.onChangeStart & Slider.onChangeEnd are not called on keyboard shortcuts (#126896 )
...
fixes https://github.com/flutter/flutter/issues/123315
--------
This PR makes changes to the _actionHandler function used on the Slider.Dart Widget for Key Events. It ensures onChangeStart is called at the beginning of a Key Event and onChangeEnd at the end of one. This PR includes a test for the changes made.
I ran all existing tests after my changes were made and they passed.
2023-05-24 22:13:15 +00:00
Brandon DeRosier
982e00527c
Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 ( #127514 )
...
Rolls engine to head with
[fixes](https://github.com/flutter/flutter/pull/127505 ) corresponding to
the [latest Dart roll](https://github.com/flutter/engine/pull/42286 ).
2023-05-24 14:35:23 -07:00
Casey Hillers
eea12df3a9
Update CP template to include timeline and changelog ( #127507 )
...
Based on recent feedback. Give more information in the CP template.
2023-05-24 21:32:10 +00:00
Sun Jiao
7b67aa587a
make suggestionsBuilder in SearchAnchor asyncable ( #127019 )
2023-05-24 13:12:47 -07:00
Victoria Ashworth
a19b3436ee
Log all lines from ios-deploy ( #127502 )
...
Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405 .
Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
2023-05-24 19:46:16 +00:00
Victoria Ashworth
555326b228
Revert "Replace rsync when unzipping artifacts on a Mac ( #126703 )" ( #127430 )
...
This reverts commit 2b3cd7f4d9fd522e2e691fbd169c0c0e1fd7c9e8.
Fixes https://github.com/flutter/flutter/issues/127281 .
2023-05-24 19:21:05 +00:00
Chris Yang
9232834ef8
test owners: cyanglaz -> vashworth ( #127391 )
...
Changes the test owners to @vashworth while I'm OOO.
2023-05-24 19:17:44 +00:00
Chris Bracken
edf4a91f5f
[Linux] Ignore deprecation of libupower call in example ( #127503 )
...
The Linux platform channels sample makes a call to the libupower
function `up_client_get_devices`, which was deprecated in libupower
0.99.8 in favour of `up_client_get_devices2`.
The prod bots have been migrated to focal, which ships libupower 0.99.11
in which the old function is deprecated and the new one is available.
The try bots have not yet been migrated and remain on bionic, which
ships libupower 0.99.7 in which the old function is not deprecated and
the new one is not available.
This marks the line in question to ignore deprecation warnings. Once all
bots have migrated to focal, we'll migrate to the new function. See
tracking issue below.
See:
https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices
Issue: https://github.com/flutter/flutter/issues/127506
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-24 11:44:05 -07:00
engine-flutter-autoroll
ff8411d896
Roll Packages from d449a17f8706 to fba97fa4cc86 (4 revisions) ( #127492 )
...
d449a17f87...fba97fa4ccgodofredoc@google.com Update infra reviewers and add label. (flutter/packages#4068 )
2023-05-23 JeroenWeener@users.noreply.github.com [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065 )
2023-05-23 stuartmorgan@google.com [in_app_purchase] Fix Java lints (flutter/packages#4032 )
2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 343718945bcb to f86c529b2cd2 (22 revisions) (flutter/packages#4066 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:52:54 +00:00
engine-flutter-autoroll
e2ae260b42
Roll Flutter Engine from eebcf36cd38f to 0c41b02cd5a6 (1 revision) ( #127461 )
...
eebcf36cd3...0c41b02cd5bdero@google.com [Impeller] Set the coverage hint on everything (flutter/engine#42264 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:51:26 +00:00
engine-flutter-autoroll
216605b60f
Roll Flutter Engine from aba9dc4640c2 to eebcf36cd38f (3 revisions) ( #127458 )
...
aba9dc4640...eebcf36cd3bdero@google.com [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269 )
2023-05-24 godofredoc@google.com Add builders for second level cache of builders. (flutter/engine#42271 )
2023-05-24 jonahwilliams@google.com [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 03:40:27 +00:00
engine-flutter-autoroll
90cf8d1dd4
Roll Flutter Engine from 76afb431a740 to aba9dc4640c2 (1 revision) ( #127453 )
...
76afb431a7...aba9dc464030870216+gaaclarke@users.noreply.github.com Turned back on debug unit tests (flutter/engine#42261 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 01:51:25 +00:00
engine-flutter-autoroll
81971c961b
Roll Flutter Engine from fc6df9512aa2 to 76afb431a740 (3 revisions) ( #127445 )
...
fc6df9512a...76afb431a7skia-flutter-autoroll@skia.org Roll Dart SDK from 90b4df96e9dc to 7546e99f8a50 (3 revisions) (flutter/engine#42260 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 28946eda0f6d to 69f7860093b4 (6 revisions) (flutter/engine#42262 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 292879d286e9 to 28946eda0f6d (5 revisions) (flutter/engine#42257 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 00:49:25 +00:00
dependabot[bot]
23fe4fca59
Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 ( #127438 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="2713f7303chttps://redirect.github.com/actions/labeler/issues/572 ">#572</a>)</li>
<li><a href="a4eda65d3dhttps://redirect.github.com/actions/labeler/issues/573 ">#573</a>)</li>
<li><a href="5c4deb8a24https://redirect.github.com/actions/labeler/issues/480 ">#480</a>)" (<a href="https://redirect.github.com/actions/labeler/issues/564 ">#564</a>)</li>
<li><a href="61662e8f41https://redirect.github.com/actions/labeler/issues/569 ">#569</a>)</li>
<li>See full diff in <a href="6b107e7a7e...2713f7303c
2023-05-23 23:26:05 +00:00
engine-flutter-autoroll
df281bb193
Roll Flutter Engine from 3535e0d301dd to fc6df9512aa2 (1 revision) ( #127440 )
...
3535e0d301...fc6df9512ajonahwilliams@google.com [Impeller] Encode render passes concurrently on iOS. (flutter/engine#42028 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 23:24:14 +00:00
chunhtai
c687dcd56f
Migrates android semanitcs integration to integration test ( #127128 )
...
I think the flake is due to setclipboard or semantics update race condition. I migrated the test to use integration test package which relies less on timing
fixes https://github.com/flutter/flutter/issues/124636
2023-05-23 22:33:19 +00:00
engine-flutter-autoroll
8c086d0171
Roll Flutter Engine from 23b04314d5d2 to 3535e0d301dd (3 revisions) ( #127428 )
...
23b04314d5...3535e0d301103135467+sealesj@users.noreply.github.com Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256 )
2023-05-23 103135467+sealesj@users.noreply.github.com Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247 )
2023-05-23 jonahwilliams@google.com Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 22:23:19 +00:00
engine-flutter-autoroll
6f00846866
Roll Flutter Engine from ccf50f344d5d to 23b04314d5d2 (2 revisions) ( #127421 )
...
ccf50f344d...23b04314d5aam@google.com Roll buildroot to 5cab8e095066d8f3de063943af26b7336aa52662 (flutter/engine#42251 )
2023-05-23 103135467+sealesj@users.noreply.github.com Vulnerability scanning print failed command in case of error (flutter/engine#42190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 20:19:35 +00:00
Ian Hickson
9c7a9e779f
Give channel descriptions in flutter channel, use branch instead of upstream for channel name ( #126936 )
...
## How we determine the channel name
Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
This PR changes the logic to uses the current branch as the channel name.
## How we display channels
The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
```
ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
Flutter channels:
master (tip of tree, for contributors)
main (tip of tree, follows master channel)
beta (updated monthly, recommended for experienced users)
stable (updated quarterly, for new users and for production app releases)
* foo_bar
Currently not on an official channel.
ianh@burmese:~/dev/flutter/packages/flutter_tools$
```
## Other changes
I made a few other changes while I was at it:
* If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
* I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
* I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
* Simplified some of the code.
* Made some of the tests more strict (checking all output rather than just some aspects of it).
* Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
* I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
* Tweaked the help text for the `downgrade` command to be clearer.
* Removed some misleading text in some error messages.
* Made the `.metadata` generator consistent with the template file.
* Removed some obsolete code to do with the `dev` branch.
## Reviewer notes
I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
2023-05-23 19:59:20 +00:00
Tomasz Gucio
25d2f90a59
Avoid catching errors in TextPainter tests ( #127307 )
2023-05-23 21:20:59 +02:00
Christopher Fujino
11cb29174f
[flutter_tools] delete entitlements files after copying to macos build dir ( #127417 )
...
Fixes https://github.com/flutter/flutter/issues/126705
Follow up fix after https://github.com/flutter/flutter/pull/126875 did NOT work.
2023-05-23 19:12:11 +00:00
engine-flutter-autoroll
3518d69d2a
Roll Flutter Engine from a6e37bde65fd to ccf50f344d5d (7 revisions) ( #127416 )
...
a6e37bde65...ccf50f344dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250 )
2023-05-23 30870216+gaaclarke@users.noreply.github.com [Impeller]
Removed last ivars to raw vk::Device's. (flutter/engine#42215 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 225d51031ad0 to
292879d286e9 (5 revisions) (flutter/engine#42249 )
2023-05-23 zanderso@users.noreply.github.com Build arm64
FlutterEmbedder.framework and lipo the result (flutter/engine#42233 )
2023-05-23 aam@google.com Roll watcher dependency for web_ui to 1.1.0.
(flutter/engine#42248 )
2023-05-23 mdebbar@google.com [web] Move platformViewRegistry to ui_web
(flutter/engine#41877 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 3ded22186598 to
225d51031ad0 (1 revision) (flutter/engine#42246 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 12:08:28 -07:00
NikolajHarderNota
c84b10474c
modal bottom sheet barrier label ( #126431 )
...
Adds barrierLabel as optional param in showModalBottomSheet
Fixes #83180
2023-05-23 18:59:49 +00:00
Justin McCandless
4341ed4229
Fix the breaking of multi-code-unit characters in obscure mode ( #123366 )
...
This PR changes the character boundary behavior of obscured fields to be based on code points instead of code units.
So it used to be possible to traverse and delete obscured text inside of code points (and breaking a code point like that would cause a crash):
But now moving the cursor and deleting is based on code points:
### Native behavior
Native iOS deletes part of the emoji, native Mac deletes the whole emoji. See https://github.com/flutter/flutter/issues/122381#issuecomment-1482042620 . So it's unclear what the desired behavior should actually be.
### Resources
Fixes https://github.com/flutter/flutter/issues/122381
I thought this might not fix the case where a broken emoji is directly pasted into the field, but it seems to work by trying this: �âð©âð¦âð¦
CC @LongCatIsLooong
2023-05-23 18:21:10 +00:00
engine-flutter-autoroll
ffbeb72336
Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) ( #127397 )
...
168b0bf3f7...a6e37bde65skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... (flutter/engine#42245 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DzmjiSg6XC0J to aAjEDVse7qfM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 17:26:27 +00:00
Victoria Ashworth
d452ce9635
Revert "Log all output of ios-deploy" ( #127405 )
...
Reverts flutter/flutter#127222
2023-05-23 16:37:36 +00:00
