engine-flutter-autoroll
487d42f9ee
Roll Flutter Engine from 9e8ccaa3842e to c2863530ce39 (2 revisions) ( #144792 )
...
9e8ccaa384...c2863530ceskia-flutter-autoroll@skia.org Roll Dart SDK from bbf21a08a92d to 4bc97350dc47 (1 revision) (flutter/engine#51256 )
2024-03-07 tugorez@users.noreply.github.com Prepend the accessibility placeholder (flutter/engine#51050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 20:28:23 +00:00
engine-flutter-autoroll
a23a9afeda
Roll Flutter Engine from 12828950890a to 9e8ccaa3842e (1 revision) ( #144784 )
...
1282895089...9e8ccaa384jesus_sguerrero@hotmail.com Skip impeller goldens on release (flutter/engine#51240 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 18:45:15 +00:00
Flutter GitHub Bot
d0287cc1c0
Marks Mac_x64 module_test_ios to be flaky ( #144681 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 module_test_ios"
}
-->
Issue link: https://github.com/flutter/flutter/issues/144680
2024-03-07 18:17:55 +00:00
Christopher Fujino
2dd06d10c9
[flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError ( #140122 )
...
Ensure tool code does not use Future.catchError or Future.onError, because it is not statically safe: https://github.com/dart-lang/sdk/issues/51248 .
This was proposed upstream in dart-lang/linter in https://github.com/dart-lang/linter/issues/4071 and https://github.com/dart-lang/linter/pull/4068 , but not accepted.
2024-03-07 18:10:07 +00:00
engine-flutter-autoroll
2ea5ca0345
Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) ( #144775 )
...
f8c3b2db8c...1282895089skia-flutter-autoroll@skia.org Roll Dart SDK from bf028d05b7fd to bbf21a08a92d (1 revision) (flutter/engine#51254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 16:56:17 +00:00
Bruno Leroux
471a82856d
[flutter_test] Use defaultTargetPlatform for key events simulation ( #143579 )
...
## Description
This PRs changes the default value for the `platform` parameter used to simulate key events.
With this PR, the default value is "web" on web, otherwise it is the operating system name retrieved from `defaultTargetPlatform`.
Previously, for methods in `WidgetController`, it defaulted to âwebâ on web, and âandroidâ everywhere else. And for methods in `KeyEventSimulator` it defaulted to âwebâ on web, and the operating system that the test was running on everywhere else. Because the operating system was based on `Platform.operatingSystem`, it usually differed from the target platform the test was running on.
AFAIK, the `platform` parameter is only meaningful for simulating `RawKeyEvent`. Once `RawKeyboard` will be fully removed, the `platform` parameter wonât be needed.
@gspencergoog In the meantime, do you think it is worth merging this fix?
## Related Issue
Fixes to https://github.com/flutter/flutter/issues/133955
## Tests
Adds one test.
2024-03-07 16:08:20 +00:00
engine-flutter-autoroll
4e63a6a2d9
Roll Packages from 9b88dbc53992 to 6701c9e61804 (3 revisions) ( #144772 )
...
9b88dbc539...6701c9e618tugorez@users.noreply.github.com [rfw] Add support for widget builders (flutter/packages#5907 )
2024-03-06 gabriel@terwesten.net [in_app_purchase_storekit] Handle translation of errors nested in dictionaries (flutter/packages#6277 )
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter from 3b5a2ecf992d to 8f84f3f32ddc (18 revisions) (flutter/packages#6276 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 15:51:23 +00:00
Matej Knopp
de72832079
Fix frameworks added to bundle multiple times instead of lipo ( #144688 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-07 15:09:15 +00:00
engine-flutter-autoroll
4d44662242
Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) ( #144766 )
...
40a42796b1...f8c3b2db8cskia-flutter-autoroll@skia.org Roll Dart SDK from 3538739eeea9 to bf028d05b7fd (1 revision) (flutter/engine#51252 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 12:10:14 +00:00
engine-flutter-autoroll
3aa89b39c4
Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) ( #144765 )
...
0246484d2b...40a42796b1kustermann@google.com Make @keepToString annotation work for web and non-web (flutter/engine#51251 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 10:50:22 +00:00
engine-flutter-autoroll
4d3e26fa6f
Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) ( #144756 )
...
6c1751bd77...0246484d2bskia-flutter-autoroll@skia.org Roll Dart SDK from 2cdf8f23c55f to 3538739eeea9 (1 revision) (flutter/engine#51249 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 08:31:25 +00:00
Bruno Leroux
8ade81fb20
[flutter_test] Change KeyEventSimulator default transit mode ( #143847 )
...
## Description
This PRs changes the default value transit mode for key event simulation.
The default transit mode for key event simulation is currently `KeyDataTransitMode.rawKeyData` while on the framework side `KeyDataTransitMode.keyDataThenRawKeyData` is the preferred transit mode.
`KeyDataTransitMode.keyDataThenRawKeyData` is more accurate and can help detect issues.
For instance the following test will fail with `KeyDataTransitMode.rawKeyData` because raw keyboard logic for modifier keys is less accurate:
```dart
testWidgets('Press control left once', (WidgetTester tester) async {
debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.keyDataThenRawKeyData;
final List<KeyEvent> events = <KeyEvent>[];
final FocusNode focusNode = FocusNode();
addTearDown(focusNode.dispose);
await tester.pumpWidget(
Focus(
focusNode: focusNode,
autofocus: true,
onKeyEvent: (_, KeyEvent event) {
events.add(event);
return KeyEventResult.handled;
},
child: Container(),
),
);
await simulateKeyDownEvent(LogicalKeyboardKey.controlLeft);
// This will fail when transit mode is KeyDataTransitMode.rawKeyData
// because a down event for controlRight is synthesized.
expect(events.length, 1);
debugKeyEventSimulatorTransitModeOverride = null;
});
```
And the following this test is ok with `KeyDataTransitMode.rawKeyData` but rightly fails with `KeyDataTransitMode.keyDataThenRawKeyData`:
```dart
testWidgets('Simulates consecutive key down events', (WidgetTester tester) async {
debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.rawKeyData;
// Simulating several key down events without key up in between is tolerated
// when transit mode is KeyDataTransitMode.rawKeyData, it will trigger an
// assert on KeyDataTransitMode.keyDataThenRawKeyData.
await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);
await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);
debugKeyEventSimulatorTransitModeOverride = null;
});
```
## Related Issue
Related to https://github.com/flutter/flutter/issues/143845
## Tests
Adds two tests.
2024-03-07 07:19:26 +00:00
engine-flutter-autoroll
f677027655
Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) ( #144747 )
...
03ebd6460b...6c1751bd77skia-flutter-autoroll@skia.org Roll Dart SDK from 3ad64881a209 to 2cdf8f23c55f (2 revisions) (flutter/engine#51247 )
2024-03-07 dkwingsmt@users.noreply.github.com Reland 5: Multiview pipeline (flutter/engine#51186 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 03:57:32 +00:00
engine-flutter-autoroll
95bf597afe
Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) ( #144746 )
...
8a859c5b3a...03ebd6460bjonahwilliams@google.com [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246 )
2024-03-07 chris@bracken.jp Move Abseil from src to flutter third_party dir (flutter/engine#51245 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 02:57:25 +00:00
engine-flutter-autoroll
894620b8c5
Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) ( #144743 )
...
4f6ea31d1f...8a859c5b3askia-flutter-autoroll@skia.org Manual roll Dart SDK from 9ea8813ab4d4 to 3ad64881a209 (5 revisions) (flutter/engine#51242 )
2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable blending in gaussian intermediate steps. (#51118 )" (flutter/engine#51244 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 02:14:08 +00:00
Valentin Vignal
96dd1984ec
Fix memory leak in editable_gesture_test.dart ( #144691 )
2024-03-06 17:51:54 -08:00
engine-flutter-autoroll
3e63c7385d
Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) ( #144741 )
...
53ddbdfc24...4f6ea31d1f#51187 )" (flutter/engine#51243 )
2024-03-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (flutter/engine#51239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 01:29:17 +00:00
engine-flutter-autoroll
4413f5bc49
Roll Flutter Engine from b2adf7471d3d to 53ddbdfc24e5 (1 revision) ( #144735 )
...
b2adf7471d...53ddbdfc24jesus_sguerrero@hotmail.com Skip impeller goldens on release branches (flutter/engine#51237 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 00:27:39 +00:00
engine-flutter-autoroll
1cbabd71a9
Roll Flutter Engine from 31bbe61dfa0d to b2adf7471d3d (1 revision) ( #144732 )
...
31bbe61dfa...b2adf7471d737941+loic-sharma@users.noreply.github.com [Windows] Allow plugins to get views (flutter/engine#51096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 23:16:19 +00:00
engine-flutter-autoroll
052eb5215b
Roll Flutter Engine from 5bbac1a5c576 to 31bbe61dfa0d (3 revisions) ( #144724 )
...
5bbac1a5c5...31bbe61dfaflar@google.com add new builder benchmark with a global saveLayer (flutter/engine#51236 )
2024-03-06 bdero@google.com [Flutter GPU] Move method tests to flutter_tester. (flutter/engine#51223 )
2024-03-06 zanderso@users.noreply.github.com Disable flaky linux desktop test (flutter/engine#51231 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 22:29:09 +00:00
Jenn Magder
aedce673f7
Run macOS test on dev/integration_tests/ui ( #142735 )
...
https://github.com/flutter/flutter/issues/87508 is complete, swap integration_test and remove TODO.
2024-03-06 22:18:17 +00:00
Martin Kustermann
aba7bc3f42
Use wasm-compatible conditional import in timeline.dart, avoid emitting timeline events in SchedulerBinding ( #144682 )
2024-03-06 23:08:24 +01:00
engine-flutter-autoroll
7a88767a1b
Roll Flutter Engine from 44405aedba13 to 5bbac1a5c576 (2 revisions) ( #144714 )
...
44405aedba...5bbac1a5c5jonahwilliams@google.com [Impeller] fold memory check into allocator_vk (flutter/engine#51187 )
2024-03-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ujOkbeYbrC8loPbfR... to y67DIBX84h7pAekIp... (flutter/engine#51233 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ujOkbeYbrC8l to y67DIBX84h7p
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 21:41:26 +00:00
keyonghan
bc867ec757
Bring back firebase tests to prod ( #144703 )
...
Context: https://github.com/flutter/flutter/issues/144183
2024-03-06 21:33:40 +00:00
engine-flutter-autoroll
f7aade93ea
Roll Flutter Engine from 20037e385bda to 44405aedba13 (3 revisions) ( #144710 )
...
20037e385b...44405aedbabdero@google.com [Impeller] Append fewer redundant points when bridging triangle strips between contours. (flutter/engine#51232 )
2024-03-06 jason-simmons@users.noreply.github.com [Impeller] Apply padding for alignment when doing HostBuffer::Emplace with a callback (flutter/engine#51221 )
2024-03-06 jason-simmons@users.noreply.github.com [Impeller] Create a new render target with the specified attachment configs when reusing cached render target textures (flutter/engine#51208 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 20:52:59 +00:00
Michael Goderbauer
9e46c67e9a
Fix code sample failing in smoke test ( #144709 )
...
This fixes the silent failure reported in https://github.com/flutter/flutter/issues/144353 . I am experimenting in https://github.com/flutter/flutter/pull/144706 with whether the failure should have been non-silent.
2024-03-06 20:51:52 +00:00
Qun Cheng
f38c5ad441
Remove deprecated errorColor from ThemeData ( #144078 )
...
This PR is to remove deprecated `ThemeData.errorColor`.
These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162 .
Part of https://github.com/flutter/flutter/issues/143956
2024-03-06 20:41:04 +00:00
Andrew Kolos
cc33f44e41
make DevFSContent descendants immutable ( #144664 )
...
`DevFSBytesContent` (and it's descendant `DevFSStringContent`) have setters that change the underlying content. These are unused outside of tests, so this PR removes them. Amongst other things, this could help me refactor https://github.com/flutter/flutter/pull/144660 into something that has fewer pitfalls.
This is purely a refactoring.
2024-03-06 20:21:41 +00:00
Jonah Williams
2ebd7f0d55
[Impeller] measure GPU memory usage. ( #144575 )
...
Framework side to https://github.com/flutter/engine/pull/51187
Part of https://github.com/flutter/flutter/issues/144617
2024-03-06 20:17:31 +00:00
engine-flutter-autoroll
0df2200b80
Roll Flutter Engine from 9aad0e93899b to 20037e385bda (1 revision) ( #144707 )
...
9aad0e9389...20037e385bmatanlurey@users.noreply.github.com Re-stamp skia_gold_client e2e tests. (flutter/engine#51220 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 20:07:51 +00:00
engine-flutter-autoroll
6cda972c00
Roll Flutter Engine from b6efe0dd88fe to 9aad0e93899b (2 revisions) ( #144702 )
...
b6efe0dd88...9aad0e9389737941+loic-sharma@users.noreply.github.com [et] Allow users to update dependencies (flutter/engine#51177 )
2024-03-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 728fcf0bcbca to 50464546d92d (5 revisions) (flutter/engine#51228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 19:20:02 +00:00
Gray Mackall
9973771cc3
Update android templates to use target sdk 34 ( #144641 )
...
We should always target the newest, and 34 is the newest. This isn't a requirement yet (like it is for 33+) but presumably it will be made required in the nearish future.
2024-03-06 19:15:07 +00:00
engine-flutter-autoroll
8f84f3f32d
Roll Packages from 2aa6e3f6bafe to 9b88dbc53992 (8 revisions) ( #144693 )
...
2aa6e3f6ba...9b88dbc539balvindersi2@gmail.com [image_picker_for_web] migrates to package:web (flutter/packages#5799 )
2024-03-06 balvindersi2@gmail.com [video_player_web] migrates to package:web (flutter/packages#5800 )
2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253 )
2024-03-05 ian@hixie.ch [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272 )
2024-03-05 louisehsu@google.com [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209 )
2024-03-05 stuartmorgan@google.com [tool] Add features to support GCB auto-publish flow (flutter/packages#6218 )
2024-03-05 ditman@gmail.com [web] Use TrustedTypes from pkg web. (flutter/packages#6273 )
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter from 65cd84b58885 to 3b5a2ecf992d (26 revisions) (flutter/packages#6269 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 15:46:24 +00:00
engine-flutter-autoroll
d0c8ad28cf
Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) ( #144668 )
...
370e7d5866...b6efe0dd88skia-flutter-autoroll@skia.org Roll Skia from db3a36120ae2 to f17ec7494469 (3 revisions) (flutter/engine#51226 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 08:10:07 +00:00
engine-flutter-autoroll
e1013f26f2
Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) ( #144661 )
...
d374c78bcf...370e7d5866skia-flutter-autoroll@skia.org Roll Skia from 1d1fd7fe1a89 to db3a36120ae2 (1 revision) (flutter/engine#51222 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 04:25:24 +00:00
engine-flutter-autoroll
2ab00ee682
Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) ( #144659 )
...
effcf97a1f...d374c78bcfmatanlurey@users.noreply.github.com Revamp the `scenario_app/../README.md` to encourage self-sustenance (flutter/engine#51196 )
2024-03-06 jonahwilliams@google.com [Impeller] disable blending in gaussian intermediate steps. (flutter/engine#51118 )
2024-03-06 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51219 )
2024-03-06 skia-flutter-autoroll@skia.org Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (flutter/engine#51216 )
2024-03-06 bdero@google.com [Impeller] Fix path winding when bridging from contours with an odd number of points. (flutter/engine#51218 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 03:33:31 +00:00
Greg Price
6b9d3ea4fc
Fill in SliverConstraints fields missing from ==, hashCode, toString ( #143661 )
...
I was doing some debugging on a RenderSliver subclass, and found
that SliverConstraints.toString was missing the precedingScrollExtent
field.
Add that, and add both that field and userScrollDirection to the
`==` and hashCode implementations, which had been skipping them,
so that all three methods now handle all the class's fields.
2024-03-06 03:23:18 +00:00
engine-flutter-autoroll
a431dee5c9
Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) ( #144653 )
...
49bc1577f3...effcf97a1f#51209 )" (flutter/engine#51217 )
2024-03-05 30870216+gaaclarke@users.noreply.github.com [Impeller] implement blur style solid (flutter/engine#50892 )
2024-03-05 xilaizhang@google.com [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214 )
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211 )
2024-03-05 737941+loic-sharma@users.noreply.github.com Fix git hooks on Windows (flutter/engine#51203 )
2024-03-05 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209 )
2024-03-05 bdero@google.com [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198 )
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207 )
2024-03-05 gspencergoog@users.noreply.github.com Skip configuration dependency if unit tests are disabled (flutter/engine#51179 )
2024-03-05 chinmaygarde@google.com [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 02:27:24 +00:00
dependabot[bot]
bbb005296c
Bump codecov/codecov-action from 4.0.2 to 4.1.0 ( #144174 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.0.2 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: set safe directory by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1304 ">codecov/codecov-action#1304</a></li>
<li>build(deps): bump github/codeql-action from 3.24.3 to 3.24.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1306 ">codecov/codecov-action#1306</a></li>
<li>build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1305 ">codecov/codecov-action#1305</a></li>
<li>chore(release): v4.1.0 by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1307 ">codecov/codecov-action#1307</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.0.2...v4.1.0 ">https://github.com/codecov/codecov-action/compare/v4.0.2...v4.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="54bcd8715ehttps://redirect.github.com/codecov/codecov-action/issues/1307 ">#1307</a>)</li>
<li><a href="8ba77ef8d7https://redirect.github.com/codecov/codecov-action/issues/1305 ">#1305</a>)</li>
<li><a href="c60aa801e3https://redirect.github.com/codecov/codecov-action/issues/1306 ">#1306</a>)</li>
<li><a href="2fc4847d3fhttps://redirect.github.com/codecov/codecov-action/issues/1304 ">#1304</a>)</li>
<li>See full diff in <a href="0cfda1dd0a...54bcd8715ehttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.0.2&new-version=4.1.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-03-05 23:55:05 +00:00
Victoria Ashworth
7e05bc4b30
Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods ( #144248 )
...
Fixes https://github.com/flutter/flutter/issues/144244 .
2024-03-05 21:59:49 +00:00
Andrew Kolos
ff3b6dc02c
Enable asset transformation feature in hot reload workflow (excluding Web) ( #144161 )
...
Partial implementation of https://github.com/flutter/flutter/issues/143348
This enables asset transformation during hot reload (except for web, because that has its own implementation of `DevFS` ð). Asset transformers will be reapplied after changing any asset and performing a hot reload during `flutter run`.
2024-03-05 21:54:06 +00:00
engine-flutter-autoroll
15e8d324f5
Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) ( #144639 )
...
3e8b0deffe...49bc1577f3zanderso@users.noreply.github.com Fix typo in githook message (flutter/engine#51205 )
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202 )
2024-03-05 john@johnmccutchan.com Add device selection to `et run` (flutter/engine#51184 )
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201 )
2024-03-05 zanderso@users.noreply.github.com Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 21:47:56 +00:00
Hans Muller
52961f761f
Updated the smiley TextButton example again ( #144630 )
...
Improved the smiley image TextButton example a little. Handling the case where the `Future.delayed` object that represents the button's one second long action is superseded by a second button press that triggers a new one-second action. This does complicate the example - just a little - but it's a little more robust. In case someone copy-and-pastes the code.
The TextButton example was recently updated: https://github.com/flutter/flutter/pull/144583
2024-03-05 20:57:02 +00:00
Tirth
311c0064d8
Adds missing style to PopupMenuButton ( #143392 )
...
Adds missing `style` to `PopupMenuButton`.
Fixes : #114709
2024-03-05 19:42:30 +00:00
engine-flutter-autoroll
bb8fc6e9a9
Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) ( #144629 )
...
a7c7858849...3e8b0deffezanderso@users.noreply.github.com Folds concurrent job calculation into `tools/gn` (flutter/engine#51193 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 19:32:55 +00:00
Michael Goderbauer
2aa1efcf0a
Add regression test for TabBar crash ( #144627 )
...
This is a regression test for https://github.com/flutter/flutter/issues/144087 and https://github.com/flutter/flutter/issues/138588 .
To be submitted after https://github.com/flutter/flutter/pull/144579 .
2024-03-05 19:24:05 +00:00
engine-flutter-autoroll
ba7749a3c9
Roll Packages from 06258277070f to 2aa6e3f6bafe (5 revisions) ( #144628 )
...
0625827707...2aa6e3f6bagabriel@terwesten.net [in_app_purchase_storekit] Fix type of error code returned from native code in `SKReceiptManager.retrieveReceiptData` (flutter/packages#6265 )
2024-03-05 slowhand0309@gmail.com [video_player] Fix typo in readme (flutter/packages#6264 )
2024-03-05 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the SwiftGenerator (flutter/packages#5959 )
2024-03-05 5384625+pzierahn@users.noreply.github.com [flutter_markdown] Fix WidgetSpan Support in MarkdownElementBuilder (flutter/packages#6225 )
2024-03-04 stuartmorgan@google.com [webview_flutter] Make WebKitWebViewWidget unit tests stateless (flutter/packages#6228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 19:14:51 +00:00
Andrew Kolos
4e6de2be33
remove unused firstBuildTime parameter in DevFS::update ( #144576 )
...
The title says it all. This parameter is unused and serves no apparent purpose.
2024-03-05 19:14:48 +00:00
engine-flutter-autoroll
4e71b4d81d
Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) ( #144624 )
...
8916bb32b7...a7c7858849skia-flutter-autoroll@skia.org Roll Skia from 10058142c8a2 to de108a9c8b54 (4 revisions) (flutter/engine#51199 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 18:45:11 +00:00
Michael Goderbauer
d93f24ab93
Revert "_DefaultTabControllerState should dispose all created TabContoller instances. ( #136608 )" ( #144579 )
...
This reverts commit 9fa9fd365c9f1d8053cc75da996407abe1537410.
Fixes https://github.com/flutter/flutter/issues/144087 .
Fixes https://github.com/flutter/flutter/issues/138588 .
This crash has been reported previously from a customer in google3 in https://github.com/flutter/flutter/issues/138588 , but we weren't able to track it down. Thankfully, a repro was now provided in https://github.com/flutter/flutter/issues/144087#issuecomment-1968257383 which traced the crash down to a change made in #136608 . This PR reverts that change to fix that crash for now. I will post a new PR shortly that will add a test to cover the use case that caused the crash with #136608 to make sure we don't re-introduce the crash in the future.
2024-03-05 18:41:56 +00:00
