engine-flutter-autoroll
bfeaf5a7f2
Roll Flutter Engine from e16f43eeaaa4 to 4128895d79a1 (1 revision) ( #143856 )
...
e16f43eeaa...4128895d79matanlurey@users.noreply.github.com Disallow files additional named `GeneratedPluginRegistrant.java`. (flutter/engine#50796 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 16:57:00 +00:00
engine-flutter-autoroll
4aecbf916b
Roll Packages from 8bba41b0c046 to 48048f6bc779 (2 revisions) ( #143853 )
...
8bba41b0c0...48048f6bc7ditman@gmail.com [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167 )
2024-02-20 kevmoo@users.noreply.github.com [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 15:54:37 +00:00
Taha Tesser
3403ca413f
Update hourMinuteTextStyle defaults for Material 3 Time Picker ( #143749 )
...
fixes [`hourMinuteTextStyle` Material 3 default doesn't match the specs](https://github.com/flutter/flutter/issues/143748 )
This updates `hourMinuteTextStyle` defaults to match Material 3 specs. `hourMinuteTextStyle` should use different font style for different entry modes based on the specs.
### Specs
### Before
```dart
return _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```
### After
```dart
return entryMode == TimePickerEntryMode.dial
? _textTheme.displayLarge!.copyWith(color: _hourMinuteTextColor.resolve(states))
: _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```
2024-02-21 10:39:35 +00:00
engine-flutter-autoroll
35fd706256
Roll Flutter Engine from 93063f61943a to e16f43eeaaa4 (2 revisions) ( #143827 )
...
93063f6194...e16f43eeaabdero@google.com [Impeller] Add GeometryResult enum with StC modes. (flutter/engine#50816 )
2024-02-21 bdero@google.com Update impeller-cmake-example (flutter/engine#50808 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 10:15:24 +00:00
engine-flutter-autoroll
ca05958f2d
Roll Flutter Engine from ed49634486e9 to 93063f61943a (1 revision) ( #143826 )
...
ed49634486...93063f6194bdero@google.com [Impeller] Remove non-Flutter fill types from impeller::Path. (flutter/engine#50814 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 09:07:19 +00:00
Taha Tesser
5d2353c105
CalendarDatePicker doesn't announce selected date on desktop (#143583 )
...
fixes [Screen reader is not announcing the selected date as selected on DatePicker](https://github.com/flutter/flutter/issues/143439 )
### Descriptions
- This fixes an issue where `CalendarDatePicker` doesn't announce selected date on desktop.
- Add semantic label to describe the selected date is indeed "Selected".
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
MyHomePageState createState() => MyHomePageState();
}
class MyHomePageState extends State<MyHomePage> {
void _showDatePicker() async {
await showDatePicker(
context: context,
initialDate: DateTime.now(),
firstDate: DateTime(1900),
lastDate: DateTime(2200),
);
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title,
style: const TextStyle(fontFamily: 'ProductSans')),
),
body: const Center(
child: Text('Click the button to show date picker.'),
),
floatingActionButton: FloatingActionButton(
onPressed: _showDatePicker,
tooltip: 'Show date picker',
child: const Icon(Icons.edit_calendar),
),
);
}
}
// import 'package:flutter/material.dart';
// void main() => runApp(const MyApp());
// class MyApp extends StatelessWidget {
// const MyApp({super.key});
// @override
// Widget build(BuildContext context) {
// return MaterialApp(
// debugShowCheckedModeBanner: false,
// home: Scaffold(
// body: Center(
// child: CalendarDatePicker(
// initialDate: DateTime.now(),
// firstDate: DateTime(2020),
// lastDate: DateTime(2050),
// onDateChanged: (date) {
// print(date);
// },
// ),
// ),
// ),
// );
// }
// }
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/c82e1f15-f067-4865-8a5a-1f3c0c8d91da
### After
https://github.com/flutter/flutter/assets/48603081/193d9e26-df9e-4d89-97ce-265c3d564607
2024-02-21 08:59:24 +00:00
engine-flutter-autoroll
a41868e506
Roll Flutter Engine from 9100d326475a to ed49634486e9 (2 revisions) ( #143824 )
...
9100d32647...ed49634486bdero@google.com [Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. (flutter/engine#50742 )
2024-02-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gKg6HlBeR52y-cMhu... to dLhvv964txwnSlvNw... (flutter/engine#50813 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gKg6HlBeR52y to dLhvv964txwn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 08:21:59 +00:00
Taha Tesser
95cdebedae
Add timeSelectorSeparatorColor and timeSelectorSeparatorTextStyle for Material 3 Time Picker ( #143739 )
...
fixes [`Time selector separator` in TimePicker is not centered vertically](https://github.com/flutter/flutter/issues/143691 )
Separator currently `hourMinuteTextStyle` to style itself.
This introduces `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` from Material 3 specs to correctly style the separator. This also adds ability to change separator color without changing `hourMinuteTextColor`.
### Specs for the time selector separator
https://m3.material.io/components/time-pickers/specs
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const App());
}
class App extends StatelessWidget {
const App({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
// timePickerTheme: TimePickerThemeData(
// hourMinuteTextColor: Colors.amber,
// )
),
home: Scaffold(
body: Center(
child: Builder(builder: (context) {
return ElevatedButton(
onPressed: () async {
await showTimePicker(
context: context,
initialTime: TimeOfDay.now(),
);
},
child: const Text('Pick Time'),
);
}),
),
),
);
}
}
```
</details>
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/20beeba4-5cc2-49ee-bba8-1c552c0d1e44 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/24927187-aff7-4191-930c-bceab6a4b4c2 " /> |
2024-02-21 08:10:01 +00:00
engine-flutter-autoroll
f923375654
Roll Flutter Engine from efc69946cb1e to 9100d326475a (2 revisions) ( #143820 )
...
efc69946cb...9100d32647leroux_bruno@yahoo.fr [Web] Update modifier state when Meta key is seen as Process key (flutter/engine#50779 )
2024-02-21 jason-simmons@users.noreply.github.com Add pub.dev to the hosted package URIs checked by the pub_get_offline script (flutter/engine#50811 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 06:48:22 +00:00
engine-flutter-autoroll
e9f3244eaa
Roll Flutter Engine from 700250436e3f to efc69946cb1e (2 revisions) ( #143816 )
...
700250436e...efc69946cbzanderso@users.noreply.github.com Make global builds uniquely named per platform (flutter/engine#50764 )
2024-02-21 zanderso@users.noreply.github.com [et] Adds a format command (flutter/engine#50747 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 05:27:23 +00:00
engine-flutter-autoroll
1f32b48c6d
Roll Flutter Engine from 3557277c575c to 700250436e3f (1 revision) ( #143814 )
...
3557277c57...700250436ebdero@google.com [Flutter GPU] Fix symbol export for windows. (flutter/engine#50755 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 04:26:24 +00:00
Jonah Williams
f58a162da0
more fixes to unstable impeller goldens. ( #143811 )
...
Part of https://github.com/flutter/flutter/issues/143616
2024-02-21 03:14:19 +00:00
engine-flutter-autoroll
35bdc94dda
Roll Flutter Engine from cb12a8cc97a1 to 3557277c575c (2 revisions) ( #143807 )
...
cb12a8cc97...3557277c57jonahwilliams@google.com Disable framework smoke tests. (flutter/engine#50800 )
2024-02-20 jonahwilliams@google.com [Impeller] more nullchecks in image decoder. (flutter/engine#50787 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-21 02:29:23 +00:00
Kevin Moore
bc334396db
[flutter_tools] enable wasm compile on beta channel ( #143779 )
...
Wasm compilation is now available on `master` and `beta` channels.
2024-02-21 01:20:04 +00:00
Simon Friis Vindum
6c78e36ccb
Fix initialization of time in repeat on AnimationController ( #142887 )
...
This PR fixes #142885 .
The issue is that in `_RepeatingSimulation` the initial time is calculated as follows:
```
(initialValue / (max - min)) * (period.inMicroseconds / Duration.microsecondsPerSecond)
```
This calculation does not work in general. For instance, if `max` is 300, `min` is 100, and `initialValue` is 100 then `initialValue / (max - min)` is 1/2 when it should be 0
The current tests work by happenstance because the numbers used happen to work. To reveal the bug I've added some more tests similar to the existing ones but with different numbers.
A "side-effect" of the incorrect calculation is that if `initialValue` is 0, then the animation will always start from `min` no matter what. For instance, in one of the tests, an `AnimationController` with the value 0 is told to `repeat` between 0.5 and 1.0, and this starts the animation from 0.5. To preserve this behavior, and to more generally handle the case where the initial value is out of bounds, this PR clamps the initial value to be within the lower and upper bounds of the repetition.
Just for reference, this calculation was introduced at https://github.com/flutter/flutter/pull/25125 .
2024-02-21 00:36:08 +00:00
Jonah Williams
1e822ca2fd
Disable debug banner to stabilize impeller goldens. ( #143794 )
...
Fixes some of https://github.com/flutter/flutter/issues/143616 by disabling the debug banner, which does not appear to be a critical part of the golden.
2024-02-21 00:34:11 +00:00
auto-submit[bot]
f9b3b84d4e
Reverts "Changing TextPainter.getOffsetForCaret implementation to remove the logarithmic search ( #143281 )" ( #143801 )
...
Reverts flutter/flutter#143281
Initiated by: LongCatIsLooong
Reason for reverting: https://github.com/flutter/flutter/issues/143797
Original PR Author: LongCatIsLooong
Reviewed By: {justinmc, jason-simmons}
This change reverts the following previous change:
Original Description:
The behavior largely remains the same, except:
1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line.
For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before).
This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation.
And it makes the navigation order consistent for `aA\naA`:
```
|aA => aA| => aA| => aA => aA => aA
aA aA aA |aA aA| aA|
(1) (2) (3) (4) (5) (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same).
But logical order navigation will always be confusing in bidi text, in one way or another.
Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess).
- On the other hand, its (new) omnibar seems to use visual order arrow navigation
Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction.
2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424 .
## Internal Tests
This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.
2024-02-21 00:10:18 +00:00
auto-submit[bot]
84b5e799d3
Reverts "Add UI Benchmarks ( #143542 )" ( #143798 )
...
Reverts flutter/flutter#143542
Initiated by: goderbauer
Reason for reverting: Failing post-submit, see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755531866181499153/+/u/run_microbenchmarks/stdout
Original PR Author: bernaferrari
Reviewed By: {goderbauer}
This change reverts the following previous change:
Original Description:
Part 1 of https://github.com/flutter/flutter/pull/138481
Cherry picking @ignatz work.
2024-02-20 23:38:19 +00:00
LongCatIsLooong
174e58697c
Avoid applying partial dartfixes on CI ( #143551 )
...
Unblocks https://github.com/flutter/tests/pull/345
Add `bulkApply: false` to partial fixes so they don't automatically get applied on registered tests.
2024-02-20 23:27:26 +00:00
Bernardo Ferrari
74a2e0d138
Add UI Benchmarks ( #143542 )
...
Part 1 of https://github.com/flutter/flutter/pull/138481
Cherry picking @ignatz work.
2024-02-20 23:13:07 +00:00
engine-flutter-autoroll
0bd7d3167a
Roll Flutter Engine from 1ae2c10e8071 to cb12a8cc97a1 (1 revision) ( #143791 )
...
1ae2c10e80...cb12a8cc97737941+loic-sharma@users.noreply.github.com [Windows] Add ID to views (flutter/engine#50788 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 22:51:48 +00:00
Nate
fc07b241ae
Implement _suspendedNode fix ( #143556 )
...
Previously we merged #142930 , to solve issue #87061 .
Since then, I discovered that the keyboard input wasn't being captured after the app had been paused and resumed. After some digging, I realized that the problem was due to [a line in editable_text.dart](d4b1b6e744/packages/flutter/lib/src/widgets/editable_text.dart (L3589)
2024-02-20 22:46:22 +00:00
xubaolin
6707f5efbe
Change ItemExtentBuilder's return value nullable ( #142428 )
...
Fixes https://github.com/flutter/flutter/issues/138912
Change `ItemExtentBuilder`'s return value nullable, it should return null if asked to build an item extent with a greater index than exists.
2024-02-20 22:14:00 +00:00
engine-flutter-autoroll
bb1271d483
Roll Flutter Engine from 27828054f07a to 1ae2c10e8071 (6 revisions) ( #143783 )
...
27828054f0...1ae2c10e80matanlurey@users.noreply.github.com Move the `scenario_app` running Impeller+OpenGLES to `bringup: triue` (flutter/engine#50789 )
2024-02-20 jason-simmons@users.noreply.github.com Implement the render_to_surface flag in GPUSurfaceGLImpeller (flutter/engine#50669 )
2024-02-20 zanderso@users.noreply.github.com [et] Adds a .bat entrypoint for Windows (flutter/engine#50784 )
2024-02-20 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Create dedicated testers to run tests and deprecate femu_test (flutter/engine#50697 )
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 50e1b709781c to 9d86359b5fe8 (2 revisions) (flutter/engine#50786 )
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 2dc00a705f1c to 50e1b709781c (5 revisions) (flutter/engine#50785 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 22:12:31 +00:00
engine-flutter-autoroll
64c63d35b7
Roll Flutter Engine from e16a260265ad to 27828054f07a (1 revision) ( #143769 )
...
e16a260265...27828054f0jonahwilliams@google.com [Impeller] add missing std::move in setup depth stencil. (flutter/engine#50750 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 21:08:09 +00:00
Jonah Williams
4c0b5ccebc
[gold] Always provide host ABI to gold config ( #143621 )
...
This can help us split goldens that are different due to arm non-arm mac, et cetera.
Part of https://github.com/flutter/flutter/issues/143616
2024-02-20 21:06:01 +00:00
Andrew Kolos
b491f16d9c
instead of exiting the tool, print a warning when using --flavor with an incompatible device ( #143735 )
...
Fixes https://github.com/flutter/flutter/issues/143574 by printing a warning (instead of exiting) when `--flavor` is used with a target platform that doesn't have flavors support.
2024-02-20 21:02:49 +00:00
Nate
7a4c2465af
Implementing switch expressions: everything in flutter/lib/src/ ( #143634 )
...
This PR is the 9áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.
(previous pull requests: #139048 , #139882 , #141591 , #142279 , #142634 , #142793 , #143293 , #143496 )
I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)
2024-02-20 21:02:47 +00:00
LongCatIsLooong
3538e4c788
Changing TextPainter.getOffsetForCaret implementation to remove the logarithmic search ( #143281 )
...
The behavior largely remains the same, except:
1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line.
For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before).
This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation.
And it makes the navigation order consistent for `aA\naA`:
```
|aA => aA| => aA| => aA => aA => aA
aA aA aA |aA aA| aA|
(1) (2) (3) (4) (5) (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same).
But logical order navigation will always be confusing in bidi text, in one way or another.
Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess).
- On the other hand, its (new) omnibar seems to use visual order arrow navigation
Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction.
2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424 .
## Internal Tests
This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.
2024-02-20 20:51:06 +00:00
Gray Mackall
3ae71f5c43
Delete local.properties that shouldn't have been pushed ( #143774 )
...
This file shouldn't be in version control
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
Co-authored-by: Gray Mackall <mackall@google.com>
2024-02-20 11:55:51 -08:00
Polina Cherkasova
39befd81dd
Clean leaks. ( #142818 )
2024-02-20 11:14:16 -08:00
Qun Cheng
a2c7ed95d1
Introduce tone-based surfaces and accent color add-ons - Part 2 ( #138521 )
...
This PR is to introduce 19 new color roles and deprecate 3 color roles in `ColorScheme`.
**Tone-based surface colors** (7 colors):
* surfaceBright
* surfaceDim
* surfaceContainer
* surfaceContainerLowest
* surfaceContainerLow
* surfaceContainerHigh
* surfaceContainerHighest
**Accent color add-ons** (12 colors):
* primary/secondary/tertiary-Fixed
* primary/secondary/tertiary-FixedDim
* onPrimary/onSecondary/onTertiary-Fixed
* onPrimary/onSecondary/onTertiary-FixedVariant
**Deprecated colors**:
* background -> replaced with surface
* onBackground -> replaced with onSurface
* surfaceVariant -> replaced with surfaceContainerHighest
Please checkout this [design doc](https://docs.google.com/document/d/1ODqivpM_6c490T4j5XIiWCDKo5YqHy78YEFqDm4S8h4/edit?usp=sharing ) for more information:)
2024-02-20 19:01:50 +00:00
Greg Price
eacf0f9e41
Explain when and why to use CrossAxisAlignment.baseline ( #143632 )
...
Improves the docs around horizontal alignment of text, due to several issues expressing confusion about this topic.
2024-02-20 10:59:12 -08:00
engine-flutter-autoroll
718c81704f
Roll Flutter Engine from a41da3701923 to e16a260265ad (2 revisions) ( #143763 )
...
a41da37019...e16a260265737941+loic-sharma@users.noreply.github.com [Windows] Make the engine create the view (flutter/engine#50673 )
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 2f9bb1517740 to 2dc00a705f1c (2 revisions) (flutter/engine#50782 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 18:07:59 +00:00
Zachary Anderson
8a8616f913
Handle FormatException from SkiaGoldClient ( #143755 )
...
Seen in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Framework%20Smoke%20Tests/17183/overview
closing the engine tree.
2024-02-20 09:57:23 -08:00
engine-flutter-autoroll
6200026a6d
Roll Packages from 84ff11d7ee5a to 8bba41b0c046 (2 revisions) ( #143757 )
...
84ff11d7ee...8bba41b0c0engine-flutter-autoroll@skia.org Roll Flutter from 064c340baf0e to 5129806e6c63 (9 revisions) (flutter/packages#6164 )
2024-02-20 stuartmorgan@google.com [flutter_markdown] Replace deprecated API (flutter/packages#6134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 17:07:12 +00:00
engine-flutter-autoroll
096c917efc
Roll Flutter Engine from 781f308c6555 to a41da3701923 (1 revision) ( #143756 )
...
781f308c65...a41da37019skia-flutter-autoroll@skia.org Roll Skia from a76b083ac4cc to 2f9bb1517740 (1 revision) (flutter/engine#50781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 16:53:17 +00:00
engine-flutter-autoroll
5129806e6c
Roll Flutter Engine from 0abe2b9d6c7c to 781f308c6555 (1 revision) ( #143750 )
...
0abe2b9d6c...781f308c65skia-flutter-autoroll@skia.org Roll Dart SDK from 8bb8ff24aea3 to f344e2266468 (1 revision) (flutter/engine#50780 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 15:36:09 +00:00
engine-flutter-autoroll
1a7a0618a7
Roll Flutter Engine from 92aad0d0fcee to 0abe2b9d6c7c (1 revision) ( #143745 )
...
92aad0d0fc...0abe2b9d6cskia-flutter-autoroll@skia.org Roll Skia from d448ca514a56 to a76b083ac4cc (1 revision) (flutter/engine#50778 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 11:41:28 +00:00
engine-flutter-autoroll
c56d4d112a
Roll Flutter Engine from 2335115f08d3 to 92aad0d0fcee (2 revisions) ( #143736 )
...
2335115f08...92aad0d0fcskia-flutter-autoroll@skia.org Roll Dart SDK from 475e710429ee to 8bb8ff24aea3 (1 revision) (flutter/engine#50775 )
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from ff602d384586 to d448ca514a56 (4 revisions) (flutter/engine#50776 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 08:37:48 +00:00
engine-flutter-autoroll
dd2447471e
Roll Flutter Engine from e96c18b6c5ee to 2335115f08d3 (1 revision) ( #143731 )
...
e96c18b6c5...2335115f08skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HFmcvzkR3TYeHa_0U... to gKg6HlBeR52y-cMhu... (flutter/engine#50771 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HFmcvzkR3TYe to gKg6HlBeR52y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 06:25:26 +00:00
Greg Price
2d422a3261
Small fixes in TextEditingController docs ( #143717 )
...
This follows up on #143452 , to slightly further address #95978 .
The double- rather than triple-slash on the blank line caused it to be ignored by dartdoc, so that the two paragraphs it's intended to separate were getting joined as one paragraph instead.
Also expand this constructor's summary line slightly to mention its distinctive feature compared with the other constructor, and make other small fixes that I noticed in other docs on this class.
2024-02-20 05:49:05 +00:00
engine-flutter-autoroll
f2eea969f7
Roll Flutter Engine from b41494f009f4 to e96c18b6c5ee (1 revision) ( #143722 )
...
b41494f009...e96c18b6c5flar@google.com [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 22:41:24 +00:00
engine-flutter-autoroll
3b5b462aba
Roll Flutter Engine from 714215d42e57 to b41494f009f4 (1 revision) ( #143713 )
...
714215d42e...b41494f009skia-flutter-autoroll@skia.org Roll Dart SDK from 6d659f880394 to 475e710429ee (1 revision) (flutter/engine#50763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 19:38:37 +00:00
Gustl22
9620e3f69c
Reland (2): "Fix how Gradle resolves Android plugin" ( #142498 )
...
Previous PR: #137115 ,
Revert: #142464
Fixes #141940
Closes #142487
2024-02-19 18:07:33 +00:00
engine-flutter-autoroll
05daee3d91
Roll Packages from 0af905d779d5 to 84ff11d7ee5a (1 revision) ( #143710 )
...
0af905d779...84ff11d7eeengine-flutter-autoroll@skia.org Roll Flutter from d7867ca7d635 to 064c340baf0e (33 revisions) (flutter/packages#6161 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 17:53:16 +00:00
engine-flutter-autoroll
064c340baf
Roll Flutter Engine from f71b7eee2266 to 714215d42e57 (1 revision) ( #143708 )
...
f71b7eee22...714215d42eskia-flutter-autoroll@skia.org Roll Skia from 6eaa7cf6d013 to ff602d384586 (1 revision) (flutter/engine#50762 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 16:30:24 +00:00
engine-flutter-autoroll
d2e7414a92
Roll Flutter Engine from 07c73b0c8413 to f71b7eee2266 (2 revisions) ( #143694 )
...
07c73b0c84...f71b7eee22tessertaha@gmail.com Revert "Fix iOS password autofill prompt dismissal causes layout to resize (#50364 )" (flutter/engine#50760 )
2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from a4ff02094bbd to 6eaa7cf6d013 (4 revisions) (flutter/engine#50759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 11:48:37 +00:00
engine-flutter-autoroll
74e054f04a
Roll Flutter Engine from 80d6745c6fd6 to 07c73b0c8413 (1 revision) ( #143682 )
...
80d6745c6f...07c73b0c84skia-flutter-autoroll@skia.org Roll Skia from b0680ba29971 to a4ff02094bbd (1 revision) (flutter/engine#50756 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 06:23:24 +00:00
engine-flutter-autoroll
4c8e30cc7f
Roll Flutter Engine from 67abf6eb36a1 to 80d6745c6fd6 (1 revision) ( #143676 )
...
67abf6eb36...80d6745c6fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uSZ0te7RWVq4IFpjb... to HFmcvzkR3TYeHa_0U... (flutter/engine#50752 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uSZ0te7RWVq4 to HFmcvzkR3TYe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 00:58:28 +00:00
