skia-flutter-autoroll
17e6f613bf
Roll Skia from ad1e3d828960 to f67db9982729 (8 revisions) ( flutter/engine#54317 )
...
https://skia.googlesource.com/skia.git/+log/ad1e3d828960..f67db9982729
2024-08-02 kjlubick@google.com Remove legacy SkCodec enum
2024-08-02 kjlubick@google.com Add some docs regarding asyncRescaleAndReadPixels
2024-08-02 nscobie@google.com Double SK_ANDROID_FRAMEWORK_ATRACE_BUFFER_SIZE to 512
2024-08-02 brianosman@google.com Add an option for unclamped (RGB) matrix color filter
2024-08-02 hitawala@chromium.org [graphite] Move bindgroup cache from DawnResourceProvider to DawnTexture
2024-08-02 kjlubick@google.com Add missing #include for VulkanMemoryAllocator
2024-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d2ee565bbb6c to b070881de5eb (4 revisions)
2024-08-02 kjlubick@google.com Make pathkit depend on Bazel buffet build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 17:28:03 +00:00
skia-flutter-autoroll
6a7f75e516
Roll Skia from 77cfae25b51d to 069274b16635 (3 revisions) ( flutter/engine#54306 )
...
https://skia.googlesource.com/skia.git/+log/77cfae25b51d..069274b16635
2024-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 52942aa78b6c to 4c3759b8afef (13 revisions)
2024-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6b512aaeec71 to f883075c10a9 (23 revisions)
2024-08-02 jvanverth@google.com Revert "Use a single source for CircularRRectEffect's analytic rrect clip."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 06:40:28 +00:00
skia-flutter-autoroll
b69402ca34
Roll Skia from 3b79cbb42bf6 to 77cfae25b51d (1 revision) ( flutter/engine#54303 )
...
https://skia.googlesource.com/skia.git/+log/3b79cbb42bf6..77cfae25b51d
2024-08-02 michaelludwig@google.com [graphite] Take count,stride separately in get[Vertex|Index|Uniform]Writer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 04:28:21 +00:00
skia-flutter-autoroll
deb3b9cebb
Roll Dart SDK from 03efd390e475 to 8dc947153d60 (1 revision) ( flutter/engine#54302 )
...
https://dart.googlesource.com/sdk.git/+log/03efd390e475..8dc947153d60
2024-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-108.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 04:07:22 +00:00
skia-flutter-autoroll
d840ba51ce
Roll Skia from 5c229d4d20bb to cfa1cda77b46 (3 revisions) ( flutter/engine#54300 )
...
https://skia.googlesource.com/skia.git/+log/5c229d4d20bb..cfa1cda77b46
2024-08-01 jvanverth@google.com Revert "[ganesh] Fix CircularRRectEffect batching."
2024-08-01 kjlubick@google.com Decouple Graphite SkSL code from Ganesh code.
2024-08-01 johnstiles@google.com Demonstrate effect specialization fan-out.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 01:20:23 +00:00
skia-flutter-autoroll
01a4b48613
Roll Dart SDK from acbbbe73b5eb to 03efd390e475 (1 revision) ( flutter/engine#54298 )
...
https://dart.googlesource.com/sdk.git/+log/acbbbe73b5eb..03efd390e475
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-107.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 23:45:20 +00:00
skia-flutter-autoroll
659739db9a
Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... ( flutter/engine#54295 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 22:32:14 +00:00
Jackson Gardner
2b915b5444
[skwasm] Implement platform view clipping. ( flutter/engine#54201 )
...
This implements platform view clipping for the Skwasm renderer.
This fixes https://github.com/flutter/flutter/issues/133466
2024-08-01 22:12:14 +00:00
skia-flutter-autoroll
bb477b53cf
Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) ( flutter/engine#54288 )
...
https://skia.googlesource.com/skia.git/+log/ddb6901e6141..5c229d4d20bb
2024-08-01 yuanjkang@google.com Adds corresponding NPM lockfiles to package.json files. This enumerates dependencies, including transitive ones, and their versions, to avoid using vulnerable ones. For more details, see go/npm-lockfile-cl-guide
2024-08-01 borenet@google.com [infra] Add find_tasks.py script
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 2395877dc55f to c830bf291754 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 21:27:21 +00:00
Matan Lurey
4950f9f2c5
Use InetAddress.getLoopback() versus a string. ( flutter/engine#54289 )
...
This is just better anyway, and will work around an Android 35 failure we're investigating.
2024-08-01 21:02:23 +00:00
Jonah Williams
82c43d466a
[iOS] Supported rendering platform views without merging the raster thread. ( flutter/engine#53826 )
...
Remove the need to merge raster and platform thread in the presence of platform views by defering UIView mutation and presentation of flutter views into separate platform thread task. Fixes priority inversion problem cause by platform thread blocking on drawable aquisition.
Open questions:
* Fixed ~What is a better interface for handling the partial submit with impeller. (TBD)~
* Fixed ~Update: We Don't | How do we fix this for Skia~ Fixed
* Fixed ~Update: Done, we post a task to the platform thread. Is there a shorter term solution for creating overlay layers on the raster thread.~ Fixed
* Fixed ~Update: seems to. Does this perform well enough (independent of platform/ui thread merge and w/ thread merge).~ Fixed
Fixes https://github.com/flutter/flutter/issues/142841
part of https://github.com/flutter/flutter/issues/150525
2024-08-01 20:40:12 +00:00
hangyu
5f18f2ebfd
Set deep linking flag to true by default ( flutter/engine#52350 )
...
doc: flutter.dev/go/deep-link-flag-migration
Action item: make sure customers are aware of this change before merging
this PR.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-01 12:58:12 -07:00
Bruno Leroux
555c2ff92a
[Android] Revert "Reset IME state on clear text input client" ( flutter/engine#54277 )
...
## Description
This PR reverts two commits https://github.com/flutter/engine/pull/49829 and https://github.com/flutter/engine/pull/53662 .
The main change was in https://github.com/flutter/engine/pull/49829 . https://github.com/flutter/engine/pull/53662 was a follow-up to mitigate the impact of https://github.com/flutter/engine/pull/49829 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/148530
Fixes https://github.com/flutter/flutter/issues/152620
Reopens https://github.com/flutter/flutter/issues/70546 .
Reopens https://github.com/flutter/flutter/issues/51478
2024-08-01 19:50:07 +00:00
skia-flutter-autoroll
3fae0ad188
Roll Skia from 03732b9f885e to ddb6901e6141 (5 revisions) ( flutter/engine#54287 )
...
https://skia.googlesource.com/skia.git/+log/03732b9f885e..ddb6901e6141
2024-08-01 egdaniel@google.com [Vulkan] Add context option to adjust default VMA block size.
2024-08-01 johnstiles@google.com Add support to SkSLTest for invoking child shaders.
2024-08-01 kjlubick@google.com Downgrade the warning for gni exporting on windows
2024-08-01 kjlubick@google.com Build only fiddle executable in skia-release
2024-08-01 johnstiles@google.com Remove assertion that modules are non-empty.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 19:44:05 +00:00
skia-flutter-autoroll
ab394e513d
Roll Dart SDK from 5acd806b6dad to acbbbe73b5eb (1 revision) ( flutter/engine#54286 )
...
https://dart.googlesource.com/sdk.git/+log/5acd806b6dad..acbbbe73b5eb
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-106.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 19:29:15 +00:00
K. P. Krasiński-Sroka
85c39faa9b
Properly calculate alwaysUse24HourFormat on MacOS ( flutter/engine#53795 )
...
Moves the implementation if isAlwaysUse24HourFormat from iOS's FlutterViewController internals to common utility, and makes use of it on MacOS in order to return correct value of `alwaysUse24HourFormat`.
This PR partially resolves [#32006 ](https://github.com/flutter/flutter/issues/32006 ).
Note that on iOS 16+ and MacOS 13+, there is a new API for obtaining this information: https://developer.apple.com/documentation/foundation/locale/components/3952289-hourcycle . However, to keep things simpler, I wanted to not include changes to the logic.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-01 18:51:06 +00:00
Jonah Williams
88b005388d
[Impeller] migrate more AIKS test to DL. ( flutter/engine#54267 )
...
Part of https://github.com/flutter/flutter/issues/142054
2024-08-01 18:35:18 +00:00
skia-flutter-autoroll
a9ee9d3a31
Roll Skia from f89a9c1902d7 to 03732b9f885e (5 revisions) ( flutter/engine#54283 )
...
https://skia.googlesource.com/skia.git/+log/f89a9c1902d7..03732b9f885e
2024-08-01 johnstiles@google.com Fix fuzzer-discovered issue with duplicate functions.
2024-08-01 johnstiles@google.com Add design doc link for go/sksl-function-specialization.
2024-08-01 jvanverth@google.com [graphite] Add CircularRRectClip shader snippet.
2024-08-01 egdaniel@google.com [Graphite] Remove immediate deletion flag when purging proxy cache.
2024-08-01 kjlubick@google.com Remove legacy Vulkan Graphite functions/methods
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 16:46:58 +00:00
skia-flutter-autoroll
bc643201de
Roll Dart SDK from 0486e486778a to 5acd806b6dad (1 revision) ( flutter/engine#54281 )
...
https://dart.googlesource.com/sdk.git/+log/0486e486778a..5acd806b6dad
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-105.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 15:03:05 +00:00
skia-flutter-autoroll
b9e6574e2e
Roll Skia from 8db309541ad9 to f89a9c1902d7 (11 revisions) ( flutter/engine#54279 )
...
https://skia.googlesource.com/skia.git/+log/8db309541ad9..f89a9c1902d7
2024-08-01 robertphillips@google.com Revert "[skif] Implement raster SkBlurEngine"
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d665a73f7d0d to 38c05c76968b (1 revision)
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 65f08d08515f to cc7d02209998 (15 revisions)
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 01b188e56477 to f72761e86766 (1 revision)
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 9b09b0a9dfa9 to 52942aa78b6c (8 revisions)
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8409c8834075 to 6b512aaeec71 (59 revisions)
2024-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9b09b0a9dfa9 to 52942aa78b6c
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a9708d3e114d to d665a73f7d0d (6 revisions)
2024-07-31 robertphillips@google.com [graphite] Address Vulkan Protected-mode Buffer Validation bug
2024-07-31 michaelludwig@google.com [skif] Implement raster SkBlurEngine
2024-07-31 robertphillips@google.com Fix graphite.gni file
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 13:40:41 +00:00
skia-flutter-autoroll
db27cc0525
Roll Dart SDK from 0b09d933cd1e to 0486e486778a (2 revisions) ( flutter/engine#54273 )
...
https://dart.googlesource.com/sdk.git/+log/0b09d933cd1e..0486e486778a
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-104.0.dev
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-103.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 05:58:52 +00:00
Brandon DeRosier
7105fd1909
[Impeller] Reland 2: Implement draw order optimization. ( flutter/engine#54268 )
...
This time for sure!
For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.
Respects clips, subpass collapse, and the clear color optimization.
Attempt 1: #54136
Revert 1: #54067
Attempt 2: #54215
Revert 2: #54261
2024-07-31 19:30:08 -07:00
skia-flutter-autoroll
49a46647f4
Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) ( flutter/engine#54270 )
...
https://dart.googlesource.com/sdk.git/+log/efabc9163078..0b09d933cd1e
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-102.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 01:50:37 +00:00
Jonah Williams
03a6784db4
[Impeller] move more aiks tests to DL. ( flutter/engine#54260 )
...
Part of https://github.com/flutter/flutter/issues/142054
2024-08-01 01:31:17 +00:00
Matan Lurey
3a829b81ad
Remove pre-existing diagnostics with no behavioral changes. ( flutter/engine#54264 )
...
Towards https://github.com/flutter/flutter/issues/152636 .
Most of these were via `dart --fix`.
2024-07-31 22:48:00 +00:00
Matan Lurey
bed7aa4dea
Cleanup dart analyze diagnostics in ignored directories. ( flutter/engine#54262 )
...
Towards https://github.com/flutter/flutter/issues/152636 .
I also deleted some code that was TODO'd 10 years ago.
2024-07-31 22:47:58 +00:00
Jason Simmons
d103053ca2
[web] Dispose a temporary image that may be created by instantiateImageCodecWithSize ( flutter/engine#54096 )
...
Fixes https://github.com/flutter/flutter/issues/147066
2024-07-31 22:40:51 +00:00
skia-flutter-autoroll
9a844d0d61
Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) ( flutter/engine#54266 )
...
https://skia.googlesource.com/skia.git/+log/b5ad5bf3696d..8db309541ad9
2024-07-31 michaelludwig@google.com [graphite] Add size to BindBufferInfo
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 5262a9f62fa6 to 0b6aba4d3d73
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 22:37:08 +00:00
skia-flutter-autoroll
d2ef670bff
Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) ( flutter/engine#54263 )
...
https://dart.googlesource.com/sdk.git/+log/5df6a6e0c037..efabc9163078
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-101.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 21:33:22 +00:00
skia-flutter-autoroll
4d50ee08ed
Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) ( flutter/engine#54259 )
...
https://skia.googlesource.com/skia.git/+log/431b57332241..b5ad5bf3696d
2024-07-31 scroggo@google.com Update SkQPTestCases for Android V (15) Release
2024-07-31 johnstiles@google.com Remove a forgotten TODO(johnstiles).
2024-07-31 jvanverth@google.com [ganesh] Fix CircularRRectEffect batching.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 20:37:41 +00:00
skia-flutter-autoroll
232c65fdde
Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... ( flutter/engine#54258 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 20:04:15 +00:00
auto-submit[bot]
fae441f0ef
Reverts "[Impeller] Reland: Implement draw order optimization. ( #54215 )" ( flutter/engine#54261 )
...
Reverts: flutter/engine#54215
Initiated by: bdero
Reason for reverting: Causing golden diffs in framework roll https://flutter-gold.skia.org/search?issue=152633&crs=github&patchsets=2&corpus=flutter
Original PR Author: bdero
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Original PR: #54136
Revert PR: #54067
Includes fixes for issue seen in [these goldens](https://flutter-gold.skia.org/search?issue=152354&crs=github&patchsets=2&corpus=flutter ).
The problem was that the scissor was ending up wrong after clip replay for opaque draws that are supposed to occur outside the parent clip scope(s).
To fix it, I made clip replay draws as well as the subpass texture draw apply lazily.
For the clip replay, there's no need to apply a given clip until we come across an entity that has a depth less than or equal to the clip.
And for the subpass texture (which is often translucent), we can defer drawing it until we come across another translucent draw. Deferring the subpass texture is important because if we draw it immediately, then all of the replay clips need to be drawn immediately too.
## Description
For each clip scope, draw opaque items in reverse order and translucent/backdrop-independent items in their original order afterwards. Clips are treated as translucent by the parent scope.
Respects clips, subpass collapse, and the clear color optimization.
### Local new_gallery before/after (iPhone 12 mini):
```
cd ~/projects/flutter/flutter/dev/integration_tests/new_gallery
flutter drive --profile --local-engine-src-path ~/projects/flutter/engine/src --local-engine=ios_profile --local-engine-host=host_profile_arm64 --trace-startup -t test_driver/transitions_perf.dart -d 00008101-000A59A93C10001E
```
2024-07-31 19:59:48 +00:00
skia-flutter-autoroll
a99fbaa228
Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) ( flutter/engine#54257 )
...
https://skia.googlesource.com/skia.git/+log/cd58e87c06f9..431b57332241
2024-07-31 nathanasanchez@google.com [Graphite] Gradient buffer optimization
2024-07-31 kjlubick@google.com Address clang-tidy suggestion
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 19:13:33 +00:00
Chris Bracken
c7af1aef53
[iOS][macOS] Eliminate use of bitcode_strip ( flutter/engine#54254 )
...
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.
Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.
This is a reland of https://github.com/flutter/engine/pull/54240 which was reverted in https://github.com/flutter/engine/pull/54250 .
The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy.
Issue: https://github.com/flutter/flutter/issues/107884
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-31 18:39:53 +00:00
skia-flutter-autoroll
87dd69c393
Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) ( flutter/engine#54253 )
...
https://skia.googlesource.com/skia.git/+log/e9e423457655..cd58e87c06f9
2024-07-31 johnstiles@google.com Clean up SK_DISABLE_MODULES_FOR_KNOWN_RUNTIME_EFFECTS flag guard.
2024-07-31 jvanverth@google.com Use a single source for CircularRRectEffect's analytic rrect clip.
2024-07-31 johnstiles@google.com Undo changes to loop index in linear morphology.
2024-07-31 robertphillips@google.com Add missing Vulkan extension
2024-07-31 kjlubick@google.com Fix use of deprecated Dawn Graphite constructors
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 17:36:30 +00:00
Matan Lurey
4d74b4b05a
Cleanup the shell test, removing unused code ( flutter/engine#54238 )
...
Guess we'll find out!
2024-07-31 17:31:24 +00:00
Yegor
38f3b2c83b
[web] rename dialog to route to match the framework ( flutter/engine#54228 )
...
Rename "dialog" to "route" to match the framework. The ARIA role "dialog" is an implementation detail, and it might change if a better implementation comes along. The semantic node itself implements the framework's "route" concept.
2024-07-31 17:18:11 +00:00
skia-flutter-autoroll
5d49c30db1
Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) ( flutter/engine#54252 )
...
https://dart.googlesource.com/sdk.git/+log/edace067d950..5df6a6e0c037
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-100.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 17:14:16 +00:00
Brandon DeRosier
8a22cb3905
[Impeller] Reland: Implement draw order optimization. ( flutter/engine#54215 )
...
Original PR: #54136
Revert PR: #54067
For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.
Respects clips, subpass collapse, and the clear color optimization.
2024-07-31 09:58:26 -07:00
Matan Lurey
66d00dddf8
Migrate the remaining real pub packages to pub workspaces. ( flutter/engine#54232 )
...
Closes https://github.com/flutter/flutter/issues/147883 .
2024-07-31 09:51:27 -07:00
skia-flutter-autoroll
1f88b46839
Roll Skia from 999e3f113dbf to e9e423457655 (1 revision) ( flutter/engine#54251 )
...
https://skia.googlesource.com/skia.git/+log/999e3f113dbf..e9e423457655
2024-07-31 michaelludwig@google.com [skif] Fix identity scale and no-effects detection
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 15:59:40 +00:00
auto-submit[bot]
8a06eaf695
Reverts "[iOS][macOS] Eliminate use of bitcode_strip ( #54240 )" ( flutter/engine#54250 )
...
Reverts: flutter/engine#54240
Initiated by: zanderso
Reason for reverting: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview
Original PR Author: cbracken
Reviewed By: {zanderso}
This change reverts the following previous change:
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.
Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.
Issue: https://github.com/flutter/flutter/issues/107884
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-31 14:12:47 +00:00
skia-flutter-autoroll
45a80efa76
Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) ( flutter/engine#54246 )
...
https://dart.googlesource.com/sdk.git/+log/f10a21fcc61c..edace067d950
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-99.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 10:01:24 +00:00
skia-flutter-autoroll
95b0d8ed73
Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) ( flutter/engine#54245 )
...
https://skia.googlesource.com/skia.git/+log/cb6ea5bd807d..fa9ecbb258b1
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0ef066874643 to 65f08d08515f (12 revisions)
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d7d76032f90 to 9b09b0a9dfa9 (10 revisions)
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0d7d76032f90 to 9b09b0a9dfa9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 08:54:23 +00:00
skia-flutter-autoroll
21a7d5d34b
Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) ( flutter/engine#54244 )
...
https://dart.googlesource.com/sdk.git/+log/68e559110999..f10a21fcc61c
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-98.0.dev
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 05:54:21 +00:00
skia-flutter-autoroll
9ddbce564d
Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) ( flutter/engine#54241 )
...
https://skia.googlesource.com/skia.git/+log/26eb1876de72..cb6ea5bd807d
2024-07-31 bungeman@google.com Remove __MSVC_RUNTIME_CHECKS support
2024-07-31 jvanverth@google.com Revert "[ganesh] Check for null ThreadSafeProxy in GrImageContext::abandoned()"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 02:34:36 +00:00
skia-flutter-autoroll
a15cdac22c
Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) ( flutter/engine#54239 )
...
https://skia.googlesource.com/skia.git/+log/b6036baeebbd..26eb1876de72
2024-07-30 johnstiles@google.com Improve error reporting when a prototype disagrees with its function.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 01:15:05 +00:00
Chris Bracken
a06a176d9f
[iOS][macOS] Eliminate use of bitcode_strip ( flutter/engine#54240 )
...
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.
Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.
Issue: https://github.com/flutter/flutter/issues/107884
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-31 01:09:18 +00:00
Jason Simmons
7e91d04146
Update flutter_shell_native_unittests for compatibility with Android API 35 emulators ( flutter/engine#54235 )
...
Previously this was using a zero EGLConfig handle in tests which use an AndroidContextGLImpeller that creates EGL surfaces. This apparently worked with older emulators, but the API 35 system image requires a real EGLConfig.
See https://github.com/flutter/flutter/pull/152498
2024-07-31 00:18:08 +00:00
Chris Bracken
b5c7bfdb41
[docs] Delete obsolete ML guided optimisation doc ( flutter/engine#54237 )
...
In 2021, we did some experiments with ML-guided optimisations in the
engine. Ultimately, these didn't provide much benefit, and much of the
information in the documentation is now out-of-date.
For those who need it, this can always be found in the git history.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-31 00:04:04 +00:00
