firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,534 Commits 1 Branch 0 Tags
Commit Graph

28674 Commits

Author SHA1 Message Date
skia-flutter-autoroll
e3e3f23e50 Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919) 
https://skia.googlesource.com/skia.git/+log/6347d8255f83..d4acfbe0b001

2024-07-15 johnstiles@google.com Mark unsupported sampler/image/texture types as reserved.
2024-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7dc21774dc62 to 6ab83f393122 (7 revisions)
2024-07-15 michaelludwig@google.com [graphite] Support writing substructs in UniformManager

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 23:28:13 +00:00
John McDole
d5069f0cbf Move images to flutter/assets-for-api-docs (flutter/engine#53917) 
27MB of images should not be in the source tree.

Caveat: If you use VSCode's markdown preview, it does not support images outside the workspace. One solution to this would be to submodule the assets back into the assets folder - however that would break github rendering of images.

Fixes flutter/flutter#151691
 2024-07-15 23:20:44 +00:00
skia-flutter-autoroll
be30d1291d Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916) 
https://skia.googlesource.com/skia.git/+log/b63d0290b826..6347d8255f83

2024-07-15 michaelludwig@google.com [graphite] Optimize Transform::mapRect for rect-stays-rect
2024-07-15 jvanverth@google.com Adjust motionmark bouncing tagged images slide.
2024-07-15 nathanasanchez@google.com Add separate flag for gradient buffer support
2024-07-15 robertphillips@google.com [graphite] Split PaintParamsKeyTest into its two subtests
2024-07-15 johnstiles@google.com Fix signedness of format string.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 22:02:51 +00:00
skia-flutter-autoroll
c057396fcc Roll Skia from 476abcbc2e4d to b63d0290b826 (5 revisions) (flutter/engine#53915) 
https://skia.googlesource.com/skia.git/+log/476abcbc2e4d..b63d0290b826

2024-07-15 johnstiles@google.com Add SkSL type alias for 'atomic_uint.'
2024-07-15 kjlubick@google.com Remove graphite-specific Mtl type aliases
2024-07-15 kjlubick@google.com [graphite] Remove SK_METAL defines from BackendSemaphore
2024-07-15 kjlubick@google.com [graphite] Remove SK_METAL defines from BackendTexture
2024-07-15 kjlubick@google.com [graphite] Remove SK_METAL defines from TextureInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 20:24:31 +00:00
skia-flutter-autoroll
725511e88f Roll Skia from 559a46957250 to 476abcbc2e4d (4 revisions) (flutter/engine#53911) 
https://skia.googlesource.com/skia.git/+log/559a46957250..476abcbc2e4d

2024-07-15 jvanverth@google.com Revert "[graphite] Remove unnecessary premul step in YUV shaders."
2024-07-15 johnstiles@google.com Reject SkSL programs with identifiers `dmatN` or `dmatNxM`.
2024-07-15 johnstiles@google.com Fix overzealous brace elimination in sksl-minify.
2024-07-15 nathanasanchez@google.com Run a graphite native vulkan test tryjob

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 18:55:22 +00:00
skia-flutter-autoroll
9f40e31a95 Roll Skia from fe05596a26ea to 559a46957250 (7 revisions) (flutter/engine#53909) 
https://skia.googlesource.com/skia.git/+log/fe05596a26ea..559a46957250

2024-07-15 robertphillips@google.com [graphite] Make PaintParamsKeyTest a bit more modular
2024-07-15 jvanverth@google.com [graphite] Remove unnecessary premul step in YUV shaders.
2024-07-15 robertphillips@google.com [graphite] Add a local-debugging-only PaintParamsKeyTestReduced
2024-07-15 robertphillips@google.com [graphite] Add explicit seed and verbose mode to PaintParamsKeyTest
2024-07-15 johnstiles@google.com Add ProgramConfig::IsMesh helper.
2024-07-15 johnstiles@google.com Remove clamp-to-1 behavior from blend_porter_duff.
2024-07-15 robertphillips@google.com [graphite] Encapsulate creation of the KeyContext in the PaintParamsKeyTest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 17:28:00 +00:00
Yegor
d7c9dafda7 [web] switch to SemanticsAction.focus (attempt 3) (flutter/engine#53689) 
This relands https://github.com/flutter/engine/pull/53679.

The difference from the previous attempt is in the last commit, which prevents synthetic focus requests from echoing back into the framework. That part broke too many tests in g3 and needs to be revisited.

## Original description

Stop using `SemanticsAction.didGain/LoseAccessibilityFocus` on the web, start using `SemanticsAction.focus`. This is because on the web, a11y focus is not observable, only input focus is. Sending `SemanticsAction.focus` will guarantee that the framework move focus to the respective widget. There currently is no "unfocus" signal, because it seems to be already covered: either another widget gains focus, or an HTML DOM element outside the Flutter view does, both of which have their respective signals already.

More details in the discussion in the issue https://github.com/flutter/flutter/issues/83809.

Fixes https://github.com/flutter/flutter/issues/83809
Fixes https://github.com/flutter/flutter/issues/148285
Fixes https://github.com/flutter/flutter/issues/143337
 2024-07-15 17:12:21 +00:00
skia-flutter-autoroll
f8ce536f93 Roll Skia from 2a45bd56601e to a3c29413cdf0 (2 revisions) (flutter/engine#53905) 
https://skia.googlesource.com/skia.git/+log/2a45bd56601e..a3c29413cdf0

2024-07-15 jvanverth@google.com [graphite] Remove colorspace transform from image shaders.
2024-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e17036dfa4eb to 7dc21774dc62 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 14:41:12 +00:00
skia-flutter-autoroll
cefb1ae181 Roll Skia from aacec1ee6359 to 2a45bd56601e (1 revision) (flutter/engine#53896) 
https://skia.googlesource.com/skia.git/+log/aacec1ee6359..2a45bd56601e

2024-07-15 michaelludwig@google.com [graphite] Respect uniform struct name when generating top-level interface block

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 07:58:24 +00:00
skia-flutter-autoroll
f0669e0c5d Roll Skia from 6a046a1394a9 to aacec1ee6359 (3 revisions) (flutter/engine#53894) 
https://skia.googlesource.com/skia.git/+log/6a046a1394a9..aacec1ee6359

2024-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 925d3cac96a5 to 1b556c012937
2024-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 556130803353 to 925d3cac96a5 (7 revisions)
2024-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 440fedc86729 to 312caa9146cf (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 06:39:22 +00:00
skia-flutter-autoroll
d0d26cfde0 Roll Skia from 3335b96bf189 to 6a046a1394a9 (2 revisions) (flutter/engine#53889) 
https://skia.googlesource.com/skia.git/+log/3335b96bf189..6a046a1394a9

2024-07-15 robertphillips@google.com [graphite] Make PrecompileRuntimeEffect part of the public API
2024-07-15 robertphillips@google.com [graphite] Simplify PaintParamsKeyTest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 02:40:08 +00:00
skia-flutter-autoroll
22624409ea Roll Skia from 22e1169ba4fe to 3335b96bf189 (1 revision) (flutter/engine#53888) 
https://skia.googlesource.com/skia.git/+log/22e1169ba4fe..3335b96bf189

2024-07-15 robertphillips@google.com [graphite] Address some lingering PrecompileRTEffect TODOs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-15 01:30:28 +00:00
Chinmay Garde
3ad1afaa59 [Impeller] Cleanup stale TODOs and fixup the format of others. (flutter/engine#53825) 
There are still tons of TODOs without issues assigned to them that I'm having a harder time tracking them down. But this cleanup is easy.
 2024-07-13 18:10:28 +00:00
skia-flutter-autoroll
9c1ad0d1cb Roll Skia from 49046798c05d to 0257e2adc7a4 (3 revisions) (flutter/engine#53852) 
https://skia.googlesource.com/skia.git/+log/49046798c05d..0257e2adc7a4

2024-07-13 michaelludwig@google.com [graphite] Allow undefined for view format in getRenderPassDescKey
2024-07-13 michaelludwig@google.com Swap radius scale factors in 270/90 rotation for SkRRect::transform
2024-07-13 michaelludwig@google.com [graphite] Add linear and flat interpolation support to Varying

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-13 05:00:17 +00:00
Kevin Moore
8c1a2c2c51 Drop self-references to hash functions from doc comments (flutter/engine#53844) 
Towards https://github.com/flutter/flutter/issues/151679
 2024-07-13 04:33:48 +00:00
skia-flutter-autoroll
713b7b2096 Roll Skia from 923034db7728 to 49046798c05d (4 revisions) (flutter/engine#53851) 
https://skia.googlesource.com/skia.git/+log/923034db7728..49046798c05d

2024-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9563c7bbc6c9 to 8aa1771a6770 (9 revisions)
2024-07-12 brianosman@google.com Allow integer translation (relative to creation) when drawing slugs
2024-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 30c12bf92339 to 9563c7bbc6c9 (7 revisions)
2024-07-12 brianosman@google.com GM that shows how to use blend modes to simulate PathOps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-13 03:42:23 +00:00
Jonah Williams
50c6b6f326 [Impeller] move Aiks path unittests to DL (flutter/engine#53799) 
Move more impeller tests to display list format. This allows our integration tests to also test the display list -> aiks interop and be future compatible with the new canvas backend that removes AIKS.

Part of https://github.com/flutter/flutter/issues/142054
 2024-07-12 23:50:05 +00:00
Jackson Gardner
e2b3f88cac [skwasm] Fix platform view placement. (flutter/engine#53845) 
Previously, each platform view contained styling/placement information from the entire stack of the layer builder. This caused issues when using `addRetained`, since it would contain stale styling/placement information from its old parent layers. I have changed it so that platform views only contain local styling information, and that styling is combined with the parent only when the layers are merged.
 2024-07-12 21:55:19 +00:00
skia-flutter-autoroll
6772b24021 Roll Dart SDK from e986ed9d0bc1 to b44d99ea2bf4 (1 revision) (flutter/engine#53846) 
https://dart.googlesource.com/sdk.git/+log/e986ed9d0bc1..b44d99ea2bf4

2024-07-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-36.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 20:49:20 +00:00
Lasse R.H. Nielsen
13b3c93787 Prepare engine for deprecation of async_minitest.dart (flutter/engine#53560) 
The Dart SDK's `package:async_helper/async_minitest.dart` was never intended for new tests, it was a drop-in polyfill for the legacy `package:unit_test` that some Dart SDK tests were using. The tests should never have used that package, and migrating them to `package:test` was not an option, so the `async_minitest.dart` file was the minimal polyfill that made all the tests run.

Since then, new tests have been written using the file, and to stop that, the file will now become deprecated, and (hopefully some day) removed.

If the Flutter engine wants to keep using the file, they should own their own copy of it, which is what this change does.

(Also migrates off the to-be-deprecated `assertStatementsEnabled` property of `package:expect/expect.dart`, moved to the new `asserts` from `package:expect/variations.dart`.)
 2024-07-12 19:12:05 +00:00
Chinmay Garde
8837250654 [Impeller] Refactor and document Android rendering related TUs. (flutter/engine#53802) 
No change in functionality. The updates:

* HeaderDoc comments have been added to the major rendering related TUs. However, not all comments are complete. I only documented the stuff I understood. For instance, it isn't clear how/why some subclasses use Attach/Detach while other use ProcessFrame. I intend to document as I go.
* Each package specific subclass is now in its own TU.
* Some subclasses used to be Skia specific. We added an Impeller variant but didn't rename to Skia TU. This has been patched.
 2024-07-12 19:08:15 +00:00
Juanjo Tugores
93de0249f9 Relax the event assumptions for keydown events. (flutter/engine#53830) 
This PR addresses an issue where autocompleting a text field, even without direct keyboard input, unexpectedly triggers keydown events. To resolve this, the code now relaxes the casting assumptions to accommodate a wider range of event types, not just keyboard events.

By just adding the following script to the console, and filling the text field using autocomplete, you can see that indeed the fired event is not of type `KeyboardEvent` but `Event`. 

```javascript
document.body.addEventListener('keydown', console.log)
```

Fixes https://github.com/flutter/flutter/issues/149968

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-12 17:54:55 +00:00
Matan Lurey
15becdc41e Move //third_party/java to //flutter/third_party/java (flutter/engine#53590) 
... as part of buildmoot.
 2024-07-12 09:25:28 -07:00
skia-flutter-autoroll
883d4ec201 Roll Skia from 9ea5603242c1 to 923034db7728 (1 revision) (flutter/engine#53841) 
https://skia.googlesource.com/skia.git/+log/9ea5603242c1..923034db7728

2024-07-12 jvanverth@google.com [graphite] Include YUV local transform in base image local transform.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 16:15:04 +00:00
skia-flutter-autoroll
7ab4e1bf9e Roll Dart SDK from 797d3df745d1 to e986ed9d0bc1 (1 revision) (flutter/engine#53840) 
https://dart.googlesource.com/sdk.git/+log/797d3df745d1..e986ed9d0bc1

2024-07-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 13:53:28 +00:00
skia-flutter-autoroll
ae073cebf8 Roll Skia from 9529b8ad9e45 to 7a91f0a4b7a0 (2 revisions) (flutter/engine#53838) 
https://skia.googlesource.com/skia.git/+log/9529b8ad9e45..7a91f0a4b7a0

2024-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from dbe6ed71568e to 6341b74cad37
2024-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 67fb1a1b693f to 556130803353 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 10:56:38 +00:00
skia-flutter-autoroll
91defeb7ca Roll Skia from 14c8d318615d to 38f355af4f36 (1 revision) (flutter/engine#53836) 
https://skia.googlesource.com/skia.git/+log/14c8d318615d..38f355af4f36

2024-07-12 michaelludwig@google.com Reland "[graphite] Add non-aa bounds filling renderer"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 06:55:47 +00:00
skia-flutter-autoroll
96e9b97956 Roll Fuchsia Linux SDK from 0e47sje8wkJ08sGJ6... to VlZIUknh6dnA23owe... (flutter/engine#53834) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 04:35:25 +00:00
Jason Simmons
604637e41f Manual roll Dart SDK from fb546f313557 to 797d3df745d1 (8 revisions) (flutter/engine#53832) 
Includes patches needed for the dart:concurrent package (see https://dart.googlesource.com/sdk/+/d2bc055651cf62c549933ed379d6b23d84a07598)

Manual roll requested by jsimmons@google.com

https://dart.googlesource.com/sdk.git/+log/fb546f313557..797d3df745d1

2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-34.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-33.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-32.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-31.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-30.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-29.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-28.0.dev 2024-07-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-27.0.dev

If this roll has caused a breakage, revert this CL and stop the roller using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-12 01:28:10 +00:00
Jonah Williams
a53478d613 [Impeller] Ensure full transform is applied to text contents (flutter/engine#53819) 
Fixes https://github.com/flutter/flutter/issues/151521

My change made the text size absorb the scale, so I wasn't applying the full transform. That is incorrect if there are negative scales.
 2024-07-11 23:28:56 +00:00
Matan Lurey
bfb6a8a100 Update Life-of-a-Flutter-Frame.md (flutter/engine#53829) 
Part of https://github.com/flutter/flutter/issues/150869.
 2024-07-11 16:11:46 -07:00
Matan Lurey
5a76d742ca Update Setting-up-the-Engine-development-environment.md (flutter/engine#53828) 
Part of https://github.com/flutter/flutter/issues/150869.
 2024-07-11 23:06:59 +00:00
Pavel Mazhnik
d809a1db38 [web] retrieve hostElement for an implicit view (flutter/engine#53296) 
This PR updates `ui_web.views.getHostElement` API to also return `hostElement` for implicit view.

Resolves https://github.com/flutter/flutter/issues/150075
 2024-07-11 22:15:20 +00:00
Jonah Williams
ac871bacc2 [dart:ui] remove expensive index assertion in Vertices. (flutter/engine#53558) 
Iterating through every index value is really, really expensive. Especially if users are suppllying hundreds of thousands of vertices.
 2024-07-11 22:13:04 +00:00
Chinmay Garde
412e42ae83 [Impeller] Enable fixed-rate compression support in Vulkan. (flutter/engine#53292) 
Fixes https://github.com/flutter/flutter/issues/129501
 2024-07-11 21:41:28 +00:00
skia-flutter-autoroll
0fa80539c5 Roll Skia from 037d5f8a727f to ddf045505cb9 (1 revision) (flutter/engine#53824) 
https://skia.googlesource.com/skia.git/+log/037d5f8a727f..ddf045505cb9

2024-07-11 nathanasanchez@google.com Reland "[Graphite] Enable storage buffers in Vulkan"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 21:07:54 +00:00
Chinmay Garde
b1f84eea71 Add instructions for source debugging with Xcode when using RBE. (flutter/engine#53822) 2024-07-11 20:33:06 +00:00
skia-flutter-autoroll
1e531db275 Roll Skia from 004c81523e44 to 037d5f8a727f (1 revision) (flutter/engine#53818) 
https://skia.googlesource.com/skia.git/+log/004c81523e44..037d5f8a727f

2024-07-11 jvanverth@google.com [ganesh] Move YUVA image factories with the other image factories.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 19:45:09 +00:00
Jonah Williams
c04f249ca0 [Impeller] move more aiks tests to DL. (flutter/engine#53792) 
Move more impeller tests to display list format. This allows our integration tests to also test the display list -> aiks interop and be future compatible with the new canvas backend that removes AIKS.

Part of https://github.com/flutter/flutter/issues/142054
 2024-07-11 18:35:52 +00:00
skia-flutter-autoroll
902e78dd2a Roll Skia from ec4a1e03f7b0 to 004c81523e44 (23 revisions) (flutter/engine#53813) 
https://skia.googlesource.com/skia.git/+log/ec4a1e03f7b0..004c81523e44

2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c9cca49b866 to 2d5b62fa0b39
2024-07-11 robertphillips@google.com [graphite] Make RuntimeEffect precompilation match the rest of the system
2024-07-11 kjlubick@google.com Add presubmit check to detect accidental leakage of src/ into include/
2024-07-11 robertphillips@google.com [graphite] Replace PrecompileChildPtr with a sk_sp<PrecompileBase>
2024-07-11 fmalita@google.com Revert "[graphite] Add non-aa bounds filling renderer"
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from eff9c7d7bfff to bc656cdad31e (3 revisions)
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3c9cca49b866 to 67fb1a1b693f (8 revisions)
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f986604e2165 to c7002cf03eb0 (14 revisions)
2024-07-11 sunnyps@chromium.org graphite: Use format index for pipeline render pass key
2024-07-10 fmalita@google.com Remove assert in SubRun deserialization
2024-07-10 jamesgk@google.com Update viewer/android build
2024-07-10 michaelludwig@google.com [graphite] Add non-aa bounds filling renderer
2024-07-10 lokokung@google.com [dawn] Use new device callback types in Graphite
2024-07-10 michaelludwig@google.com [graphite] CoverBoundsRenderStep can be configured with custom DepthStencilSettings
2024-07-10 jvanverth@google.com [graphite] Add colorspace xform to primitive color
2024-07-10 nathanasanchez@google.com Revert "[Graphite] Enable storage buffers in Vulkan"
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 14d1f6cd4cd2 to f986604e2165 (11 revisions)
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ad77082be54 to eff9c7d7bfff (2 revisions)
2024-07-10 nathanasanchez@google.com [Graphite] Add perspective local matrix shader
2024-07-10 nathanasanchez@google.com [Graphite] Add perspective flag to precompile LMS
2024-07-10 johnstiles@google.com Reject interface blocks containing a boolean.
2024-07-10 nathanasanchez@google.com [Graphite] Enable storage buffers in Vulkan
2024-07-10 michaelludwig@google.com [graphite] Add substruct support to UniformOffsetCalculator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 14:56:37 +00:00
skia-flutter-autoroll
8d354698bb Roll Skia from 2783ba54bf8e to ec4a1e03f7b0 (9 revisions) (flutter/engine#53797) 
https://skia.googlesource.com/skia.git/+log/2783ba54bf8e..ec4a1e03f7b0

2024-07-10 robertphillips@google.com [graphite] Update the runtimeEffect subtest in CombinationBuilderTest
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fa0d147877f0 to 06f0adf6d6df
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8800433c75e6 to 14d1f6cd4cd2 (22 revisions)
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 14b58abf4d15 to 9ad77082be54 (15 revisions)
2024-07-10 kjlubick@google.com Move ContextOptionsPriv from include/private to src/
2024-07-10 brianosman@google.com In the stroker: store tangent vectors, not tangent points
2024-07-10 chengyangyang-hf@loongson.cn [loong64] Fix linker error by undefined symbols.
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3ab5644b59e3 to 3c9cca49b866 (8 revisions)
2024-07-10 e2lahav@gmail.com Change instances of true/false to TRUE/FALSE for libjpeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 13:46:06 +00:00
skia-flutter-autoroll
973ba5a587 Roll Fuchsia Linux SDK from SrAow18WmBW8IDjza... to 0e47sje8wkJ08sGJ6... (flutter/engine#53804) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 01:50:33 +00:00
skia-flutter-autoroll
50cac1a36e Roll Dart SDK from c6053ad84f2b to fb546f313557 (1 revision) (flutter/engine#53801) 
https://dart.googlesource.com/sdk.git/+log/c6053ad84f2b..fb546f313557

2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-26.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 23:38:30 +00:00
Srujan Gaddam
b33b900e77 Remove casts for toDartObject (flutter/engine#53621) 
ExternalDartReference is now generic, so we can just type it and
toDartObject will do the cast for us if needed. Also removes now-stale
ignores.
 2024-07-10 15:47:39 -07:00
Tong Mu
bfc7116202 [macOS] Multiview compositor (flutter/engine#52253) 
This PR makes the macOS `FlutterCompositor` able to handle multiple views by adding methods `AddView` and `RemoveView`.

These two methods must take place on the main queue (platform thread), which is indeed the case, but extra effort is made to assert so. This is important because, due to the constraint of the macOS system that requires rendering to take place on the platform thread (hence `FlutterThreadSynchronizer`), no locks are needed to avoid race condition between `Add/RemoveView` and presenting.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-10 21:10:06 +00:00
skia-flutter-autoroll
f7e349e54e Roll Dart SDK from dba0dfbd06eb to c6053ad84f2b (3 revisions) (flutter/engine#53798) 
https://dart.googlesource.com/sdk.git/+log/dba0dfbd06eb..c6053ad84f2b

2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-25.0.dev
2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-24.0.dev
2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 19:27:48 +00:00
Jackson Gardner
76caabd2c4 Reland (x2) "Output .js files as ES6 modules. (flutter#52023)" (flutter/engine#53718) 
Second attempt to reland https://github.com/flutter/engine/pull/52023

Fixes since the previous reland attempt:
* We need to pass the skwasm main JS URI when loading the module so that it can pass that along to the worker. Since the worker uses the workaround to allow a cross script worker, it has trouble locating the main JS URI in relation to itself in a way that actually works for dynamic imports, so passing it along fixes that issue.
* Some of the Google3 tests relied on the relative default canvaskit path. Dynamic module imports seems to not handle relative paths the way we expect, so we do our own URL resolution using the URL constructor before passing it into the dynamic import API. Also cleaned up some of the other relative pathing stuff that we do around the base URI. in flutter.js
 2024-07-10 16:19:28 +00:00
skia-flutter-autoroll
8f0cb56a60 Roll Skia from 46e5bf98158a to 2783ba54bf8e (2 revisions) (flutter/engine#53796) 
https://skia.googlesource.com/skia.git/+log/46e5bf98158a..2783ba54bf8e

2024-07-10 petermcneeley@chromium.org Shader trace for cache load and pipeline creation
2024-07-10 michaelludwig@google.com [graphite] Preliminary update to ShaderSnippet to support aggregate uniforms in structs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 15:27:55 +00:00
Chinmay Garde
8c45ce5af9 [Impeller] Fix markdown formatting for blocks with tips. (flutter/engine#53789) 
In the previous patch, I had used the incorrect markdown syntax.

Followup for https://github.com/flutter/engine/pull/53671
 2024-07-10 05:40:20 +00:00
auto-submit[bot]
5a218a1b99 Reverts "dart:ui - drop deprecated hash functions (#53787)" (flutter/engine#53794) 
Reverts: flutter/engine#53787
Initiated by: jiahaog
Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](72f83d3237/packages/flutter/lib/src/painting/basic_types.dart (L58)) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a
Original PR Author: kevmoo

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
These were deprecated a LONG time ago
 2024-07-10 03:16:50 +00:00