28674 Commits

Author SHA1 Message Date
skia-flutter-autoroll
61dd39b2f8 Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630)
https://dart.googlesource.com/sdk.git/+log/4005e5f1fb8e..341dbaf977a3

2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-313.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 10:55:38 +00:00
skia-flutter-autoroll
1b952e7807 Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627)
https://skia.googlesource.com/skia.git/+log/2204428a75ca..6650fcc6d054

2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 46dd6457f4bf to e86ba9abe996 (5 revisions)
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 79660091faba to 40eb79dec2d6 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 08:23:39 +00:00
skia-flutter-autoroll
4a2783955d Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626)
https://dart.googlesource.com/sdk.git/+log/0820b0766ac9..4005e5f1fb8e

2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-312.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 06:02:10 +00:00
skia-flutter-autoroll
9a4788d6b1 Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 05:06:54 +00:00
Jim Graham
c47337f291 [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622)
Impeller supports `ClipOval` and will detect oval paths and rrects and use that call instead when appropriate. Adding support for `ClipOval` to DisplayList allows that optimization code to be moved up into the recording process.
2024-06-28 03:34:23 +00:00
skia-flutter-autoroll
0e1263a589 Roll Dart SDK from e7022f6eb6c9 to 0820b0766ac9 (1 revision) (flutter/engine#53623)
https://dart.googlesource.com/sdk.git/+log/e7022f6eb6c9..0820b0766ac9

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-311.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 01:44:11 +00:00
skia-flutter-autoroll
0265dd6c14 Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619)
https://skia.googlesource.com/skia.git/+log/cbd6e55139ca..1700e3962acd

2024-06-27 nicolettep@google.com [graphite] Disable MultisampleRetainTest which fails on a task
2024-06-27 brianosman@google.com Always emit stack_rewind stages in SkSL's RP Builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 22:17:22 +00:00
skia-flutter-autoroll
0a8f2f0a75 Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616)
https://dart.googlesource.com/sdk.git/+log/b5f079c2936e..e7022f6eb6c9

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-310.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 21:30:12 +00:00
skia-flutter-autoroll
37184cf7c8 Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615)
https://skia.googlesource.com/skia.git/+log/c73e514838b4..cbd6e55139ca

2024-06-27 jamesgk@google.com [graphite] Don't exceed 128 workgroup invocations in test
2024-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7ff358e64e2b to 117f1e2fcf1c (7 revisions)
2024-06-27 kjlubick@google.com Extract VulkanMemoryAllocator into its own module
2024-06-27 nicolettep@google.com [graphite] Restore running of certain unit tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 20:58:09 +00:00
John O'Neil
e76e0548bc Fix #150515 Provide required headers for build with Clang-16 and GCC … (flutter/engine#53479)
Fixes Impeller engine build with `clang-16` and GCC 14 C++Stdlib does not implicitly include `<algorithm>`.

Fixes issue: #150515 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-27 20:07:19 +00:00
Gray Mackall
8e2c560e10 Re-re-re-land "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53592)
Re-re-re-land https://github.com/flutter/engine/pull/53001.

I recreated the postsubmit failures of the [roll](https://github.com/flutter/flutter/pull/150733) of the [last land](https://github.com/flutter/engine/pull/53532), and then verified on a local branch that those same postsubmits pass with this upgrade after the land of https://github.com/flutter/flutter/pull/150873. 

So I have pretty high confidence this won't cause any problems in the framework repo. I also tested on a previous land attempt that the `all_packages` app builds on this branch, so that is also a good sign for the packages repo.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-27 19:56:47 +00:00
skia-flutter-autoroll
1ab57d3af1 Roll Skia from dee7339d0b53 to c73e514838b4 (7 revisions) (flutter/engine#53613)
https://skia.googlesource.com/skia.git/+log/dee7339d0b53..c73e514838b4

2024-06-27 jvanverth@google.com Disable all wacky_yuv_formats GMs on the Wembleys
2024-06-27 brianosman@google.com Test Graphite in scale-pixels GMs
2024-06-27 jvanverth@google.com [graphite] Add no-swizzle YUV shader.
2024-06-27 bungeman@google.com Use -no-pie insead of -nopie
2024-06-27 bungeman@google.com GN to use compilation_mode dbg for Bazel
2024-06-27 sjong.hwang@samsung.com SkSLTest: Disable SwizzleIndexStore test on Samsung GPU
2024-06-27 nicolettep@google.com [graphite] Hook up YCbCr functionality and enable GM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 19:42:32 +00:00
Håkon Bertheussen
8311e5eca9 Fix AccessibilityFeatures.disableAnimations flag on Android 12+ (flutter/engine#53428)
This PR fixes the problem where Flutter would not respect the "remove animation" accessibility setting on Android 12+.

Please see this issue for details: https://github.com/flutter/flutter/issues/130976

As [mentioned](https://github.com/flutter/flutter/issues/130976#issuecomment-1931388665) by [horsemankukka](https://github.com/horsemankukka), the problem has to do with reading `Settings.Global.TRANSITION_ANIMATION_SCALE` as a string instead of a float. Flutter would compare it to the string "0" to determine if animations should be disabled. Presumably, this worked because the settings app did indeed use the string "0" or "1" for this setting. But as of Android 12 it's instead written using float representation ("0.0" or "1.0"), at least on Samsung devices. [The documentation](https://developer.android.com/reference/android/provider/Settings.Global#TRANSITION_ANIMATION_SCALE) also states that this setting should be read as a float, which is what this PR does.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-27 18:44:04 +00:00
skia-flutter-autoroll
e95c0d9c7a Roll Skia from 09a46ebe4c01 to dee7339d0b53 (5 revisions) (flutter/engine#53612)
https://skia.googlesource.com/skia.git/+log/09a46ebe4c01..dee7339d0b53

2024-06-27 michaelludwig@google.com [graphite] Remove stray vertex attribute declaration
2024-06-27 jvanverth@google.com Disable more wacky_yuv GMs on Wembley.
2024-06-27 nathanasanchez@google.com [Graphite] Make gradient buffer support more defined
2024-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from cd996ffba12a to 0a3b1b98cce7 (6 revisions)
2024-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 79660091faba to c3324a905ed2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 18:21:12 +00:00
skia-flutter-autoroll
ac46a1b22e Roll Dart SDK from 65fa56a24416 to b5f079c2936e (1 revision) (flutter/engine#53611)
https://dart.googlesource.com/sdk.git/+log/65fa56a24416..b5f079c2936e

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-309.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 16:58:18 +00:00
skia-flutter-autoroll
ba5eb90ffe Roll Skia from a407ec8a29b9 to 09a46ebe4c01 (1 revision) (flutter/engine#53610)
https://skia.googlesource.com/skia.git/+log/a407ec8a29b9..09a46ebe4c01

2024-06-27 robertphillips@google.com [graphite] Move PrecompileImageFilter to public API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 16:16:53 +00:00
skia-flutter-autoroll
55ed66b03e Roll Dart SDK from 7d7fbb30e0ca to 65fa56a24416 (1 revision) (flutter/engine#53609)
https://dart.googlesource.com/sdk.git/+log/7d7fbb30e0ca..65fa56a24416

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-308.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 12:48:24 +00:00
skia-flutter-autoroll
a6e6d5a800 Roll Dart SDK from d825219c0ce1 to 7d7fbb30e0ca (1 revision) (flutter/engine#53608)
https://dart.googlesource.com/sdk.git/+log/d825219c0ce1..7d7fbb30e0ca

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-307.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 08:38:14 +00:00
skia-flutter-autoroll
21b52bb6a4 Roll Skia from e2f68b30ea63 to fb1458ac7bfd (1 revision) (flutter/engine#53606)
https://skia.googlesource.com/skia.git/+log/e2f68b30ea63..fb1458ac7bfd

2024-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 72fd79ddaace to 79660091faba (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 07:11:25 +00:00
skia-flutter-autoroll
f4ce933153 Roll Dart SDK from 8dd486ebfab4 to d825219c0ce1 (1 revision) (flutter/engine#53602)
https://dart.googlesource.com/sdk.git/+log/8dd486ebfab4..d825219c0ce1

2024-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-306.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 04:29:07 +00:00
skia-flutter-autoroll
b067f6b934 Roll Fuchsia Linux SDK from n2dgSmMCaCO7ujvmr... to gBWzGuicxu76K82lg... (flutter/engine#53601)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 03:50:24 +00:00
skia-flutter-autoroll
5bb46705f3 Roll Dart SDK from c01f907d34d8 to 8dd486ebfab4 (1 revision) (flutter/engine#53599)
https://dart.googlesource.com/sdk.git/+log/c01f907d34d8..8dd486ebfab4

2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-305.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 00:15:09 +00:00
skia-flutter-autoroll
f69b0a4012 Roll Skia from 55ada83438cd to 001694095f1b (3 revisions) (flutter/engine#53598)
https://skia.googlesource.com/skia.git/+log/55ada83438cd..001694095f1b

2024-06-26 bungeman@google.com [cmake] Enable OBJC and OBJCXX
2024-06-26 jamesgk@google.com [graphite] Support running on Dawn compat
2024-06-26 egdaniel@google.com Fix clock granularity on GraphitePurgeNotUsedSinceResourcesTest.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 23:44:03 +00:00
skia-flutter-autoroll
f0e8927fff Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596)
https://skia.googlesource.com/skia.git/+log/173ee0af82c9..55ada83438cd

2024-06-26 nscobie@google.com Add (CoGS) team ownership to Android.bp's CtsSkQPTestCases
2024-06-26 bungeman@google.com Roll gn
2024-06-26 lehoangquyen@google.com GraphiteDawn: increase number of cached UBO bindgroups

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 22:12:19 +00:00
Jason Simmons
0954220cbf Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594)
Previously CreateEGLImage had been failing an assertion if an EGL display is not active on the calling thread.  CreateEGLImage should not assert here because it could be called from a deferred task that runs after the raster thread has lost its EGL state.

See https://github.com/flutter/flutter/issues/149396
2024-06-26 22:10:18 +00:00
gaaclarke
4629bf49ff [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562)
This should be no functional change, just makes the case of clipped backdrop filters take up less memory.

fixes: https://github.com/flutter/flutter/issues/150713

test coverage:
- the framework's "backdrop filter" test
- GaussianBlurAnimatedBackdrop

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-26 21:23:10 +00:00
skia-flutter-autoroll
a4e8769d78 Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593)
https://skia.googlesource.com/skia.git/+log/0a979d9f3606..173ee0af82c9

2024-06-26 nathanasanchez@google.com [Graphite] Consolidate ssbo caps
2024-06-26 brianosman@google.com Fix asymmetry in lattice validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 20:42:09 +00:00
Matan Lurey
75a2393b53 Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588)
There are no usages other than the reference in the LICENSE checker.
2024-06-26 20:40:04 +00:00
Matan Lurey
af854d0c7b Copy flutter/flutter/docs/engine to flutter/engine/docs as-is (no changes) (flutter/engine#53595)
See https://github.com/flutter/flutter/issues/150869.
2024-06-26 13:35:07 -07:00
skia-flutter-autoroll
e0700b7c71 Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585)
https://dart.googlesource.com/sdk.git/+log/38bb74f63829..c01f907d34d8

2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-304.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-303.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-302.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-301.0.dev
2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-300.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 20:02:19 +00:00
Matan Lurey
df2c6daa5a Replace Log.w with Log.d, and tidy the file up a bit. (flutter/engine#53586)
Closes https://github.com/flutter/flutter/issues/150849.

(Almost all of these are mechanical auto-fix changes from Android Studio/Best Practices).
2024-06-26 19:31:02 +00:00
skia-flutter-autoroll
4d2d538709 Roll Skia from 695d35a0559e to 0a979d9f3606 (3 revisions) (flutter/engine#53591)
https://skia.googlesource.com/skia.git/+log/695d35a0559e..0a979d9f3606

2024-06-26 lehoangquyen@google.com GraphiteDawn: Use larger static storage for bindgroup keys.
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1c484942880c to 782b625ca1dc (3 revisions)
2024-06-26 bungeman@google.com Roll ninja

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 19:20:20 +00:00
Matan Lurey
0c9f812104 Move impeller-cmake-example to flutter/third_party. (flutter/engine#53589)
... as part of buildmoot.

I _think_ this is all that is needed but am not confident.
2024-06-26 18:59:18 +00:00
skia-flutter-autoroll
937568d312 Roll Skia from e836fa986829 to 695d35a0559e (1 revision) (flutter/engine#53584)
https://skia.googlesource.com/skia.git/+log/e836fa986829..695d35a0559e

2024-06-26 michaelludwig@google.com [graphite] Use sk_FragCoord for dithering

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 18:08:08 +00:00
skia-flutter-autoroll
ad34e76d60 Roll Skia from 354b30fe7ab5 to e836fa986829 (3 revisions) (flutter/engine#53583)
https://skia.googlesource.com/skia.git/+log/354b30fe7ab5..e836fa986829

2024-06-26 nathanasanchez@google.com [Graphite] Remove hard-coded buffer indices
2024-06-26 michaelludwig@google.com [graphite] Consolidate built-in shader-snippet tables
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 72fd79ddaace to 79660091faba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 16:48:23 +00:00
Srujan Gaddam
554e637a35 Ignore lints that will be triggered by ExternalDartReference changes (flutter/engine#53572)
https://dart-review.googlesource.com/c/sdk/+/370663 makes
ExternalDartReference generic. By doing so, it triggers two
cast_nullable_to_non_nullable lints that need to be silenced for it to
land. Once the above SDK changes land, this can be refactored to utilize
the generic and avoid the manual cast altogether.
2024-06-26 09:32:08 -07:00
skia-flutter-autoroll
1a21f12d44 Roll Skia from 79587650d153 to 354b30fe7ab5 (2 revisions) (flutter/engine#53580)
https://skia.googlesource.com/skia.git/+log/79587650d153..354b30fe7ab5

2024-06-26 zhusida@bytedance.com Reland "Add 16bit BT2020, YCGCO color space support"
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 720ace3b91cf to fa24f1553bec (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 14:55:23 +00:00
skia-flutter-autoroll
bf5d10e4c7 Roll Skia from 0c9a66786ba1 to 7e85023a57b7 (3 revisions) (flutter/engine#53577)
https://skia.googlesource.com/skia.git/+log/0c9a66786ba1..7e85023a57b7

2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from de870ac7518f to a0ec371d8331 (2 revisions)
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dc1551316ebe to 720ace3b91cf (13 revisions)
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d6925c2a17cc to 72fd79ddaace (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 07:01:23 +00:00
skia-flutter-autoroll
89d213c19f Roll Fuchsia Linux SDK from WUN7NQK04NjF9fRmf... to n2dgSmMCaCO7ujvmr... (flutter/engine#53575)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 02:43:34 +00:00
Jenn Magder
53573f860f Remove FlutterUndoManagerPlugin handlers from undo manager on dealloc (flutter/engine#53553)
When `FlutterUndoManagerPlugin` deallocated, it is supposed to deregister itself from the `NSUndoManager` stack.
However, during dealloc `_undoManagerDelegate.undoManager` is nil (`_undoManagerDelegate` = the engine, and `undoManager` was its view controller's `undoManager`, which was already gone).

Since `_undoManagerDelegate.undoManager` is nil, it doesn't actually call `-[NSUndoManager removeAllActionsWithTarget]`. In the add-to-app scenario, after the view controller pops back to the native view, and "undo" is invoked, the undo action for the `FlutterUndoManagerPlugin` is handled, but it already dealloced so crash.

Fixes https://github.com/flutter/flutter/issues/150408

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-25 23:54:26 +00:00
skia-flutter-autoroll
335e888cf5 Roll Skia from ea8ec1a618b0 to 7cbcb2f0e818 (4 revisions) (flutter/engine#53573)
https://skia.googlesource.com/skia.git/+log/ea8ec1a618b0..7cbcb2f0e818

2024-06-25 bungeman@google.com Update CMake generator compile flags
2024-06-25 robertphillips@google.com [graphite] Make PrecompileMaskFilter part of the public Precompile API
2024-06-25 brianosman@google.com Remove SK_LEGACY_RECT_DASHING_BUG
2024-06-25 jvanverth@google.com Change wacky_yuv GMs to split full colorspaces from limited.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 23:22:13 +00:00
skia-flutter-autoroll
320cedb30b Roll Dart SDK from 65ab2f2cf0d3 to 38bb74f63829 (1 revision) (flutter/engine#53570)
https://dart.googlesource.com/sdk.git/+log/65ab2f2cf0d3..38bb74f63829

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-299.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 22:04:01 +00:00
Jackson Gardner
8ab7c5d6e9 [skwasm] Fixes for getting pixels from an image. (flutter/engine#53561)
There were two issues here:

1) We have to stop using the emscripten thread scheduling APIs, as they can be invoked out of order from the rest of the messages that are posted. In some cases, out of order message handling can cause the request for reading pixels in an image to be serviced before some of the texture sources have been transfered to the web worker.

2) Skia's `readPixels` fails if there is is a lazy picture image made from a picture that contains a lazy texture image. The pertinent bug is here: https://g-issues.skia.org/issues/349201915

To work around the Skia bug, we just render the image itself onto our scratch canvas and pull the pixels out with `glReadPixels`.

This fixes https://github.com/flutter/flutter/issues/141326
2024-06-25 18:11:11 +00:00
Jason Parrott
384f44cafc fix: web canvaskit fragment shaders were not using updated uniform values (flutter/engine#53246)
This fixes an issue where in CanvasKit builds, uniforms set in setFloat function in the Paint class don't get updated after the initial render.
For example, like in the issue linked below, having a shader that animates a value over time and you want to reuse the Paint object that the shader is set to.

I'm no expert with CanvasKit nor with the Flutter Engine, but from what I could tell it seemed that the uniforms were only being sent to Skia on creation of the shader via _makeEffect.

However, any uniforms set afterwords were just stored in a local dart-side List<double> and forgotten about.

This PR changes the List<double> to use a WASM backed SkFloat32List to keep the references to the uniforms linked to dart-side.

fixes https://github.com/flutter/flutter/issues/149800
2024-06-25 17:59:24 +00:00
skia-flutter-autoroll
7a5d676a11 Roll Dart SDK from b5fc85cfcf1b to 65ab2f2cf0d3 (1 revision) (flutter/engine#53565)
https://dart.googlesource.com/sdk.git/+log/b5fc85cfcf1b..65ab2f2cf0d3

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-298.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 17:47:48 +00:00
Jim Graham
34bb05029e [DisplayList] Switch to recording DrawVertices objects by reference (flutter/engine#53548)
The Vertices objects are already allocated in a shared object by default so copying them inline into the recording buffer is usually a waste of time rather than reusing the memory allocated for the shared object by recording a reference. Note that the shared DlVertices objects already inline all of their data so we have good data locality as it is without further copying the data into the buffer.

Might help with https://github.com/flutter/flutter/issues/150513
2024-06-25 17:41:14 +00:00
skia-flutter-autoroll
af59a1f298 Roll Skia from 5f21260470cf to e4e4feb97a54 (1 revision) (flutter/engine#53559)
https://skia.googlesource.com/skia.git/+log/5f21260470cf..e4e4feb97a54

2024-06-25 nicolettep@google.com Revert "Add 16bit BT2020, YCGCO color space support"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 16:24:02 +00:00
gaaclarke
956c30fbf3 [impeller] Cleanup blur (flutter/engine#53543)
This is a refactor, no functional change.

We have a few issues in flight that talk about improving the blur. This
attempts to clean everything up a bit to make it easier for us to
change.


issues: 
- https://github.com/flutter/flutter/issues/150713
- https://github.com/flutter/flutter/issues/150722
- https://github.com/flutter/flutter/issues/150720

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-06-25 08:35:37 -07:00
Mouad Debbar
2d762001d3 [web] Implement AppLifecycleState.detached as documented (flutter/engine#53506)
Currently, we are transitioning to the `AppLifecycleState.detached` incorrectly. This is causing the framework to stop pumping frames when the app is still active and visible.

This PR re-implements the transition to `AppLifecycleState.detached` as documented [here](https://api.flutter.dev/flutter/dart-ui/AppLifecycleState.html#detached) (based on whether the app has any views or not).

Fixes https://github.com/flutter/flutter/issues/150636
Fixes https://github.com/flutter/flutter/issues/149417
2024-06-25 14:14:17 +00:00
skia-flutter-autoroll
833ddf5993 Roll Skia from 335200e57c26 to 3029f75db702 (2 revisions) (flutter/engine#53554)
https://skia.googlesource.com/skia.git/+log/335200e57c26..3029f75db702

2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e080995c5d21 to d6925c2a17cc (4 revisions)
2024-06-25 michaelludwig@google.com Fix NPE in Tagged Images slide

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 10:12:21 +00:00