firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,534 Commits 1 Branch 0 Tags
Commit Graph

28674 Commits

Author SHA1 Message Date
Chris Bracken
d49826f5d2 clangd_check: write .clangd as part of test (flutter/engine#54766) 
This eliminates the checked-in `.clangd` file at the root of the engine repository, which gets picked up by editors that rely on `clangd`. In particular, the `Remove: [-m*, -f*]` is problematic for iOS/macOS embedder developers since it removes the `-fobjc-arc` flag, which causes `clangd` to emit errors when using ARC features. Example:

    Cannot create __weak reference in file using manual reference counting

This removes the checked-in file, and instead writes the file before running the test, then cleans it up afterwards. Unfortunately, `clangd` does not appear to have a mechanism to point to a config file elsewhere and run as though it were present in a specified directory.

Fixes: https://github.com/flutter/flutter/issues/154064

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-26 17:16:20 +00:00
skia-flutter-autoroll
f9bc640393 Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) (flutter/engine#54776) 
https://dart.googlesource.com/sdk.git/+log/c7eb3230248a..94c21ec02e28

2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-180.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-179.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-26 17:00:14 +00:00
chunhtai
47bc9a3abb [Android] Drops semantics query when app is not attached (flutter/engine#52040) 
Is seems automatic test may send a11y query before the engine is attached. Add a guard to guard against it.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-26 16:37:05 +00:00
Jonah Williams
c88eb87bd5 [ui] fix missing color conversion in drawAtlas. (flutter/engine#54750) 
Ensure that int32 ui colors are correctly converted to Dl Colors (convert instead of reinterpret cast).
 2024-08-26 16:28:21 +00:00
skia-flutter-autoroll
1e20113fe4 Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) (flutter/engine#54774) 
https://skia.googlesource.com/skia.git/+log/ce0656c1d79c..a05dbd2a60f0

2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b1ee6973bca0 to 38174d6926f6 (1 revision)
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 387d930f2e5e to 1e4466d51783 (4 revisions)
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3f25662c1140 to b4c5e1b2a8d9 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-26 15:16:24 +00:00
skia-flutter-autoroll
3f21a1e6b5 Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... (flutter/engine#54770) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-26 12:43:37 +00:00
Jonah Williams
5cfb3bbf9d [Impeller] delete impeller image class. (flutter/engine#54767) 
This class does nothing but wrap impeller::Texture. Lets just use impeller::Texture.
 2024-08-26 00:20:32 +00:00
Jonah Williams
85442ec532 [Impeller] more test migration. (flutter/engine#54763) 
Move more aiks tests to DL

Part of https://github.com/flutter/flutter/issues/142054
 2024-08-25 21:49:53 +00:00
Chris Bracken
b105e9b1cd [macOS] Add TODOs to remove AppKit bug workaround (flutter/engine#54764) 
In https://github.com/flutter/engine/pull/40241, I added a workaround for an AppKit bug wherein mouseDown/Up events were ignored when the *Reduced Transparency* accessibility setting was enabled, and the view was hosted in an `NSPopover`.

I filed a Radar and Apple reported the bug fixed in macOS 13.3.1.

When we drop support for macOS 12 in Flutter, we should remove the workaround.

So long as nothing else has been added to these methods at that time, the method overrides themselves should be removed, so that we fall back to the default behaviour.

See: http://www.openradar.me/FB12050037
See: https://developer.apple.com/documentation/appkit/nsresponder/1535349-mouseup

Issue: https://github.com/flutter/flutter/issues/154063
Issue: https://github.com/flutter/flutter/issues/115015

No tests modified since this only adds a comment.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-25 15:00:36 +00:00
skia-flutter-autoroll
b5e7036a72 Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... (flutter/engine#54765) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-25 11:26:14 +00:00
skia-flutter-autoroll
b0e5d82f86 Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... (flutter/engine#54757) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-24 10:10:07 +00:00
skia-flutter-autoroll
5a039fcc0e Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) (flutter/engine#54755) 
https://dart.googlesource.com/sdk.git/+log/586ba94c96a4..c7eb3230248a

2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-178.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-177.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-24 06:06:15 +00:00
skia-flutter-autoroll
a422eed480 Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) (flutter/engine#54753) 
https://skia.googlesource.com/skia.git/+log/0086a17e0d4c..741972846fa2

2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d95811d4259d to 05f092235902 (4 revisions)
2024-08-23 kjlubick@google.com Remove GR_GL_CUSTOM_SETUP_HEADER
2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c830bf291754 to f96615e73170 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-24 02:59:27 +00:00
skia-flutter-autoroll
80ee1f2ffd Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) (flutter/engine#54752) 
https://dart.googlesource.com/sdk.git/+log/b81b344a194f..586ba94c96a4

2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-176.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-24 01:52:18 +00:00
Chris Bracken
e2264d0090 iOS: don't bundle simulator dSYMs in xcframework (flutter/engine#54746) 
While we do produce a simulator slice in our iOS release framework binaries, this is actually an unsupported runtime mode, therefore there is no need to bundle dSYMs for this mode.

This saves roughly 1GB of cached debug info.

Issue: https://github.com/flutter/flutter/issues/116493
Fixes: https://github.com/flutter/flutter/issues/154019
Related issue: https://github.com/flutter/flutter/issues/11754

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-24 00:12:21 +00:00
skia-flutter-autoroll
c555158a02 Roll Dart SDK from ca8ee3f5f266 to b81b344a194f (3 revisions) (flutter/engine#54738) 
https://dart.googlesource.com/sdk.git/+log/ca8ee3f5f266..b81b344a194f

2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-175.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-174.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-173.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 18:17:19 +00:00
Jonah Williams
1ba45ac86e [Engine] Add no op surface (flutter/engine#54694) 
Still needs to be tested in metalless environment. This should probably print out some kind of error message that tells folks that this is WAI, but I'm not sure if that would be too disruptive for g3.

Fixes https://github.com/flutter/flutter/issues/153883
 2024-08-23 17:06:16 +00:00
Jonah Williams
c8fc2ff531 [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655) 
Does it blend?
 2024-08-23 17:06:14 +00:00
Mouad Debbar
ff452d94a3 [web] Multi-view support for Skwasm (flutter/engine#48893) 
Support multi-view mode in the Skwasm renderer.

Fixes https://github.com/flutter/flutter/issues/138925
 2024-08-23 15:20:07 +00:00
skia-flutter-autoroll
25772c447e Roll Dart SDK from f9e6abb21ac7 to ca8ee3f5f266 (1 revision) (flutter/engine#54734) 
https://dart.googlesource.com/sdk.git/+log/f9e6abb21ac7..ca8ee3f5f266

2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-172.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 11:00:09 +00:00
skia-flutter-autoroll
fc55b348f0 Roll Fuchsia Linux SDK from s8Qn72-dRInu0Avzn... to 0d2McFgsNwG-5r1Rb... (flutter/engine#54733) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 08:56:26 +00:00
Jim Graham
2932511ae8 Revert "Framework wide color" (flutter/engine#54728) 
Reverts flutter/engine#54415

Reverting for failures in the engine roll: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738846858081700577/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout
 2024-08-23 08:11:16 +00:00
skia-flutter-autoroll
f1dda22591 Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731) 
https://skia.googlesource.com/skia.git/+log/7ac776072577..7d96b8516e8d

2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 82ebd6669b10 to 387d930f2e5e (7 revisions)
2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 387d930f2e5e to 8db4baf70cfc
2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7216df70d311 to dc27069e5d04 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 07:17:22 +00:00
skia-flutter-autoroll
a5d8cc4c40 Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726) 
https://skia.googlesource.com/skia.git/+log/b25553b2fb9f..789f5cb0b9c2

2024-08-22 borenet@google.com [bazel] Add windows toolchain

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 03:12:25 +00:00
skia-flutter-autoroll
e0d14971a2 Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725) 
https://dart.googlesource.com/sdk.git/+log/ca009736fb3e..f9e6abb21ac7

2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-171.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-23 02:08:19 +00:00
Brandon DeRosier
adbc360970 [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673) 
For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.
 2024-08-22 18:22:09 -07:00
Jenn Magder
7e82588c31 Test running the macOS engine has no stray logging (flutter/engine#54716) 
Assert that running the macOS engine does not log anything unexpected 
See also issue https://github.com/flutter/flutter/issues/111577
Similar Windows check in https://github.com/flutter/engine/pull/47774

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-22 22:40:10 +00:00
skia-flutter-autoroll
98f1580a2b Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719) 
https://dart.googlesource.com/sdk.git/+log/937389f7bc48..ca009736fb3e

2024-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-170.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 22:38:21 +00:00
Matan Lurey
d68876bb1d More diagnostic clean ups (flutter/engine#54265) 
Towards https://github.com/flutter/flutter/issues/152636.

Almost all changes are `dart --fix`.
 2024-08-22 21:04:17 +00:00
gaaclarke
6f9776424c Framework wide color (flutter/engine#54415) 
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This does the preliminary work for implementing wide gamut colors in the
Flutter framework. Here are the following changes:
1) colors now specify a colorspace with which they are to be interpreted
1) colors now store their components as floats to accommodate bit depths
more than 8

The storage of this Color class is weird with float/int storage but that
is a temporary solution to support a smooth transition. Here is the plan
for landing this:
1) Land this PR
1) Wait for it to roll into the Framework
1) Land https://github.com/flutter/flutter/pull/153938 which will make
CupertinoDynamicColor implement Color
1) Land another engine PR that rips out the int storage:
https://github.com/flutter/engine/pull/54714

Here are follow up PRs:
1) https://github.com/flutter/engine/pull/54473 - changes DlColor so the
wide gamut colors are rendered
1) https://github.com/flutter/engine/pull/54567 - Hooks up these changes
to take advantage of wide DlColor
1) https://github.com/flutter/flutter/pull/153319 - the integration test
for the framework repo

There are some things that have been left as follow up PRs since they
are technically breaking:
1) The math on `lerp` hasn't been updated to take advantage of the
higher bit depth
1) `operator==` hasn't been updated to take advantage of the higher bit
depth
1) `hashCode` hasn't been updated to take advantage of the higher bit
depth
1) `alphaBlend` hasn't been updated to take advantage of the higher bit
depth
1) `toString` hasn't been updated to take advantage of the higher bit
depth

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-08-22 12:36:28 -07:00
skia-flutter-autoroll
2ddccd8b79 Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715) 
https://dart.googlesource.com/sdk.git/+log/ce160bf13347..937389f7bc48

2024-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-169.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 18:20:21 +00:00
Yegor
41041672af [web:semantics] fix double click due to long-press (flutter/engine#54697) 
Remember the timestamp of _all_ `pointerup` events, not just those that were flushed. Clicks should be deduplicated after a `pointerup` even when not debouncing anything. This is because when not debouncing the engine already forwards all the pointer events to the framework, and sending click events on top only causes double-clicks.

Fixes https://github.com/flutter/flutter/issues/147050
 2024-08-22 17:54:47 +00:00
Zachary Anderson
4eeb21e718 Pin mac host and iOS builds to arm64 builders (flutter/engine#54711) 
For https://github.com/flutter/flutter/issues/153925.

This limits these builds to using a little under 60% of mac capacity. If
the queue times go up, we can trade intel and arm machines between the
prod and try pool.
 2024-08-22 10:36:49 -07:00
Chris Bracken
7d3065fd52 macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696) 
As of Xcode 16, App Store validation requires dSYMs for frameworks in app archives. Bundling dSYMs also significantly simplifies stack trace symbolification, so we should be doing this regardless.

This adds both framework and simulator framework dSYMs to the FlutterMacOS.xcframework bundle.

Issue: https://github.com/flutter/flutter/issues/153879

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-22 16:40:08 +00:00
skia-flutter-autoroll
baa9b2d202 Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712) 
https://skia.googlesource.com/skia.git/+log/7611984dc27b..04ce2e2bfc35

2024-08-22 robertphillips@google.com [graphite] Move the Precompilation testing files into a precompile sub-directory
2024-08-22 aperez@igalia.com Fix undefined SkData class build issue with GCC 13.2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 16:15:55 +00:00
Joel Winarske
5c34b2ad0e vulkan_glfw validation layer logging (flutter/engine#54607) 
This PR enables printing validation output when the Vulkan validation layer is enabled.  Without this change no messages are printed which provides a false positive for the Vulkan Embedder API health.

*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/153663

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

cc @chinmaygarde 

Fixes https://github.com/flutter/flutter/issues/153663
 2024-08-22 16:03:17 +00:00
skia-flutter-autoroll
f3788f243e Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709) 
https://dart.googlesource.com/sdk.git/+log/025bf8d376d3..ce160bf13347

2024-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-168.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 14:10:19 +00:00
skia-flutter-autoroll
1b9dc772d3 Roll Skia from 0429e894d3f6 to 4c66b7e42027 (1 revision) (flutter/engine#54708) 
https://skia.googlesource.com/skia.git/+log/0429e894d3f6..4c66b7e42027

2024-08-22 kjlubick@google.com Remove unnecessary GL shim files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 13:26:16 +00:00
skia-flutter-autoroll
c77dc1f3a9 Roll Fuchsia Linux SDK from XGzE3idakwfQZ68pb... to s8Qn72-dRInu0Avzn... (flutter/engine#54706) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 07:37:24 +00:00
skia-flutter-autoroll
d88dd87247 Roll Skia from 34aa8ce13af6 to a9af6f466355 (5 revisions) (flutter/engine#54705) 
https://skia.googlesource.com/skia.git/+log/34aa8ce13af6..a9af6f466355

2024-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 82ebd6669b10 to 504f49204b21
2024-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 244b54c99d6e to 82ebd6669b10 (10 revisions)
2024-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a38b02612272 to f1015ca7ba5b (4 revisions)
2024-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 447c179b707d to 20bd94932cd1 (1 revision)
2024-08-22 jvanverth@google.com [graphite] Fix loop counter for Image_YUVA::textureSize().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-22 07:31:32 +00:00
Joel Winarske
1961f2c5cc Export GPU symbols for embedder (flutter/engine#54662) 
This PR exports GPU symbols for the embedder library.

*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/153196

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-22 04:37:31 +00:00
Jason Simmons
d6079c8165 [Impeller] Remove a log message in the Vulkan back end that is visible during engine startup (flutter/engine#54699) 2024-08-22 02:05:11 +00:00
Chris Bracken
1e7584e7a2 macOS: Make framework creation consistent with iOS (flutter/engine#54685) 
Separates dSYM creation from archiving, consistent with iOS tooling. This
introduces no semantic changes, but simply adjusts `create_fat_macos_framework`
and `process_framework` for consistency with the equivalent iOS tooling in
`create_ios_framework.py`.

Related issue: https://github.com/flutter/flutter/issues/153879

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-21 23:19:59 +00:00
skia-flutter-autoroll
c571a9aeb7 Roll Skia from 69f4bd859025 to 3cd00377cefc (8 revisions) (flutter/engine#54693) 
https://skia.googlesource.com/skia.git/+log/69f4bd859025..3cd00377cefc

2024-08-21 bungeman@google.com Remove --with-fontations from GN build
2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 7ee30f5d2f5a to a38b02612272 (7 revisions)
2024-08-21 robertphillips@google.com Rename join -> joinpath in infra/bots directories
2024-08-21 brianosman@google.com Ignore more deleted test files on Android devices
2024-08-21 robertphillips@google.com Replace 'python' call w/ 'python3' in infra/bots/recipe_modules
2024-08-21 brianosman@google.com Stop forcing debug symbol generation with skia_enable_optimize_size
2024-08-21 fmalita@google.com [skottietool] Fix text rendering in worker threads
2024-08-21 kjlubick@google.com Fix builds after flag removal

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 22:54:08 +00:00
skia-flutter-autoroll
e2755ea6a8 Roll Dart SDK from 060e40916514 to 025bf8d376d3 (1 revision) (flutter/engine#54692) 
https://dart.googlesource.com/sdk.git/+log/060e40916514..025bf8d376d3

2024-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-167.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 22:20:14 +00:00
Zachary Anderson
67bceb8185 Split tests out of Linux Android artifact creation builds (flutter/engine#54683) 
Towards https://github.com/flutter/flutter/issues/145842.

Mostly a note to self: I'll need to write a lint at some point that this
does not regress. Possibly part of
https://github.com/flutter/engine/blob/main/tools/pkg/engine_build_configs/bin/check.dart,
but it will also need to query the ci.yaml to ask whether a build config
json is part of a `release_build: "true"` build.
 2024-08-21 15:14:03 -07:00
skia-flutter-autoroll
ca3518ac1a Roll Skia from 249d3f07c4d5 to 69f4bd859025 (5 revisions) (flutter/engine#54691) 
https://skia.googlesource.com/skia.git/+log/249d3f07c4d5..69f4bd859025

2024-08-21 fmalita@google.com [skottie] Fix Shift Channels effect coverage with FullOn alpha
2024-08-21 kjlubick@google.com Delete all filegroups that supported legacy (non-buffet) Bazel build
2024-08-21 cwallez@chromium.org Replace deprecated wgpu::SwapChain with wgpu::Surface
2024-08-21 kjlubick@google.com Move utils/SkTestCanvas -> tools/gpu/TestCanvas
2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 86508e2014f8 to 36f7e03a3578 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 21:28:22 +00:00
Chinmay Garde
74861200d4 [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 
We don't have an OpenGL backend on iOS.
 2024-08-21 20:46:04 +00:00
Jonah Williams
02a6c7a676 [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 
Fixes https://github.com/flutter/flutter/issues/153623
Fixes https://github.com/flutter/flutter/issues/153788

* Avoids slow CPU resizer
* Avoids us having to write any code at all to resize these images
* Avoids reading from the GPU staging buffers that are not read cached (similar to Glyph cache performance issues).

Also changes the single frame codec upload to either use the device private storage path or to defer upload until the GPU returns. This allows us to ensure that mips are always constructed and makes sure that we don't need to keep around the CPU texture reisze that depends on the Skia software backend.

Separately, I updated the deferred task system to allow separate success/failure tasks to make it easier to track the final state.
 2024-08-21 20:22:09 +00:00
Matan Lurey
7279070455 Remove spammy warning message on FlutterView (flutter/engine#54686) 
@matanlurey:

> As of 2f6952657d, we are now printing a `W/FlutterView( 7775): API level 34 is too low to query bounding rects.` message which is not user actionable. Was this intended to stay in the merged PR? What value is it supposed to have?

@yaakovschectman:

> You might be right about that
 2024-08-21 19:57:52 +00:00