Sky itself does't need to depend on //services/debugger. That's already taken
care of by //services depending on //services/debugger. Also, add some direct
depenencies from //sky/sdk to the mojom interfaces used by //sky/sdk.
TBR=eseidel@google.com
Review URL: https://codereview.chromium.org/1232783006 .
Previously, the standard C tolower() function was used, which
didn't support any characters beyond the basic ASCII letters.
Bug: 22506121
Change-Id: Ibb81121caa29be44fbb59aa98891e9faafc57592
- Instead of using a ColorFilter or an Opacity widget to colorize the Icons,
add a ColorFilter parameter it the image classes. This avoids needing to
call saveLayer for each DrawerItem.
- Ask Android for unbuffered input events to avoid bad synchronization with
vsync.
R=ianh@google.com
Review URL: https://codereview.chromium.org/1236043004 .
This adds various hyphen-like characters missed in the previous
patch, that should disallow automatic hyphenation of words containing
them.
Bug: 22484266
Change-Id: Ie972cb50384dbe0aa1ab5ec50286b75f9877953a
Previously, automatic hyphenation blindly took almost every line
breaking opportunity as a word break, so words like "low-budget" were
treated as two separate words, "low-", and "budget", each
automatically hyphenated.
This patch makes sure the subwords in already-hyphenated phrases are
not passed to the automatic hyphenator, while keeping the possibility
of a potential line break where a hyphen already exists.
Bug: 22484266
Bug: 22287425
Change-Id: Ie46dbdd70e993d64a9b9cf44b4ae93b21459dbc2
I also made the add_argument blocks shorter by allowing more
than one named arg per line. I removed the metavar lines
and action=store lines since one was only used in help messages
and the other was already matching the default for add_argument.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1234803004 .
Also, fixes the stocks list to work properly including hit testing at
the bottom of the screen.
New classes:
RenderViewport: a class that supports positioning a child inside
itself and offsetting it.
Viewport: a RenderObjectWrapper that wraps RenderViewport.
ScrollableViewport: a Component that hooks Viewport up to some
scrolling behaviour.
Code changes:
RenderBlock now only works when it has an unbounded height constraint.
I removed the clipping in there since it's no longer needed.
I made FixedHeightScrollable use Viewport instead of hand-rolling its
clipping with Transform and Clip. This is what fixes the stocks list
hit testing at the bottom of the screen.
I made anywhere that used to use Block now use ScrollableViewport.
RenderFlex now takes a list of children.
Justifications for test changes:
tests/examples/stocks: changing FixedHeightScrollable to use a
RenderViewport instead of a RenderClipRect/RenderTransform combination
removes the use of an actual transform.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1223153004 .
We bypass the word layout cache for "complex" cases, which includes
things like OpenType features. We were counting a hyphen edit as such
a case, but the problem is that we measure a _lot_ of these when
doing layout with hyphenation.
This patch adds plumbing for hyphen edits to the layout cache, so
that word fragments with hyphens can be cached as well.
Bug: 22378829
Change-Id: Idba4df4faa14f48a5faccc8a7a7955a36c19ef27
At startup, we make a list of all the temp directories that already exist and
then nuke them on a background thread after a five second delay. The five
second delay isn't particularly satisfying, but I think it's wortwhile to get
this work off the critical path of startup.
R=eseidel@chromium.org, eseidel@google.com
Review URL: https://codereview.chromium.org/1228083003 .
Now that we have all the Dart packages we need in //third_party, we can build
skyx bundles by default.
As part of this change, I've made it possible to build skyx bundles on Linux
and I've made the gn target names of the mojoms in //sky/services consistent
with each other and with //mojo/services/public.
TBR=eseidel@google.com
Review URL: https://codereview.chromium.org/1227973002 .
