7303 Commits

Author SHA1 Message Date
xster
fa1b8d5821 A low scope error message height fix for #3091 (#7685)
* Print the error message multiple times to avoid overlap with status bar and add paragraph to mock_canvas
2017-01-31 11:28:52 -08:00
Adam Barth
650b939f48 Update dartdoc (#7758)
This update includes the fix for the search box.
2017-01-31 11:03:48 -08:00
Ian Hickson
6469b475d2 Let's document this line so I don't accidentally remove it again. (#7750) 2017-01-30 23:32:44 -08:00
Ian Hickson
68ebf64525 Remove the timeout on test_test.dart (#7754)
It was causing the flakiness because it was too short. The default timeout is better.
2017-01-30 21:17:29 -08:00
Ian Hickson
b257f6eac0 Make tests more resilient to timing. (#7753)
These tests would fail sometimes when run locally. Since they happen
to also be the ones that are flaky on bots, maybe there's some
relationship, even though the failure mode on bots is different. In
any case, this removes a variable.
2017-01-30 20:11:01 -08:00
Ian Hickson
d7b523e004 Apply @required according to the rules, for all of material/* (#7732) 2017-01-30 20:10:53 -08:00
Ian Hickson
0400107cdf Apply @required according to the rules, for all of widgets/* (#7730) 2017-01-30 20:10:44 -08:00
Jason Simmons
8f7d0a45c8 Remove unnecessary type parameter (#7751) 2017-01-30 17:49:31 -08:00
Adam Barth
9119969ad2 Add SliverGrid and ScrollGrid (#7745)
This patch adds grid supports to slivers and introduces a ScrollGrid
convenience class for making the common types of scrollable grids.

This patch also deploys ScrollGrid in an example in the Flutter Gallery.
2017-01-30 17:27:51 -08:00
Jason Simmons
8ef17e0a6a Create flutter_driver key finders using parameterized ValueKey types (#7749)
The finder will only match the widget's ValueKey if both have identical
runtime types
2017-01-30 16:52:59 -08:00
Adam Barth
edcab3c340 Add TabBar.unselectedLabelColor (#7747)
Our previous behavior of hard-coding the unselected label color to 70% of the
selected color was too restrictive.

Fixes #7738
2017-01-30 16:46:09 -08:00
Adam Barth
a0dee550c0 Use ScrollView in more places (#7746)
Now that ScrollView supports itemExtent, we can use it in a few more places.
2017-01-30 16:45:51 -08:00
Ian Hickson
64d3647084 Tab crash in complex_layout (#7744) 2017-01-30 16:11:01 -08:00
Devon Carew
8e3ea7523e fix app launch in intellij (#7737) 2017-01-30 13:01:41 -08:00
Adam Barth
098af18393 Add SliverList (#7727)
Add SliverList

A SliverList is a linear layout of box children in a viewport that all
have a common, fixed extent along the scroll axis. The layout is similar
to a SliverBlock but more efficient.
2017-01-30 00:40:50 -08:00
Ian Hickson
6e30cae8fa Warn about the size setter. (#7729) 2017-01-29 23:58:42 -08:00
Ian Hickson
a8ed018386 Documentation fixes (#7731)
Fixes https://github.com/flutter/flutter/issues/4620
2017-01-29 23:43:01 -08:00
Ian Hickson
e8c9797d1a Various documentation fixes. (#7726)
Fixes for: https://github.com/flutter/flutter/issues/7570 https://github.com/flutter/flutter/issues/7231 https://github.com/flutter/flutter/issues/2841 and others
2017-01-29 22:39:15 -08:00
Devon Carew
8e64624a36 add a bots module to the intellij project (#7712) 2017-01-29 18:57:28 -08:00
Ian Hickson
ab28e2c46a Key improvements (#7719)
ValueKey and ObjectKey shouldn't be == with subclasses.
Fixes https://github.com/flutter/flutter/issues/3107

Clean up toString for the keys a bit.

Add a test for keys.
2017-01-28 16:29:23 -08:00
Ian Hickson
65ca387075 Make the Ahem font available to tests. (#7725) 2017-01-28 15:55:47 -08:00
Ian Hickson
96e11e1bf1 Clean up the file names of the hot and cold runners. (#7697) 2017-01-28 14:26:49 -08:00
Ian Hickson
512a9af6a0 deprecate needsLayout (#7718)
The needsLayout getter is prone to misuse. See discussion on #3083.
2017-01-28 14:26:08 -08:00
Ian Hickson
62c1b0b217 Fix wording of app bar vs toolbar in gallery (#7720)
Reverts a change from https://github.com/flutter/flutter/pull/3158.
Fixes https://github.com/flutter/flutter/issues/3161
2017-01-28 14:24:19 -08:00
Ian Hickson
571834ea3c Indicate required fields in flutter_gallery demo. (#7717) 2017-01-28 01:48:18 -08:00
Michael Goderbauer
c234d405af Replace bin/flutter.ps1 with bin/flutter.bat (#7713)
fixes https://github.com/flutter/flutter/issues/7654
2017-01-27 23:12:33 -08:00
Ian Hickson
078f6854cd An evil test for slivers. (#7671)
Combines many sliver features at once.
2017-01-27 15:31:53 -08:00
Hans Muller
17389244bf Fix BorderSide rendering (#7705) 2017-01-27 15:03:20 -08:00
Adam Barth
743be6746e Split ScrollableViewport2 from Scrolllable2 (#7707)
This structure makes it easier to customize the viewport used in a Scrollable.
Now Scrollable2 doesn't commit to using slivers.
2017-01-27 13:14:41 -08:00
xster
573e7c1b8e Small wiki edit
Responding to https://github.com/flutter/flutter/pull/7640#pullrequestreview-18563416
2017-01-27 11:40:55 -08:00
Michael Goderbauer
06a0836d79 Add a .bat entry point for flutter tools (#7701)
Currently, this only calls out to the PowerShell Script, which is kind of slow. In the future, we will transfer more logic from PowerShell to cmd for faster starup time.
2017-01-27 10:58:32 -08:00
Ian Hickson
21434fcf1a Refactor 'flutter drive' to get the observatory port from the logs (#7695)
This remove a very brittle aspect of flutter drive, whereby it would
assume a known port instead of explicitly finding out what it was.

Fixes #7692 and hopefully fixes the devicelab tests.
2017-01-27 01:37:28 -08:00
Ian Hickson
f888bbed48 Refactor hot/cold/drive runners a little (#7694)
Move the drive/run common stuff to RunCommandBase, rather than the
superclass which applies to everything.

Implement --no-resident (fixes
https://github.com/flutter/flutter/issues/5448). This is particularly
useful when running flutter from scripts.

Rename RunAndStayResident to ColdRunner.
2017-01-27 01:03:04 -08:00
Ian Hickson
56eca97a75 Engine roll to pick up Ahem font crash (#7691) 2017-01-26 23:58:54 -08:00
Adam Barth
5ecf8786b4 Add ScrollView.padding (#7690)
Uses SliverPadding to implementing paddding in ScrollView. Also, deploy
ScrollView in more places now that it implements padding.

Finally, remove loader_app.dart because it is not referenced.
2017-01-26 23:14:37 -08:00
Adam Barth
9c288040ce Improve SliverBlockDelegate.estimateScrollOffsetExtent (#7689)
We now report an accurate estimate when the lastIndex is the final index
in the list.

Also, we now project forward from the lastIndex using the extent of the
reified children instead of trying to project forward from index 0.

This new algorithm leads to estimation error as you reach the end of a
list, avoiding some ballistic overscrolls.
2017-01-26 22:59:10 -08:00
Ian Hickson
a67c79a1c7 converge flutter run and flutter drive onto one behavior (#7688)
...for the port arguments
2017-01-26 21:47:14 -08:00
Ian Hickson
19d22c9726 Make devicelab count as a bot so we can see crash logs (#7687) 2017-01-26 20:17:40 -08:00
Ian Hickson
ed2be89569 Try moving from closures to direct calls. (#7679)
Rumours have it that this is faster now.

Fixes https://github.com/flutter/flutter/issues/5154
2017-01-26 18:54:48 -08:00
Ian Hickson
f1cdf57053 Be gentler, for MacOS (#7684)
Turns out MacOS has a really low open files limit and so if you try to
open EVERY FILE AT THE SAME TIME it falls over.

This just opens the files one at a time, the way we used to back in
the old days.
2017-01-26 18:48:01 -08:00
Ian Hickson
a4a1392c44 --debug-port is now --observatory-port (#7680) 2017-01-26 18:01:34 -08:00
Chris Bracken
3241f643f0 Migrate sample applications off FlutterAppDelegate (#7677)
Almost all real-world apps will want a custom app delegate, and 'flutter
create' code-gens one by default. This brings the samples in line with
our templates and the most common use case.
2017-01-26 17:37:42 -08:00
Adam Barth
a90e25502a Don't overshoot ballisitic scroll activities (#7670)
When we start a ballisitic scroll activity to correct an out-of-range scroll
offset, make sure we start with a velocity that is headed in the right
direction.
2017-01-26 17:26:24 -08:00
Michael Goderbauer
9f28b4ff71 Windows Fixes for Flutter Tools (#7678) 2017-01-26 17:04:53 -08:00
Ian Hickson
aff4e82891 Technical Debt tracker (#7667) 2017-01-26 17:04:37 -08:00
Ian Hickson
576b4e1179 Change --debug-port to --observatory-port (#7675)
...and add --diagnostic-port.

...and document port 0.
2017-01-26 16:42:48 -08:00
xster
682c7992e5 Fix a crash (#7597) when the flutter sdk moves after getting packages (#7601)
* Add a check in case the flutter directory in .packages no longer exists. Clean up and prompt user

* Update documentation to use flutter packages get for end-users instead of flutter update-packages.

* Merge missing sdk error with the multiple sdk error. They're really the same thing.

* Use flutterPath in both checks.

* Change file_system’s copy folder to copy director which takes into account the file system

* Test support files

* Add test and split into 2 messages again.

* Move tests to run in memory file system's copy. Tested with dev/bots/test.sh
2017-01-26 15:43:28 -08:00
Jason Simmons
bc04c53231 Fix VMIsolateRef type declaration (#7666)
Fixes https://github.com/flutter/flutter/issues/7661
2017-01-26 14:24:04 -08:00
Todd Volkert
8a1990ce45 Separate data_table_test util code into its own file. (#7663)
This yields a cleaner separation between common testing code
and actual tests (a distinction which is important in Google's
internal build system).
2017-01-26 12:46:28 -08:00
Todd Volkert
71242888f1 Revert method generics in packages/flutter/lib/src/http (#7662)
We converted all code to use method generics in #7235, but
we shouldn't have touched the `http` folder since this code
is pulled from upstream.
2017-01-26 12:46:00 -08:00