firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,092 Commits 1 Branch 0 Tags
Commit Graph

27490 Commits

Author SHA1 Message Date
Chinmay Garde
e88cb577df Update "Vulnerability scanning" to add the actions: read permission. (flutter/engine#53409) 2024-06-15 00:52:54 +00:00
gaaclarke
12ccf1ee1c [Impeller] moved blur to unrotated local space, started respecting respect_ctm flag (flutter/engine#53377) 
Resolves https://github.com/flutter/flutter/issues/142014
Resolves https://github.com/flutter/flutter/issues/150114

A previous patch made the blur operate in source space. This doesn't
work for text since it jumbles up the characters. We probably want the
text crisp when scaled anyways so it would make sense not to render
those is source space. Instead I moved the blur to "scaled source space"
or "unrotated local space", if you will.

This is more closely what we had previously but it handles rotation
correctly.

Also, brandon fixed a problem where we weren't minding a flag on how the
ctm should be used when rendering mask blurs. That was important to this
fix too.

## new golden results before patch
<img width="966" alt="Screenshot 2024-06-13 at 3 32 29 PM"
src="https://github.com/flutter/engine/assets/30870216/097ef2d3-26a6-45fc-b1a5-e0b699d31dfd">

<img width="962" alt="Screenshot 2024-06-13 at 3 32 36 PM"
src="https://github.com/flutter/engine/assets/30870216/3b6c03fd-bf88-47eb-a0eb-c362dcaecd63">

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Brandon DeRosier <bdero@google.com>
 2024-06-14 15:17:28 -07:00
skia-flutter-autoroll
8b481e855e Roll Skia from 5560041fcfc0 to 136c7cc18d1e (4 revisions) (flutter/engine#53406) 
https://skia.googlesource.com/skia.git/+log/5560041fcfc0..136c7cc18d1e

2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 42ee85cf2154 to dd296c842e50 (2 revisions)
2024-06-14 bungeman@google.com [fontations] Define SkFontMgr_New_Fontations_Empty with SK_API
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6cfa730ae00a to b9f194451019
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1b41a295c513 to c0388f6de1dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 21:33:05 +00:00
Jason Simmons
285c718c82 Roll web_ui dependencies to enable the next roll of the Dart SDK (flutter/engine#53399) 
Dart has removed the UnmodifiableXXXView classes, which were used by older versions of the archive package.

See https://dart.googlesource.com/sdk/+/18994e6e46ec9fb2fac8368c43d448119abd579f
 2024-06-14 20:52:04 +00:00
Jackson Gardner
5dd33ba48e Hack to prevent Safari from being backgrounded during unit tests. (flutter/engine#53402) 
Safari actually pauses execution of our unit tests if the window becomes occluded or non-visible. As such, I am inserting this egregious hack which just makes the Safari window frontmost every 2 seconds so that the unit tests don't get stalled out.

This should fix https://github.com/flutter/flutter/issues/150023
 2024-06-14 20:18:32 +00:00
skia-flutter-autoroll
6d88e21691 Manual roll Dart SDK from cabe65966815 to e90b0a53e058 (1 revision) (flutter/engine#53404) 
Manual roll requested by jsimmons@google.com

https://dart.googlesource.com/sdk.git/+log/cabe65966815..e90b0a53e058

2024-06-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 20:10:23 +00:00
skia-flutter-autoroll
20cbde6609 Roll Skia from de1a50046289 to 5560041fcfc0 (1 revision) (flutter/engine#53393) 
https://skia.googlesource.com/skia.git/+log/de1a50046289..5560041fcfc0

2024-06-14 blundell@chromium.org [Dawn] Add External to known Dawn formats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 15:13:20 +00:00
skia-flutter-autoroll
7bc3d0649e Manual roll Dart SDK from 115a9a2b26cd to cabe65966815 (1 revision) (flutter/engine#53390) 
Manual roll requested by kustermann@google.com

https://dart.googlesource.com/sdk.git/+log/115a9a2b26cd..cabe65966815

2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-260.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com,kustermann@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 13:11:29 +00:00
skia-flutter-autoroll
daffb21107 Roll Skia from 3bebb0602780 to de1a50046289 (3 revisions) (flutter/engine#53388) 
https://skia.googlesource.com/skia.git/+log/3bebb0602780..de1a50046289

2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a7b72d6c8490 to 42ee85cf2154 (1 revision)
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 65f8dc8e3ad8 to 165b85b69226 (10 revisions)
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ad5ea87faf24 to 1b41a295c513 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 09:53:14 +00:00
skia-flutter-autoroll
fec3dbcd08 Roll Fuchsia Linux SDK from pGxbL7JoNb3yAYFw4... to BkYg1UB1jdbAZv3gA... (flutter/engine#53386) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-14 02:35:22 +00:00
Jim Graham
d8b3b9a280 [Impeller] restore accidentally deleted Cap/Join benchmarks (flutter/engine#53385) 
These benchmark invocations were accidentally deleted when the invocations of the "UV" versions were eliminated.

No unit tests because only benchmark code is changed.
 2024-06-14 01:01:34 +00:00
Matan Lurey
5300aafdb5 Add a FlutterEngineRule (JUnit TestRule) and use it in FlutterRendererTest (flutter/engine#53361) 
In https://github.com/flutter/engine/pull/53280, I'm adding
lifecycle-aware methods to `SurfaceProducer`.

That means, in order to test that it WAI, we'll need to be running in a
simulated activity, and be able to switch scenario states (i.e. to
`RESUMED`). This was mentioned as well in
https://github.com/flutter/flutter/issues/133151 as being something we
want to do.

This PR adds a `FlutterEngineRule`, which allows the creation of a
"real" `FlutterEngine` and an `Intent` that can power
`AndroidScenarioRule<FlutterActivity>`. I felt bad doing all of this
work for a single `@Test`, so I also refactored the rest of the file and
cleaned things up a bit.

That said, I'm happy to revert or make changes if we liked how things
were setup before.
 2024-06-13 16:22:54 -07:00
skia-flutter-autoroll
5778351976 Roll Skia from b21429b0ea78 to d248a9f99ff5 (2 revisions) (flutter/engine#53383) 
https://skia.googlesource.com/skia.git/+log/b21429b0ea78..d248a9f99ff5

2024-06-13 brianosman@google.com Remove isUsingMask plumbing through AAA scan converter
2024-06-13 drott@chromium.org [Fontations-backend] Return default palette if index out of range

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 21:21:12 +00:00
skia-flutter-autoroll
c39ce6490e Roll Skia from 40bdee9eedd6 to b21429b0ea78 (3 revisions) (flutter/engine#53382) 
https://skia.googlesource.com/skia.git/+log/40bdee9eedd6..b21429b0ea78

2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f32e0658b219 to a7b72d6c8490 (8 revisions)
2024-06-13 bungeman@google.com Cache the default mask gamma
2024-06-13 michaelludwig@google.com [skif] Split blur filling into strict and fast regions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 20:04:19 +00:00
Jim Graham
7ff652e5bf [DisplayList] cull clip operations that can be trivially and safely ignored (flutter/engine#53367) 
This mechanism pulls some clip-reduction logic from Impeller Entities up into DisplayListBuilder to simplify the work that Impeller has to do and also amortize the work if the DisplayList is reused from frame to frame. Since the DisplayList does not have access to information such as surface sizes, there will still be cases that Impeller can catch that must be conservatively included by the recording process in the Builder, so this mechanism does not replace the same code in Impeller, it merely catches some cases earlier, while recording widget output, to avoid the same work on every frame down in Impeller.

In this first pass only the most conservative and straightforward cases are handled - a clip on a layer which has a previous clip that the new clip fully contains (and which was not already restored).

This limited approach is already enough to eliminate a couple of clip operations in the layout of many of the pages in the `new_gallery` benchmarks.
 2024-06-13 19:06:22 +00:00
skia-flutter-autoroll
edf06d07fd Roll Skia from 0f47a9333edb to 40bdee9eedd6 (2 revisions) (flutter/engine#53381) 
https://skia.googlesource.com/skia.git/+log/0f47a9333edb..40bdee9eedd6

2024-06-13 robertphillips@google.com [graphite] Rearrange code for newly public PrecompileShader API
2024-06-13 robertphillips@google.com [graphite] Expose PrecompileShader to public API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 18:43:11 +00:00
skia-flutter-autoroll
86c982b7f9 Roll Dart SDK from aa2265e5a192 to 115a9a2b26cd (5 revisions) (flutter/engine#53380) 
https://dart.googlesource.com/sdk.git/+log/aa2265e5a192..115a9a2b26cd

2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-259.0.dev
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-258.0.dev
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-257.0.dev
2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-256.0.dev
2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-255.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 18:11:12 +00:00
skia-flutter-autoroll
88f016862a Roll Skia from bf5a0e0dbf41 to 0f47a9333edb (2 revisions) (flutter/engine#53378) 
https://skia.googlesource.com/skia.git/+log/bf5a0e0dbf41..0f47a9333edb

2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 22f8618f7005 to 5dbd83fd10db
2024-06-13 robertphillips@google.com [graphite] Rearrange code after PrecompileBlender had been made public

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 16:58:09 +00:00
skia-flutter-autoroll
d04ff169fe Roll Skia from ecc64fb82374 to bf5a0e0dbf41 (2 revisions) (flutter/engine#53376) 
https://skia.googlesource.com/skia.git/+log/ecc64fb82374..bf5a0e0dbf41

2024-06-13 enga@chromium.org Remove usage of wgpu::VertexFormat::Undefined
2024-06-13 robertphillips@google.com [graphite] Expose blenders in public Precompile API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 15:37:12 +00:00
Victoria Ashworth
ecad29a177 Change element to wait for in AppExtensionTests testAppExtensionLaunching (flutter/engine#53358) 
Instead of waiting for the first cell in the share sheet to appear, wait for the first cell matching the predicate to appear. It seems that on macOS 14 it [occasionally doesn't find any matches](https://github.com/flutter/flutter/issues/150117#issuecomment-2163493564), presumably a race condition - so this will wait up to 10 seconds for the desired elements to appear.

Attempting to fix https://github.com/flutter/flutter/issues/150117. I wasn't able to recreate locally and it only happens flakily in CI so hard to guarantee it will fix.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-13 14:39:18 +00:00
skia-flutter-autoroll
39eb74f203 Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373) 
https://skia.googlesource.com/skia.git/+log/9ea9f37e8e1d..0fe7f7ac43c5

2024-06-13 drott@chromium.org [Fontations-backend] Fix get_font_style Rust tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 10:21:32 +00:00
skia-flutter-autoroll
25ec2ce764 Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370) 
https://skia.googlesource.com/skia.git/+log/69a53db434a6..704f70b7d756

2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6a805cf8a5fb to 9f4eff245f36 (23 revisions)
2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3e4b1b489466 to ad5ea87faf24 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 06:22:24 +00:00
skia-flutter-autoroll
305ae8ca47 Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365) 
https://skia.googlesource.com/skia.git/+log/b2f163ae11bf..69a53db434a6

2024-06-12 michaelludwig@google.com [skif] Use FilterResult::rescale() for blur()
2024-06-12 brianosman@google.com Remove SKSL_STANDALONE from SkSLModuleLoader
2024-06-12 ccameron@chromium.org SkGainmapEncoder: Add Exif segment
2024-06-12 brianosman@google.com Remove guard for AAA scan converter intersection bugfix
2024-06-12 brianosman@google.com Fully remove deferred blitting from AAA scan converter
2024-06-12 ccameron@chromium.org SkTiff: Make constants public
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ec3221eef698 to 8489c5749b4b
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9a693759186a to c3c17897c123 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 02:31:52 +00:00
Jonah Williams
673ff9c03b [Impeller] Move Gradient tests to display list. (flutter/engine#53345) 
Migrate almost all of the gradient unittests to display list. Removes tests for disabled dithering and the dithering flag, as it has not been possible to disable dithering on gradients for months and months.

Part of https://github.com/flutter/flutter/issues/142054
 2024-06-13 01:49:57 +00:00
skia-flutter-autoroll
72373a1c04 Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 01:10:52 +00:00
skia-flutter-autoroll
f16b85fc15 Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357) 
https://skia.googlesource.com/skia.git/+log/be6a57569a92..b2f163ae11bf

2024-06-12 robertphillips@google.com [graphite] Rearrange code to match exposed Precompile API
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from efa3591618f5 to 9a693759186a (6 revisions)
2024-06-12 robertphillips@google.com [graphite] Begin exposing Precompilation API
2024-06-12 bungeman@google.com Add needed include to SkPathRef.cpp
2024-06-12 bungeman@google.com Remove SkScalerContextRec::fPaintGamma

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-13 00:38:05 +00:00
Victoria Ashworth
b6f5261c79 Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355) 
Allow Mac mac_host_engine tests to run for up to 90 minutes (previously assumed 60) and allow the tests to run on Mac-14. This should give the test more time when it needs to do additional tasks like install Xcode.

Timeout was recently added in https://flutter-review.googlesource.com/c/recipes/+/57980.

Timeout tested in https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/941415/infra (timeout set to 4 minutes).

Fixes https://github.com/flutter/flutter/issues/150011.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-13 00:36:19 +00:00
John McDole
2a344eafcf 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362) 
This is a modified planet shader from the SimonDev's "GLSL Shaders from Scratch" course on teachables. With permission from Simon:

> 100% use however you want, with or without credit

I choose "with credit".

https://github.com/flutter/engine/assets/1924313/47da62b5-6b6d-47c2-ac9f-f3a33f177a86
 2024-06-13 00:32:42 +00:00
skia-flutter-autoroll
44b391bfa9 Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353) 
https://skia.googlesource.com/skia.git/+log/1ba0c3ebc7a5..be6a57569a92

2024-06-12 nathanasanchez@google.com Add storage buffer implementation for many stop gradients

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-12 14:37:10 +00:00
skia-flutter-autoroll
a9bb4d26dd Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352) 
https://dart.googlesource.com/sdk.git/+log/24fbead7105d..aa2265e5a192

2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-12 14:00:24 +00:00
skia-flutter-autoroll
06661750ee Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351) 
https://skia.googlesource.com/skia.git/+log/52d829ac6a0b..1ba0c3ebc7a5

2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ec3221eef698 to 3e4b1b489466 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-12 10:47:11 +00:00
skia-flutter-autoroll
d796bea4b1 Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348) 
https://dart.googlesource.com/sdk.git/+log/b61536f05f99..24fbead7105d

2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-253.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-12 06:58:21 +00:00
skia-flutter-autoroll
d1e112759b Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347) 
https://dart.googlesource.com/sdk.git/+log/269125c33a35..b61536f05f99

2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-252.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-12 02:46:56 +00:00
Jonah Williams
c6a811e2e5 [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322) 
Otherwise should be semantically equivalent/no-op.
 2024-06-12 02:14:00 +00:00
skia-flutter-autoroll
d791caa8c3 Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 23:56:05 +00:00
skia-flutter-autoroll
d0aaa2006f Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344) 
https://dart.googlesource.com/sdk.git/+log/ab4d5a0b789d..269125c33a35

2024-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-251.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 22:44:18 +00:00
gaaclarke
41f2a43998 [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320) 
fixes https://github.com/flutter/flutter/issues/149946

depends on:
- https://skia-review.googlesource.com/c/skcms/+/864516
- https://skia-review.googlesource.com/c/skia/+/864536

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-11 22:34:19 +00:00
skia-flutter-autoroll
577c5a5761 Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343) 
https://skia.googlesource.com/skia.git/+log/af907b24d873..51eabd0d1e44

2024-06-11 sky@google.com SkPath: optimize reading paths

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 22:23:15 +00:00
Jonah Williams
6ac4449341 [Impeller] add missing position to exp canvas text. (flutter/engine#53339) 
This was missing when I wired up subpixel alignment for the regualr canvas, causing glyphs to not be found with experimental canvas.

Part of https://github.com/flutter/flutter/issues/142054
 2024-06-11 21:46:46 +00:00
skia-flutter-autoroll
0e934c882c Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341) 
https://skia.googlesource.com/skia.git/+log/4cbc1129e587..af907b24d873

2024-06-11 ccameron@chromium.org SkGainmapEncoder: Add MP extensions to all individual images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 21:03:22 +00:00
Yegor
c3f77aa187 Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (… (flutter/engine#53342) 
…#53134)"

This reverts commit f1978535f0355491a67a07ddaf87297361e90d83.

Reverting because the engine PR landed prematurely. It needs to wait for
a framework change, otherwise, things will break.
 2024-06-11 13:27:53 -07:00
Jonah Williams
b73c18158a [Impeller] move some tests from aiks to display list. (flutter/engine#53336) 
Move some tests to display list so we can cover them in experimental canvas. 

Part of https://github.com/flutter/flutter/issues/142054
 2024-06-11 20:10:01 +00:00
Jason Simmons
593a9d0da5 Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 19:08:22 +00:00
Yegor
f1978535f0 [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 
Stop using `SemanticsAction.didGain/LoseAccessibilityFocus` on the web, start using `SemanticsAction.focus`. This is because on the web, a11y focus is not observable, only input focus is. Sending `SemanticsAction.focus` will guarantee that the framework move focus to the respective widget. There currently is no "unfocus" signal, because it seems to be already covered: either another widget gains focus, or an HTML DOM element outside the Flutter view does, both of which have their respective signals already.

More details in the discussion in the issue https://github.com/flutter/flutter/issues/83809.

Fixes https://github.com/flutter/flutter/issues/83809
Fixes https://github.com/flutter/flutter/issues/148285
Fixes https://github.com/flutter/flutter/issues/143337
 2024-06-11 18:41:49 +00:00
skia-flutter-autoroll
3d2fa03445 Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 
https://dart.googlesource.com/sdk.git/+log/282b3347dc3e..ab4d5a0b789d

2024-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-250.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 18:28:14 +00:00
Brandon DeRosier
f6559124a1 [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 
Part of https://github.com/flutter/flutter/issues/145011.

This gets Flutter GPU working on Android.
 2024-06-11 11:25:29 -07:00
skia-flutter-autoroll
7bc9e4533b Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 
https://skia.googlesource.com/skia.git/+log/cd2249d1ba33..b5f974ec2dcd

2024-06-11 bungeman@google.com [pdf] Have DM set producer
2024-06-11 nathanasanchez@google.com Add epsilon to linear gradient
2024-06-11 aaclarke@google.com Fixed destination pixel format when png encoding bgra10_xr.
2024-06-11 brianosman@google.com Remove all skpbench jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 18:11:58 +00:00
Jonah Williams
51c8b05cff [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 
This was an early attempt to support batching that ended up not being important, as well as an attempted work around for high memory reads that ended being unrelated (it was blending)

Since its not a performance improvement and just makes things more complicated, remove the feature.
 2024-06-11 17:36:22 +00:00
skia-flutter-autoroll
c3bf7cd875 Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 
https://skia.googlesource.com/skia.git/+log/67c3ee616fb5..cd2249d1ba33

2024-06-11 bungeman@google.com Revert "Manual roll of skp"
2024-06-11 robertphillips@google.com Disable custommesh_cs_uniforms on Pixel3a (due to crash)
2024-06-11 scroggo@google.com Skia.org: Provide info on how to capture SKPs
2024-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 5d9221d28f9c to bc467ef5ef35 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-11 16:52:56 +00:00
Jonah Williams
acf48b5a05 [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 
From the issue, it looks like an NPE in this closure, we're not sure what else it could be besides the weak ptr - which could be null.

Fixes https://github.com/flutter/flutter/issues/149895
 2024-06-11 16:48:03 +00:00