5757 Commits

Author SHA1 Message Date
Ian Hickson
94636bd206 Cleanup based on new lints (#4052) 2016-05-20 14:08:46 -07:00
Ali Ghassemi
4052aa7157 Merge pull request #4078 from aghassemi/contributing-fixes
Small fixes to contributing documentation.
2016-05-20 14:04:21 -07:00
Ali Ghassemi
705b5d12ad spinning_square.dart -> widgets/spinning_square.dart 2016-05-20 13:53:18 -07:00
Ali Ghassemi
53c86e0d94 Small fixes to contributing documentation.
- Using widgets/spinning_square.dart instead of non-existing
  examples/widgets for the `run -t` example
 - travis/test.sh -> dev/bots/test.sh
 - Couple of style changes.
2016-05-20 13:10:28 -07:00
Todd Volkert
3042da9f6d Prefer getAdbPath(androidSdk) over androidSdk.adbPath (#4076)
For developers with the platform tools installed but no SDK, it prevents
crashing in the flutter tool in favor of more user-friendly error messages
downstream.
2016-05-20 10:45:35 -07:00
Mitch Rudominer
719add8171 New Material Design calculator example. (#3999)
* New Material Design calculator example. (Attempt 2 after git fetch upstream).

* Responded to code review.

* Second round of code review.
2016-05-20 10:27:03 -07:00
Phil Quitslund
2a9994d0b1 Merge pull request #4069 from pq/master
Rev the dart sdk to 1.17.0-dev.4.1
2016-05-20 09:17:24 -07:00
pq
bd92db4d4f Rev the dart sdk to 1.17.0-dev.4.1
Keeps up with the Joneses, pulling in the latest dev build (and with it a number of stability and perf improvements).
2016-05-20 09:05:38 -07:00
Hans Muller
b4ecaaa9f6 Enable the gallery smoke test (#4060) 2016-05-19 17:12:35 -07:00
Chinmay Garde
6f365d33ac Update engine revision to pull in Dart gen_snapshot fixes. (#4057) 2016-05-19 14:24:39 -07:00
Adam Barth
8283d05eb5 Tabs and scrolling has odd card text (#4019)
Looks like our intent here was to show the tab label rather than
"Instance of '_Page'".

Also, fix an issue where the scrollableKey wasn't being forwarded to the
actual scrollable.

Fixes #3090
2016-05-19 14:13:43 -07:00
Devon Carew
3b3b0ff1bb make sdb getprop less verbose (#4053) 2016-05-19 14:10:09 -07:00
Devon Carew
95f838b072 Update trace.dart (#4055) 2016-05-19 14:06:40 -07:00
Phil Quitslund
3693a7c303 Merge pull request #4054 from pq/overriden_field
Fix analyzer field overrides.
2016-05-19 13:43:27 -07:00
Viktor Lidholt
0bbb25b25a Adds missing Flutter Sprites API docs and improved README (#4022) 2016-05-19 13:37:29 -07:00
pq
2a9d2b5f30 Fix analyzer field overrides.
Cleans up 3 of the 4 violations of the `overriden_field` lint.

The last one is more interesting and I'll defer to someone closer to that code:

    [lint] Do not override fields. (packages/flutter/test/rendering/rendering_tester.dart, line 91, col 14)
2016-05-19 13:12:04 -07:00
Eric Seidel
880f2f785e flutter test now works on mac as well as linux
@chinmaygarde
2016-05-19 13:10:15 -07:00
Devon Carew
a48b063a10 rebuild when the build type changes (#4032)
* rebuild when the build type changes

* handle local engine builds

* also check the timestamp
2016-05-19 12:49:40 -07:00
Hans Muller
589cd0bb67 correct Block scrollableKey plumbing (#4048) 2016-05-19 12:44:16 -07:00
Chinmay Garde
199f24ad3d Roll engine to pull in fixes to the standalone shell on Mac. (#4028) 2016-05-19 11:46:44 -07:00
Phil Quitslund
8109bde6e3 Merge pull request #4036 from pq/comment_refs
Cleanup dangling comment references.
2016-05-19 11:19:55 -07:00
Devon Carew
0b5072c2ef fix check to ignore bots (#4034) 2016-05-19 10:51:31 -07:00
pq
1a6f499bc1 Cleanup dangling comment references.
Quick pass at fixing a few dangling references as revealed by the new `comment_references` lint (https://github.com/dart-lang/linter/issues/240).

There's a bunch more to do here before we can turn it on by default (~430 lints as of now).  Many of them are a simple matter of adding an import (e.g., `dart:async` for library docs that reference `Future`) but others will require a bit of thought.  Probably best done by the folks writing the code. :)
2016-05-19 10:21:38 -07:00
Chinmay Garde
376cb2eb38 Attach standard streams of the child sky_shell process so that logs from the shell show up. (#4024) 2016-05-18 16:58:46 -07:00
Ian Hickson
07719ad5ba Improve error reporting (#4025)
Don't suggest filing an issue when we can definitively say that the
assertion in question was not thrown from within the flutter package.
Fixes https://github.com/flutter/flutter/issues/3812.

Put the stack trace first after the message, with more details below the
stack trace, since the stack is often very useful and the stacks are no
longer stupidly long.

Better document the 'rescheduling' feature, and improve the error
handling asserts when it is misused.
Fixes https://github.com/flutter/flutter/issues/3888.

Improve the wording around the stack dump for exceptions during
callbacks.

Improve the color and font size of messages in live tests.
Fixes https://github.com/flutter/flutter/issues/4018.
2016-05-18 16:39:27 -07:00
Adam Barth
69311c28ba Improve date picker fidelity (#4023)
This patch updates the date picker to match the new spec.

We're still missing a fade effect when scrolling from one month to
another and we're missing the landscape layout.

Fixes #3558
2016-05-18 16:01:47 -07:00
Ian Hickson
ef563c485e Handle stack traces that don't give column numbers (#4016) 2016-05-18 12:34:43 -07:00
Ian Hickson
dacfdb64cf Track fake pointers in live test runs (#4011) 2016-05-18 12:09:39 -07:00
Phil Quitslund
80ed23e9ae Merge pull request #4015 from pq/linter_0_1_17
Update to new analyzer and linter.
2016-05-18 12:00:58 -07:00
pq
addc888926 Update to new analyzer and linter.
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
2016-05-18 11:47:44 -07:00
pq
7163cf115d Revert "Update to new analyzer and linter."
This reverts commit f91cf1c4505e1e8f20ade7aad865c938a6ac2054.
2016-05-18 11:45:25 -07:00
pq
f91cf1c450 Update to new analyzer and linter.
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
2016-05-18 11:44:43 -07:00
Ian Hickson
942ccc5cb0 Try to simplify our bot setup. (#3986)
This moves all the bot-related files to `dev/bots`, hiding it from our
home page in github. Also, simplifies the travis setup, though that
doesn't do any difference to the performance sadly.
2016-05-18 11:38:45 -07:00
Ian Hickson
06043b0585 Revert latest engine roll. (#4012)
The latest engine roll caused a performance regression: https://github.com/flutter/flutter/issues/4005
2016-05-18 11:15:03 -07:00
Adam Barth
c1dfbd274b Not every month begins on a Monday (#4004)
Also, clean up the DatePicker to use more modern technology, such as a
grid for displaying the days of the month.

Fixes #3976
2016-05-18 09:01:15 -07:00
Adam Barth
8294b96f94 Complete dartdocs for painting.dart (#4003) 2016-05-18 09:01:03 -07:00
Adam Barth
4e1108e742 Improve dartdoc comments for gestures.dart (#4000)
Also, make some previously private classes public for better
documentation.
2016-05-17 21:52:08 -07:00
Ian Hickson
d2c8c82f4b Some cleanup of the test framework (#4001)
* Add a "build" phase to EnginePhase for completeness.
* Ignore events from the device during test execution.
* More dartdocs
* Slightly more helpful messages about Timers in verifyInvariants.
* Add widgetList, elementList, stateList, renderObjectList.
* Send test events asynchronously for consistency with other APIs.
* Fix a test that was depending on test events being synchronous (or
  rather, scheduled in a microtask that came before the microtask for
  the completer of the future that the tap() function returned).
2016-05-17 17:12:03 -07:00
Adam Barth
0dafe1a480 Add dartdoc to Tooltip (#3957)
Also, remove several unused configuration options and fix an animation
leak.
2016-05-17 16:02:12 -07:00
Adam Barth
0e8e8bbb24 Finish dartdoc for gestures.dart (#3994) 2016-05-17 15:39:46 -07:00
Jason Simmons
833942788d Update the engine (#3997) 2016-05-17 15:19:41 -07:00
Ian Hickson
b803d187ca Catch async functions passed to setState(). (#3992) 2016-05-17 14:53:17 -07:00
Jason Simmons
fc61060421 Log an error if the Android intent fails during flutter refresh (#3988) 2016-05-17 14:35:11 -07:00
Ian Hickson
f284c1a049 Fix tests (#3977)
Also, make sure that broken tests actually break the bots.

And add a test to make sure that keeps happening.
2016-05-17 12:45:37 -07:00
Jason Simmons
c192a7e4ca Replace the checked flag in DebuggingOptions with the build mode (#3901)
This also fixes some related problems affecting "flutter run":
  * FLXes built during AndroidDevice.startApp need to match the build mode
  * APKs should always be rebuilt if the build mode uses AOT compilation
2016-05-17 12:38:25 -07:00
Matt Perry
0628c64b79 Use KeyboardType.phone for the Gallery app's text demo. (#3983)
BUG=https://github.com/flutter/flutter/issues/3970
2016-05-17 15:36:59 -04:00
Hans Muller
ee3db6e61a Tweaks (#3975)
* ScrollableBuilder tweaks
2016-05-17 12:27:13 -07:00
Adam Barth
e9fe39e5e5 Explicitly specify linear curves (#3973)
We now required the curve parameter for CurvedAnimation.
2016-05-17 11:15:58 -07:00
Phil Quitslund
d6548133ce Merge pull request #3972 from pq/implementation_imports
Re-enable `implementation_imports` lint rule.
2016-05-17 11:15:41 -07:00
Adam Barth
355a1d8ecf Add some docs to gestures.dart (#3966)
Also, add some missing docs to http.dart and widgets.dart.
2016-05-17 11:14:15 -07:00