437 Commits

Author SHA1 Message Date
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
David Shuckerow
f844fadaf3
Reorderable list widget and Material demo (#18374) 2018-07-30 15:21:00 -07:00
xster
cded7efbd0
Fix CupertinoSwitch accessibility (#19927) 2018-07-30 11:18:32 -07:00
Michael Goderbauer
3156c28882
Improve semantics for Drawer-Demo (#19911) 2018-07-30 09:28:24 -07:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Jonah Williams
810a29d663
Semantics framework updates (#18758)
Changes:

- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
2018-07-24 13:10:17 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Jonah Williams
d2d17abeec
Add support for custom semantics actions to Android and iOS. (#18882) 2018-07-19 20:47:21 -07:00
Jonah Williams
a66ea0a628
add textCapitalization property (#19367) 2018-07-19 18:06:44 -07:00
Viet Do
953db753ab
Adding multicolumn cupertino picker to the Gallery. (#19284)
* Add sample of multicolumn picker to Flutter Gallery
* Modify CupertinoPicker to be able to be rendered off-center.
2018-07-18 16:29:26 -07:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const (#19342)" (#19423)
This reverts commit cc1cf13eec6752af992d3db0265cf04cc90bfd13.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const (#19342) 2018-07-16 21:43:48 +02:00
Ian Hickson
418b15354d
Update style for CupertinoRefreshControl. (#19025)
All slivers must start with Sliver (or CupertinoSliver).
All widgets must have a key argument.

Also, some minor tweaks here and there to style and docs.
2018-07-11 15:40:19 -07:00
Chris Bracken
32af169946
Revert "Add segmented control to gallery (#19192)" (#19227)
This appears to trigger an error during AOT snapshot of the gallery as
follows:

```
stdout: [   +6 ms] Building AOT snapshot in release mode (ios-release)...
stdout: [  +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
stdout: [   +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart
stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState
stderr: [        ] class _CupertinoSegmentedControlDemoState extends State {
stderr: [        ] ^
stderr: [  +33 ms] Dart snapshot generator failed with exit code 254
stderr: [        ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254
stdout: [        ] Built to build/aot/.
stdout: [  +10 ms] "flutter aot" took 9,485ms.
```

This reverts commit 9d49ee3bf06e634e53331b544dbb640453f81348.
2018-07-10 14:38:52 -07:00
Natalie Sampsell
9d49ee3bf0
Add segmented control to gallery (#19192)
* Adding segmented control to gallery
2018-07-10 11:17:47 -07:00
Jonah Williams
472bbccf75
Fix both platform system chrome definitions (#18808) 2018-06-26 17:01:46 -07:00
Jonah Williams
d6465c477a
Fix system chrome colors on gallery and definition in iOS (#18735) 2018-06-22 13:51:08 -07:00
amirh
c39f2f26f7
Move the notch computation from the FAB to the BAB. (#18372)
Move the notch computation from the FAB to the BAB.

The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled.
That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB.

This CL uncouples the FAB and the notch computation.
With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate.

This includes multiple breaking changes:
  * Scaffold.setFloatingActionButtonNotchFor is deleted.
  * The ComputeNotch type is deleted.
  * The hasNotch property of BottomAppBar is deleted.
  * The notchMargin property of FloatingActionButton is deleted.

Quick migration guide from the previous API:

| Previous API | New API |
| ------------------|-------------|
| BottomAppBar(hasNotch: false) | BottomAppBar() |
| Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) |
| Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
2018-06-21 15:51:21 -07:00
Greg Spencer
efa2a474ea
Adding HSLColor and color 'within' matchers for HSVColor and HSLColor (#18294)
This adds an HSLColor class which uses a perceptual color space based upon human perception of colored light (as opposed to HSV, which is based on pigment colors).

You can see the difference in the color spaces here: https://en.wikipedia.org/wiki/HSL_and_HSV

I also added a "within" matcher for both HSLColor and HSVColor that will check if the (floating point) color components are within a certain error.

And tests.
2018-06-18 17:11:42 -07:00
Chris Bracken
03b5b1c0bd Check video widget is mounted on call to setState (#18467)
When setState() calls occur asynchronously, it's possible that the
Futures on which they're waiting don't complete until the widget is
offscreen. To avoid this, we check the widget is mounted before calling
setState().
2018-06-13 20:51:53 -07:00
Chris Bracken
2ae48845a8
Revert elimination of Dart 1 (#18460)
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb2. (#18362)
This reverts commit 3daebd0. (#18316)
2018-06-13 12:46:39 -07:00
Alexandre Ardhuin
e45836f271
enable lint avoid_field_initializers_in_const_classes (#18415) 2018-06-13 07:20:18 +02:00
Greg Spencer
6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. (#18362)
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Mehmet Fidanboylu
226f2c1e99
Fix broken asset uris (#18336) 2018-06-09 20:11:08 -07:00
Will Larche
326caa5d22 [Gallery] Updated assets and copy (#18324) 2018-06-09 00:39:27 -07:00
Jonah Williams
d803f02d4f
Add activeIcon property to BottomNavigationBarItem (#18125) 2018-06-07 15:42:54 -07:00
Jonah Williams
0891a1136b
update a11y for material slider (#18005) 2018-06-07 15:41:35 -07:00
Anthony
fc5d44d7ac
Correct RaisedButton to OutlineButton for disabled outline example in buttons demo (#18243) 2018-06-06 17:44:07 -04:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Jonah Williams
49bcda52a2
remove ExcludeSemantics from bottom app bar demo (#18033) 2018-05-31 10:45:07 -07:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)
This reverts commit 3258602073c6a05b1b051fddf644cba92116694b.
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)
Fixes #18028

Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Michael Goderbauer
d5a103402c
Expandable Search (#17629) 2018-05-24 09:30:37 -07:00
Greg Spencer
3c5a7a3005
Make non-global constants have consistent naming (with just _ instead of _k) (#17584)
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this.

Only naming changes to private vars: no logic changes.
2018-05-17 23:04:41 -07:00
Greg Spencer
e4b574d3d3
Cupertino Dialog Changes (#17676)
This replaces abandoned PR #14824 by @ekbiker, and gives it some love.
2018-05-17 22:36:16 -07:00
Greg Spencer
ac67efbc83
Moving API doc asset URLs to point to the new location. (#17697)
I'm moving the assets in the assets-for-api-docs repo to a slightly different location to help with organization in that repo, so this PR points the doc URLs to the new location. The old assets won't be removed until this PR makes its way to the API docs website.

No documentation or code changes here, other than changing doc image URLs.
2018-05-17 09:53:06 -07:00
xster
e8d99d12c4
Fix backdrop demo margin for iPhone X (#17480) 2018-05-10 17:36:20 -07:00
xster
e42c50cf20
Post libtxt/post iOS 11 fidelity fine tuning (#17366) 2018-05-10 17:35:18 -07:00
Hans Muller
eee986b076
Gallery cosmetic updates (#17310) 2018-05-07 09:25:50 -07:00
Konstantin Scheglov
9fe53b0d2b
Export @required from src/widgets/framework.dart (#17208) 2018-05-03 08:50:40 -07:00
Hans Muller
c75db13f18 Fixed a typeO (#17223) 2018-05-02 17:43:32 -07:00
Hans Muller
dba7855de8
Update the gallery BottomAppBar demo (#17177) 2018-05-02 11:18:48 -07:00
Hans Muller
5c2259d505
Cross fade gallery UI front layer (#17064) 2018-04-30 08:23:11 -07:00
Hans Muller
cdb82fce92
Put the backdrop demo controls on the right (#16902) 2018-04-23 17:19:39 -07:00
Jonah Williams
034a663d33
Semantics object support for edge triggered semantics (#16081)
Semantics object support for edge triggered semantics
2018-04-19 17:59:19 -07:00
xster
d05bc9c0e3
Remove UI with the word 'demo' from the gallery (#16767) 2018-04-19 16:53:21 -07:00
Greg Spencer
b83eb465fd
Updating the Chip demo in the Gallery to include all the new types of chips. (#16522)
This chip demo is more interactive than the last one, trying to exercise all of the types of chips for a demo that lets you select different types of "chips" (like tortilla, wood, micro, etc.), and then filter them and select an action on them.
2018-04-19 16:43:22 -07:00
Greg Spencer
5129d8ffa6
Rename Rail to Track, per UX guideline (#16519) 2018-04-12 12:32:30 -07:00
David Shuckerow
5cd825a8dc
Fix performance regression caused by the Bottom App Bar demo (#16389) 2018-04-11 12:01:28 -07:00
Alexander Aprelev
a2951a9a1f Roll engine to ed303c628fe4b322529f8cf01ecb38135a2bab73 (dart roll)
Changes since last roll:
```
ed303c628 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (#4966)
8cd272733 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)" (#4965)
9199b40f2 Revert "Support multiple shells in a single process. (#4932)" (#4964)
6baff4c82 Support multiple shells in a single process. (#4932)
31c5bb427 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)
c8e4c6984 Avoid copying the contents of large platform message responses (#4947)
5ff527295 Update to use new vulkan GrBackendRenderTarget ctor. (#4962)
0c8993a1a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (#4963)
132ebdda8 Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)" (#4961)
11882ab9e Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)
```

Add consts
2018-04-10 20:17:06 -07:00