firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,090 Commits 1 Branch 0 Tags
Commit Graph

42090 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kamil Kras
735958ef9a
Fix typo in CHANGELOG.md (#152543) 2024-08-01 17:20:05 +00:00
Matan Lurey
4ff9462be8
Fix local testing, gradle XML errors, and enable on CI. (#152383) 
TIL you cannot have XML comments before the initial `<?xml` declaration.

Follow-up to https://github.com/flutter/flutter/pull/152326.
 2024-08-01 09:10:45 -07:00
Valentin Vignal
7f4f1a0a62
Fix formatting issues in search_anchor.0_test.dart (#152669) 
Fix formatting issues in `examples/api/test/material/search_anchor/search_anchor.0_test.dart`

Comes from https://github.com/flutter/flutter/pull/152371
Linked to https://github.com/flutter/flutter/issues/130459
 2024-08-01 08:59:17 +00:00
Valentin Vignal
e38f730335
Add tests for search anchor examples (#152659) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/search_anchor/search_anchor.1.dart`
- `examples/api/lib/material/search_anchor/search_anchor.2.dart`
 2024-08-01 08:51:23 +00:00
engine-flutter-autoroll
cd1aae1c47
Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) (#152665) 
4dc94d6f88...7c4a44611a

2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b09d933cd1e to 0486e486778a (2 revisions) (flutter/engine#54273)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 07:33:26 +00:00
engine-flutter-autoroll
6db25c5fdf
Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) (#152663) 
f546fef7d7...4dc94d6f88

2024-08-01 bdero@google.com [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 05:58:53 +00:00
engine-flutter-autoroll
f064c3e5c0
Roll Flutter Engine from 0fbff219c498 to f546fef7d7cd (2 revisions) (#152661) 
0fbff219c4...f546fef7d7

2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) (flutter/engine#54270)
2024-08-01 jonahwilliams@google.com [Impeller] move more aiks tests to DL. (flutter/engine#54260)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 03:55:31 +00:00
engine-flutter-autoroll
c298549f12
Roll Flutter Engine from 32f788823f43 to 0fbff219c498 (5 revisions) (#152658) 
32f788823f...0fbff219c4

2024-07-31 matanlurey@users.noreply.github.com Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264)
2024-07-31 matanlurey@users.noreply.github.com Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262)
2024-07-31 jason-simmons@users.noreply.github.com [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 02:58:04 +00:00
engine-flutter-autoroll
b242de6b74
Manual roll Flutter Engine from 32f788823f43 to ed95b491f260 (3 revisions) (#152654) 
Manual roll requested by zra@google.com

32f788823f...ed95b491f2

2024-07-31 jason-simmons@users.noreply.github.com [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 02:06:25 +00:00
engine-flutter-autoroll
828cc2878d
Manual roll Flutter Engine from 16332725788c to 32f788823f43 (11 revisions) (#152648) 
Manual roll requested by jacksongardner@google.com

1633272578...32f788823f

2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) (flutter/engine#54259)
2024-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... (flutter/engine#54258)
2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: Implement draw order optimization. (#54215)" (flutter/engine#54261)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) (flutter/engine#54257)
2024-07-31 chris@bracken.jp [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54254)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) (flutter/engine#54253)
2024-07-31 matanlurey@users.noreply.github.com Cleanup the shell test, removing unused code (flutter/engine#54238)
2024-07-31 yjbanov@google.com [web] rename dialog to route to match the framework (flutter/engine#54228)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) (flutter/engine#54252)
2024-07-31 bdero@google.com [Impeller] Reland: Implement draw order optimization. (flutter/engine#54215)
2024-07-31 matanlurey@users.noreply.github.com Migrate the remaining real pub packages to pub workspaces. (flutter/engine#54232)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from cYjTzxe0MskG to uF76DfQgigt4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 00:46:08 +00:00
Tong Mu
3303973d99
[CupertinoActionSheet] Make _ActionSheetButtonBackground stateless (#152283) 
This PR is a refactor that makes `_ActionSheetButtonBackground` widgets no longer record their own `pressed` state, but instead receive this state from their parent. In this way, `_ActionSheetButtonBackground` becomes a stateless widget. The children states are duplicate because the parent has to keep track of the state for rendering dividers.

An obstacle with this change is that `_ActionSheetButtonBackground` needs an object that is persistent across rebuilds to provide to `Metadata.data`. Either it is kept as a stateful widget without any actual states, or it is made stateless and its `Element` as the object. After discussion, the first option is used.

`_ActionSheetSlideTarget` is renamed to `_SlideTarget` since the alert dialog will soon use this class as well.

This refactor shouldn't need additional tests. Still, one test is added for a behavior that I broke during development and found not covered by the unit tests then.
 2024-07-31 23:39:25 +00:00
Nate Wilson
788a0e3d2f
Implementing null-aware logic in /packages/flutter/ (#152294) 
Hopefully soon, [flutter.dev/go/dart-patterns](https://flutter.dev/go/dart-patterns) will have lots of good feedback; in the meantime, I'll focus refactoring efforts on uncontroversial things :)

Previously, I was under the impression that I could solve issue #143803 with [just 1 PR](https://github.com/flutter/flutter/pull/143804).
It turns out that I had overlooked quite a bit!

<br>

```dart
// before
if (chunkEvents != null) {
  chunkEvents.listen((ImageChunkEvent event) {
      reportImageChunkEvent(event);
    },
  );
}

// after
chunkEvents?.listen(reportImageChunkEvent);
```
 2024-07-31 23:35:24 +00:00
Andrew Kolos
535e88b092
Reintroduce verbose logging for hot reload flake (#152639) 
Adds some logging to assist with troubleshooting https://github.com/flutter/flutter/issues/152220 (which is a reapperance of flake https://github.com/flutter/flutter/issues/146879) on CI.

TL;DR [the tool sometimes never receives the `IsolateRunnable` event from the vm service after calling `_flutter.runInView`](https://github.com/flutter/flutter/issues/146879#issuecomment-2118629953).
 2024-07-31 23:15:17 +00:00
davidhicks980
d62069ff37
[material/menu_anchor.dart] Remove unused early key event listener (#150915) 
Removes an unused block of code (I think -- I could be wrong but it does not appear to have any effect).
 2024-07-31 22:47:59 +00:00
Victor Sanni
303cbb7cde
Improve CupertinoCheckbox fidelity (#151441) 
**NOTE: Previous [PR](https://github.com/flutter/flutter/pull/148804)
was closed because of a bad merge leading to pollution with unrelated
commits.**

This PR improves on the look and feel of `CupertinoCheckbox` to more
closely match native iOS/macOS checkboxes.

Adds the following updates from a native macOS checkbox:
* Fill color of an unchecked checkbox is a linear gradient that goes
from darker at the top to lighter at the bottom in dark mode
* Size of box reduced from 18.0 to 14.0
* Stroke width of check reduced from 2.5 to 2.0
* Border color changed from solid black to gray black in light mode and
a transparent gray in dark mode
* In light mode, checkbox darkens when pressed
* In dark mode, checkbox lightens when pressed
* Default blue color of a checked checkbox is darker in dark mode

### Light Mode

| Native macOS | Flutter Before | Flutter After |
| ----------- | ----------- | ----------- |
| <img width="63" alt="native checkbox"
src="https://github.com/flutter/flutter/assets/77553258/d57d4c78-2e67-49fb-9491-a5acee3782a7">
| <img width="66" alt="Screenshot 2024-06-27 at 10 23 18 AM"
src="https://github.com/flutter/flutter/assets/77553258/31c913ff-d36f-4eb5-b737-3a9117bd7eff">
| <img width="66" alt="Screenshot 2024-06-27 at 10 39 22 AM"
src="https://github.com/flutter/flutter/assets/77553258/ace8ef29-efae-4049-8f78-13fd39851947">
|

### Dark Mode - Checked

| Native macOS | Flutter Before | Flutter After |
| ----------- | ----------- | ----------- |
| <img width="22" alt="native light"
src="https://github.com/user-attachments/assets/fc52d5e1-7ab0-4a5d-b0fa-5b5bee3ed39d">
| <img width="22" alt="flutter before light"
src="https://github.com/user-attachments/assets/16e033a1-d2dd-4fb2-a5a5-f730c5f7cdc7">
| <img width="22" alt="flutter after light"
src="https://github.com/user-attachments/assets/8c0cff99-930e-4f5e-8540-e64294c1b4fa">
|

### Dark Mode - Unchecked
| Native macOS | Flutter Before | Flutter After |
| ----------- | ----------- | ----------- |
| <img width="22" alt="native dark mode"
src="https://github.com/user-attachments/assets/333280a0-85db-4464-9663-03ef7eafc270">
| <img width="22" alt="flutter before dark mode"
src="https://github.com/user-attachments/assets/a46e01ec-0d0b-4bb7-8d08-4b2723424a12">
| <img width="22" alt="flutter dark mode"
src="https://github.com/user-attachments/assets/a70ae4ad-f1ad-4441-a416-350cbdc32679">
|

### Light Mode - Disabled

| Native macOS | Flutter Before | Flutter After |
| --- | --- | --- |
| <img width="121" alt="native disabled checkbox"
src="https://github.com/user-attachments/assets/ed050d14-efec-49dd-82b6-1e7ed7fa99f9">
| <img width="136" alt="flutter b4 disabled checkbox"
src="https://github.com/user-attachments/assets/564918cf-f936-448d-b975-7bf9248bbf35">
| <img width="156" alt="flutter disabled checkbox"
src="https://github.com/user-attachments/assets/82f672a7-12e8-469c-99af-9f94c959df8f">
|

### Dark Mode - Disabled

| Native macOS | Flutter Before | Flutter After |
| --- | --- | --- |
| <img width="110" alt="disabled dark checkbox native"
src="https://github.com/user-attachments/assets/02a43b3f-5619-4b05-9066-2fd43a58c956">
| <img width="136" alt="disabled dark checkbox flutter b4"
src="https://github.com/user-attachments/assets/3a3db322-2002-4808-adc0-b10a7ab42381">
| <img width="140" alt="disabled dark checkbox flutter"
src="https://github.com/user-attachments/assets/cb91955a-8302-4dc7-8050-221fa2a7045f">

Fixes #148719.

Related PR exploring these changes: #147892

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
 2024-07-31 14:43:20 -07:00
Camille Simon
0b41781c78
Update docs to support new Android version (#152503) 
Includes the following updates:

- Spacing and capitalization fixes for readability
- Corrects instructions on updating AVD dependencies
- Links to engine docs to reduce redundancy
 2024-07-31 20:47:04 +00:00
Camille Simon
c3fbf3dd98
[Android] Update integration test AVD dependency to use Android 35 emulators (#152498) 
Updates AVD dependency to use [latest available AVD dependency](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/I7SIawD0okHpiEe8fKvI5NQrMEWDibsvOduVbbK5pDEC) (actually I'm one behind by the time of publishing--I assume this is ok) so that engine integration tests run on emulators running Android 35, the current latest version of Android.

Updated docs to reflect this is the new way to update this dependency in https://github.com/flutter/flutter/pull/152503.

Kinda part of https://github.com/flutter/flutter/issues/150215 (the original instructions anyway).
 2024-07-31 20:44:56 +00:00
Renzo Olivares
70bda95422
Shift + click gesture support for SelectionArea on desktop platforms (#148574) 
Shift + Click to move the selection end edge on desktop platforms. This is consistent with native Linux and Windows. On macOS the behavior moves the selection edge closest to the tapped position (will implement in a later PR).

Part of: #129583
 2024-07-31 19:58:07 +00:00
Taha Tesser
0d154e55d1
Add ability to clip Stepper step content (#152370) 
fixes [Dismissible content overlays Stepper interface while dismissing it](https://github.com/flutter/flutter/issues/66007)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final List<String> items =
      List<String>.generate(20, (int i) => 'Item ${i + 1}');

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Padding(
          padding: const EdgeInsets.all(20),
          child: DecoratedBox(
            decoration: BoxDecoration(
              border: Border.all(color: Colors.amber, width: 2),
            ),
            child: Padding(
              padding: const EdgeInsets.all(2.0),
              child: Column(
                children: <Widget>[
                  const SizedBox(height: 8.0),
                  Text(
                    'Dismissible Widget - Vertical Stepper Widget',
                    style: Theme.of(context).textTheme.titleLarge,
                  ),
                  Expanded(
                    child: Stepper(
                      clipBehavior: Clip.hardEdge,
                      steps: <Step>[
                        Step(
                          isActive: true,
                          title: const Text('Step 1'),
                          content: ColoredBox(
                            color: Colors.black12,
                            child: ListView.builder(
                              itemCount: items.length,
                              shrinkWrap: true,
                              itemBuilder: (BuildContext context, int index) {
                                final String item = items[index];
                                return Dismissible(
                                  key: Key(item),
                                  onDismissed: (DismissDirection direction) {
                                    setState(() {
                                      items.removeAt(index);
                                    });
                                    ScaffoldMessenger.of(context).showSnackBar(
                                        SnackBar(
                                            content: Text('$item dismissed')));
                                  },
                                  background: Container(color: Colors.red),
                                  child: ListTile(title: Text(item)),
                                );
                              },
                            ),
                          ),
                        ),
                        const Step(
                          title: Text('Step 2'),
                          content: Text('content'),
                        ),
                      ],
                    ),
                  ),
                  const Divider(height: 1),
                  const SizedBox(height: 8.0),
                  Text(
                    'Dismissible Widget - Horizontal Stepper Widget',
                    style: Theme.of(context).textTheme.titleLarge,
                  ),
                  Expanded(
                    child: Stepper(
                      clipBehavior: Clip.hardEdge,
                      type: StepperType.horizontal,
                      elevation: 0.0,
                      steps: <Step>[
                        Step(
                          isActive: true,
                          title: const Text('Step 1'),
                          content: ColoredBox(
                            color: Colors.black12,
                            child: ListView.builder(
                              itemCount: items.length,
                              shrinkWrap: true,
                              itemBuilder: (BuildContext context, int index) {
                                final String item = items[index];
                                return Dismissible(
                                  key: Key(item),
                                  onDismissed: (DismissDirection direction) {
                                    setState(() {
                                      items.removeAt(index);
                                    });
                                    ScaffoldMessenger.of(context).showSnackBar(
                                        SnackBar(
                                            content: Text('$item dismissed')));
                                  },
                                  background: Container(color: Colors.red),
                                  child: ListTile(title: Text(item)),
                                );
                              },
                            ),
                          ),
                        ),
                        const Step(
                          title: Text('Step 2'),
                          content: Text('content'),
                        ),
                      ],
                    ),
                  ),
                ],
              ),
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Without `Stepper` step content clipping

![Group 1](https://github.com/user-attachments/assets/1814ad90-8d43-4e03-9f68-7da47e08c718)

### With `Stepper` step content clipping

![Group 2](https://github.com/user-attachments/assets/652ff597-7e9a-4d35-abc2-80d60cee03f4)
 2024-07-31 19:58:04 +00:00
Mitchell Goodwin
91a3f69f11
Calendar font factor (#152341) 
Increases the max text can be scaled for the date picker in calendar mode and input mode. Previously the max across the whole widget was 1.3. Due to the size of the widget, this was increased as much as possible with different values used in different places. Testing and screenshots where taken on the iPhone SE 3rd generation simulator, set at max font size, which is a value of 3.0. Android has a lower max font scale value of 2.0, and the iPhone SE is about the smallest phone with a lower pixel density ratio.

Fixes internal issues b/316958515 and b/316959677 
Also fixes #61334

Comparison for calendar mode in portrait and landscape:

| Before    | After |
| -------- | ------- |
| <img width="375" alt="Old-SE-Portrait-DayPicker" src="https://github.com/user-attachments/assets/4dd1735f-f4c7-4a0a-b8d3-e5ea84d2ba3c"> | <img width="376" alt="Screenshot 2024-07-25 at 1 25 41 PM" src="https://github.com/user-attachments/assets/a53d7d68-87ef-4b29-9479-36ef22bd6cc9"> |
| <img width="375" alt="Old-SE-Portrait-YearPicker" src="https://github.com/user-attachments/assets/37c2965d-1ec0-429b-aa4d-37396f90cb74"> | <img width="377" alt="Screenshot 2024-07-25 at 1 26 38 PM" src="https://github.com/user-attachments/assets/2a00d90f-d523-4ff5-a1d7-e1bfafb245d3"> |
| <img width="665" alt="Old-SE-Landscape-DayPicker" src="https://github.com/user-attachments/assets/1cc4cd26-d56a-4f35-88b1-1c13fa460c2f"> | <img width="665" alt="Screenshot 2024-07-25 at 1 25 52 PM" src="https://github.com/user-attachments/assets/729ac66c-d6b9-4a2a-8303-b5c9face0f62"> |
| <img width="664" alt="Old-SE-Landscape-YearPicker" src="https://github.com/user-attachments/assets/f00a9ab8-1925-4c33-bfcc-31020b2858b8"> | <img width="666" alt="Screenshot 2024-07-25 at 1 26 47 PM" src="https://github.com/user-attachments/assets/d6116c20-4862-4e07-8ab4-fb8ecb71bfa5"> |

The title text is smaller when the entry mode button is available:
<img width="374" alt="Screenshot 2024-07-25 at 1 24 52 PM" src="https://github.com/user-attachments/assets/83305c11-97d5-4986-bf51-fe0be71f653e">

Adjustments were made to input mode as well, but they are simpler

<img width="372" alt="Screenshot 2024-07-25 at 1 43 39 PM" src="https://github.com/user-attachments/assets/2440cf6f-160f-4689-978e-d0a3df2db102">
<img width="666" alt="Screenshot 2024-07-25 at 1 43 48 PM" src="https://github.com/user-attachments/assets/e8d8dbf3-c7d8-4668-9245-7b5036165e75">

Date range picker was not adjusted with this PR. It still has a max of 1.3.
 2024-07-31 19:56:15 +00:00
Ian Hickson
a5609dfa5a
Remove redundant usages of zones in skia_client.dart (#149366) 
The SkiaGoldHttpOverrides don't have any effect since we never build our own HttpClient, it's always passed in.

This is part 18 of a broken down version of the #140101 refactor.

This particular change is more risky than other changes in this series. While by inspection and some instrumentation testing I'm reasonably sure that my assumptions here are correct, it would behoove us to make sure Skia Gold testing still works post-commit after this lands. To this end, I've included a change to the "inconsequential" test. It should fail the tests. I recommend we land this _with this failure_ to make sure it also fails post-commit, then immediately flag the image as passing and rerun the relevant shard.
 2024-07-31 19:52:08 +00:00
Gray Mackall
a1f03609f7
Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (#151568) 
Sets up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range.

Post submit only, because the suite takes ~30 minutes to run, and I expect it to be _somewhat_ rare that we break only one of these versions (and therefore it doesn't get caught by existing presubmits).
 2024-07-31 19:14:46 +00:00
Andrew Kolos
118a015b65
remove bringup from Windows tool_integration_tests_* (#152599) 
Followup to https://github.com/flutter/flutter/pull/152582
 2024-07-31 19:12:37 +00:00
Aliasgar Vohra
836e794b46
✨ : Animation controller now has ability to repeat animation 'n' no. of times. (#150764) 
Right now animation controller does not have any way by which user can repeat animation with specific no. of times. Adding the changes in existing `repeat` method in which users can specific no. of times they want to repeat the animation. If not specified, it would simulate infinitely. [Existing repeat behaviour]

This PR fixes : https://github.com/flutter/flutter/issues/53262
 2024-07-31 18:19:56 +00:00
engine-flutter-autoroll
fdb8ebfeac
Roll Flutter Engine from 3b31b21599d1 to 16332725788c (1 revision) (#152631) 
3b31b21599...1633272578

2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from 999e3f113dbf to e9e423457655 (1 revision) (flutter/engine#54251)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 17:36:32 +00:00
engine-flutter-autoroll
86a4c93997
Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (#152625) 
b73367a30e...3b31b21599

2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (flutter/engine#54250)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241)
2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239)
2024-07-31 chris@bracken.jp [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 16:40:10 +00:00
engine-flutter-autoroll
14a607cbab
Roll Packages from 99e860679a9a to 46a712f38301 (8 revisions) (#152622) 
99e860679a...46a712f383

2024-07-31 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds initial iOS implementation (flutter/packages#7063)
2024-07-31 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#6770)
2024-07-31 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/interactive_media_ads/android (flutter/packages#7238)
2024-07-30 tarrinneal@gmail.com [shared_preferences] full api redesign with DataStore and cache-less interface (flutter/packages#5210)
2024-07-30 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.browser:browser from 1.5.0 to 1.8.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6811)
2024-07-30 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.1.0 to 6.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6413)
2024-07-30 51940183+Sameri11@users.noreply.github.com [path_provider] fix 151823: update minimum required path_provider_android to 2.2.0 (flutter/packages#7181)
2024-07-30 tarrinneal@gmail.com [shared_preferences] Platform implementations of async api (flutter/packages#6965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 15:41:10 +00:00
Valentin Vignal
27e53c813c
Add tests for scaffold messenger examples (#152536) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/scaffold/scaffold_messenger.0.dart`
- `examples/api/lib/material/scaffold/scaffold_messenger.of.0.dart`
- `examples/api/lib/material/scaffold/scaffold_messenger.of.1.dart`
 2024-07-31 14:59:13 +00:00
Valentin Vignal
99e201e2ef
Add test for search_anchor.0.dart (#152371) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/search_anchor/search_anchor.0.dart`
 2024-07-31 13:28:08 +00:00
Bruno Leroux
1a8e57f42e
Use decoration hint text as the default value for dropdown button hints (#152474) 
## Description

This PR makes `DropdownButtonFormField` hint defaults to the provided inputDecoration hintText.

Because `DropDownButtonFormField` accepts both a `hint` parameter and a `decoration`parameter, one can expect `InputDecoration.hintText` to be valid.

Before this PR, when `InputDecoration.hintText` was specified, it is shown but the vertical position is wrong.
After this PR, when `InputDecoration.hintText` is specified, it is used as the default value for `DropDownButtonFormField.hint` and `DropDownButtonFormField.disabledHint`.

| Before | After |
|--------|--------|
| ![image](https://github.com/user-attachments/assets/a08ff75c-edd4-4e16-9cfa-98ddb349d860) | ![image](https://github.com/user-attachments/assets/55f08bee-8f88-4125-8fae-68e2be724955) |

## Related Issue

Fixes https://github.com/flutter/flutter/issues/111958.

## Tests

Adds 5 tests.
 2024-07-31 11:22:26 +00:00
Bruno Leroux
0c6b600e76
Deprecate invalid InputDecoration.collapsed parameters (#152486) 
## Description

This PR is a follow up to https://github.com/flutter/flutter/pull/152165#pullrequestreview-2200072459.
It deprecates two parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) to `InputDecoration.collapsed`. Those parameters are related to the floating label but a collapsed input decoration is not supposed to have labels.

For the dart_fix, I created a new fix file and moved some previous fixes to it.

## Tests

Adds 1 test, updates 1.
 2024-07-31 07:59:41 +00:00
Andrew Kolos
7133a89c44
increase sharding on Windows tool_integration_tests (#152582) 
Resolves https://github.com/flutter/flutter/issues/152211

Will remove `bringup` status after this merges.
 2024-07-31 06:52:06 +00:00
engine-flutter-autoroll
6eceedd769
Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) (#152592) 
e2ece7e584...b73367a30e

2024-07-31 jason-simmons@users.noreply.github.com Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235)
2024-07-31 chris@bracken.jp [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237)
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236)
2024-07-30 1961493+harryterkelsen@users.noreply.github.com enumify ImageType and ImageFileSignature (flutter/engine#54131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 02:46:18 +00:00
engine-flutter-autoroll
14b51b498f
Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) (#152589) 
0b42657a18...e2ece7e584

2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from e8fb6f320da0 to b6036baeebbd (3 revisions) (flutter/engine#54234)
2024-07-30 chinmaygarde@google.com [Impeller] Use linear sampling to sample from AHB textures in Vulkan. (flutter/engine#54233)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 01:29:30 +00:00
engine-flutter-autoroll
357599b58a
Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) (#152586) 
08f9be3ab2...0b42657a18

2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 4e31906b6312 to e8fb6f320da0 (5 revisions) (flutter/engine#54229)
2024-07-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Do not disable partial repaint based on thread merging state (#54219)" (flutter/engine#54230)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 00:23:10 +00:00
Matan Lurey
888149f9f5
Clarify and cleanup the test-exemption wording in tree-hygiene. (#152402) 
Based off a [discussion on
Discord](https://discord.com/channels/608014603317936148/608018585025118217/1266501306852446421),
but I've also anecdotally had a few people ask this before.

Other than a bit of reformatting, I wanted to clarify that the PR
reviewer should still _agree_ an exemption is needed (i.e. not defer
this responsibility entirely to our small volunteer staff of reviewers),
and that _all_ reviewers should feel empowered to push back, and not
wait for a test exemption reviewer to do it. This [matches the guidance
in the
bot](f1b20b6e4c/app_dart/lib/src/service/config.dart (L253-L255)).

If this change LGTY I can make a [minor change to the Github
bot](f1b20b6e4c/app_dart/lib/src/service/config.dart (L239-L255))
as well.
 2024-07-30 16:53:54 -07:00
David Iglesias
111b4fe6d1
[web] Set COEP:credentialless on flutter run/drive. (#152413) 
This PR changes the value of the `COEP` response header from `require-corp` to `credentialless` in the Flutter tool, when running `flutter run`/`drive` for Web projects.

This enables running tests compiled to wasm, that access 3P resources (like Google Maps) without blocking those resources.

Docs:

* https://developer.chrome.com/blog/coep-credentialless-origin-trial#credentialless_to_the_rescue

## Issue

* https://github.com/flutter/flutter/issues/152411
 2024-07-30 23:14:06 +00:00
engine-flutter-autoroll
4778895036
Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) (#152583) 
a4b88a37d5...08f9be3ab2

2024-07-30 chris@bracken.jp [iOS] Delete unused create_ios_framework.py (flutter/engine#54227)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226)
2024-07-30 jonahwilliams@google.com [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200)
2024-07-30 matej.knopp@gmail.com Do not disable partial repaint based on thread merging state (flutter/engine#54219)
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 22:59:04 +00:00
Flutter GitHub Bot
9bf8a283aa
Marks Mac platform_channel_sample_test_macos to be flaky (#151884) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac platform_channel_sample_test_macos"
}
-->
Issue link: https://github.com/flutter/flutter/issues/151883
 2024-07-30 22:50:59 +00:00
engine-flutter-autoroll
ccb58a9cef
Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) (#152575) 
a6c5ff26c2...a4b88a37d5

2024-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QsN_RyaTWxm-8AD47... to cYjTzxe0MskG7PtkB... (flutter/engine#54223)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from c1fcf8e5a55c to b9b208f11c67 (2 revisions) (flutter/engine#54222)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from QsN_RyaTWxm- to cYjTzxe0MskG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 21:20:25 +00:00
hangyu
dc6a15995e
Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. (#152526) 
https://github.com/flutter/flutter/pull/151599 was reverted because it was a breaking change to g3

Will reland 151599 in 5 steps 
1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false)  
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly.
3. Send a PR to flip the default value to true.
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.

 (<----This PR is step 1)
 2024-07-30 20:38:06 +00:00
Zachary Anderson
5f460e10fc
Shift macOS/Android tests from Pixel 7 to mokey in staging (#152571) 
Part of https://github.com/flutter/flutter/issues/148085
 2024-07-30 12:48:34 -07:00
engine-flutter-autoroll
6a368d8680
Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) (#152573) 
31bb9f9847...a6c5ff26c2

2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from a4d59988bde0 to c1fcf8e5a55c (1 revision) (flutter/engine#54220)
2024-07-30 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] Use downsample shader for blur instead of mip levels. (flutter/engine#54149)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 2cb7f5443a48 to a4d59988bde0 (1 revision) (flutter/engine#54218)
2024-07-30 30870216+gaaclarke@users.noreply.github.com [Impeller] makes the gaussian down sample scalar fixed by adjusting the downsample padding (flutter/engine#54150)
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from ad4d2e8b2c65 to 14b51d32e3a6 (1 revision) (flutter/engine#54216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 18:56:35 +00:00
engine-flutter-autoroll
5a47cfb3b0
Roll Packages from 247fb5f0b7e7 to 99e860679a9a (5 revisions) (#152567) 
247fb5f0b7...99e860679a

2024-07-29 andrelvsousa@gmail.com [video_player_android] Add RTSP support (flutter/packages#7081)
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.3.1 to 1.4.0 in /packages/video_player/video_player_android/android (flutter/packages#7241)
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/camera/camera_android/android (flutter/packages#7236)
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/path_provider/path_provider_android/android (flutter/packages#7244)
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/packages#7234)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 17:53:10 +00:00
Taha Tesser
cd60efc618
Fix default avatar icon theme size for Material 2 (#152307) 
fixes [ActionChip avatar still does not respect padding](https://github.com/flutter/flutter/issues/116508)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(brightness: Brightness.dark, useMaterial3: false),
      home: Scaffold(
        body: Center(
          child: Builder(
            builder: (BuildContext context) {
              return Chip(
                padding: const EdgeInsets.all(16.0),
                avatar: const Icon(Icons.favorite),
                label: const Text('Chip A'),
                onDeleted: () {},
              );
            },
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before

<img width="490" alt="Screenshot 2024-07-25 at 16 24 08" src="https://github.com/user-attachments/assets/45408aa2-b3ab-4ff9-ae72-53a91c87c76a">

### After

<img width="490" alt="Screenshot 2024-07-25 at 16 23 56" src="https://github.com/user-attachments/assets/07ba367d-9ca3-46cc-8122-d1155dd2f32b">
 2024-07-30 16:44:08 +00:00
engine-flutter-autoroll
61848a448b
Roll Flutter Engine from c58d87d62c20 to 31bb9f98472a (8 revisions) (#152555) 
c58d87d62c...31bb9f9847

2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 1339015537a3 to 2cb7f5443a48 (4 revisions) (flutter/engine#54212)
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ab9452297e0 to ad4d2e8b2c65 (1 revision) (flutter/engine#54211)
2024-07-30 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/engine#54208)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 20e4dfabb6b2 to 1339015537a3 (1 revision) (flutter/engine#54207)
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from e8eca6f05494 to 6ab9452297e0 (1 revision) (flutter/engine#54206)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 56de22c39d0e to 20e4dfabb6b2 (1 revision) (flutter/engine#54205)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 946ca24d03ab to 56de22c39d0e (1 revision) (flutter/engine#54204)
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 8167ff71af2c to 946ca24d03ab (2 revisions) (flutter/engine#54202)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 16:42:10 +00:00
Bruno Leroux
85960d24b9
Fix Shortcut label for CharacterActivator does not include modifiers (#152233) 
## Description

This PR fixes the shortcut label for CharacterActivator with modifiers keys.

**Before**:

![image](https://github.com/user-attachments/assets/1cb8defe-2600-45ef-878d-fbdde5aaf2ad)

**After**:

![image](https://github.com/user-attachments/assets/cd3b1c79-2f23-40fd-b0b9-934fa182fff3)

## Related Issue

Fixes https://github.com/flutter/flutter/issues/145040.

## Tests

Adds 1 test.
 2024-07-30 07:03:00 +00:00
Rexios
dfedcfe702
[wiki] Remove text saying wiki edits do not get code reviewed (#152530) 
Sequel to https://github.com/flutter/flutter/pull/152529
 2024-07-30 03:23:37 +00:00
engine-flutter-autoroll
c71d495fe4
Roll Flutter Engine from cb96743cc955 to c58d87d62c20 (1 revision) (#152527) 
cb96743cc9...c58d87d62c

2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 832023dc041a to 8167ff71af2c (1 revision) (flutter/engine#54199)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 01:55:30 +00:00
Greg Spencer
b05c2fad0c
Add find.backButton finder and StandardComponentType enum to find components in tests. (#149349) 
## Description

This adds `find.backButton()` in the Common Finders to allow finding different types of standard UI elements. It works by attaching a key made from an enum value in a new enum called `StandardComponentType` to all of the standard widgets that perform the associated function.

I also substituted the finder in several places where it is useful in tests.

This allows writing tests that want to find the "back" button without having to know exactly which icon the back button uses under what circumstances.  To do it correctly is actually quite complicated, since there are several adaptations that occur (based on platform, and whether it is web or not).

## Tests
 - Added tests.
 2024-07-30 01:29:31 +00:00