firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
skia-flutter-autoroll
db27cc0525 Roll Dart SDK from 0b09d933cd1e to 0486e486778a (2 revisions) (flutter/engine#54273) 
https://dart.googlesource.com/sdk.git/+log/0b09d933cd1e..0486e486778a

2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-104.0.dev
2024-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-103.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 05:58:52 +00:00
Brandon DeRosier
7105fd1909 [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268) 
This time for sure!

For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.

Attempt 1: #54136
Revert 1: #54067
Attempt 2: #54215
Revert 2: #54261
 2024-07-31 19:30:08 -07:00
skia-flutter-autoroll
49a46647f4 Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) (flutter/engine#54270) 
https://dart.googlesource.com/sdk.git/+log/efabc9163078..0b09d933cd1e

2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-102.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-01 01:50:37 +00:00
Jonah Williams
03a6784db4 [Impeller] move more aiks tests to DL. (flutter/engine#54260) 
Part of https://github.com/flutter/flutter/issues/142054
 2024-08-01 01:31:17 +00:00
Matan Lurey
3a829b81ad Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 
Towards https://github.com/flutter/flutter/issues/152636.

Most of these were via `dart --fix`.
 2024-07-31 22:48:00 +00:00
Matan Lurey
bed7aa4dea Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 
Towards https://github.com/flutter/flutter/issues/152636.

I also deleted some code that was TODO'd 10 years ago.
 2024-07-31 22:47:58 +00:00
Jason Simmons
d103053ca2 [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 
Fixes https://github.com/flutter/flutter/issues/147066
 2024-07-31 22:40:51 +00:00
skia-flutter-autoroll
9a844d0d61 Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 
https://skia.googlesource.com/skia.git/+log/b5ad5bf3696d..8db309541ad9

2024-07-31 michaelludwig@google.com [graphite] Add size to BindBufferInfo
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 5262a9f62fa6 to 0b6aba4d3d73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 22:37:08 +00:00
skia-flutter-autoroll
d2ef670bff Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) 
https://dart.googlesource.com/sdk.git/+log/5df6a6e0c037..efabc9163078

2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-101.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 21:33:22 +00:00
skia-flutter-autoroll
4d50ee08ed Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) (flutter/engine#54259) 
https://skia.googlesource.com/skia.git/+log/431b57332241..b5ad5bf3696d

2024-07-31 scroggo@google.com Update SkQPTestCases for Android V (15) Release
2024-07-31 johnstiles@google.com Remove a forgotten TODO(johnstiles).
2024-07-31 jvanverth@google.com [ganesh] Fix CircularRRectEffect batching.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 20:37:41 +00:00
skia-flutter-autoroll
232c65fdde Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... (flutter/engine#54258) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 20:04:15 +00:00
auto-submit[bot]
fae441f0ef Reverts "[Impeller] Reland: Implement draw order optimization. (#54215)" (flutter/engine#54261) 
Reverts: flutter/engine#54215
Initiated by: bdero
Reason for reverting: Causing golden diffs in framework roll https://flutter-gold.skia.org/search?issue=152633&crs=github&patchsets=2&corpus=flutter
Original PR Author: bdero

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Original PR: #54136
Revert PR: #54067

Includes fixes for issue seen in [these goldens](https://flutter-gold.skia.org/search?issue=152354&crs=github&patchsets=2&corpus=flutter).

The problem was that the scissor was ending up wrong after clip replay for opaque draws that are supposed to occur outside the parent clip scope(s).

To fix it, I made clip replay draws as well as the subpass texture draw apply lazily.
For the clip replay, there's no need to apply a given clip until we come across an entity that has a depth less than or equal to the clip.
And for the subpass texture (which is often translucent), we can defer drawing it until we come across another translucent draw. Deferring the subpass texture is important because if we draw it immediately, then all of the replay clips need to be drawn immediately too.

## Description
For each clip scope, draw opaque items in reverse order and translucent/backdrop-independent items in their original order afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.

### Local new_gallery before/after (iPhone 12 mini):
```
cd ~/projects/flutter/flutter/dev/integration_tests/new_gallery
flutter drive --profile --local-engine-src-path ~/projects/flutter/engine/src --local-engine=ios_profile --local-engine-host=host_profile_arm64 --trace-startup -t test_driver/transitions_perf.dart -d 00008101-000A59A93C10001E
```
![image](https://github.com/user-attachments/assets/7372c128-ca71-44a6-8e6c-b0043025f751)
 2024-07-31 19:59:48 +00:00
skia-flutter-autoroll
a99fbaa228 Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) (flutter/engine#54257) 
https://skia.googlesource.com/skia.git/+log/cd58e87c06f9..431b57332241

2024-07-31 nathanasanchez@google.com [Graphite] Gradient buffer optimization
2024-07-31 kjlubick@google.com Address clang-tidy suggestion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 19:13:33 +00:00
Chris Bracken
c7af1aef53 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54254) 
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

This is a reland of https://github.com/flutter/engine/pull/54240 which was reverted in https://github.com/flutter/engine/pull/54250.

The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy.

Issue: https://github.com/flutter/flutter/issues/107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-31 18:39:53 +00:00
skia-flutter-autoroll
87dd69c393 Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) (flutter/engine#54253) 
https://skia.googlesource.com/skia.git/+log/e9e423457655..cd58e87c06f9

2024-07-31 johnstiles@google.com Clean up SK_DISABLE_MODULES_FOR_KNOWN_RUNTIME_EFFECTS flag guard.
2024-07-31 jvanverth@google.com Use a single source for CircularRRectEffect's analytic rrect clip.
2024-07-31 johnstiles@google.com Undo changes to loop index in linear morphology.
2024-07-31 robertphillips@google.com Add missing Vulkan extension
2024-07-31 kjlubick@google.com Fix use of deprecated Dawn Graphite constructors

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 17:36:30 +00:00
Matan Lurey
4d74b4b05a Cleanup the shell test, removing unused code (flutter/engine#54238) 
Guess we'll find out!
 2024-07-31 17:31:24 +00:00
Yegor
38f3b2c83b [web] rename dialog to route to match the framework (flutter/engine#54228) 
Rename "dialog" to "route" to match the framework. The ARIA role "dialog" is an implementation detail, and it might change if a better implementation comes along. The semantic node itself implements the framework's "route" concept.
 2024-07-31 17:18:11 +00:00
skia-flutter-autoroll
5d49c30db1 Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) (flutter/engine#54252) 
https://dart.googlesource.com/sdk.git/+log/edace067d950..5df6a6e0c037

2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-100.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 17:14:16 +00:00
Brandon DeRosier
8a22cb3905 [Impeller] Reland: Implement draw order optimization. (flutter/engine#54215) 
Original PR: #54136
Revert PR: #54067

For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.
 2024-07-31 09:58:26 -07:00
Matan Lurey
66d00dddf8 Migrate the remaining real pub packages to pub workspaces. (flutter/engine#54232) 
Closes https://github.com/flutter/flutter/issues/147883.
 2024-07-31 09:51:27 -07:00
skia-flutter-autoroll
1f88b46839 Roll Skia from 999e3f113dbf to e9e423457655 (1 revision) (flutter/engine#54251) 
https://skia.googlesource.com/skia.git/+log/999e3f113dbf..e9e423457655

2024-07-31 michaelludwig@google.com [skif] Fix identity scale and no-effects detection

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 15:59:40 +00:00
auto-submit[bot]
8a06eaf695 Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (flutter/engine#54250) 
Reverts: flutter/engine#54240
Initiated by: zanderso
Reason for reverting: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview
Original PR Author: cbracken

Reviewed By: {zanderso}

This change reverts the following previous change:
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

Issue: https://github.com/flutter/flutter/issues/107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-31 14:12:47 +00:00
skia-flutter-autoroll
45a80efa76 Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246) 
https://dart.googlesource.com/sdk.git/+log/f10a21fcc61c..edace067d950

2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-99.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 10:01:24 +00:00
skia-flutter-autoroll
95b0d8ed73 Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245) 
https://skia.googlesource.com/skia.git/+log/cb6ea5bd807d..fa9ecbb258b1

2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0ef066874643 to 65f08d08515f (12 revisions)
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d7d76032f90 to 9b09b0a9dfa9 (10 revisions)
2024-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0d7d76032f90 to 9b09b0a9dfa9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 08:54:23 +00:00
skia-flutter-autoroll
21a7d5d34b Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244) 
https://dart.googlesource.com/sdk.git/+log/68e559110999..f10a21fcc61c

2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-98.0.dev
2024-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-97.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 05:54:21 +00:00
skia-flutter-autoroll
9ddbce564d Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241) 
https://skia.googlesource.com/skia.git/+log/26eb1876de72..cb6ea5bd807d

2024-07-31 bungeman@google.com Remove __MSVC_RUNTIME_CHECKS support
2024-07-31 jvanverth@google.com Revert "[ganesh] Check for null ThreadSafeProxy in GrImageContext::abandoned()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 02:34:36 +00:00
skia-flutter-autoroll
a15cdac22c Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239) 
https://skia.googlesource.com/skia.git/+log/b6036baeebbd..26eb1876de72

2024-07-30 johnstiles@google.com Improve error reporting when a prototype disagrees with its function.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 01:15:05 +00:00
Chris Bracken
a06a176d9f [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240) 
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

Issue: https://github.com/flutter/flutter/issues/107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-31 01:09:18 +00:00
Jason Simmons
7e91d04146 Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235) 
Previously this was using a zero EGLConfig handle in tests which use an AndroidContextGLImpeller that creates EGL surfaces.  This apparently worked with older emulators, but the API 35 system image requires a real EGLConfig.

See https://github.com/flutter/flutter/pull/152498
 2024-07-31 00:18:08 +00:00
Chris Bracken
b5c7bfdb41 [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237) 
In 2021, we did some experiments with ML-guided optimisations in the
engine. Ultimately, these didn't provide much benefit, and much of the
information in the documentation is now out-of-date.

For those who need it, this can always be found in the git history.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-31 00:04:04 +00:00
skia-flutter-autoroll
43e98782ac Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236) 
https://dart.googlesource.com/sdk.git/+log/e16dc217b1ac..68e559110999

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-96.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-31 00:00:48 +00:00
Harry Terkelsen
55ac232563 enumify ImageType and ImageFileSignature (flutter/engine#54131) 
Use enhanced enums to clarify the image detection code.

Part of a refactor towards https://github.com/flutter/flutter/issues/151911

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 23:59:22 +00:00
skia-flutter-autoroll
fe1f597820 Roll Skia from e8fb6f320da0 to b6036baeebbd (3 revisions) (flutter/engine#54234) 
https://skia.googlesource.com/skia.git/+log/e8fb6f320da0..b6036baeebbd

2024-07-30 johnstiles@google.com Fix fuzzer-discovered issue with duplicate array types.
2024-07-30 johnstiles@google.com Reland "Add defensive check for unreachable specialized functions."
2024-07-30 johnstiles@google.com Ensure that all functions are specialized.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 23:31:23 +00:00
Chinmay Garde
60a58538aa [Impeller] Use linear sampling to sample from AHB textures in Vulkan. (flutter/engine#54233) 
Fixes https://github.com/flutter/flutter/issues/152579

This now matches Skia OpenGL behavior with SurfaceTexture.
![flutter_04](https://github.com/user-attachments/assets/ccae62a0-4b46-4776-b8ee-f7314722aa68)
 2024-07-30 22:22:59 +00:00
skia-flutter-autoroll
2016939425 Roll Skia from 4e31906b6312 to e8fb6f320da0 (5 revisions) (flutter/engine#54229) 
https://skia.googlesource.com/skia.git/+log/4e31906b6312..e8fb6f320da0

2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ce5411a16fa to 51742b289ba3 (5 revisions)
2024-07-30 nathanasanchez@google.com [SkSL] Remove loadFloatBuffer intrinsic
2024-07-30 nathanasanchez@google.com [Graphite] Change module functions to take array parameters
2024-07-30 nathanasanchez@google.com [SkSL] Add a specialization in a call test
2024-07-30 johnstiles@google.com Reland "Move most KnownRuntimeEffects into the sksl_rt_shader module."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 21:28:23 +00:00
auto-submit[bot]
55758e1e8e Reverts "Do not disable partial repaint based on thread merging state (#54219)" (flutter/engine#54230) 
Reverts: flutter/engine#54219
Initiated by: jonahwilliams
Reason for reverting: incorrect rendering on last frame after platform view is removed.
Original PR Author: knopp

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Currently we force full repaint when thread merging is detected, but that is not a good way to determine whether platform view is in hierarchy when thread merging is no longer needed. Alternative solution here makes the PlatformViewLayer  force full repaint when diffing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 21:00:26 +00:00
Chris Bracken
7bb5ee5e6e [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 
This script is unused and is superseded by create_full_ios_framework.py.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 20:48:03 +00:00
skia-flutter-autoroll
aa5c147fc6 Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 
https://skia.googlesource.com/skia.git/+log/b9b208f11c67..4e31906b6312

2024-07-30 johnstiles@google.com Add design doc links for go/sksl-rp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 20:11:12 +00:00
Jonah Williams
9650917c7e [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 
This makes it much easier to implement the deferred submit required for https://github.com/flutter/engine/pull/53826
 2024-07-30 19:58:21 +00:00
Matej Knopp
e078967646 Do not disable partial repaint based on thread merging state (flutter/engine#54219) 
Currently we force full repaint when thread merging is detected, but
that is not a good way to determine whether platform view is in
hierarchy when thread merging is no longer needed. Alternative solution
here makes the PlatformViewLayer force full repaint when diffing.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-07-30 21:36:02 +02:00
skia-flutter-autoroll
1fe35315e0 Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) 
https://dart.googlesource.com/sdk.git/+log/14b51d32e3a6..e16dc217b1ac

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-95.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 19:04:24 +00:00
skia-flutter-autoroll
e66f26eb62 Roll Fuchsia Linux SDK from QsN_RyaTWxm-8AD47... to cYjTzxe0MskG7PtkB... (flutter/engine#54223) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 18:48:15 +00:00
skia-flutter-autoroll
495974ec1f Roll Skia from c1fcf8e5a55c to b9b208f11c67 (2 revisions) (flutter/engine#54222) 
https://skia.googlesource.com/skia.git/+log/c1fcf8e5a55c..b9b208f11c67

2024-07-30 nathanasanchez@google.com [SkSL][SPIR-V] Unsized array parameter support
2024-07-30 kjlubick@google.com [graphite] Remove SK_DAWN defines from TextureInfo and BackendTexture.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 18:25:29 +00:00
skia-flutter-autoroll
db8f154594 Roll Skia from a4d59988bde0 to c1fcf8e5a55c (1 revision) (flutter/engine#54220) 
https://skia.googlesource.com/skia.git/+log/a4d59988bde0..c1fcf8e5a55c

2024-07-30 kjlubick@google.com Change vello's #ifdef guards

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 17:07:09 +00:00
gaaclarke
179daffb5a Reland: [Impeller] Use downsample shader for blur instead of mip levels. (flutter/engine#54149) 
relands https://github.com/flutter/engine/pull/53760
reverted in https://github.com/flutter/engine/pull/54148

The fix for this was found with the help of Jonah.

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 16:44:08 +00:00
skia-flutter-autoroll
62eab65524 Roll Skia from 2cb7f5443a48 to a4d59988bde0 (1 revision) (flutter/engine#54218) 
https://skia.googlesource.com/skia.git/+log/2cb7f5443a48..a4d59988bde0

2024-07-30 johnstiles@google.com Revert "Move most KnownRuntimeEffects into the sksl_rt_shader module."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 15:47:21 +00:00
gaaclarke
c0908f857e [Impeller] makes the gaussian down sample scalar fixed by adjusting the downsample padding (flutter/engine#54150) 
This removes jitter in the gaussian blur.

Previous version of the shimmer test show this drops the average RMSE 30%.

testing:
  - positive change shown in average RMSE in ShimmerTest
  - existing golden tests

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 15:35:18 +00:00
skia-flutter-autoroll
412cf31283 Roll Dart SDK from ad4d2e8b2c65 to 14b51d32e3a6 (1 revision) (flutter/engine#54216) 
https://dart.googlesource.com/sdk.git/+log/ad4d2e8b2c65..14b51d32e3a6

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-94.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 14:00:25 +00:00
skia-flutter-autoroll
6709f14400 Roll Skia from 1339015537a3 to 2cb7f5443a48 (4 revisions) (flutter/engine#54212) 
https://skia.googlesource.com/skia.git/+log/1339015537a3..2cb7f5443a48

2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 572025841d09 to 0ef066874643 (9 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3c1dcf83f79 to 0ce5411a16fa (6 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8ebaca0a412e to 0d7d76032f90 (7 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c4dfa69de7de to 01b188e56477 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 09:49:40 +00:00
skia-flutter-autoroll
c3a3ece966 Roll Dart SDK from 6ab9452297e0 to ad4d2e8b2c65 (1 revision) (flutter/engine#54211) 
https://dart.googlesource.com/sdk.git/+log/6ab9452297e0..ad4d2e8b2c65

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-93.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 09:23:22 +00:00