firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
Jonah Williams
693f99ae00 [Impeller] expose reference to tessellator instead of shared_ptr. (flutter/engine#56244) 
All geometries were incrementing the shared_ptr usage count which shows up in profiles. Instead expose a Tessellator reference like we do with HostBuffer.
 2024-10-31 00:40:18 +00:00
Chris Bracken
a4bb83e6e8 iOS: Eliminate strong retain loop in Scenario tests (flutter/engine#56249) 
`FlutterViewControllerTest testDrawLayer` created a callback which strongly referenced itself in its own body as part of an asynchronous recursive loop. The recursion was unnecessary and the test consistently passes, even if run on repeat > 100 times without it.

Now that there's only one call, eliminates the unnecessary local and inlines it into the `dispatch_after` call.

This was originally introduced in https://github.com/flutter/engine/pull/50072.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-31 00:37:26 +00:00
skia-flutter-autoroll
2bc2d9e328 Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) (flutter/engine#56248) 
https://skia.googlesource.com/skia.git/+log/85b77db25fa3..3c62d4a94d78

2024-10-30 fmalita@google.com Add verb measurement utils to SkContourMeasure

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 23:08:07 +00:00
skia-flutter-autoroll
3c6aaffb34 Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) (flutter/engine#56246) 
https://dart.googlesource.com/sdk.git/+log/4566845d8e30..6a8058eef22c

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-85.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 23:04:05 +00:00
skia-flutter-autoroll
193c2511a9 Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) (flutter/engine#56245) 
https://skia.googlesource.com/skia.git/+log/f334411b0a08..85b77db25fa3

2024-10-30 jvanverth@google.com [graphite] Add round cap support to CircularArcRenderStep.
2024-10-30 jlavrova@google.com Reland "Reland "Reland "Adding Fontations to FontConfig manager"""
2024-10-30 bungeman@google.com [pdf] Emit correct tag for marked-content items
2024-10-30 drott@chromium.org [Fontations] Fix bounding box calculation under transforms
2024-10-30 vigneshv@google.com SkCrabbyAvifCodec: Add support for gainmaps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 21:50:06 +00:00
Matan Lurey
eb42dc7b9d Add and use mergeGnArgs with --gn-args from et. (flutter/engine#56228) 
Closes https://github.com/flutter/flutter/issues/156909.

This PR adds (and implements) the `--gn-args` (extra command-line GN args) functionality by generalizing on the concept of "merged" GN args that @zanderso had special-cased for `--lto` and `--rbe`, and further testing it.

There is also a logical place for us to expand support of merged arguments at a future point in time.
 2024-10-30 21:44:35 +00:00
skia-flutter-autoroll
85bf745fbc Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243) 
https://skia.googlesource.com/skia.git/+log/77779dfed911..f334411b0a08

2024-10-30 jvanverth@google.com [graphite] Remove legacy rrect clip

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 20:08:18 +00:00
Jonah Williams
b1b224f8e8 [engine] add back opt out for merged thread mode. (flutter/engine#56242) 
Leave an opt out in the engine for iOS as well. This will give developers an escape hatch in case there are problems we miss...
 2024-10-30 20:00:22 +00:00
Jason Simmons
d24eb30b3d [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223) 
Based on https://github.com/flutter/engine/pull/55230

Fixes https://github.com/flutter/flutter/issues/156438
 2024-10-30 18:45:45 +00:00
skia-flutter-autoroll
bbe385cf21 Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 18:40:23 +00:00
skia-flutter-autoroll
05e65b6663 Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240) 
https://dart.googlesource.com/sdk.git/+log/36aed3607108..4566845d8e30

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-84.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 18:14:09 +00:00
skia-flutter-autoroll
788af1d0c1 Roll Skia from d022fe64116f to 77779dfed911 (1 revision) (flutter/engine#56239) 
https://skia.googlesource.com/skia.git/+log/d022fe64116f..77779dfed911

2024-10-30 jlavrova@google.com Revert "Reland "Reland "Adding Fontations to FontConfig manager"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 17:02:19 +00:00
skia-flutter-autoroll
ae6950d066 Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237) 
https://skia.googlesource.com/skia.git/+log/03600bc22ab8..d022fe64116f

2024-10-30 jlavrova@google.com Reland "Reland "Adding Fontations to FontConfig manager""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 15:13:20 +00:00
skia-flutter-autoroll
4d7029a182 Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235) 
https://dart.googlesource.com/sdk.git/+log/b319b2e53bfa..36aed3607108

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-83.0.dev
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 13:39:36 +00:00
skia-flutter-autoroll
1a555cf0ce Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231) 
https://skia.googlesource.com/skia.git/+log/1a47627e627a..948b01e28f48

2024-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e50eebfa6917 to 548705375403 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 08:18:24 +00:00
skia-flutter-autoroll
90f0a83511 Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229) 
https://dart.googlesource.com/sdk.git/+log/70eca740f23f..b319b2e53bfa

2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-81.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 05:20:21 +00:00
Chris Bracken
d6ad223584 iOS: make unopt debug builds unopt and debug (flutter/engine#56226) 
The following iOS builds were named "unopt" and "debug" but did not have
the `--unoptimized` flag passed to `gn`, resulting in them not being
unopt, and having the gn `is_debug` setting set to `false`:

* ios_debug_unopt_sim
* ios_debug_unopt_sim_arm64
* ios_debug_unopt_sim_arm64_extension_safe

No test changes because this is a compile config change.

Issue: https://github.com/flutter/flutter/issues/156166

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-30 04:15:18 +00:00
skia-flutter-autoroll
c732984e6b Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225) 
https://dart.googlesource.com/sdk.git/+log/fcc2bc69db3e..70eca740f23f

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-80.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 00:56:41 +00:00
skia-flutter-autoroll
6b989d0e0c Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222) 
https://skia.googlesource.com/skia.git/+log/6e0c0a255166..7385b2d99fe9

2024-10-29 lukasza@chromium.org Reapply "[rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests."
2024-10-29 lukasza@chromium.org [rust png] Don't retry `parse...FrameInfos` if input didn't change.
2024-10-29 michaelludwig@google.com Revert "Reland "Adding Fontations to FontConfig manager""
2024-10-29 lukasza@chromium.org [rust png] Don't look for more `fcTL` chunks during incremental decode.
2024-10-29 lukasza@chromium.org [rust png] Account for `fFrameAtCurrentStreamPosition` inaccuracies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-30 00:20:06 +00:00
David Iglesias
ba7deba7c5 [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187) 
Moves "split" font fallbacks (woff2) over "monolythic" ones (ttf) when resolving fonts.

Fixes https://github.com/flutter/flutter/issues/157763

It makes flutter web prefer "Noto Color Emoji" over "Noto Sans Symbols" when rendering emoji, for example.

This also changes the methods that process the font lists so they *return* the fonts they processed, instead of causing a side effect on an incoming array.

---

CIPD Upload log

```
398 sets covering 22287 ranges
Uploading fallback fonts to CIPD with hash 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
Enumerating files to zip...
Instance: flutter/flutter_font_fallbacks:6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC
Setting new fallback fonts deps version to 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
```

Link to uploaded bundle:

* https://chrome-infra-packages.appspot.com/p/flutter/flutter_font_fallbacks/+/6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC

---

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-29 23:01:22 +00:00
skia-flutter-autoroll
621f137ec6 Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215) 
https://skia.googlesource.com/skia.git/+log/5758d9c344e3..6e0c0a255166

2024-10-29 jlavrova@google.com Reland "Adding Fontations to FontConfig manager"
2024-10-29 bungeman@google.com [pdf] Expand content item scope
2024-10-29 jamesgk@google.com [graphite] Simplify ShaderInfo API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 22:53:48 +00:00
Brandon DeRosier
3fed10bf0d [Flutter GPU] Fix MSAA sample size and HostBuffer alignment. (flutter/engine#56218) 
- Align HostBuffer emplacements properly (fix Metal validation failures).
- Correctly set the pipeline sample size.
- Throw an error when attempting to bind `deviceTransient` textures.
 2024-10-29 22:52:21 +00:00
Jim Graham
80d757ef56 Change default TileMode for blur ImageFilter objects to null (flutter/engine#55552) 
Fixes https://github.com/flutter/flutter/issues/154935

Historically ImageFilter.blur supported setting a TileMode and had a default mode of `clamp`, but few developers actually set the value and the default was not appropriate for some common uses like as a backdrop filter where the clamp mode produces flashing when scrolling high frequency pixel content underneath a blurred title bar.

This PR removes the default tile mode instead allowing a null value as the default which will allow the engine to use an appropriate context-dependent default tile mode depending on the action being performed. Typically:

- decal for rendering operations and saveLayers and ImageFilterLayer
- clamp for image operations
- mirror for backdrop filters
 2024-10-29 22:47:32 +00:00
auto-submit[bot]
728997cd8f Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#56213)" (flutter/engine#56220) 
Reverts: flutter/engine#56213
Initiated by: jtmcdole
Reason for reverting: breaks the tree. :'(
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde, jtmcdole}

This change reverts the following previous change:
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 22:24:19 +00:00
gaaclarke
ae96943065 Made et compilation errors relative to the CWD (flutter/engine#56177) 
fixes https://github.com/flutter/flutter/issues/157735

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-29 19:25:04 +00:00
Jonah Williams
103b3b7cf5 [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56213) 
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 19:12:16 +00:00
Jonah Williams
1f229c58cf [Impeller] disable Adreno 506. (flutter/engine#56210) 
Fixes https://github.com/flutter/flutter/issues/155185
 2024-10-29 18:43:22 +00:00
auto-submit[bot]
bc43093cdd Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. (#56202)" (flutter/engine#56212) 
Reverts: flutter/engine#56202
Initiated by: jonahwilliams
Reason for reverting: tests didn't actually run.
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde, jtmcdole}

This change reverts the following previous change:
Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 17:45:47 +00:00
Alexander Aprelev
d0141e3ee3 Remove --time run of gen_snapshot. (flutter/engine#56204) 
'--time'-runs were done to investigate https://github.com/flutter/flutter/issues/154437, which was fixed.
 2024-10-29 17:20:15 +00:00
Jason Simmons
ac991b9a6e [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter/engine#56183) 
The destination rect will then be updated to a mapping of the clipped source rect.

This matches the behavior of Skia's SkCanvas::drawImageRect.

Fixes https://github.com/flutter/flutter/issues/157167
 2024-10-29 17:10:31 +00:00
Jonah Williams
f1300a6ce6 [Impeller] disable Maleoon GPU from using Vulkan. (flutter/engine#56203) 
Fixes https://github.com/flutter/flutter/issues/156623

using info from https://vulkan.gpuinfo.org/displayreport.php?id=23730 . I dont believe these vulkan drivers are working correctly.
 2024-10-29 17:09:14 +00:00
Jonah Williams
3e9f90a834 [Impeller] disable AHBs on devices that were upgraded to 29. (flutter/engine#56202) 
Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29.

Fixes https://github.com/flutter/flutter/issues/157113
 2024-10-29 17:02:23 +00:00
skia-flutter-autoroll
74c637967e Roll Skia from 6d8a5ebeb76c to 5758d9c344e3 (7 revisions) (flutter/engine#56201) 
https://skia.googlesource.com/skia.git/+log/6d8a5ebeb76c..5758d9c344e3

2024-10-29 jamesgk@google.com Revert "[rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests."
2024-10-29 briansalomon@gmail.com Reland "Update Ganesh GL interface to look for timer query functionality."
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 098ec4c2bd02 to a5edfbb83552 (10 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fe99836c8bb8 to 0e0e5eae7d22 (13 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 98a334bd44af to e50eebfa6917 (5 revisions)
2024-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3aaa6784ca31 to 1495532f997f (2 revisions)
2024-10-29 lukasza@chromium.org [rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 16:14:59 +00:00
skia-flutter-autoroll
20a9d2e775 Roll Dart SDK from 52af705f878b to fcc2bc69db3e (1 revision) (flutter/engine#56199) 
https://dart.googlesource.com/sdk.git/+log/52af705f878b..fcc2bc69db3e

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 14:06:28 +00:00
skia-flutter-autoroll
fc5d069156 Roll Fuchsia Linux SDK from RXUZ9eDc7cS4NpKoh... to zuDYsDZHnJMZVvrc8... (flutter/engine#56197) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 12:01:23 +00:00
skia-flutter-autoroll
3ae0ed5a7d Roll Dart SDK from 6e55dfe77483 to 52af705f878b (2 revisions) (flutter/engine#56195) 
https://dart.googlesource.com/sdk.git/+log/6e55dfe77483..52af705f878b

2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-77.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 09:00:18 +00:00
dependabot[bot]
68933d2e77 Bump actions/setup-python from 5.2.0 to 5.3.0 (flutter/engine#56192) 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li>Upgrade IA publish by <a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/943">actions/setup-python#943</a></li>
</ul>
<h3>Bug Fixes:</h3>
<ul>
<li>Normalise Line Endings to Ensure Cross-Platform Consistency by <a href="https://github.com/priya-kinthali"><code>@​priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/938">actions/setup-python#938</a></li>
<li>Revise <code>isGhes</code> logic by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
<li>Bump pillow from 7.2 to 10.2.0 by <a href="https://github.com/aparnajyothi-y"><code>@​aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/956">actions/setup-python#956</a></li>
</ul>
<h3>Enhancements:</h3>
<ul>
<li>Enhance workflows and documentation updates by <a href="https://github.com/priya-kinthali"><code>@​priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/965">actions/setup-python#965</a></li>
<li>Bump default versions to latest by <a href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/905">actions/setup-python#905</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li><a href="https://github.com/jww3"><code>@​jww3</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.3.0">https://github.com/actions/setup-python/compare/v5...v5.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0b93645e9f"><code>0b93645</code></a> Enhance workflows: Add macOS 13 support, upgrade publish-action, and update d...</li>
<li><a href="9c76e71650"><code>9c76e71</code></a> Bump pillow from 7.2 to 10.2.0 in /<strong>tests</strong>/data  (<a href="https://redirect.github.com/actions/setup-python/issues/956">#956</a>)</li>
<li><a href="f4c5a1183d"><code>f4c5a11</code></a> Revise <code>isGhes</code> logic (<a href="https://redirect.github.com/actions/setup-python/issues/963">#963</a>)</li>
<li><a href="19dfb7b659"><code>19dfb7b</code></a> Bump default versions to latest (<a href="https://redirect.github.com/actions/setup-python/issues/905">#905</a>)</li>
<li><a href="e9675cc634"><code>e9675cc</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/943">#943</a> from actions/Jcambass-patch-1</li>
<li><a href="3226af69c0"><code>3226af6</code></a> Upgrade IA publish</li>
<li><a href="70dcb22d26"><code>70dcb22</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/941">#941</a> from actions/Jcambass-patch-1</li>
<li><a href="65b48c7115"><code>65b48c7</code></a> Create publish-immutable-actions.yml</li>
<li><a href="29a37be0a3"><code>29a37be</code></a> initial commit (<a href="https://redirect.github.com/actions/setup-python/issues/938">#938</a>)</li>
<li>See full diff in <a href="f677139bbe...0b93645e9f">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=5.2.0&new-version=5.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-10-29 06:24:35 +00:00
skia-flutter-autoroll
2938ff0592 Roll Skia from bdd225968dab to 6d8a5ebeb76c (3 revisions) (flutter/engine#56185) 
https://skia.googlesource.com/skia.git/+log/bdd225968dab..6d8a5ebeb76c

2024-10-29 lukasza@chromium.org [rust png] Explicitly handle unsupported `dstInfo` in `SkPngCodecBase`.
2024-10-28 lukasza@chromium.org [rust png] Implement `rust_png::BlendOp::Over` in `SkPngRustCodec`.
2024-10-28 jvanverth@google.com [graphite] Add CircularArcRenderStep.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 01:24:04 +00:00
skia-flutter-autoroll
dd00983844 Roll Dart SDK from c9180e9de9e8 to 6e55dfe77483 (1 revision) (flutter/engine#56184) 
https://dart.googlesource.com/sdk.git/+log/c9180e9de9e8..6e55dfe77483

2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-29 00:25:01 +00:00
Harry Terkelsen
18214377a3 [canvaskit] Deduplicate golden test file names (flutter/engine#56143) 
Two different golden tests produced output named `canvaskit_picture.png`. This PR deduplicates those.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-28 23:31:19 +00:00
Brandon DeRosier
40062dbfe5 [Flutter GPU] Replace HostBuffer with Dart version. (flutter/engine#56054) 
Resolves https://github.com/flutter/flutter/issues/157431.
 2024-10-28 21:16:17 +00:00
Jonah Williams
23641d582a [Impeller] add basic Impeller+Vulkan support to embedder API. (flutter/engine#55490) 
Works on GLFW example app with no validation errors.
 2024-10-28 20:20:17 +00:00
skia-flutter-autoroll
2c6a76e3d1 Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (flutter/engine#56180) 
https://dart.googlesource.com/sdk.git/+log/69b50768d733..c9180e9de9e8

2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-74.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-28 20:14:19 +00:00
Jonah Williams
e357d1899d [Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. (flutter/engine#56148) 
Both changes were required to get playground tests validation free with moltenvk. becuase an initial state of undefined means "I don't care what was in this texture before" but that doesn't make sense if we're setting "kLoad" since that explicitly asks vulkan to load the previous contents.

Fixes https://github.com/flutter/flutter/issues/157557
 2024-10-28 20:10:10 +00:00
Chris Bracken
aa5298b270 iOS/macOS: migrate darwin/common to ARC (flutter/engine#56155) 
Migrates //flutter/shell/platform/darwin/common` targets to ARC. Most of
these were already ARC compatible.

This does add use of the `FLUTTER_ASSERT_ARC` define since that is
defined in a public framework header, but this code has no dependency on
the framework.

This removes `flutter_cflags_objc` and `flutter_cflags_objcc` compile
configs from `availability_version_check_unittests` since that target is
pure C++ and contains no Objective-C code.

No test changes since this there is no semantic change to the code.

Issue: https://github.com/flutter/flutter/issues/137801
 2024-10-28 12:34:59 -07:00
auto-submit[bot]
d66f209f9e Reverts "Pin local_engine mac builds to arm64 (#56172)" (flutter/engine#56179) 
<!-- start_original_pr_link -->
Reverts: flutter/engine#56172
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: mysterious infra failures:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20local_engine_builds/2951/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: zanderso
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {chinmaygarde}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2024-10-28 12:28:07 -07:00
Chris Bracken
dd8db914de Migrate PlatformViewIOS to ARC (flutter/engine#55672) 
Migrates PlatformViewIOS from manual reference counting to ARC. Eliminates use of scoped_nsobject, scoped_nsprotocol, and WeakNSObject.

Since this is the last non-ARC file in `flutter_framework_source`, this also eliminates the `flutter_framework_source` target, then also renames the `flutter_framework_source_arc` target to `flutter_framework_source` since... it's ALL ARC.

No semantic changes, therefore no semantic changes to tests.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-28 19:23:48 +00:00
skia-flutter-autoroll
57167c8067 Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (flutter/engine#56176) 
https://skia.googlesource.com/skia.git/+log/35ad4e89212f..21035cd95b68

2024-10-28 tikuta@google.com base: include minimum header for x86 SIMD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-28 18:26:05 +00:00
Alexander Aprelev
21e4c09337 Roll buildroot to pick up revert of debugging gen_snapshot prints (flutter/engine#56175) 
Changes since last roll

```
3f1a1f0 Revert "For --time'd failed gn_run_binary.py runs repeat failed command (#910)" (#914)
e256f5c Remove github actions from buildroot (#913)
```
 2024-10-28 18:20:13 +00:00
Zachary Anderson
314ea9eae7 Pin local_engine mac builds to arm64 (flutter/engine#56172) 2024-10-28 18:08:55 +00:00