firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

38118 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
ad7a7ba7a1 Roll Skia from a3388794e06e to d576296091e0 (1 revision) (flutter/engine#54670) 
https://skia.googlesource.com/skia.git/+log/a3388794e06e..d576296091e0

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 40d470c73393 to 7ee30f5d2f5a (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 06:02:21 +00:00
Jason Simmons
164eb442db Remove unnecessary breaks in default clauses of switch statements (flutter/engine#54669) 
See https://dart.googlesource.com/sdk.git/+/045d26bc74209f5acc6466669f89686344e83de2
 2024-08-21 04:31:26 +00:00
Chinmay Garde
bc6d7fa164 [Impeller] Remove unused ColorHSB. (flutter/engine#54659) 
I didn't realize I hadn't cleaned this up. We've never needed it in Impeller.
 2024-08-21 03:47:19 +00:00
skia-flutter-autoroll
3452638b57 Roll Skia from 90671d1b342c to a3388794e06e (1 revision) (flutter/engine#54666) 
https://skia.googlesource.com/skia.git/+log/90671d1b342c..a3388794e06e

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3fa5bf77e2bf to b36cd71bb7c9 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 01:58:29 +00:00
Chris Bracken
d18ba04282 Clean up macOS framework creation scripts (flutter/engine#54658) 
This refactors `create_fat_macos_framework`, `_regenerate_symlinks` and
`_set_framework_permissions` to be more generic and not hardcode "FlutterMacOS"
as a framework name. Further, it reuses several utility functions from the iOS
code in `sky_utils` to improve readability and eliminate duplication.

This is refactoring prior to embedding dSYMs in FlutterMacOS.xcframework in a
followup patch.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-21 00:46:15 +00:00
skia-flutter-autoroll
950352ab04 Roll Skia from 51d7e221fef0 to 90671d1b342c (1 revision) (flutter/engine#54663) 
https://skia.googlesource.com/skia.git/+log/51d7e221fef0..90671d1b342c

2024-08-20 robertphillips@google.com Revert "Add [[nodiscard]] to Sk[I]Rect::intersect"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 23:53:05 +00:00
Brandon DeRosier
28f75263ff Revert "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54661) 
Reverts flutter/engine#54484

Fixes https://github.com/flutter/flutter/issues/153737
 2024-08-20 23:16:05 +00:00
skia-flutter-autoroll
d109230b49 Roll Dart SDK from 04c57423f90d to 49f655b526c7 (2 revisions) (flutter/engine#54660) 
https://dart.googlesource.com/sdk.git/+log/04c57423f90d..49f655b526c7

2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-164.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 23:08:20 +00:00
skia-flutter-autoroll
76a55c1355 Roll Skia from b472cacb48d6 to 51d7e221fef0 (2 revisions) (flutter/engine#54656) 
https://skia.googlesource.com/skia.git/+log/b472cacb48d6..51d7e221fef0

2024-08-20 michaelludwig@google.com Add [[nodiscard]] to Sk[I]Rect::intersect
2024-08-20 jvanverth@google.com Reland "[graphite] Add purge() method to DrawAtlas."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 21:48:04 +00:00
gaaclarke
a6c6c50a25 Changes DlColor to support wide gamut colors (#54473) (flutter/engine#54648) 
relands https://github.com/flutter/engine/pull/54473
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

## Difference from last attempt

1) The default color is now opaque black, not transparent black (not the issue for revert)
1) Updated a test to send in valid numbers when constructing a color and added asserts to avoid those problems in the future.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 21:44:24 +00:00
skia-flutter-autoroll
e256163e94 Roll Skia from a8160d808252 to b472cacb48d6 (1 revision) (flutter/engine#54653) 
https://skia.googlesource.com/skia.git/+log/a8160d808252..b472cacb48d6

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from ae5dd592666e to 40d470c73393 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 20:21:12 +00:00
skia-flutter-autoroll
a11c7c0aed Manual roll Dart SDK from c5264a1bd1d2 to 04c57423f90d (13 revisions) (flutter/engine#54649) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..04c57423f90d

2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-162.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-161.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-160.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-159.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-158.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-157.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-156.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-155.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-154.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-153.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-152.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:44:07 +00:00
skia-flutter-autoroll
0c19856b76 Roll Skia from 6299c5744307 to a8160d808252 (6 revisions) (flutter/engine#54651) 
https://skia.googlesource.com/skia.git/+log/6299c5744307..a8160d808252

2024-08-20 nscobie@google.com [Android] Don't evaluate trace arguments if using ATrace but !ATRACE_ENABLED()
2024-08-20 bungeman@google.com Roll FreeType from 73720c7c to f92c9655 (23 commits)
2024-08-20 robertphillips@google.com Revert "[rust png] Extract minimal `SkPngCodecBase`."
2024-08-20 lukasza@chromium.org [rust png] Extract minimal `SkPngCodecBase`.
2024-08-20 sharaks@google.com Merge 5 release notes into RELEASE_NOTES.md
2024-08-20 sharaks@google.com Update Skia milestone to 130

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:42:19 +00:00
yaakovschectman
2f6952657d Use getBoundingRects to add support inset MediaQuery/SafeArea when in freeform mode controls are shown. (flutter/engine#54294) 
Original Title: Add FlutterViewDelegate and BoundingRect methods

Check the bounding rect for caption bar when sending viewport metrics to
Flutter to account for freeform mode. Use the more recent
`getBoundingRects` over `getInsets`.

Tests will need to be kept separate until Robolectric publishes a
version that supports API level 35.
Roboletric tests for this pr will be part of google testing until then. 
Pr for tests here https://critique.corp.google.com/cl/657302386. 

https://github.com/flutter/flutter/issues/146658

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-08-20 13:09:00 -04:00
skia-flutter-autoroll
149b1974f5 Manual roll Dart SDK from c5264a1bd1d2 to c22bf5aedbcf (2 revisions) (flutter/engine#54646) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..c22bf5aedbcf

2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 16:43:21 +00:00
skia-flutter-autoroll
444b7b801c Roll Skia from d6548fdb78c1 to 6299c5744307 (1 revision) (flutter/engine#54643) 
https://skia.googlesource.com/skia.git/+log/d6548fdb78c1..6299c5744307

2024-08-20 kjlubick@google.com Delete old GLFW interface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 14:24:24 +00:00
skia-flutter-autoroll
916f7e5ec0 Roll Skia from cc9c81d7fc4d to d6548fdb78c1 (1 revision) (flutter/engine#54642) 
https://skia.googlesource.com/skia.git/+log/cc9c81d7fc4d..d6548fdb78c1

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b038f07b8faf to 3fa5bf77e2bf (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 12:40:34 +00:00
Jim Graham
ef6db0c87e Check return values for Sk[I]Rect::intersect (flutter/engine#54577) 
The `SkRect::intersect` and `SkIRect::intersect` methods return values that must be handled or the calling code might end up with a non-empty answer for non-intersecting rectangles. There were 3 or 4 places in our code that we weren't doing this so now we check them all, in some cases even if we believe that the answer will not be empty.

This is prep work so that Skia can add `[[nodiscard]]` directives to these 2 methods so that nobody else makes that mistake.
 2024-08-20 09:48:20 +00:00
skia-flutter-autoroll
e2a19f2099 Roll Skia from ada9a367c5f2 to cc9c81d7fc4d (1 revision) (flutter/engine#54641) 
https://skia.googlesource.com/skia.git/+log/ada9a367c5f2..cc9c81d7fc4d

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 579a58552fa6 to 1a191b1d5dc8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 08:33:21 +00:00
skia-flutter-autoroll
616470db70 Roll Skia from 30a00629e135 to ada9a367c5f2 (4 revisions) (flutter/engine#54640) 
https://skia.googlesource.com/skia.git/+log/30a00629e135..ada9a367c5f2

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 87111746e4cc to c71e16037f25
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from da2e5cb8d546 to 87111746e4cc (5 revisions)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 65157d32945d to 7216df70d311 (1 revision)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from db1fa936ad0a to ae5dd592666e (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 06:52:24 +00:00
skia-flutter-autoroll
54ae1c04d5 Roll Fuchsia Linux SDK from hNxjRSbGnxD3IhdOm... to 3a16kOsyFmJh3lo7e... (flutter/engine#54638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 04:53:04 +00:00
skia-flutter-autoroll
64e5de4381 Roll Fuchsia Test Scripts from -XDS8eBA0Le-zCEfW... to 2fOjXGNxdSoRSGCL7... (flutter/engine#54635) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 02:59:01 +00:00
Srujan Gaddam
d16a9057a0 Update package:js version constraints to ^0.7.0 and update test versions to match (flutter/engine#54629) 
This removes the dependency on `dart:js` and allows that library to be removed from dart2wasm. Also updates `test` dependencies to work with the new `package:js` constraints.
 2024-08-20 02:58:58 +00:00
skia-flutter-autoroll
8f02ca0cbe Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (flutter/engine#54634) 
https://skia.googlesource.com/skia.git/+log/e65e02c50d66..30a00629e135

2024-08-20 brianosman@google.com Reland "Guard division in luminosity blend against overflow"
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8f75e8cc154 to b038f07b8faf (3 revisions)
2024-08-19 kschmi@microsoft.com Revert "Revert "Reland "Reduce size of linear SkMaskGamma LUT"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 02:57:29 +00:00
auto-submit[bot]
8aabbdd12f Reverts "Changes DlColor to support wide gamut colors (#54473)" (flutter/engine#54636) 
Reverts: flutter/engine#54473
Initiated by: jonahwilliams
Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue
Original PR Author: gaaclarke

Reviewed By: {flar}

This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 02:19:47 +00:00
Jonah Williams
d6f4f4a66e [Impeller] account for negative scale in max basis xy. (flutter/engine#54630) 
Otherwise we get funky negative scales that break tessellation.
 2024-08-19 23:27:54 +00:00
gaaclarke
1fde0ad466 Changes DlColor to support wide gamut colors (flutter/engine#54473) 
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-19 23:16:55 +00:00
skia-flutter-autoroll
d96f5fd76b Roll Skia from b6224c9e6611 to e65e02c50d66 (2 revisions) (flutter/engine#54628) 
https://skia.googlesource.com/skia.git/+log/b6224c9e6611..e65e02c50d66

2024-08-19 robertphillips@google.com Revert "GPU support for F16F16F16x SkColorType."
2024-08-19 robertphillips@google.com [graphite] Break DrawTypeFlags::kText into finer grained draw types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 22:33:06 +00:00
Kevin Moore
28e7d0ec2a web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 
Also removed two unused dev dependencies

Enables usage of `Since` in dart:js_interop
 2024-08-19 22:11:55 +00:00
Chinmay Garde
0ac477bb08 [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 
Action item from go/impeller-faq-followups.
 2024-08-19 22:07:10 +00:00
Jackson Gardner
5e39c69831 [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 
This previously was basically assuming that two clip regions would be a union but instead it's actually an intersection. Also, for some reason I had forgotten to actually implement `boundingRect` for the rrect clip region. I changed this for a bit more clarity.
 2024-08-19 21:45:07 +00:00
skia-flutter-autoroll
f93445acce Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) 
https://skia.googlesource.com/skia.git/+log/318b7958f748..b6224c9e6611

2024-08-19 danieldilan@google.com GPU support for F16F16F16x SkColorType.
2024-08-19 brianosman@google.com Revert "Guard division in luminosity blend against overflow"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 21:15:15 +00:00
Robert Ancell
2bbc3b4b41 Allow the default background color to be changed (flutter/engine#54575) 
Fixes https://github.com/flutter/flutter/issues/149920
 2024-08-20 08:00:06 +12:00
skia-flutter-autoroll
11288f546d Roll Skia from d528658273db to 318b7958f748 (4 revisions) (flutter/engine#54620) 
https://skia.googlesource.com/skia.git/+log/d528658273db..318b7958f748

2024-08-19 kjlubick@google.com Apply clang-tidy suggestion to graphite files
2024-08-19 bungeman@google.com Add SK_USE_FREETYPE_EMBOLDEN to NativeFonts_FreeType
2024-08-19 danieldilan@google.com CPU support of F16F16F16x SkColorType.
2024-08-19 borenet@google.com [bazel] Fix defines for freetype on Windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 19:44:24 +00:00
Chinmay Garde
41c82cd7f9 [Impeller] use paragraphs instead of bullet points in the FAQ. (flutter/engine#54622) 
Fixes https://github.com/flutter/flutter/issues/153316

Other than one question that pointed to outdated links, its just the same as the old FAQ. Will submit the updates based on recent conversations in a followup patch.

It should now be possible to link to specific questions in the FAQ.
 2024-08-19 19:40:15 +00:00
Jonah Williams
8b7101800f [Impeller] finish experimental canvas changes. (flutter/engine#54569) 
Make sure the old dispatcher cannot be used if the new dispatcher is enabled. Migrate tests using old canvas to new canvas, mostly to make deleting the old one easier...
 2024-08-19 19:37:17 +00:00
skia-flutter-autoroll
b5881266a3 Roll Skia from d88bfe2939e8 to d528658273db (9 revisions) (flutter/engine#54619) 
https://skia.googlesource.com/skia.git/+log/d88bfe2939e8..d528658273db

2024-08-19 borenet@google.com [bazel] Fix skshaper build for Windows
2024-08-19 brianosman@google.com Guard division in luminosity blend against overflow
2024-08-19 kjlubick@google.com Remove unused gni file list
2024-08-19 borenet@google.com [bazel] Fix zlib defines for Windows
2024-08-19 borenet@google.com [bazel] Fix global compile options for Windows
2024-08-19 michaelludwig@google.com [ganesh] Fix MeshOp index combination logic
2024-08-19 robertphillips@google.com [graphite] Revise DrawTypeFlags
2024-08-19 michaelludwig@google.com Update $color_burn_component  to single flow of control
2024-08-19 michaelludwig@google.com Reland "Avoid branches and early returns in $color_dodge_component"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 18:09:22 +00:00
Reid Baker
859b18e112 Set download_jdk variable (flutter/engine#54584) 
Follow up from https://github.com/flutter/engine/pull/54450#issuecomment-2282244288
 2024-08-19 15:33:08 +00:00
skia-flutter-autoroll
a5bad33fbc Roll Skia from e49cd5f3cffb to d88bfe2939e8 (1 revision) (flutter/engine#54613) 
https://skia.googlesource.com/skia.git/+log/e49cd5f3cffb..d88bfe2939e8

2024-08-19 borenet@google.com [bazel] Fix copy and patch commands for Windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 15:00:24 +00:00
Kaylee Lubick
b5ac6eafc9 Update gni filegroup when building Skia's codec files (flutter/engine#54588) 
This was added in https://skia-review.googlesource.com/c/skia/+/890319
and Skia plans to delete the old group.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-08-19 07:15:05 -07:00
skia-flutter-autoroll
8cf4bf7e56 Roll Skia from 3896447e3531 to e49cd5f3cffb (1 revision) (flutter/engine#54612) 
https://skia.googlesource.com/skia.git/+log/3896447e3531..e49cd5f3cffb

2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 99bced033e05 to f8f75e8cc154 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 09:59:29 +00:00
skia-flutter-autoroll
9f734ce281 Roll Skia from 5274def7cf1f to 3896447e3531 (1 revision) (flutter/engine#54611) 
https://skia.googlesource.com/skia.git/+log/5274def7cf1f..3896447e3531

2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 83ca89e58cef to 579a58552fa6 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 08:49:29 +00:00
skia-flutter-autoroll
4b47c0cf23 Roll Skia from 75bd296f9756 to 5274def7cf1f (2 revisions) (flutter/engine#54610) 
https://skia.googlesource.com/skia.git/+log/75bd296f9756..5274def7cf1f

2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from da2e5cb8d546 to db27834aff1f
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 521d0157ce62 to da2e5cb8d546 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 07:18:38 +00:00
skia-flutter-autoroll
d89be06f16 Roll Skia from 7025ec4bff25 to 75bd296f9756 (1 revision) (flutter/engine#54609) 
https://skia.googlesource.com/skia.git/+log/7025ec4bff25..75bd296f9756

2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 69433722b83b to db1fa936ad0a (23 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 06:01:27 +00:00
skia-flutter-autoroll
97d9479fd6 Roll Fuchsia Linux SDK from yKkNB9F8Hwnjq2AMW... to hNxjRSbGnxD3IhdOm... (flutter/engine#54608) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 03:30:32 +00:00
skia-flutter-autoroll
72f1100cb0 Roll Skia from ac7149e315ec to 7025ec4bff25 (1 revision) (flutter/engine#54605) 
https://skia.googlesource.com/skia.git/+log/ac7149e315ec..7025ec4bff25

2024-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d8208b108762 to 99bced033e05 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-18 06:26:23 +00:00
skia-flutter-autoroll
85e645fb6b Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... (flutter/engine#54602) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-18 02:07:23 +00:00
skia-flutter-autoroll
4bc75e7bd6 Roll Skia from 570b18e1afda to ac7149e315ec (1 revision) (flutter/engine#54600) 
https://skia.googlesource.com/skia.git/+log/570b18e1afda..ac7149e315ec

2024-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ff16cd9feaa to d8208b108762 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-17 18:05:17 +00:00
Zachary Anderson
21fdc613b0 Shift linux_fuchsia_tests from staging to prod (flutter/engine#54597) 
Follow up to https://github.com/flutter/engine/pull/54591
 2024-08-16 22:21:26 -07:00
skia-flutter-autoroll
338ea8ebb6 Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-17 00:46:20 +00:00