14803 Commits

Author SHA1 Message Date
Darren Austin
7ce0dce2e5
Migrate even more Material framework tests to null safety. (#67849) 2020-10-12 11:30:26 -07:00
Michael Goderbauer
18795b471e
Migrate some widget tests to NNBD (#67776) 2020-10-12 11:18:52 -07:00
Jonah Williams
b4e4e8d965
[flutter_tools] do not crash validator if intellij JAR file is missing (#67931)
This failure has been happening for a while but was covered by the overly broad catch. Removing that revealed that newer intellij versions have a different plugins file. The tool still can't find the file, but it won't crash now

Fixes #67918
2020-10-12 10:34:05 -07:00
Per Classon
7668f06ffe
[Material] Use primary color for selected rows and checkboxes in DataTable (#67919) 2020-10-12 10:17:03 -07:00
Justin McCandless
b93f71f9c8
NNDB TextField tests (#67696)
Just another nnbd conversion PR.
2020-10-12 09:59:05 -07:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
Jonah Williams
0afddf3578
[flutter_tools] use fixed entry for dill uploads (#67837)
For historical reasons, the flutter tool uploads dill files to paths based on the entrypoint URI. This isn't actually necessary, and the tool can use specific files : main.dart.incremental.dill for incremental dills, and main.dart.dill/main.dart.swap.dill for full dills. This allows hot restarting applications with an entrypoint outside of lib/ and simplifies the devFS code.

Fixes #63243
2020-10-12 09:47:41 -07:00
xubaolin
8538b4f546
Fix TextField bug when the formatter repeatedly format (#67892) 2020-10-12 09:37:03 -07:00
chunhtai
345188d40e
make Router.of nullable (#67683) 2020-10-12 09:32:07 -07:00
Jonah Williams
08576cb671
[flutter_tools] HACKTOBERFEST (#67882)
HACKTOBERFEST
2020-10-12 09:31:02 -07:00
xubaolin
8211aaa2ae
Fix ListTile assert when layout at zero size (#66798)
* Fix ListTile assert when layout at zero size #66636
2020-10-12 17:25:38 +08:00
xubaolin
d914d5d2f9
Fix typos in the [BottomNavigationBar] document (#67811) 2020-10-12 02:22:01 -07:00
Alexandre Ardhuin
eefcff900c
Final definite assignment (#67682) 2020-10-10 14:42:02 -07:00
Jonah Williams
1a9d635f64
[flutter_tools] remove --with-driver-test (#67783)
Remove flutter create --with-driver-test . Fixes #64095
2020-10-09 21:03:37 -07:00
Dan Field
8bb61c3801
Reland ensure visible fix for nested viewports (#67773)
* Revert "Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)"

This reverts commit e8812c409b646d44ade244c6d425c47940214c6b.

* Fix for page views

* comment
2020-10-09 17:40:33 -07:00
Marcin Jeleński
439992472a
Export finder factory (#67779) 2020-10-09 16:50:54 -07:00
Alexander Markov
1973cf2d6c
Remove uses of bytecode mode of Dart VM (#67755) 2020-10-09 16:33:06 -07:00
James D. Lin
e4206ac5dd
[flutter tools] Add a DelegatingLogger class (#67581)
[flutter tools] Add a DelegatingLogger class

Move most of `DelegateLogger` `from test/src/testbed.dart` to
`lib/src/base/logger.dart` to better formalize the common practice of
chaining `Logger`s together.  I renamed the class since it isn't
itself the delegate and to better match the `Delegating...` classes
from `package:collection`.

Additionally, add a freestanding `asLogger<T>` function to "cast" a
`Logger` into a matching delegate if possible.  This will allow
`Logger` chains to be ordered a *bit* more freely (e.g.
`NotifyingLogger` and `AppRunLogger` will no longer required to be
at the end of the chain, an unwritten rule that has led to breakage in
google3).  Chain order still matters since lack of virtual dispatch
means that parent `Logger`s can never invoke child methods, however.

I made `asLogger<T>` a freestanding function because I didn't want to
make it part of the `Logger` interface (and I thought that making it
an extension method might be weird).

Bonus cleanup:
There no longer appears to be a way to construct an `AppRunLogger`
with a null parent, so remove all of code paths for that case and
make the `parent` construction parameter required.
2020-10-09 15:55:24 -07:00
Jonah Williams
bdb830a833
[flutter_tools] pretty print hot reload rejection error (#66701)
If the vm of an attached device rejects a hot reload, pretty print the reason. Suggest a hot restart so that users are aware that they do not have to detach and rebuild. Also resets the last compilation time, so a subsequent restart would still apply the last change. Adds an integration test for the const field removal.

Fixes #64027
2020-10-09 15:44:52 -07:00
Jonah Williams
5fa801718f
[flutter_tools] remove train and inject-plugins command (#67766)
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.

#29805
2020-10-09 15:43:39 -07:00
Jonah Williams
92702a28ec
Revert "Flutter driver patch: export finder factory (#67769)" (#67777)
This reverts commit be5830cdf0915c5df929e2523885da3eb553f247.
2020-10-09 15:16:24 -07:00
Greg Spencer
c083f02f3a
Migrate more material tests to NNBD (#67674)
This migrates more material tests to NNBD.
2020-10-09 14:58:13 -07:00
Marcin Jeleński
be5830cdf0
Flutter driver patch: export finder factory (#67769) 2020-10-09 14:49:45 -07:00
Marcin Jeleński
759ddb1ccd
Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety (#67711)
* Flutter Driver - Create widget finders from serialized finders extensions
2020-10-09 13:28:25 -07:00
Matej Knopp
24abe59f38
Provide oldLayer where possible (#67320) 2020-10-09 13:07:05 -07:00
Jonah Williams
cba84d5127
[flutter_tools] remove globals from IntelliJ validator, refactor tests to remove dependency on JAR (#67240)
Move the intellij validator to its own file, and split off the tests. Remove globals from each, and remove dependency on a real jar/filesystem by creating a minimal version of the manifest xml and setting it up in the memory file system.

#47161
2020-10-09 13:05:42 -07:00
Jonah Williams
9a3a0dc18f
[flutter_tools] hot reload/restart update for asset manager change (#66742)
Do not upload all assets on initial devFS sync. This should increase the reliability of the initial connection, even in the face of flaky devfs behavior, in addition to a moderate perf improvement.

Updates fast-start to build assets as part of the initial bundle

Requires flutter/engine#21436
Requires flutter/engine#21586
Requires flutter/engine#21611
2020-10-09 12:25:15 -07:00
nturgut
a755c03819
Add web e2e to the flutter/flutter repo (#67693)
* adding tests that uses integration_test (e2e) package to flutter

* change the package name for the import

* fix licenses. fix README commands. add links

* adding dependency change auto generated by the tool

* more analyzer error fixes
2020-10-09 12:24:36 -07:00
Michael Goderbauer
0dc10deb79
Fix tree (#67751) 2020-10-09 11:12:57 -07:00
Michael Goderbauer
793678d50e
Migrate tests to null-safety (#67692) 2020-10-09 10:42:02 -07:00
Nan Kim
28a9a6b48c
Add sample code for CupertinoActionSheet (#65274) 2020-10-09 09:08:13 -07:00
Per Classon
8d80592d46
Add tristate to parent checkbox for DataTable (#67414)
* Add tristate to parent checkbox for DataTable to follow Material specifications
2020-10-09 16:33:39 +02:00
Rami
bbf1b5579f
[Material] Time picker semantics updates (#67562) 2020-10-09 10:28:20 -04:00
Per Classon
ee08c2278a
Add decoration parameter to DataTable and DataTableTheme (#66640)
* Add decoration parameter to DataTable and DataTableTheme
2020-10-09 14:11:17 +02:00
Jenn Magder
98aeef2d98
Build xcarchive command (#67598) 2020-10-08 19:51:35 -07:00
Mouad Debbar
ffcf419136
[web] Support custom url strategies (#59797) 2020-10-08 17:57:02 -07:00
Jonah Williams
4f2fcca6a9
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" (#67570) 2020-10-08 17:42:02 -07:00
Greg Spencer
1bcaf94062
Fix nullability warnings in routes_test (#67694) 2020-10-08 17:02:33 -07:00
Jenn Magder
f92ba2d2c5
Replace MockUsage with Usage.test in build tests (#67670) 2020-10-08 16:09:49 -07:00
xster
41325b5677
Turn timer_picker_test goldens back on (#67555) 2020-10-08 15:57:03 -07:00
Michael Goderbauer
d127f2c94a
Fix nullability for some routing related stuff (#67675) 2020-10-08 15:56:31 -07:00
Jonah Williams
4042eb97b9
Revert "Flutter Driver - Create widget finders from serialized finders extensions (#67456)" (#67687)
This reverts commit 74f6fa4564784090874a5023eabce4a1c8e13da0.
2020-10-08 15:34:55 -07:00
Marcin Jeleński
74f6fa4564
Flutter Driver - Create widget finders from serialized finders extensions (#67456) 2020-10-08 15:27:02 -07:00
chunhtai
cb0bdb4994
make router assert more strict (#67672) 2020-10-08 14:12:03 -07:00
Jonah Williams
973404a27f
[flutter_tools] support powershell style help request (#67493) 2020-10-08 14:06:58 -07:00
Jason Simmons
e3c441e0fd
Replace the flag emoji in the emoji caret test with a modifier sequence (#67652) 2020-10-08 13:52:09 -07:00
Greg Spencer
58287aceef
Convert services tests to NNBD (#62694)
This converts the packages/flutter/test/services directory to NNBD, now that the services package is converted.

I changed the signature of checkMessageHandler and checkMockMessageHandler on BinaryMessenger to take a nullable handler, since the tests wanted to check to make sure a handler wasn't set, and that functionality no longer works if the handler is non-nullable.
2020-10-08 13:46:44 -07:00
Jonah Williams
ddab09f553
[flutter_tools] enable LocalDevFSWriter for desktop devices, iOS simulator (#66678)
* [flutter_tools] enable LocalDevFSWriter for desktop devices, iOS simulator

* Update device.dart

* Update desktop_device_test.dart

* fix analysis errors
2020-10-08 13:40:19 -07:00
Christopher Fujino
ccdaa37043
Remove the .zip method from OSUtils, as it was not used (#67367)
We used to use zip to verify the integrity of downloaded zip archives, but we now use unzip. This removes the .zip method from OperatingSystemUtils.
2020-10-08 13:40:01 -07:00
Justin McCandless
96ae589a2e
Fix new analyzer rule failure (#67656) 2020-10-08 12:47:46 -07:00