gaaclarke
6596a35625
Reland: Hooks up framework wide gamut to engine wide gamut ( flutter/engine#54906 )
...
relands https://github.com/flutter/engine/pull/54567
depends on https://github.com/flutter/engine/pull/54905
This was reverted because the PR that it depends on was reverted. There is nothing to be addressed here.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-30 18:22:04 +00:00
skia-flutter-autoroll
94750958ca
Roll Fuchsia Linux SDK from ohUS2y1HixZYziUtX... to JKPo9G1NaAdstrimW... ( flutter/engine#54907 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 18:12:59 +00:00
gaaclarke
df9fc7786b
Reland: Framework wide color ( #54415 ) ( #54737 ) ( flutter/engine#54905 )
...
[This PR](https://github.com/flutter/engine/pull/54415 ) was reverted
because it required customer testing updates.
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415
This does the preliminary work for implementing wide gamut colors in the
Flutter framework. Here are the following changes: 1) colors now specify
a colorspace with which they are to be interpreted 1) colors now store
their components as floats to accommodate bit depths more than 8
The storage of this Color class is weird with float/int storage but that
is a temporary solution to support a smooth transition. Here is the plan
for landing this: 1) Land this PR
1) Wait for it to roll into the Framework
1) Land https://github.com/flutter/flutter/pull/153938 which will make
CupertinoDynamicColor implement Color 1) Land another engine PR that
rips out the int storage: https://github.com/flutter/engine/pull/54714
Here are follow up PRs:
1) https://github.com/flutter/engine/pull/54473 - changes DlColor so the
wide gamut colors are rendered 1)
https://github.com/flutter/engine/pull/54567 - Hooks up these changes to
take advantage of wide DlColor 1)
https://github.com/flutter/flutter/pull/153319 - the integration test
for the framework repo
There are some things that have been left as follow up PRs since they
are technically breaking: 1) The math on `lerp` hasn't been updated to
take advantage of the higher bit depth 1) `operator==` hasn't been
updated to take advantage of the higher bit depth 1) `hashCode` hasn't
been updated to take advantage of the higher bit depth 1) `alphaBlend`
hasn't been updated to take advantage of the higher bit depth 1)
`toString` hasn't been updated to take advantage of the higher bit depth
## Reland 2 notes
This was reverted because it changes the math on `_lerpDouble`. While
those changes were mathematcially equivalent, they had different
behaviors when working with non-numbers which created unexpected
changes. The change has been reverted and a test added.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-30 10:33:07 -07:00
skia-flutter-autoroll
285d77e993
Roll Skia from f3811180e7df to 2727e4e5d7ec (3 revisions) ( flutter/engine#54904 )
...
https://skia.googlesource.com/skia.git/+log/f3811180e7df..2727e4e5d7ec
2024-08-30 brianosman@google.com Remove SkColorFilter::filterColor
2024-08-30 egdaniel@google.com [Dawn] Add remaining changes to enable ycbcr sampling in Dawn
2024-08-30 lukasza@chromium.org [rust png] Minimal `on[Start]IncrementalDecode` implementation.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 17:09:53 +00:00
skia-flutter-autoroll
f0e1eb0511
Roll Skia from 2b633f7626ea to f3811180e7df (2 revisions) ( flutter/engine#54900 )
...
https://skia.googlesource.com/skia.git/+log/2b633f7626ea..f3811180e7df
2024-08-30 egdaniel@google.com [Graphite] Fix Vulkan Protected in BackendTexture tests.
2024-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 83affe9d7595 to 3b60161f180b (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 14:57:32 +00:00
skia-flutter-autoroll
60604f1091
Roll Fuchsia Test Scripts from DtxLvjJOVzo_oZGui... to p5MYp7o9Tt0sossYJ... ( flutter/engine#54899 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 14:53:29 +00:00
auto-submit[bot]
9eacec1bbc
Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) ( #54886 )" ( flutter/engine#54902 )
...
Reverts: flutter/engine#54886
Initiated by: zanderso
Reason for reverting: An issue with `dart fix` is failing the roll to the framework.
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/139867e57ba9..88d311c9a531
2024-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-199.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 14:49:26 +00:00
auto-submit[bot]
6ff48eade1
Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) ( #54896 )" ( flutter/engine#54901 )
...
Reverts: flutter/engine#54896
Initiated by: zanderso
Reason for reverting: Reverting Dart rolls for an issue with `dart fix`.
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/88d311c9a531..995324d1b218
2024-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-200.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 14:20:50 +00:00
skia-flutter-autoroll
406a8dd0fb
Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) ( flutter/engine#54896 )
...
https://dart.googlesource.com/sdk.git/+log/88d311c9a531..995324d1b218
2024-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-200.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 13:15:24 +00:00
skia-flutter-autoroll
e7370d7795
Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... ( flutter/engine#54891 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 08:40:35 +00:00
skia-flutter-autoroll
e8f1a34853
Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) ( flutter/engine#54890 )
...
https://skia.googlesource.com/skia.git/+log/c23d19fdf117..2b633f7626ea
2024-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c094d4bc2343 to b43f888968df (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 08:26:17 +00:00
skia-flutter-autoroll
f99439c19e
Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) ( flutter/engine#54889 )
...
https://skia.googlesource.com/skia.git/+log/9ce15f8b2c7e..c23d19fdf117
2024-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e04dcb74a523 to 3bd0a4a92866 (7 revisions)
2024-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2d913200c831 to 91a753ae9ce1 (20 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 07:09:23 +00:00
skia-flutter-autoroll
285f34741a
Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) ( flutter/engine#54886 )
...
https://dart.googlesource.com/sdk.git/+log/139867e57ba9..88d311c9a531
2024-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-199.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 05:47:17 +00:00
auto-submit[bot]
7b38e8d173
Reverts "Reland: Framework wide color ( #54415 ) ( #54737 )" ( flutter/engine#54885 )
...
Reverts: flutter/engine#54737
Initiated by: chingjun
Reason for reverting: Breaking internal tests. See b/363125155
Original PR Author: gaaclarke
Reviewed By: {matanlurey, jonahwilliams}
This change reverts the following previous change:
[This PR](https://github.com/flutter/engine/pull/54415 ) was reverted because it requires a manual roll into the framework.
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415
This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8
The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this:
1) Land this PR
1) Wait for it to roll into the Framework
1) Land https://github.com/flutter/flutter/pull/153938 which will make CupertinoDynamicColor implement Color
1) Land another engine PR that rips out the int storage: https://github.com/flutter/engine/pull/54714
Here are follow up PRs:
1) https://github.com/flutter/engine/pull/54473 - changes DlColor so the wide gamut colors are rendered
1) https://github.com/flutter/engine/pull/54567 - Hooks up these changes to take advantage of wide DlColor
1) https://github.com/flutter/flutter/pull/153319 - the integration test for the framework repo
There are some things that have been left as follow up PRs since they are technically breaking:
1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth
1) `operator==` hasn't been updated to take advantage of the higher bit depth
1) `hashCode` hasn't been updated to take advantage of the higher bit depth
1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth
1) `toString` hasn't been updated to take advantage of the higher bit depth
2024-08-30 04:31:26 +00:00
auto-submit[bot]
677c70aa8a
Reverts "Hooks up framework wide gamut to engine wide gamut ( #54567 )" ( flutter/engine#54884 )
...
Reverts: flutter/engine#54567
Initiated by: chingjun
Reason for reverting: Breaking internal tests. See b/363125155
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams, chinmaygarde}
This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-30 04:27:48 +00:00
Jonah Williams
beb4e397b3
[android] Disable AHB swapchain and import on huawei API 29 devices. ( flutter/engine#54879 )
...
From local testing, it seems that AHB imports and swapchain usage of AHBs does not work on these Huawei devices. Vulkan does seem to work OK with these optional features disabled, but so far we've only tested on the P40 Pro.
Fixes https://github.com/flutter/flutter/issues/154068
* https://github.com/flutter/flutter/issues/153228
* https://github.com/flutter/flutter/issues/153762
* https://github.com/flutter/flutter/issues/154068
2024-08-30 00:09:24 +00:00
gaaclarke
fdc343efec
Hooks up framework wide gamut to engine wide gamut ( flutter/engine#54567 )
...
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-29 23:22:07 +00:00
skia-flutter-autoroll
b6a477db73
Roll Skia from 82e12bf2991a to 9ce15f8b2c7e (4 revisions) ( flutter/engine#54881 )
...
https://skia.googlesource.com/skia.git/+log/82e12bf2991a..9ce15f8b2c7e
2024-08-29 lukasza@chromium.org [rust png] Use public header of skcms.
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e5360151769c to 83affe9d7595 (4 revisions)
2024-08-29 brianosman@google.com Prevent overflow when growing an SkRegion's RunArray
2024-08-29 jlavrova@google.com RemoteStrike should use typeface Id from StrikeSpec
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 23:20:36 +00:00
skia-flutter-autoroll
c24235c3bc
Roll Dart SDK from e6ccd7185482 to 139867e57ba9 (1 revision) ( flutter/engine#54880 )
...
https://dart.googlesource.com/sdk.git/+log/e6ccd7185482..139867e57ba9
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-198.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 22:44:13 +00:00
skia-flutter-autoroll
e295d95517
Roll Skia from 1d16eab57a8e to 82e12bf2991a (6 revisions) ( flutter/engine#54876 )
...
https://skia.googlesource.com/skia.git/+log/1d16eab57a8e..82e12bf2991a
2024-08-29 maxhudnell@google.com First commit to skia
2024-08-29 fmalita@google.com [mesh2d] Enable the origin trial for demo app
2024-08-29 egdaniel@google.com [Graphite] Add finished procs to updateBackendTexture.
2024-08-29 kjlubick@google.com Update gpu version for Intel Iris Xe tasks
2024-08-29 brianosman@google.com Check for size overflow before allocating SkMask data
2024-08-29 egdaniel@google.com [Graphite] Allow Vulkan to run UpdateImageBAckendTextureTest.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 20:40:05 +00:00
John Bauman
d3d50bb57d
Use fuchsia.scheduler.RoleManager protocol ( flutter/engine#54587 )
...
As of f20, fuchsia.scheduler.RoleManager is preferred over fuchsia.media.ProfileProvider. The Vulkan ICD uses fuchsia.scheduler.RoleManager and is loaded into the flutter component, so the component needs to use the fuchsia.scheduler.RoleManager protocol.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/153591
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-29 20:14:00 +00:00
zijiehe@
be83f077ed
[fuchsia] Remove duplicate gn_configs ( flutter/engine#54855 )
...
Change https://crrev.com/c/5823950 moved most of the gn_configs to
fuchsia-gn-sdk, and they are not needed to be repeated again in
the gn_configs.gni anymore
Bug: [359657446](http://crbug.com/359657446 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-29 13:12:03 -07:00
skia-flutter-autoroll
5115e49f34
Roll Skia from 10e44e318a72 to 1d16eab57a8e (3 revisions) ( flutter/engine#54874 )
...
https://skia.googlesource.com/skia.git/+log/10e44e318a72..1d16eab57a8e
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e04dcb74a523 to 956883ecef1d
2024-08-29 borenet@google.com [infra] Tweaks for bazel_build task driver
2024-08-29 lukasza@chromium.org [rust png] Reuse `applyXformRow` from `SkPngRustCodec`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 19:20:10 +00:00
gaaclarke
3b2f540e54
Reland: Framework wide color ( #54415 ) ( flutter/engine#54737 )
...
[This PR](https://github.com/flutter/engine/pull/54415 ) was reverted because it requires a manual roll into the framework.
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415
This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8
The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this:
1) Land this PR
1) Wait for it to roll into the Framework
1) Land https://github.com/flutter/flutter/pull/153938 which will make CupertinoDynamicColor implement Color
1) Land another engine PR that rips out the int storage: https://github.com/flutter/engine/pull/54714
Here are follow up PRs:
1) https://github.com/flutter/engine/pull/54473 - changes DlColor so the wide gamut colors are rendered
1) https://github.com/flutter/engine/pull/54567 - Hooks up these changes to take advantage of wide DlColor
1) https://github.com/flutter/flutter/pull/153319 - the integration test for the framework repo
There are some things that have been left as follow up PRs since they are technically breaking:
1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth
1) `operator==` hasn't been updated to take advantage of the higher bit depth
1) `hashCode` hasn't been updated to take advantage of the higher bit depth
1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth
1) `toString` hasn't been updated to take advantage of the higher bit depth
2024-08-29 19:02:59 +00:00
skia-flutter-autoroll
4a9bdeaebc
Roll Dart SDK from 3c1bb8338b79 to e6ccd7185482 (2 revisions) ( flutter/engine#54872 )
...
https://dart.googlesource.com/sdk.git/+log/3c1bb8338b79..e6ccd7185482
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-197.0.dev
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-196.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 18:17:22 +00:00
Matan Lurey
d740f70f7d
Fix build/dart/rules.gni which contains erroneous code after my refactor. ( flutter/engine#54867 )
...
In https://github.com/flutter/engine/pull/54845 , I removed `common_vm_args = ['--disable-dart-dev']`, but the resulting change created invalid code `vm_args = (args = common_args)`. We don't seem to run this configuration on our own CI, so it wasn't noticed, but it broke the Dart monorepo build, which does use it:
https://ci.chromium.org/p/dart/g/monorepo/console
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738311211510911329/+/u/gn_--runtime-mode_debug_--full-dart-sdk_--rbe_--no-goma_--unoptimized_--no-prebuilt-dart-sdk_--gn-args_engine_version__5295ec1b816af727165015d84d4a1091520122ae__--rbe-server-address_unix:___b_s_w_ir_x_w_recipe_cleanup_rbe4v23ir8o_reproxy.sock/stdout
I am open to reverting instead, but this seems straight-forward enough for something that isn't tested on either pre or post-submit.
2024-08-29 16:50:55 +00:00
skia-flutter-autoroll
3cb84525d1
Roll Skia from 20b3af58d4a5 to 10e44e318a72 (1 revision) ( flutter/engine#54869 )
...
https://skia.googlesource.com/skia.git/+log/20b3af58d4a5..10e44e318a72
2024-08-29 lukasza@chromium.org [rust png] Better encapsulation of `SkPngCodec::initializeXforms`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 16:50:52 +00:00
skia-flutter-autoroll
7209341ef8
Roll Fuchsia Linux SDK from ZL8AvfXX5LFIH1LYN... to ohUS2y1HixZYziUtX... ( flutter/engine#54868 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 16:49:15 +00:00
Matan Lurey
1e6dde4eb1
Migrate another big chunk of the engine repo to package:test ( flutter/engine#54853 )
...
There are almost no behavioral changes.
Because `dart test` runs with assertions, and the former command does not, I had to tweak some of the engine tool tests because they would assert that there were duplicate names - but I didn't change any actual code besides the test expectations themselves/the fixtures.
This is not all of the engine, but is approximately 1/3 of all imports of `package:litetest` migrated.
2024-08-29 15:35:52 +00:00
skia-flutter-autoroll
31eb6227a2
Roll Skia from 31406e74142b to 20b3af58d4a5 (2 revisions) ( flutter/engine#54866 )
...
https://skia.googlesource.com/skia.git/+log/31406e74142b..20b3af58d4a5
2024-08-29 kjlubick@google.com Add moved mock Ganesh files to ganesh_mock target
2024-08-29 danieldilan@google.com GPU support for 101010x color type (RGB only) and fixed some tests.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 15:26:23 +00:00
skia-flutter-autoroll
bd3882b56e
Roll Dart SDK from 0caad7938587 to 3c1bb8338b79 (1 revision) ( flutter/engine#54864 )
...
https://dart.googlesource.com/sdk.git/+log/0caad7938587..3c1bb8338b79
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-195.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 13:30:37 +00:00
skia-flutter-autoroll
bd9d905b55
Roll Skia from 253b10915d32 to 31406e74142b (2 revisions) ( flutter/engine#54863 )
...
https://skia.googlesource.com/skia.git/+log/253b10915d32..31406e74142b
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 804d105c7169 to e5360151769c (3 revisions)
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 851f949bc3a1 to c094d4bc2343 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 12:46:24 +00:00
skia-flutter-autoroll
e74661e050
Roll Dart SDK from fed5ce7ea2ad to 0caad7938587 (1 revision) ( flutter/engine#54862 )
...
https://dart.googlesource.com/sdk.git/+log/fed5ce7ea2ad..0caad7938587
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-194.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 09:10:23 +00:00
skia-flutter-autoroll
728e6a3682
Roll Skia from dac455fdf502 to 253b10915d32 (1 revision) ( flutter/engine#54860 )
...
https://skia.googlesource.com/skia.git/+log/dac455fdf502..253b10915d32
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fb93bdd85957 to e04dcb74a523 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 07:45:26 +00:00
skia-flutter-autoroll
97a7bbace5
Roll Skia from e37b6b198016 to dac455fdf502 (1 revision) ( flutter/engine#54859 )
...
https://skia.googlesource.com/skia.git/+log/e37b6b198016..dac455fdf502
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d90557b380fa to 2d913200c831 (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 06:16:06 +00:00
Jonah Williams
95d3280800
[engine] add an ios noop context. ( flutter/engine#54856 )
...
This is required to allow simulators to run without exiting when impeller is enabled and there is no available metal contxt.
2024-08-29 05:07:24 +00:00
Jonah Williams
4385a96ee1
[Impeller] Use multiple command buffers for blur submission. ( flutter/engine#54846 )
...
Fixes https://github.com/flutter/flutter/issues/154046
Use three different command buffers when it would be possible to combine the operations into a single buffer. From testing and user bug reports (see https://github.com/flutter/flutter/issues/154046 ), this sometimes causes deviceLost errors on older Adreno devices. Breaking the work up into three different command buffers seems to prevent this crash.
I suspect this is due to some internal timeouts we may be hitting in the adreno driver.
2024-08-29 01:23:31 +00:00
skia-flutter-autoroll
355475444a
Roll Skia from 0d8d9d2974fa to e37b6b198016 (1 revision) ( flutter/engine#54854 )
...
https://skia.googlesource.com/skia.git/+log/0d8d9d2974fa..e37b6b198016
2024-08-28 jlavrova@google.com Revert "Split FreeType & FontConfig, step #1 "
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 00:18:21 +00:00
Matan Lurey
87727168e8
Remove --disable-dart-dev across flutter/engine. ( flutter/engine#54845 )
...
As per the Dart CLI team and @bkonyi, this is no longer providing value and we shouldn't cargo-cult it.
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-08-29 00:12:32 +00:00
skia-flutter-autoroll
3141bb2cbe
Roll Fuchsia Test Scripts from vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... ( flutter/engine#54852 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 23:46:22 +00:00
Jonah Williams
83e59dbe68
[Impeller] fix clip culling with exp canvas. ( flutter/engine#54701 )
...
Fixes performance problem where image filters break clip culling, and lack of clip culling stops the clear color optimization from firing.
on the current canvas the cull rect computation is slightly incorrect, as we drop it as soon as we get a image filter. With the new canvas, we have the actual render target sizes, so we can correctly cull without it.
After switching to experimental canvas, I will remove the cull rect field from the canvas stack entry - as the clip coverage stack already performs basically the same culling.
This fixes the performance issue on the uncached zoom page transition where we lose the clear color optimization too early.
2024-08-28 23:36:09 +00:00
skia-flutter-autoroll
fd64484d2c
Roll Dart SDK from bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) ( flutter/engine#54851 )
...
https://dart.googlesource.com/sdk.git/+log/bc3dad16b2d3..fed5ce7ea2ad
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-193.0.dev
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 22:51:20 +00:00
skia-flutter-autoroll
e7df189b08
Roll Skia from d55406ca32e9 to 0d8d9d2974fa (4 revisions) ( flutter/engine#54850 )
...
https://skia.googlesource.com/skia.git/+log/d55406ca32e9..0d8d9d2974fa
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 03b32d20940d to d90557b380fa (4 revisions)
2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1
2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType."
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 22:45:12 +00:00
Jackson Gardner
c518ebc094
[skwasm] Always do backdrop filter operation even if empty. ( flutter/engine#54844 )
...
This is a partial fix for https://github.com/flutter/flutter/issues/152026
We are still blocked on https://g-issues.skia.org/issues/362552959 for things to be completely working.
2024-08-28 21:19:54 +00:00
Matan Lurey
712e7b9a05
Migrateheader_guard_check to package:test. ( flutter/engine#54811 )
...
Work towards https://github.com/flutter/flutter/issues/133569 .
I also augmented the `run_tests.py` script to support an incremental migration to `package:test`, PTAL.
2024-08-28 21:12:12 +00:00
skia-flutter-autoroll
6929e0f92a
Roll Fuchsia GN SDK from OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... ( flutter/engine#54848 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-gn-sdk-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 21:06:05 +00:00
skia-flutter-autoroll
b8c02b83e3
Roll Skia from cd3d3daafe55 to d55406ca32e9 (10 revisions) ( flutter/engine#54847 )
...
https://skia.googlesource.com/skia.git/+log/cd3d3daafe55..d55406ca32e9
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 23ed8d76c58a to 804d105c7169 (4 revisions)
2024-08-28 brianosman@google.com Fix viewer scaling when changing displays on Mac
2024-08-28 jamesgk@google.com [ganesh] Fix NonAALatticeOp combine check
2024-08-28 jamesgk@google.com [ganesh] Avoid int overflow in PatternHelper
2024-08-28 bungeman@google.com [pdf] extract_cff_data doesn't need ownership
2024-08-28 robertphillips@google.com [graphite] Add example Chrome Precompilation
2024-08-28 lukasza@chromium.org [rust png] Inline `SkPngCodec::fBitDepth` field.
2024-08-28 lukasza@chromium.org [rust png] Use `this->` prefix for method calls (for consistent style).
2024-08-28 lukasza@chromium.org [rust png] Use `SkSpan` for `dst` manipulations in `onGetPixels`.
2024-08-28 robertphillips@google.com [graphite] Set up the FakeWGPU job just like the other Graphite_Dawn jobs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 19:51:48 +00:00
Jonah Williams
30eeaf6e98
[Impeller] ensure that srcOver to src conversion takes stroke coverage into account. ( flutter/engine#54817 )
...
When computing whether or not an entity can be coerced into src blend from srcOver, take into account that stroke geometries may modulate with alpha to emulate stroke widths less than 1.0.
While we're at it, update several computations to use max basis XY (from https://github.com/flutter/flutter/issues/153451 ) since that can lead to incorrect stroke width computations in the presence of canvas scaling.
Most of the changes update the APIs that used to take a ` const Entity& entity` to instead use the `const Matrix& transform`, since that is all we used the entity for.
See screeenshots in https://github.com/flutter/flutter/issues/154178#issuecomment-2313714407
Fixes https://github.com/flutter/flutter/issues/154178
2024-08-28 18:49:24 +00:00
skia-flutter-autoroll
1e1cc048ba
Roll Fuchsia GN SDK from ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... ( flutter/engine#54840 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-gn-sdk-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 18:15:52 +00:00
Matan Lurey
8a7a89d6f0
Remove scorecards and other bading we are no longer tracking/links are borked ( flutter/engine#54839 )
...
Similar to the work in https://github.com/flutter/flutter/issues/153626 .
2024-08-28 18:14:04 +00:00
