firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,473 Commits 1 Branch 0 Tags
Commit Graph

43473 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Martin Kustermann
e2d8121708
Remove dependency on [Target] and instead operate on [Architecture] (#159196) 
The dart-lang/native repository contains a `Target` class that is almost
not needed anymore. The remaining uses are mainly due to kernel asset
mapping (which we may be able to remove in the future).

This PR removes usages of that `Target` (in favor of `Architecture`)
class in most places in flutter tools.
This makes the code also cleaner because we no longer have an implicit
assumption that
a `List<Target>` all belong to the same operating system.
 2024-11-20 12:44:43 +00:00
HongeSun
15a03a4ada
Fix git command in Quality-Assurance.md (#155146) 
Correct the Quality-Assurance contributing doc's wrong git command.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-11-20 06:32:04 +00:00
engine-flutter-autoroll
0234757554
Roll Flutter Engine from 7eb87547cbc6 to 3f19207e820e (4 revisions) (#159176) 
7eb87547cb...3f19207e82

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from d776efdac21b to
2614590b4f32 (1 revision) (flutter/engine#56718)
2024-11-19 chris@bracken.jp TestMetalContext: Use ARC-managed Metal
types (flutter/engine#56717)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from a694b9e85a49 to
d776efdac21b (3 revisions) (flutter/engine#56716)
2024-11-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
b01654fa26c7 to dde57dc75c15 (3 revisions) (flutter/engine#56714)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 00:21:22 +00:00
Matan Lurey
1fdcb757fd
Make runner non-nullable as it always is. (#159156) 2024-11-20 00:11:39 +00:00
Taha Tesser
1686fa7eb4
Update Material 3 CircularProgressIndicator for new visual style (#158104) 
Related [Update both `ProgressIndicator` for Material 3
redesign](https://github.com/flutter/flutter/issues/141340)
Fixes [Issue: Cannot theme progress indicators, many properties
missing](https://github.com/flutter/flutter/issues/131690)
Fixes [Cannot override default `CircularProgressIndicator`
size](https://github.com/flutter/flutter/issues/158106)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
          // progressIndicatorTheme: const ProgressIndicatorThemeData(
          //   constraints: BoxConstraints.tightFor(width: 100, height: 100),
          //   strokeWidth: 12
          // ),
          ),
      home: Scaffold(
        appBar: AppBar(title: const Text('CircularProgressIndicator')),
        body: const Center(
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: [
              CircularProgressIndicator(year2023: false, value: 0.5),
              CircularProgressIndicator(year2023: false),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Preview 

<img width="579" alt="Screenshot 2024-11-04 at 16 01 57"
src="https://github.com/user-attachments/assets/d27768c6-5570-48d0-9eed-565e02be8041">

### New custom `CircularProgressIndicator.constraints` and stroke  width

<img width="579" alt="Screenshot 2024-11-04 at 16 02 40"
src="https://github.com/user-attachments/assets/c67c4a31-58f4-4f82-bfb6-f1b78a000bac">


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 23:23:26 +00:00
engine-flutter-autoroll
a1c7a0dda4
Roll Flutter Engine from 4ff696b555dc to 7eb87547cbc6 (3 revisions) (#159168) 
4ff696b555...7eb87547cb

2024-11-19 chris@bracken.jp EmbedderTest: templatise GetEmbedderContext
(flutter/engine#56709)
2024-11-19 chris@bracken.jp display_list: Extract backend-specific
surface providers (flutter/engine#56711)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 78ef6b7a574f to
a694b9e85a49 (5 revisions) (flutter/engine#56713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 21:55:12 +00:00
Jenn Magder
c12f75066d
Add platform-android label for all flutter_tools *android* files (#159166) 
Label PRs that touch any `*android*` files in flutter_tool with
`platform-android`. In particular this should catch the template android
directories.

Labeler log:
https://github.com/flutter/flutter/actions/runs/11921551623/job/33225914301?pr=159166#step:2:240

<details>

<summary>Included files</summary>

```
$ git ls-files 'packages/flutter_tools/*android**'
packages/flutter_tools/ide_templates/intellij/dev/manual_tests/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/flutter_gallery/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/hello_world/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_channel/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_view/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/stocks/android.iml.copy.tmpl
packages/flutter_tools/lib/src/android/README.md
packages/flutter_tools/lib/src/android/adb.dart
packages/flutter_tools/lib/src/android/android.dart
packages/flutter_tools/lib/src/android/android_builder.dart
packages/flutter_tools/lib/src/android/android_console.dart
packages/flutter_tools/lib/src/android/android_device.dart
packages/flutter_tools/lib/src/android/android_device_discovery.dart
packages/flutter_tools/lib/src/android/android_emulator.dart
packages/flutter_tools/lib/src/android/android_sdk.dart
packages/flutter_tools/lib/src/android/android_studio.dart
packages/flutter_tools/lib/src/android/android_studio_validator.dart
packages/flutter_tools/lib/src/android/android_workflow.dart
packages/flutter_tools/lib/src/android/application_package.dart
packages/flutter_tools/lib/src/android/build_validation.dart
packages/flutter_tools/lib/src/android/deferred_components_gen_snapshot_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_prebuild_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_validator.dart
packages/flutter_tools/lib/src/android/gradle.dart
packages/flutter_tools/lib/src/android/gradle_errors.dart
packages/flutter_tools/lib/src/android/gradle_utils.dart
packages/flutter_tools/lib/src/android/java.dart
packages/flutter_tools/lib/src/android/migrations/android_studio_java_gradle_conflict_migration.dart
packages/flutter_tools/lib/src/android/migrations/cmake_android_16k_pages_migration.dart
packages/flutter_tools/lib/src/android/migrations/min_sdk_version_migration.dart
packages/flutter_tools/lib/src/android/migrations/multidex_removal_migration.dart
packages/flutter_tools/lib/src/android/migrations/top_level_gradle_build_file_migration.dart
packages/flutter_tools/lib/src/build_system/targets/android.dart
packages/flutter_tools/lib/src/commands/android_analyze.dart
packages/flutter_tools/lib/src/isolated/native_assets/android/native_assets.dart
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/src/main/java/androidIdentifier/MainActivity.java.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/src/main/kotlin/androidIdentifier/MainActivity.kt.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/debug/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable-v21/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-mdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values-night/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/profile/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle/wrapper/gradle-wrapper.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/settings.gradle.kts.tmpl
packages/flutter_tools/templates/module/android/deferred_component/build.gradle.tmpl
packages/flutter_tools/templates/module/android/deferred_component/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/gradle/build.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/gradle.properties.tmpl
packages/flutter_tools/templates/module/android/gradle/settings.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/java/androidIdentifier/host/MainActivity.java.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/values/styles.xml
packages/flutter_tools/templates/module/android/host_app_editable/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/host_app_ephemeral/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/flutter.iml.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/include_flutter.groovy.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/common/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/main/java/androidIdentifier/pluginClass.java.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/test/java/androidIdentifier/pluginClassTest.java.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/main/kotlin/androidIdentifier/pluginClass.kt.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/test/kotlin/androidIdentifier/pluginClassTest.kt.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin_shared/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/test/android_java11_integration.shard/android_dependency_version_checking_test.dart
packages/flutter_tools/test/android_preview_integration.shard/README.md
packages/flutter_tools/test/android_preview_integration.shard/flutter_build_preview_sdk_test.dart
packages/flutter_tools/test/commands.shard/hermetic/android_analyze_test.dart
packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart
packages/flutter_tools/test/general.shard/android/android_device_discovery_test.dart
packages/flutter_tools/test/general.shard/android/android_device_port_forwarder_test.dart
packages/flutter_tools/test/general.shard/android/android_device_start_test.dart
packages/flutter_tools/test/general.shard/android/android_device_test.dart
packages/flutter_tools/test/general.shard/android/android_emulator_test.dart
packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart
packages/flutter_tools/test/general.shard/android/android_install_test.dart
packages/flutter_tools/test/general.shard/android/android_project_migration_test.dart
packages/flutter_tools/test/general.shard/android/android_sdk_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_validator_test.dart
packages/flutter_tools/test/general.shard/android/android_workflow_test.dart
packages/flutter_tools/test/general.shard/android/build_validation_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_gen_snapshot_validator_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_prebuild_validator_test.dart
packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart
packages/flutter_tools/test/general.shard/android/gradle_find_bundle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_utils_test.dart
packages/flutter_tools/test/general.shard/android/java_test.dart
packages/flutter_tools/test/general.shard/android/migration/cmake_android_16k_pages_migration_test.dart
packages/flutter_tools/test/general.shard/android/template_test.dart
packages/flutter_tools/test/general.shard/android_plugin_test.dart
packages/flutter_tools/test/general.shard/build_system/targets/android_test.dart
packages/flutter_tools/test/general.shard/isolated/android/native_assets_test.dart
packages/flutter_tools/test/integration.shard/android_e2e_api_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_daemon_cache_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_deprecated_plugin_apply_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_flutter_source_path_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_java_version_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_legacy_flutter_plugins_strings_in_comments_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_outputs_app_link_settings_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_print_build_variants_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_example_app_build_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_ndkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_new_output_dir_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart
packages/flutter_tools/test/integration.shard/flutter_build_android_app_project_builddir_test.dart
packages/flutter_tools/test/integration.shard/gradle_non_android_plugin_test.dart
packages/flutter_tools/test/src/android_common.dart
```

</details>

Expand https://github.com/flutter/flutter/pull/158970

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 21:53:38 +00:00
engine-flutter-autoroll
79c5ae0c7a
Roll Flutter Engine from d5820a638885 to 4ff696b555dc (1 revision) (#159164) 
d5820a6388...4ff696b555

2024-11-19 47866232+chunhtai@users.noreply.github.com Update
Engine-Clang-Tidy-Linter.md (flutter/engine#56708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 20:51:18 +00:00
Bernardo Ferrari
1fdb159d11
Reland Add UI Benchmarks (#153368) 
Reland https://github.com/flutter/flutter/pull/143799 which is part 1 of
https://github.com/flutter/flutter/pull/138481 and
https://github.com/flutter/flutter/issues/146211.

Could someone run this in device-lab so we are 100% sure it works? I
don't know if it was a flake or what last time. Locally it works well.
 2024-11-19 20:47:15 +00:00
Mohellebi abdessalem
f0dc0b798f
fix lint usage of task inside resolve_dependecies.gradle file (#158022) 
according to
[Gradle](https://docs.gradle.org/current/userguide/task_configuration_avoidance.htmll)
:`As of Gradle 5.1, we recommend that the configuration avoidance APIs
be used whenever tasks are created.`

![writing-tasks-4](https://github.com/user-attachments/assets/407c79bb-7bfa-4bea-9b13-dec01c60dc1c)
what android studio lint is failing ?
![Capture d’écran 2024-11-01
214856](https://github.com/user-attachments/assets/af745305-6310-406c-b427-fb8a5dd5755c)


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 20:32:05 +00:00
engine-flutter-autoroll
41006014ab
Roll Flutter Engine from cff1e751f853 to d5820a638885 (5 revisions) (#159155) 
cff1e751f8...d5820a6388

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 0b74a1bb1b55 to
78ef6b7a574f (6 revisions) (flutter/engine#56707)
2024-11-19 chris@bracken.jp Move renderer config to EmbedderTestContext
(flutter/engine#56699)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 8a1a84509501 to
0b74a1bb1b55 (1 revision) (flutter/engine#56702)
2024-11-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
05d58364e92f to b01654fa26c7 (1 revision) (flutter/engine#56694)
2024-11-19 chris@bracken.jp EmbedderTest: Eliminate unused include
(flutter/engine#56698)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 19:38:09 +00:00
Mohellebi abdessalem
1d01955721
Removing redundant backticks in flutter\packages\flutter_tools\gradle\gradle.kts (#159051) 
`what android studio lint is failing ?`

![Capture d’écran 2024-11-19
110315](https://github.com/user-attachments/assets/d86605f6-0060-4721-9233-09d8ec5774d4)

![Capture d’écran 2024-11-19
110338](https://github.com/user-attachments/assets/7ee7465e-7a06-43db-bebb-ca87dda3cdc8)
see #147122
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:32:22 +00:00
Mairramer
fc53c71381
Fixes initial validation with AutovalidateMode.always on first build (#156708) 
Fixes #142701
This PR fixes an issue where on the first build
`AutovalidateMode.always` was not called.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:11:00 +00:00
Taha Tesser
56cfef73fc
Introduce new Material 3 Slider shapes (#152237) 
fixes [Update `Slider` for Material 3
redesign](https://github.com/flutter/flutter/issues/141842)
previous implementation https://github.com/flutter/flutter/pull/147783

### Description

This PR introduces new Material 3 Slider design. 

### Slider Preview

<img width="912" alt="Screenshot 2024-07-24 at 16 38 11"
src="https://github.com/user-attachments/assets/9645ff6c-b72a-40aa-ae95-4f76994f8302">

<img width="912" alt="Screenshot 2024-07-24 at 16 38 24"
src="https://github.com/user-attachments/assets/fbaed8bb-2717-43a9-9415-ea1365165d9a">

### Value indicator Preview



https://github.com/user-attachments/assets/45fa001c-de81-433a-a8e9-6c0d6a2335c0

### New stop indicator



https://github.com/user-attachments/assets/ad05621d-042d-4b17-9dbb-7f7b802a2593


### Customized 

<img width="912" alt="Screenshot 2024-07-24 at 16 41 49"
src="https://github.com/user-attachments/assets/2f279240-5af8-4bc8-9c65-a4b4ac718101">



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:10:44 +00:00
Matan Lurey
8536b96ebb
Terminate flutter test when no longer needed in integration test. (#159117) 
Towards https://github.com/flutter/flutter/issues/51421.

```sh
flutter_tools % dart test test/integration.shard/break_on_framework_exceptions_test.dart

02:38 +29: All tests passed!

54692 ttys003    0:00.02 /opt/homebrew/bin/zsh -il
```

Requires https://github.com/flutter/flutter/pull/159115 for the process
cleanup to work properly, but this is safe to land as-is, otherwise we
still accumulate `flutter` processes over and over as each test case
runs which is not WAI.
 2024-11-19 16:16:08 +00:00
Matan Lurey
c5379557b3
Terminate the test device if the flutter tool is signal-killed. (#159115) 
Closes https://github.com/flutter/flutter/issues/20949.

Signals (such as SIGTERM or SIGKILL) end up flowing through
`exitWithHooks`, which in turn, after running hooks, call `exit().` That
means, as a result, any `try { } finally { }` guarded execution may
_not_ run, which happens to also be how `flutter_tester` instances are
cleaned up if they have not terminated.

This PR adds in-progress `flutter_tester` runs (or any platform
`flutter_platform` supports) to the shutdown hooks, guaranteeing that
the finalizers (which in turn, kill the process) are _always_ executed
as long as either the test completes, _or_ `exitWithHooks` is called.

The existing integration tests (`integration.shard/test_test.dart`)
still pass as well.
 2024-11-19 16:10:32 +00:00
engine-flutter-autoroll
0e1c6330ea
Roll Packages from c1eabf5e32cc to fc4adc78aa24 (10 revisions) (#159143) 
c1eabf5e32...fc4adc78aa

2024-11-18 magder@google.com [ci] Take screenshot when native drive test
is taking longer than 10 minutes (flutter/packages#8050)
2024-11-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
for Most Remaining Plugin Example Apps (Part 3) (flutter/packages#8037)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7867)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8097)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7869)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android
(flutter/packages#8092)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7868)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7866)
2024-11-18 magder@google.com Add autosubmit label to dependabot PRs
(flutter/packages#8101)
2024-11-18 engine-flutter-autoroll@skia.org Roll Flutter from
0e2d55e0e7b2 to b3818f6b5979 (23 revisions) (flutter/packages#8118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 15:44:31 +00:00
Reid Baker
eea2fe7781
Deflake api 35 emulator tests by updating emulator definitions version to latest available from chrome infra (#158017) 
Update to the latest definitions of emulator configurations.

Specifically to past https://crrev.com/c/5908894 which added `gpu_mode:
"swangle_indirect"` to the api 35 proto. This should help with emulator
stability on versions past android 13.
Related to  b/371020223
Related: https://github.com/flutter/engine/pull/56313 
Research notes / my findings for how this system works at
go/flutter-android-ci-emulator
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-11-19 15:35:58 +00:00
engine-flutter-autoroll
87872a6095
Roll Flutter Engine from b6723e33b858 to cff1e751f853 (1 revision) (#159141) 
b6723e33b8...cff1e751f8

2024-11-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
io00npG_eDCYC7bac... to dJ0gh-z1KVnSzvfjW... (flutter/engine#56701)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from io00npG_eDCY to dJ0gh-z1KVnS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 14:57:28 +00:00
Bruno Leroux
043c59b075
Fix InkWell overlayColor resolution ignores selected state (#159072) 
## Description

This PR fixes `InkWell` overlay colors resolution.
The `InkWell` overlay color is resolved when the `InkWell` is either
focused, hovered , and/or pressed.
This resolution happens at two places:
- first when the highlight is created.
- then on each build, using the inner function named
`getHighlightColorForType`.
This second resolution should be aware of other current states (such as
selected) as it might impact the color resolution.

For instance, several Material styles have colors resolution define
similarly to:

dc44547d0d/packages/flutter/lib/src/material/date_picker_theme.dart (L982-L1006)

## Related Issue

Fixes [InkWell overlay colors aren't applied on MaterialState.selected
state](https://github.com/flutter/flutter/issues/159063)
First step for [Date picker overlay colors aren't applied on
MaterialState.selected state](Date picker overlay colors aren't applied
on MaterialState.selected state).

## Tests

Adds 3 tests.
 2024-11-19 11:33:40 +00:00
engine-flutter-autoroll
966aeb28ea
Roll Flutter Engine from 983b7b85d122 to b6723e33b858 (3 revisions) (#159134) 
983b7b85d1...b6723e33b8

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 17601e471acf to
8a1a84509501 (4 revisions) (flutter/engine#56700)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 8d652f142911 to
17601e471acf (1 revision) (flutter/engine#56696)
2024-11-19 robert.ancell@canonical.com Add missing cancellable to text
input handler (flutter/engine#56666)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 09:17:26 +00:00
engine-flutter-autoroll
57dca6946d
Roll Flutter Engine from c1b0e18a70b3 to 983b7b85d122 (2 revisions) (#159124) 
c1b0e18a70...983b7b85d1

2024-11-19 lhkbob@gmail.com Remove SK_USE_LEGACY_BLUR_RASTER staging
flag (flutter/engine#56618)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 492e8347d7a4 to
8d652f142911 (1 revision) (flutter/engine#56693)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 04:22:04 +00:00
engine-flutter-autoroll
4426413ec6
Roll Flutter Engine from 878f593802e1 to c1b0e18a70b3 (13 revisions) (#159118) 
878f593802...c1b0e18a70

2024-11-19 jonahwilliams@google.com [Impeller] use sync fence for image
uploads. (flutter/engine#56609)
2024-11-18 reidbaker@google.com Update emulator definitions version to
latest available from chrome infra (flutter/engine#56313)
2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
625e0a9cb67a to 05d58364e92f (1 revision) (flutter/engine#56688)
2024-11-18 chris@bracken.jp iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 jacksongardner@google.com [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 chris@bracken.jp Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 jason-simmons@users.noreply.github.com Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 chris@bracken.jp iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 matanlurey@users.noreply.github.com Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 tugorez@users.noreply.github.com Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 02:08:20 +00:00
Loïc Sharma
6b6f481f19
[SwiftPM] Move where the migration checks feature flags (#159110) 
Previously, the Swift Package Manager app migration would only be
registered if the feature was on.

Now, the Swift Package Manager app migration is always registered but
only runs if the SwiftPM feature is on. This change will make it easier
to introduce a separate feature flag for just the SwiftPM app migration.

This is a refactoring with no semantic change.

Part of https://github.com/flutter/flutter/issues/151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 01:23:08 +00:00
Greg Spencer
e68ed3d1f1
Plumbs scrollBehavior into SelectableText so that the scrollbar may be hidden (#158887) 
## Description

This adds a `scrollBehavior` attribute to `SelectableText` so that the
scrolling can be controlled more directly.

I added this specifically because it's not possible to turn off the
scrollbar on a selectable text, even if you set the scroll physics to be
`NeverScrollableScrollPhysics`. We had a UI where we needed to have a
clipped, multi-line selectable text field, but have it not be scrollable
unless it was expanded in size, and it wasn't possible to hide the
scrollbar, but still wanted it to be selectable.

## Tests
- Added a test that makes sure that the scroll behavior makes it down to
the `Scrollable` in the `EditableText`.
 2024-11-18 23:59:28 +00:00
Matan Lurey
3a17b67353
Add a tag and assert some state in FlutterTestDriver tests. (#159099) 
Towards https://github.com/flutter/flutter/issues/51421.

Asserts some state we would not like to be hit by in integration tests
using `Flutter*TestDriver`.

In addition, adds a tag that can be used to run all tests that currently
use this pattern:

```sh
flutter test --tags flutter-test-driver
```

This showcases processes leaking quite a bit:
<https://gist.github.com/matanlurey/190d9084d3a45bc5737b8406bc05b4cd>.
 2024-11-18 23:37:05 +00:00
dependabot[bot]
7d4b2d31fc
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the all-github-actions group (#159104) 
Bumps the all-github-actions group with 1 update:
[codecov/codecov-action](https://github.com/codecov/codecov-action).

Updates `codecov/codecov-action` from 4.6.0 to 5.0.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: override commit and pr values for PR cases by <a
href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1657">codecov/codecov-action#1657</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.1...v5.0.2">https://github.com/codecov/codecov-action/compare/v5.0.1...v5.0.2</a></p>
<h2>v5.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: use marketplace v5 badge by <a
href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1646">codecov/codecov-action#1646</a></li>
<li>fix: update tokenless branch logic by <a
href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1650">codecov/codecov-action#1650</a></li>
<li>chore(release): 5.0.1 by <a
href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1656">codecov/codecov-action#1656</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.0.0...v5.0.1">https://github.com/codecov/codecov-action/compare/v5.0.0...v5.0.1</a></p>
<h2>v5.0.0</h2>
<h2>v5 Release</h2>
<p><code>v5</code> of the Codecov GitHub Action will use the <a
href="https://github.com/codecov/wrapper">Codecov Wrapper</a> to
encapsulate the <a
href="https://github.com/codecov/codecov-cli">CLI</a>. This will help
ensure that the Action gets updates quicker.</p>
<h3>Migration Guide</h3>
<p>The <code>v5</code> release also coincides with the opt-out feature
for tokens for public repositories. In the <code>Global Upload
Token</code> section of the settings page of an organization in
codecov.io, you can set the ability for Codecov to receive a coverage
reports from any source. This will allow contributors or other members
of a repository to upload without needing access to the Codecov token.
For more details see <a
href="https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token">how
to upload without a token</a>.</p>
<blockquote>
<p>[!WARNING]<br />
<strong>The following arguments have been changed</strong></p>
<ul>
<li><code>file</code> (this has been deprecated in favor of
<code>files</code>)</li>
<li><code>plugin</code> (this has been deprecated in favor of
<code>plugins</code>)</li>
</ul>
</blockquote>
<p>The following arguments have been added:</p>
<ul>
<li><code>binary</code></li>
<li><code>gcov_args</code></li>
<li><code>gcov_executable</code></li>
<li><code>gcov_ignore</code></li>
<li><code>gcov_include</code></li>
<li><code>report_type</code></li>
<li><code>skip_validation</code></li>
<li><code>swift_project</code></li>
</ul>
<p>You can see their usage in the <code>action.yml</code> <a
href="https://github.com/codecov/codecov-action/blob/main/action.yml">file</a>.</p>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): bump to eslint9+ and remove eslint-config-google by <a
href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1591">codecov/codecov-action#1591</a></li>
<li>build(deps-dev): bump <code>@​octokit/webhooks-types</code> from
7.5.1 to 7.6.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1595">codecov/codecov-action#1595</a></li>
<li>build(deps-dev): bump typescript from 5.6.2 to 5.6.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1604">codecov/codecov-action#1604</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
8.8.0 to 8.8.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1601">codecov/codecov-action#1601</a></li>
<li>build(deps): bump <code>@​actions/core</code> from 1.11.0 to 1.11.1
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1597">codecov/codecov-action#1597</a></li>
<li>build(deps): bump github/codeql-action from 3.26.9 to 3.26.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1596">codecov/codecov-action#1596</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 8.8.0 to 8.8.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1600">codecov/codecov-action#1600</a></li>
<li>build(deps-dev): bump eslint from 9.11.1 to 9.12.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1598">codecov/codecov-action#1598</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="5c47607acb"><code>5c47607</code></a>
fix: override commit and pr values for PR cases (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1657">#1657</a>)</li>
<li><a
href="3b1354a6c4"><code>3b1354a</code></a>
chore(release): 5.0.1 (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1656">#1656</a>)</li>
<li><a
href="2e2a9c6d58"><code>2e2a9c6</code></a>
fix: update tokenless branch logic (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1650">#1650</a>)</li>
<li><a
href="cfc521b7a1"><code>cfc521b</code></a>
Update README.md</li>
<li><a
href="06425412c8"><code>0642541</code></a>
fix: use marketplace v5 badge (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1646">#1646</a>)</li>
<li><a
href="968872560f"><code>9688725</code></a>
Update README.md</li>
<li><a
href="2112eaec1b"><code>2112eae</code></a>
chore(deps): bump wrapper to 0.0.23 (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1644">#1644</a>)</li>
<li><a
href="193421c5b3"><code>193421c</code></a>
fixL use the correct source (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1642">#1642</a>)</li>
<li><a
href="6018df70b0"><code>6018df7</code></a>
fix: update container builds (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1640">#1640</a>)</li>
<li><a
href="eff1a643d6"><code>eff1a64</code></a>
fix: add missing vars (<a
href="https://redirect.github.com/codecov/codecov-action/issues/1638">#1638</a>)</li>
<li>Additional commits viewable in <a
href="b9fd7d16f6...5c47607acb">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.6.0&new-version=5.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-11-18 22:28:05 +00:00
Nate Wilson
c25790e3db
Add @protected to public State method overrides (#157313) 
I don't want to see these methods in my autofill suggestions.

<br>

![navigator
dispose](https://github.com/user-attachments/assets/5d2dc37c-abe9-44f4-ad16-4396a3aeeaf7)
 2024-11-18 21:28:08 +00:00
engine-flutter-autoroll
ff47d63235
Roll Flutter Engine from 9686de154114 to 878f593802e1 (5 revisions) (#159097) 
9686de1541...878f593802

2024-11-18 chris@bracken.jp EmbedderTest: Extract backend-specific
user_data (flutter/engine#56642)
2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
ae5111067032 to 625e0a9cb67a (1 revision) (flutter/engine#56679)
2024-11-18 30870216+gaaclarke@users.noreply.github.com Started only
loading gles3 functions if we have a gles3 context
(flutter/engine#56636)
2024-11-18 30870216+gaaclarke@users.noreply.github.com [impeller] enable
framebuffer blit when available (flutter/engine#56596)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 7594233ff914 to
0b74d5c3eb4f (4 revisions) (flutter/engine#56678)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 21:19:04 +00:00
Ben Konyi
c7d158d9f9
Fix flaky failure related to core_device_list.json not being found (#158946) 
It's possible that the tool can be in the process of shutting down,
which could result in the temp directory being deleted after the
shutdown hooks run before we check if `output` exists. If this happens,
we shouldn't crash but just carry on as if no devices were found as the
tool will exit on its own.

Fixes https://github.com/flutter/flutter/issues/141892

---------

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
 2024-11-18 19:52:52 +00:00
Kate Lovett
26d5ec3edd
Prettier merge_queue.md (#158969) 
Spruced up a bit, added mention of edge case for older PRs.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: David Iglesias <ditman@gmail.com>
 2024-11-18 19:32:23 +00:00
Matan Lurey
03c13af0b4
Define and use flutterBin consistently across integration.shard. (#159007) 
Towards https://github.com/flutter/flutter/issues/158875.

This should be a NOP, and just reduce the amount of copy-pasted code
across tests.
 2024-11-18 19:00:04 +00:00
Matan Lurey
74384004ce
No longer download android-x86-jit-release. (#159011) 
Unblocks https://github.com/flutter/flutter/issues/151610.
 2024-11-18 18:22:24 +00:00
engine-flutter-autoroll
0d0bf35b21
Roll Flutter Engine from e1f4e7d9bfc4 to 9686de154114 (1 revision) (#159082) 
e1f4e7d9bf...9686de1541

2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 78fd0dfa6cf8 to
7594233ff914 (1 revision) (flutter/engine#56677)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 17:14:23 +00:00
engine-flutter-autoroll
6d45f75958
Roll Flutter Engine from f365c9f5dce3 to e1f4e7d9bfc4 (4 revisions) (#159078) 
f365c9f5dc...e1f4e7d9bf

2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
8795a3eaa87b to ae5111067032 (1 revision) (flutter/engine#56675)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 5968000526fe to
78fd0dfa6cf8 (1 revision) (flutter/engine#56674)
2024-11-18 kjlubick@users.noreply.github.com Use updated gni source list
(flutter/engine#56627)
2024-11-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
K-3yXpPmmu1f0idCa... to io00npG_eDCYC7bac... (flutter/engine#56673)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from K-3yXpPmmu1f to io00npG_eDCY

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 16:21:10 +00:00
engine-flutter-autoroll
e06d66ae9a
Roll Packages from b164be312ca2 to c1eabf5e32cc (6 revisions) (#159077) 
b164be312c...c1eabf5e32

2024-11-16 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in
/packages/interactive_media_ads/android (flutter/packages#8095)
2024-11-16 kevmoo@users.noreply.github.com
[google_identity_services_web] Migrate all types to JSObject
(flutter/packages#8053)
2024-11-15 49699333+dependabot[bot]@users.noreply.github.com
[file_selector]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1
in /packages/file_selector/file_selector_android/android
(flutter/packages#7982)
2024-11-15 ditman@gmail.com [web_benchmarks] Remove `WebRenderer` enum.
(flutter/packages#8103)
2024-11-15 kevmoo@users.noreply.github.com [google_maps_flutter] Fix
detection of WebAssembly compatibility (flutter/packages#8102)
2024-11-15 engine-flutter-autoroll@skia.org Roll Flutter from
ed553d10cf63 to 0e2d55e0e7b2 (40 revisions) (flutter/packages#8106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 15:45:29 +00:00
engine-flutter-autoroll
b3818f6b59
Roll Flutter Engine from a63841d0c64b to f365c9f5dce3 (1 revision) (#159064) 
a63841d0c6...f365c9f5dc

2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 452208ce96aa to
5968000526fe (3 revisions) (flutter/engine#56671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 10:49:32 +00:00
engine-flutter-autoroll
dc44547d0d
Roll Flutter Engine from 4878f1c9ed1c to a63841d0c64b (8 revisions) (#159057) 
4878f1c9ed...a63841d0c6

2024-11-18 chris@bracken.jp iOS: Clean up @synthesize directives / ivars
(flutter/engine#56665)
2024-11-17 skia-flutter-autoroll@skia.org Roll Skia from 4708534db2e7 to
452208ce96aa (1 revision) (flutter/engine#56664)
2024-11-17 chris@bracken.jp iOS: Extract constant for
CADisableMinimumFrameDurationOnPhone (flutter/engine#56659)
2024-11-17 chris@bracken.jp iOS: Eliminate unnecessary use of
NSClassFromString (flutter/engine#56660)
2024-11-17 chris@bracken.jp iOS: Eliminate unnecessary bridged retain
casts (flutter/engine#56662)
2024-11-17 chris@bracken.jp iOS,macOS: Fix string constant declarations
(flutter/engine#56661)
2024-11-17 chris@bracken.jp iOS: Make FlutterViewController.engine a
strong ref (flutter/engine#56663)
2024-11-17 chris@bracken.jp iOS: Clean up uses of string literal
constants (flutter/engine#56658)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-18 02:16:40 +00:00
engine-flutter-autoroll
41c273f8c6
Roll Flutter Engine from 4c1eb8cacb95 to 4878f1c9ed1c (1 revision) (#159050) 
4c1eb8cacb...4878f1c9ed

2024-11-17 skia-flutter-autoroll@skia.org Roll Skia from 1086e39c04cf to
4708534db2e7 (1 revision) (flutter/engine#56657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-17 14:12:30 +00:00
engine-flutter-autoroll
012f6b34c6
Roll Flutter Engine from 9d0720a7b0ec to 4c1eb8cacb95 (1 revision) (#159049) 
9d0720a7b0...4c1eb8cacb

2024-11-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
c5padahsa9sMecBb3... to K-3yXpPmmu1f0idCa... (flutter/engine#56656)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from c5padahsa9sM to K-3yXpPmmu1f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-17 11:34:08 +00:00
engine-flutter-autoroll
83ee53767f
Roll Flutter Engine from 6f9854ad6ed7 to 9d0720a7b0ec (2 revisions) (#159047) 
6f9854ad6e...9d0720a7b0

2024-11-17 skia-flutter-autoroll@skia.org Roll Skia from b88c7b03a838 to
1086e39c04cf (1 revision) (flutter/engine#56654)
2024-11-17 chris@bracken.jp iOS: Eliminate FlutterEngine dealloc
notification (flutter/engine#56650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-17 10:16:26 +00:00
engine-flutter-autoroll
2a966d3c53
Roll Flutter Engine from 40000c742910 to 6f9854ad6ed7 (2 revisions) (#159041) 
40000c7429...6f9854ad6e

2024-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
dfa7b3ac976b to 8795a3eaa87b (1 revision) (flutter/engine#56652)
2024-11-16 skia-flutter-autoroll@skia.org Roll Skia from f8ec97344733 to
b88c7b03a838 (1 revision) (flutter/engine#56651)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-17 03:20:29 +00:00
Christofer
c2309f3a9e
Fix NavigationBar example overflow alignment (#159034) 
Fix the NavigationBar example overflow alignment.

### Before: 
<img
src="https://github.com/user-attachments/assets/a6cf2cbb-ac32-482c-9aed-8cac15152a0d"
height="450" />


### After:
<img
src="https://github.com/user-attachments/assets/d476c617-edd3-449d-93cf-4a9a87c26d98"
height="450" />



*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-16 22:24:39 +00:00
engine-flutter-autoroll
0571df9bef
Roll Flutter Engine from 908061196148 to 40000c742910 (1 revision) (#159038) 
9080611961...40000c7429

2024-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from
d47c22e5f63a to dfa7b3ac976b (1 revision) (flutter/engine#56649)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 22:22:34 +00:00
engine-flutter-autoroll
7bd353dcce
Roll Flutter Engine from 85d445e3cf78 to 908061196148 (3 revisions) (#159032) 
85d445e3cf...9080611961

2024-11-16 41930132+hellohuanlin@users.noreply.github.com [ios]fix
unused variable clang tidy warning (flutter/engine#56637)
2024-11-16 skia-flutter-autoroll@skia.org Roll Skia from 6b0f264bde33 to
f8ec97344733 (1 revision) (flutter/engine#56646)
2024-11-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
UpSQzyXGUhMfedYIh... to c5padahsa9sMecBb3... (flutter/engine#56645)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from UpSQzyXGUhMf to c5padahsa9sM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 19:50:38 +00:00
engine-flutter-autoroll
dc17d943fd
Roll Flutter Engine from 1800193ba961 to 85d445e3cf78 (1 revision) (#159020) 
1800193ba9...85d445e3cf

2024-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from
77a4ee3266a4 to d47c22e5f63a (1 revision) (flutter/engine#56644)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 08:38:42 +00:00
engine-flutter-autoroll
4bbaa0dfd1
Roll Flutter Engine from 98c3b7f8d1a7 to 1800193ba961 (1 revision) (#159019) 
98c3b7f8d1...1800193ba9

2024-11-16 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from
6FgM4KTbxxmyYoiOs... to OA7UxNZkbxCRfr80A... (flutter/engine#56643)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 07:14:01 +00:00
engine-flutter-autoroll
fd276da092
Roll Flutter Engine from f23832175b7a to 98c3b7f8d1a7 (1 revision) (#159017) 
f23832175b...98c3b7f8d1

2024-11-16 chris@bracken.jp Backend-specific
EmbedderTestBackingStoreProducers (flutter/engine#56638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 05:05:25 +00:00
engine-flutter-autoroll
97f1630305
Roll Flutter Engine from f649330affa8 to f23832175b7a (1 revision) (#159016) 
f649330aff...f23832175b

2024-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from
eccb15756020 to 77a4ee3266a4 (1 revision) (flutter/engine#56640)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-16 04:18:26 +00:00
engine-flutter-autoroll
1ef8d51282
Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions) (#159015) 
Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions)

619804c0fb...f649330aff

2024-11-16 skia-flutter-autoroll@skia.org Roll Skia from 1ef3b910e064 to
6b0f264bde33 (6 revisions) (flutter/engine#56635)
2024-11-16 zanderso@users.noreply.github.com Revert "Remove
`android_jit_release_x86`." (flutter/engine#56634)
2024-11-15 chris@bracken.jp Move SetRenderTargetType to
EmbedderTestCompositor (flutter/engine#56626)
2024-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
b62dadb14d82 to eccb15756020 (2 revisions) (flutter/engine#56630)
2024-11-15 andre.stein.1985@gmail.com [TextInput] Add
TextInputType.webSearch (#15762) (flutter/engine#56428)
2024-11-15 mdebbar@google.com [web] Send the correct view ID with
semantics actions (flutter/engine#56595)
2024-11-15 41930132+hellohuanlin@users.noreply.github.com [macos] early
return to suppress clang-tidy warning (flutter/engine#56588)
2024-11-15 chinmaygarde@google.com [Impeller] libImpeller: Tinker on the
README to cross reference the SDK and the example.
(flutter/engine#56623)
2024-11-15 chaopeng@google.com [fuchsia] MaybeRunInitialVsyncCallback
should only called once (flutter/engine#56429)
2024-11-15 magder@google.com Move mac clangd build from x64 to arm
(flutter/engine#56567)
2024-11-15 30870216+gaaclarke@users.noreply.github.com Added assert for
opengles thread safety (flutter/engine#56585)
2024-11-15 jonahwilliams@google.com [Impeller] enable OpenGL fallback on
Android. (flutter/engine#56591)
2024-11-15 jason-simmons@users.noreply.github.com [Impeller] Maintain
separate queues of GLES operations for each thread in the reactor
(flutter/engine#56573)
2024-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
abe86ca4eb01 to b62dadb14d82 (2 revisions) (flutter/engine#56615)
2024-11-15 skia-flutter-autoroll@skia.org Roll Skia from b730eb340852 to
1ef3b910e064 (4 revisions) (flutter/engine#56613)
2024-11-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
JkpuAsLzcmYLzf1iX... to UpSQzyXGUhMfedYIh... (flutter/engine#56611)
2024-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
bf0eeb9d929c to abe86ca4eb01 (1 revision) (flutter/engine#56610)
2024-11-15 skia-flutter-autoroll@skia.org Roll Skia from e5fda8472b21 to
b730eb340852 (1 revision) (flutter/engine#56608)
2024-11-15 skia-flutter-autoroll@skia.org Roll Skia from 8ff65da4b8bf to
e5fda8472b21 (1 revision) (flutter/engine#56603)
2024-11-15 chris@bracken.jp Move TestMetalContext/Surface to testing
namespace (flutter/engine#56602)
2024-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
343b9fc6eafe to bf0eeb9d929c (1 revision) (flutter/engine#56604)
2024-11-15 chinmaygarde@google.com [Impeller] Don't enable KHR_debug on
Angle. (flutter/engine#56601)
2024-11-15 chinmaygarde@google.com [Impeller] libImpeller: Reset the GL
state when transitioning control back to the embedder.
(flutter/engine#56597)
2024-11-15 skia-flutter-autoroll@skia.org Roll Skia from 8946ea477b42 to
8ff65da4b8bf (2 revisions) (flutter/engine#56600)
2024-11-14 chinmaygarde@google.com [Impeller] Put test components in the
testing namespace. (flutter/engine#56594)
2024-11-14 chinmaygarde@google.com [Impeller] libImpeller: Add a warning
about OpenGL state being trampled. (flutter/engine#56599)
2024-11-14 chris@bracken.jp Embedder: Refactor EmbedderConfigBuilder by
backend (flutter/engine#56598)
2024-11-14 chris@bracken.jp Migrate Metal translation units to Obj-C++
(flutter/engine#56592)
2024-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
db4d7d52db48 to 343b9fc6eafe (1 revision) (flutter/engine#56590)
2024-11-14 chris@bracken.jp iOS,macOS: Build/test
test_metal_surface_unittests (flutter/engine#56586)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from 3222456e63dc to
8946ea477b42 (2 revisions) (flutter/engine#56587)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from 16178bf63de7 to
3222456e63dc (3 revisions) (flutter/engine#56584)
2024-11-14 bruno.leroux@gmail.com [Android] Fix Slider semantics double
tap behaviors (flutter/engine#56452)
2024-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
a3b6652100c8 to db4d7d52db48 (1 revision) (flutter/engine#56581)
2024-11-14 chris@bracken.jp Move Vulkan context to
EmbedderTestContextVulkan (flutter/engine#56571)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from a076435073fc to
16178bf63de7 (1 revision) (flutter/engine#56579)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from 70553189e4e8 to
a076435073fc (1 revision) (flutter/engine#56577)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from fa52f2c1ddba to
70553189e4e8 (1 revision) (flutter/engine#56576)
2024-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
3f05b3540cb2 to a3b6652100c8 (3 revisions) (flutter/engine#56575)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from ddbd8d1cb8d8 to
fa52f2c1ddba (3 revisions) (flutter/engine#56574)
2024-11-14 jonahwilliams@google.com [Android] choose 24 bit depth
buffer. (flutter/engine#56553)
2024-11-14 skia-flutter-autoroll@skia.org Roll Skia from 3750b8939c7f to
ddbd8d1cb8d8 (1 revision) (flutter/engine#56562)
2024-11-14 robert.ancell@canonical.com Move FlMouseCursorHandler from
FlView to FlEngine (flutter/engine#56026)
2024-11-14 jonahwilliams@google.com [Impeller] force software resize
usage for GLES backend. (flutter/engine#56511)
2024-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
66ab1774bfe9 to 3f05b3540cb2 (2 revisions) (flutter/engine#56564)
2024-11-14 chris@bracken.jp Embedder: Refactor EmbedderTestContext
creation (flutter/engine#56563)
...
 2024-11-16 02:02:25 +00:00