* Allow apps to change the title margin in app bar.
* Fix documentation links and the shouldLayout function in the _ToolbarLayout
* Rename margin to spacing
* review comments
* Test fixes. Now we also test the width to make sure enough space is left for trailing widget
* Expose the middle spacing default and use it in app bar.
* Fix analyzer break
* Doc fixes due to review
* Roll engine dependency forward
* Tests seem to fail with segfault. Trying different engine version to troubleshoot
* Tests seem to fail with segfault. Trying original engine version to troubleshoot
* Tests seem to pass with original engine version. Continue bisecting.
* Tests seem to fail now. Continue bisecting.
* Reverted culprit cl, rolling to that
1. Migrate simulator device log tailing to os_log toolchain
2. When the log tag (component) is available (iOS 11/Xcode 9), filter to
the set of log lines with tag 'Flutter'.
As of iOS 11 / Xcode 9, Flutter engine logs are no longer recorded in the
simulator's syslog file, which we previously read using tail -f. Instead
they're now accessible through Apple's new macOS/iOS os_log facility,
via /usr/bin/log, which supports a relatively flexible query language.
When run in non-interactive mode, /usr/bin/log buffers its output in 4k
chunks, which is significantly smaller than what's emitted up to the
point where the observatory/diagnostics port information is logged. As a
workaround we force it to run in interactive mode via the script tool.
This ports the five-second retry interval from flutter.bat to the Bash
version. Failures during "pub get" of the flutter tool are common on
Travis and so this should help Travis reliability if nothing else.
* Add --trace-skia parameter to flutter run
Skia tracing is extremely useful for internal debug, but reduces the
amount of space available in the Dart Timeline buffers.
Disable skia tracing by default and expose them via the --trace-skia
flag.
* Roll Engine to 57a1445a45964d386500c39f5e8d06db060abadb
* only tap on widgets reachable by hit testing
* use FractionalOffset
* added tests
* check finder finds correct widget
* undo unintentional changes
* address comments
* style fix
* add Directionality in test
* fix analysis warning
* Make an app's supported locales configurable
* Added an supportedLocales.isNotEmpty assert
* WidgetsApp no longer const because supportedLocales.isNotEmpty
* updated per review feedback
* tweaked dartdoc to restart the build
* updated per review feedback
* Updated per review feedback
* Rename BannerLocation enum values
* topLeft -> topStart
* topRight -> topEnd
* bottomLeft -> bottomStart
* bottomRight -> bottomEnd
These names will make it easier for us to adjust the location of the
banner in right-to-left mode.
See the discussion on flutter-dev.
* Add RTL support for Banner
Fixes#11905
* Selectively apply margin between middle and leading
If ToolbarLayout does not have a leading widget, we should not put a margin between leading and middle areas since it ends up being blank space that looks odd. Fixes https://github.com/flutter/flutter/issues/11963
* Fix the failing test which is a good test case for missing leading widget
