10108 Commits

Author SHA1 Message Date
Hans Muller
f0f0f09707
Fix InkRipple.cancel animation race (#14442) 2018-02-02 16:13:56 -08:00
Ian Hickson
21ee1a25fd
Explain MaterialColor's constructor better. (#14407)
Fixes https://github.com/flutter/flutter/issues/14393
2018-02-02 16:00:57 -08:00
Alexandre Ardhuin
c02b6a8bcf
some whitespace cleanup (#14443) 2018-02-02 23:27:29 +01:00
Devon Carew
688a571c71
update doc styles for 'implementation' sections (#14441) 2018-02-02 12:36:03 -08:00
Zachary Anderson
ce38cf6e1d Roll engine to d5338ed14376f62b252078b1dcd742bd3b01a7da (#14434) 2018-02-02 04:27:11 -08:00
Michael Thomsen
e941299862
Change sky_engine to use a sdk dependency (#14436) 2018-02-02 11:22:00 +01:00
Ian Hickson
c12d120bbf
Provide a way to override global InheritedWidgets (#14348)
For example, so that the gallery can override the media query globally.
2018-02-01 23:12:52 -08:00
Alexandre Ardhuin
12ceaefb18
work around const lints (#14416)
* work around const lints

* update nonconst doc
2018-02-02 08:06:42 +01:00
jcollins-g
08823595b0
Fix devicelab tests broken by #14173 (#14420) 2018-02-01 20:23:40 -08:00
Devon Carew
759dae835f
bump the dart sdk version (#14426)
* bump the dart sdk version to 2.0.0-dev.17.0

* 2.0.0-dev.20.0

* 2.0.0-dev.19.0
2018-02-01 18:31:54 -08:00
Jason Simmons
d5149d4457
Toolchain support for Android ARM64 targets (#14394) 2018-02-01 15:14:48 -08:00
jcollins-g
26102c9120
Condense and summarize doctor output without --verbose (#14173)
* Flatten change out from lots of merges and temporary hacks for #7224

* Expand fakes to cover cases where doctor passes

* -v != --verbose

* Cosmetic touchups

* delint

* Clean up summary line, add a switch for review comments

* Review comments

* nit

* review comment

* review comments
2018-02-01 10:27:55 -08:00
Zachary Anderson
308899f874
Roll engine to de34a3e272ba31cd7a80befbdb60cf9af532327f (#14418) 2018-02-01 09:42:18 -08:00
jcollins-g
c81a5ed09a
fix rare flutter_tools logging crash in daemon mode (#14401)
* Populate AnsiTerminal in context for daemon launches

* Strip out AnsiTerminal additions to context since they are no longer needed
2018-02-01 09:30:53 -08:00
Michael R Fairhurst
51158c9177 Fix passing "void" into "dynamic" to future-proof new changes. (#14366)
Using a void list literal in this case is valid and correct, and will be
required for dart 2.

Note: void can be inferred here, but followed the lints to write it
explicitly even though that's arguably a bit weird in this case and less
backwards compatible.
2018-02-01 05:09:07 -08:00
Alexandre Ardhuin
841d5d7bd5
prefer_const_declarations on local variables (#14358) 2018-02-01 07:51:26 +01:00
Chris Bracken
b0e17949aa
Position bottom bar widgets relative to window (#14406)
Note: also fixes a bug wherein bottom media padding was applied even in the
presence of persistent footer buttons.

The material spec states that the keyboard should be positioned on top
of any bottom navigation bar or persistent footer buttons widget(s).

We no longer inset the bottom of bottom navigation bars / persistent
footer buttons by the bottom viewInset.

Body content bottom (and the bottom of bottom sheets) is now determined
by the greater of:
  1. bottom view inset (the keyboard height)
  2. bottom elements (nav bar, footer buttons)
relative to the window max-Y.
2018-01-31 21:19:15 -08:00
Siva Annamalai
5c2323fc3e address review comment. 2018-01-31 21:02:40 -08:00
Siva Annamalai
337ad9dc9e Add meta tag @optionalTypeArgs to the mixin classes where we don't expect a generic type to be specified at the points where the mixin is applied. This suppresses the analyzer warnings. 2018-01-31 21:02:40 -08:00
Siva Annamalai
1c236d5245 Fixes in flutter framework code to address the mixin issue raised
in https://github.com/dart-lang/sdk/issues/31984
2018-01-31 21:02:40 -08:00
Ian Hickson
17c50693b1
Rationalize the ScrollMetrics cloning logic (#14281) 2018-01-31 17:10:56 -08:00
amirh
d9ef7df978
Use RRects instead of Paths when possible in Material. (#14404)
0672055a72ff1265b2aedb037f2848455318f22a changed the Material widget to
always use Paths for representing the outline.
These paths are later used for clipping and drawing a shadow.
This changed introduced a performance regression, see:
https://github.com/flutter/flutter/issues/14403

We did not expect a path that is a rounded rectangle to be less
performant than a rounded rectangle, as Skia should be able to tell the
path is just a rounded rectangle.
Until we find a solution for this regression, we keep using RRect when
we can represent the shape with it.
2018-01-31 16:06:14 -08:00
Michael Goderbauer
b54b576c1a
Assorted a11y fixes (#14395) 2018-01-31 15:23:20 -08:00
Chris Bracken
882be89e4c
Improved bottom media padding for SnackBars (#14396)
In a scaffold, snackbars are positioned above the BottomNavigationBar
and/or PersistentBottomButtons, if present. In such cases, they should
not apply bottom media padding to their widget sub-tree.
2018-01-31 12:35:13 -08:00
Michael Goderbauer
3fd737c8f7
a11y on Android: copy/cut/paste (#14343)
With a little refactor and unification of how availability of copy/cut/paste is determined across platforms.

Minor remaining issue: https://github.com/flutter/flutter/issues/14331.

Fixes https://github.com/flutter/flutter/issues/13501.
2018-01-31 12:26:24 -08:00
Ian Hickson
217bcfe261
Update the roll dev script to actually work (#14376) 2018-01-31 12:24:10 -08:00
xster
82ddabd32a
Fastlane instructives for tool publishing the Gallery (#14347)
* first round fastlane working on Android

* clean up and start ios

* Partial iOS

* Got a fastfile that works on iOS

* Finalize Android push instructions

* Finalize instructions for iOS

* Extra cleanup and optipng

* Disable readme autogen and add a default readme
2018-01-31 11:21:37 -08:00
jensjoha
5ccd5a1e75 [kernel/flutter] Improve speed of first hot reload (#13699)
* [kernel/flutter] Improve speed of first hot reload

* [kernel/flutter] Improve speed of first hot reload

* Revert "[kernel/flutter] Improve speed of first hot reload"

This reverts commit f3dc133878ec7405a8efb5715f1cfe720f4ea05f.

* Revert "[kernel/flutter] Improve speed of first hot reload"

This reverts commit f7bcb082b01cf9cf48f02c6aad9e5c79705def8f.

* Revert "Revert "[kernel/flutter] Improve speed of first hot reload""

This reverts commit 73c7a1a8e85a4c0397984d8b65a98b2f71bf84f3.

* [kernel/flutter] Improve speed of first hot reload

Do so by not evicting unnecessary paths (while still evicting paths
that was changed between the generation of the package file and the
initial upload).

* Fix grammar in method name

* Fix bad merge

* Add method to super class
2018-01-31 07:39:58 -08:00
amirh
06d12a78d7
Use const constructor for RoundedRectangleBorder. (#14384)
This triggered an analysis failure only on the devicelab.
2018-01-31 00:21:09 -08:00
amirh
0672055a72
Support arbitrary shaped Material. (#14367)
For backward compatibility we keep supporting specifying the shape as a
combination of MaterialType and borderRadius, and we just use that as a
default when shapeBorder is null.

To cleanup the implementation if shapeBorder was not specified we just
translate the specified shape to a shapeBorder internally.
I benchmarked paint, layout and hit testing, with the specialized shape
clippers vs. the equivalent path clippers and did not see any
significant performance difference.

For testing, I extended the clippers/physicalShape matchers to match either the
specialized shape or the equivalent shape.
2018-01-30 23:24:42 -08:00
Vyacheslav Egorov
340d9e00cf
Fix various strong mode issues. (#14284) 2018-01-31 08:21:32 +01:00
Greg Spencer
122796137b
Make Cupertino alert dialog honor text scale factor (#14346)
This updates the CupertinoAlertDialog to respect text scale factor more properly. Before this, it would scale, but would clip the action buttons at large scales, and would draw in the safe area. It also didn't match the iOS alert because the content didn't scroll. Now it does those properly.

I didn't address the fact that buttons should lay out properly (Issue #14345), but that's probably pretty low priority.

Fixes #12484
2018-01-30 17:23:03 -08:00
Chris Bracken
4a1eeed677
Roll engine to dbc071aa6211596c25e6c6e6cc6862178e937d18 (#14365)
Includes:
* Only implement application:performActionForShortcutItem:completionHandler on iOS 9.0+ (flutter/engine#4600)
* [fuchsia] Remove MessageLoopHandler dependency (flutter/engine#4618)
* Use @available checks for iOS 11 features (#4619)
2018-01-30 14:23:48 -08:00
amirh
178ad8aba8
Add unit tests for the Material widget (for clipping and elevation) (#14334) 2018-01-30 12:54:52 -08:00
Ian Hickson
3001b3307d
Try to make transitioning channels actually work. (#14353)
* Try to make transitioning channels actually work.

* Update upgrade.dart
2018-01-30 11:37:15 -08:00
xster
2580e6eb1f
Upgrade gallery xcode project pod hookup to cocoapods 1.4 (#14332) 2018-01-30 11:36:28 -08:00
Ian Hickson
6379fe0bba
Release script should tag with vX.Y.Z (#14351) 2018-01-30 10:05:39 -08:00
Ian Hickson
45e81140c3
Actually update docs on dev branch (#14357) 2018-01-30 09:00:57 -08:00
Ian Hickson
6e87292bba
Fix "extracing" typo (#14356) 2018-01-30 09:00:45 -08:00
Alexander Markov
a0ffbe29ff
Add tracing to print front-end command (#14340) 2018-01-30 08:52:04 -08:00
Chris Bracken
adcb5ab493
Roll engine to 8f2d72b183fa996449d2a2252c497a64126b44c4 (#14355)
Includes:
* Roll Dart SDK (flutter/engine#4613)
2018-01-29 23:58:44 -08:00
Greg Spencer
ddfc322de8
Creates a package publishing script to publish packages as part of the dev roll process. (#14294)
This script will update release metadata in the cloud, and copy the already-built package to the right location and name on cloud storage.

The release metadata will be located in gs://flutter_infra/releases/releases.json, and the published packages will end up in gs://flutter_infra/releases/<channel>/<platform>/flutter_<platform>_<version><archive suffix>, where <channel>, <platform>, <version>, and <archive suffix> are determined by the script.

At the moment, it only supports dev rolls, but (once we know how those will work) should easily support beta rolls as well.
2018-01-29 23:15:57 -08:00
Tom Larsen
b7f6be6ff2 Add onLeave callback to DragTarget (#14103)
* Add a callback that fires when a Draggable leaves a DragTarget.  This enables the DragTarget to manage its state from entry to exit.

* It helps to have a null check here

* Add test for onLeave callback and add verbiage to onWillAccept explaining the callback lifecycle of a DragTarget.
2018-01-29 22:48:35 -08:00
Ankur Kedia
47e52b827f adds properties to dismissible widget (#14162)
* adds crossAxisEndOffset and rollbackDuration properties to dismissible widget

* re-added removed license comment

* corrected license comments

* Adds test for rollbackDuration and crossAxisEndOffset

* added tests and comments

* modified tests for dismissible widgets
2018-01-29 22:45:30 -08:00
Chris Bracken
c54fab0444
Roll engine to 293b37c61f41e07cb5d9949d1bd16f656bae788e (#14352)
Includes:
* Remove unnecessary trim (#4616)
2018-01-29 22:26:28 -08:00
Ian Hickson
a9c1399243
Improve test.dart output (#14333)
It adds lines like `SHARD=analyze` to each shard, and a message like `Contents of packages/flutter_localizations/lib/src/l10n/localizations.dart matches output of gen_localizations.dart script.`  to the analysis shard.
2018-01-29 21:14:41 -08:00
Chris Bracken
d6f16dcfbe
Roll engine to f557f476c86c09d9659fe22072237efcb4a2faa7 (#14350)
Includes:
* Extract common iOS asset path lookup code: #4594
* Introduce VulkanProvider fb9782a5294e700e45e372da0cd25165697b2e45
* Transition render target images before submit 0de8218778f1bb5d913db8b8a67789a44f8bb28f
* Update buildtools to Fuchsia HEAD #4599
2018-01-29 20:24:32 -08:00
Tom Larsen
52d47751a0 Add onCancelled callback to PopupMenu (#14226)
* Add onCancelled callback to PopupMenu

* Fix spelling, don't call onCanceled if disposed, improve documentation.
2018-01-29 20:10:43 -08:00
amirh
2e449f06f0
import all generated files in animated_icons_private_test (#14329) 2018-01-29 14:26:51 -08:00
amirh
85b5b88e0b
Add more animated icon assets (#14328) 2018-01-29 10:36:59 -08:00