We can simplify the checks given that there's fewer node types now. This does
make the error messages from Range a little worse, but it's weird that Range
is doing its own error checking anyway.
I also took this as an opportunity to add a bunch of DOM tests.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/732203004
Unfortunately we don't yet have a way to walk into
imports, so this only is the first-level of the
source tree, but this is a huge step forward.
You can now click to set breakpoints, however
setting breakpoints crashes sky.
I had to fix Console.log to flush stdout
so that I could actually debug my timing-out test.
Also had to fix Chai to dump differences for deepEqual.
R=esprehn@chromium.org, abarth@chromium.org, esprhen@chromium.org
Review URL: https://codereview.chromium.org/732413004
The debugger can now correctly break on exceptions
and show the corresponding line in the inspector.
It correctly understands which scripts are internal
to sky and does not pause during them.
There is still a ton to make work here
(including stacktraces which I have not tested),
but basic functionality seems to work.
The current implementation is not smart enough to
unpause the inspector when the frontend disconnects.
BUG=434510,434513
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/727593004
-Add RenderParagraph and display:paragraph. This is the only
render type that's allowed to contain inlines or text.
-If you put text nodes directly in a non-paragraph, wrap them
in an anonymous paragraph. This may not be the place we want
to end up, but it's a good stopgap to make it so we don't
crash in this case.
-Make StyleAdjuster force that non-paragraph blocks only contain
RenderBlock subclasses and that paragraphs and inlines only contain
inlines.
-Considerably simplify addChildIgnoringAnonymousColumnBlocks
now that we only create anonymous blocks for the case of
text nodes in non-paragraphs. Also get rid of the behavior
where we try to group multiple nodes into a single
anonymous block.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/729693003
This CL adds a simple scheduler for animation frames that holds a given interval
in a given phase. The scheduler can be told the estimated duration of the
BeginFrame callback and can adjust the callback to hit a given vsync interval.
This CL also makes ganesh_app use this scheduler to animate.
R=jamesr@chromium.org, ernstm@chromium.org
Review URL: https://codereview.chromium.org/731893002
Since Sky is checked directly into mojo and does not contain
Blink history, I knew of no easy way to resurrect Blink files.
In making the V8 debugger work, I had to bring back a ton
of files and thus wrote a script to help me do so.
Maybe others will find this useful.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/732193002
Eventually all of this should be moved out of Sky
and instead sit on top of Sky as just a mojo v8 debug service
but for now I'm just bringing back what we had in Blink
so I can make it work with our new inspector backend
and then we can move it out.
I also sorted gn lists and fixed two .idl files
which were in the wrong sources list in core.gni.
R=abarth@chromium.org, yurys@chromium.org
Review URL: https://codereview.chromium.org/723773002
This CL adds the beginning of a new module loading system that matches the
conceptual module in the spec. I've writed it up to the import API on
AbstractModule. In a future CL, I'll replace the old module loading system with
this one.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/720903002
When we removed Aura from the build, we broke event targeting. This CL hacks
around the issue by blindly forwarding events from the root view to the content
view in skydb. Once we have proper event targeting, we should rip out this code.
R=erg@chromium.org
Review URL: https://codereview.chromium.org/714213003
[Changes: Remove additional deps which Linux/Windows was fine with, but
which broke android because it implied an aura dependency. window_manager
should now be properly deauraed.]
This patch is only half done, however the main driver (removing aura) is
needed by other teams for them to make progress.
Input handling is regressed in this patch; while FocusController is
rebuilt to the point where it should theoretically work, all of the
details about ui::EventTargeter don't work correctly. There is an empty
subclass ViewTargeter which will need to be filled out before
Thankfully, this should only regress people who are using the wm_flow
demo, and this should unblock the android guys who don't have aura
support on their platform.
BUG=431047
TBR=eseidel@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/710203006
This patch is only half done, however the main driver (removing aura) is needed by other teams for them to make progress.
Input handling is regressed in this patch; while FocusController is rebuilt to the point where it should theoretically work, all of the details about ui::EventTargeter don't work correctly. There is an empty subclass ViewTargeter which will need to be filled out before
Thankfully, this should only regress people who are using the wm_flow demo, and this should unblock the android guys who don't have aura support on their platform.
BUG=431047
R=eseidel@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/698543005
This CL moves the |exports| from Document to the new |Module| interface,
matching the spec. Also, the |module| object available to scripts is now really
an instance of |Module|.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/703593003
This CL teaches test_perf how to walk the benchmarks directory to find the
benchmarks and how to actually run them. We're still not uploading results to
the server yet, however.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/710133002
This CL introduces an HTMLViewElement which, when inserted into a document,
causes a mojo::View to be created and navigated to the provided URL. No
compositing is done, but the view manager handles the rendering (as I
understand it).
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/708903002
