engine-flutter-autoroll
cbfb222446
Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) ( #152824 )
...
980577996f...16012e2f8czanderso@users.noreply.github.com Don't use intel clang on arm64 macs (flutter/engine#54291 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-04 01:13:39 +00:00
engine-flutter-autoroll
f442763154
Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) ( #152821 )
...
2a51c687fd...980577996fskia-flutter-autoroll@skia.org Roll Skia from 8f0e1486b887 to 80ef0f91fb7b (2 revisions) (flutter/engine#54336 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 23:28:40 +00:00
engine-flutter-autoroll
2dbfd55cc8
Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) ( #152818 )
...
4c868ee856...2a51c687fdflar@google.com [DisplayList] benchmark DisplayList dispatch method (flutter/engine#54324 )
2024-08-03 skia-flutter-autoroll@skia.org Roll Skia from 60c660ecdf0a to 8f0e1486b887 (1 revision) (flutter/engine#54331 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 21:58:31 +00:00
engine-flutter-autoroll
63be857288
Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) ( #152814 )
...
afb7007298...4c868ee856bdero@google.com Revert "[Impeller] Reland 2: Implement draw order optimization. (#54268 ) (flutter/engine#54325 )
2024-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3a0b4143fe47 to d4a2c6a52b4a (1 revision) (flutter/engine#54334 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 20:57:41 +00:00
Zachary Anderson
8b93ab9d52
Fix device_os requested in linux_build_test tests ( #152808 )
...
The MotoG4's had device_os=N, the mokey's have device_os=U.
Eventually I'll get this right...
2024-08-03 17:26:31 +00:00
engine-flutter-autoroll
a13abe88e5
Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) ( #152804 )
...
516235e445...afb7007298skia-flutter-autoroll@skia.org Roll Dart SDK from c4c9a84c3532 to 3a0b4143fe47 (1 revision) (flutter/engine#54333 )
2024-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from ff56a84f7661 to c4c9a84c3532 (1 revision) (flutter/engine#54332 )
2024-08-03 chinmaygarde@google.com Delete //flutter/fml/compiler_specific.h (flutter/engine#54330 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 11:56:37 +00:00
Zachary Anderson
355a4607f2
Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests ( #152796 )
...
In "build tests", the `properties` of the build specify the
configuration of the coordinator, and the `drone_dimensions` specify the
configuration of the devicelab bot. This PR should therefore fix the
infra errors on the `Linux_build_test` tests caused by my last PR at
https://github.com/flutter/flutter/pull/152756 . (Unfortunately, a simple
revert won't work since the MotoG4s have already been removed from the
Linux hosts.)
2024-08-02 19:50:02 -07:00
engine-flutter-autoroll
d6515afed4
Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) ( #152790 )
...
3c9d7e3f7c...516235e445chinmaygarde@google.com [Impeller] Use the typed allocation sizes in impeller::Allocation. (flutter/engine#54327 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vpJQheqicAUK_qjD-... to kNaYSiTeLcsVNOSDa... (flutter/engine#54328 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 46bcc8466168 to ff56a84f7661 (2 revisions) (flutter/engine#54326 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from vpJQheqicAUK to kNaYSiTeLcsV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 01:57:29 +00:00
Victor Sanni
6b73de27bd
Improve CupertinoRadio fidelity ( #149703 )
...
Adds the following:
* Darkens when pressed in light mode
* Lightens when pressed in dark mode.
* Tests that confirm `CupertinoRadio` is focusable and has correct focus
colors
* Tests that confirm `CupertinoRadio` uses correct default
active/inactive/fill colors
* Same look in disabled vs. enabled states as native macOS:
| Native macOS | Flutter Before | Flutter After |
--- | --- | --- |
| <img width="50" alt="radio native"
src="https://github.com/flutter/flutter/assets/77553258/27c8c27e-f0dc-4ad7-a8c2-361ae8b437bb ">
| <img width="50" alt="flutter radio before"
src="https://github.com/flutter/flutter/assets/77553258/580d9c4b-0f0d-457e-851f-73450738ee16 ">
| <img width="50" alt="flutter radio after"
src="https://github.com/flutter/flutter/assets/77553258/da6ae21b-87f8-45d8-a2d2-da70ff4853a1 ">
|
* Same look of an unselected radio button in dark mode as native macOS:
| Native light mode | Flutter before light mode | Flutter after light
mode | Native dark mode | Flutter before dark mode | Flutter after dark
mode
--- | --- | --- | --- | --- | --- |
| <img width="23" alt="native radio light"
src="https://github.com/flutter/flutter/assets/77553258/b52fc18b-e10d-4205-b10b-1536fbbf1ca0 ">
| <img width="23" alt="flutter radio after light"
src="https://github.com/flutter/flutter/assets/77553258/54294523-8254-479c-b668-77927a8295f1 ">
| <img width="23" alt="flutter radio light"
src="https://github.com/flutter/flutter/assets/77553258/8472deee-e5ce-4d39-9207-d788ad7f34f4 ">
| <img width="23" alt="native radio dark"
src="https://github.com/flutter/flutter/assets/77553258/44143099-6ab4-4fb8-8a94-ebb1386022c9 ">
| <img width="23" alt="flutter radio before dark"
src="https://github.com/flutter/flutter/assets/77553258/3411d9fb-fc7f-4b20-86a5-34fda167d5b9 ">
| <img width="23" alt="flutter radio dark"
src="https://github.com/flutter/flutter/assets/77553258/39ea3649-142e-43ad-9681-24e1216e0987 ">
|
## Light mode (with focus highlight)
| Native light mode | Flutter before light mode | Flutter after light
mode |
--- | --- | --- |
| <img width="70" alt="native radio light mode"
src="https://github.com/user-attachments/assets/914b9f1f-5819-4c5b-8739-8498a72b337f ">
| <img width="70" alt="radio flutter focus before"
src="https://github.com/user-attachments/assets/3129fca3-3310-4b2b-bcf3-98aa8f049911 ">
| <img width="70" alt="radio flutter focus after"
src="https://github.com/user-attachments/assets/7a2089d9-b2b5-4ff0-9db9-444455301146 ">
|
## Dark mode
| Native dark mode | Flutter before dark mode | Flutter after dark mode
|
--- | --- | --- |
| <img width="70" alt="native radio dark mode"
src="https://github.com/user-attachments/assets/4da3c055-ce89-4f37-8fcd-d4cbbc4031a0 ">
| <img width="70" alt="flutter before radio dark mode"
src="https://github.com/user-attachments/assets/36b5f36a-f1d9-4c32-8493-3533a749cf5d ">
| <img width="70" alt="flutter radio dark mode after"
src="https://github.com/user-attachments/assets/28828e01-bb2f-4217-9756-2766be3919a6 ">
|
## Disabled light mode
| Native | Flutter before | Flutter after |
--- | --- | --- |
| <img width="120" alt="light disabled radio native"
src="https://github.com/user-attachments/assets/bf6d2561-5dcf-4882-afac-6b639fa949b0 ">
| <img width="120" alt="Screenshot 2024-07-30 at 3 13 30 PM"
src="https://github.com/user-attachments/assets/3efc978c-fa58-44e8-877a-ea29778ea384 ">
| <img width="120" alt="light disabled radio flutter after"
src="https://github.com/user-attachments/assets/b2c2e30a-cb8d-40d0-aa6f-75a98caa4829 ">
|
## Disabled dark mode
| Native | Flutter before | Flutter after |
--- | --- | --- |
| <img width="120" alt="dark disabled radio native"
src="https://github.com/user-attachments/assets/feedccc7-9802-4b0c-8038-c9eb771b0eb0 ">
| <img width="120" alt="Screenshot 2024-07-30 at 3 13 30 PM"
src="https://github.com/user-attachments/assets/6d2f03f7-7216-4850-8c4f-f79ae05bb9da ">
| <img width="136" alt="dark disabled radio flutter after"
src="https://github.com/user-attachments/assets/5e03d4fc-4b8e-4518-b429-6bb58f6d988d ">
|
`CupertinoRadio` is missing a tristate/mixed state, but [Apple's latest
HIG specs discourages its
use](https://developer.apple.com/design/human-interface-guidelines/toggles#Radio-buttons ).
Fixes https://github.com/flutter/flutter/issues/151994
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
2024-08-02 18:32:17 -07:00
engine-flutter-autoroll
9893ec99d0
Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) ( #152777 )
...
353c6b237b...3c9d7e3f7cskia-flutter-autoroll@skia.org Roll Skia from 88449344d36d to 60c660ecdf0a (1 revision) (flutter/engine#54323 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from 21f4d4a4a025 to 88449344d36d (1 revision) (flutter/engine#54322 )
2024-08-02 jonahwilliams@google.com [Impeller] check allocation failures. (flutter/engine#54320 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 00:29:06 +00:00
Greg Spencer
51ed348f3b
Fix handling of iconSize and iconColor defaults for ButtonStyleButton subclasses. ( #143501 )
...
## Description
Adds defaults that use tokens to define default `iconSize` and `iconColor` values. Previously, the Material 3 token values for button icon sizes and colors were not being used as defaults when the `ButtonStyleButton.defaultStyleOf` function returned the default values.
Adds tests to make sure appropriate `ButtonStyle` fields are populated when defaultStyle is called on buttons.
Updated documentation for `defaultStyleOf` to indicated that not _all_ fields need to be non-null, since some fields make sense to be null (e.g. `fixedSize`) because they would otherwise override the behavior of other fields in the same `ButtonStyle`.
## Tests
- Added tests to make sure that the appropriate fields are non-null in the default button styles for each type of button.
2024-08-02 23:31:07 +00:00
Matan Lurey
97996b07a2
Use print logging on LUCI. ( #152776 )
...
Work around https://github.com/flutter/flutter/issues/152775 diagnosing https://github.com/flutter/flutter/issues/152769 .
2024-08-02 23:21:18 +00:00
Zachary Anderson
8d3d3ee4d0
Reland: Shift Linux_build_test tests from MotoG4 to mokey ( #152756 )
...
Reland of https://github.com/flutter/flutter/pull/152750 with fixes to
hopefully make the test run in the devicelab. Also, shifts the tests to
`bringup: true` this time to avoid breaking the tree.
For For https://github.com/flutter/flutter/issues/148085
2024-08-02 14:51:26 -07:00
Greg Price
1dcc1b1876
Write more on Animation and related docs ( #150727 )
...
A few days ago I started reading up on how animations work, in
preparation for starting to use them in a more complex way than
I'd done before. I found it a bit difficult to get my head around;
in particular the many different classes involved, how they relate
to each other, and how to fit them together.
So once I had worked that out, I sat down to express it in the form
of documentation.
The largest change here is an expansion of the docs on [Animation]
itself, including a new section "Using animations" with several
paragraphs laying out how one typically fits together
AnimationController, TickerProvider, CurvedAnimation and/or Tween,
and AnimatedWidget subclasses. [Animation] also gets an expanded
"See also" list, a revised conceptual intro, and a new summary line.
There are also revisions on [TickerProvider], [AnimatedController],
and elsewhere; some new exposition, some revisions for clarity, and
various small fixes.
2024-08-02 21:46:17 +00:00
Tirth
d6e4555494
Quick Grammar Fixes ( #152744 )
...
Quick Grammar Fixes
2024-08-02 21:16:24 +00:00
engine-flutter-autoroll
7b25a068e2
Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) ( #152762 )
...
077b6f057b...353c6b237bskia-flutter-autoroll@skia.org Roll Skia from f67db9982729 to 21f4d4a4a025 (1 revision) (flutter/engine#54319 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 8dc947153d60 to 46bcc8466168 (1 revision) (flutter/engine#54318 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from ad1e3d828960 to f67db9982729 (8 revisions) (flutter/engine#54317 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 20:49:37 +00:00
Anurag Roy
419f0230c4
[SliderTheme] Fix markdown links for api doc images ( #152748 )
...
Fixes incorrect syntax of image links for the api documentation of the following classes:
- [RectangularSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularSliderTrackShape-class.html )
- [RoundedRectSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectSliderTrackShape-class.html )
- [RectangularRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderTrackShape-class.html )
- [RoundedRectRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectRangeSliderTrackShape-class.html )
- [RoundSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundSliderTickMarkShape-class.html )
- [RoundRangeSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderTickMarkShape-class.html )
- [RoundSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundSliderThumbShape-class.html )
- [RoundRangeSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderThumbShape-class.html )
- [RectangularSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularSliderValueIndicatorShape-class.html )
- [RectangularRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderValueIndicatorShape-class.html )
- [PaddleSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleSliderValueIndicatorShape-class.html )
- [PaddleRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleRangeSliderValueIndicatorShape-class.html )
2024-08-02 20:44:23 +00:00
Juanjo Tugores
af834eed23
Make the App's title optional on web ( #152003 )
...
Title (in web) results in updating the [title element][1] which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.
2024-08-02 20:00:43 +00:00
Valentin Vignal
b7997cba54
Add tests for scaffold messenger state ( #152735 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/scaffold/scaffold_messenger_state.show_snack_bar.0.dart`
- `examples/api/lib/material/scaffold/scaffold_messenger_state.show_material_banner.0.dart`
2024-08-02 19:46:04 +00:00
Sam Rawlins
5c5b3c5796
Ignore both unused_element and unused_element_parameter ( #152689 )
...
Work towards https://dart-review.googlesource.com/c/sdk/+/378500
2024-08-02 19:39:03 +00:00
Parker Lougheed
c1872f9752
Update dartdoc to 8.0.12 to fix focusing search field ( #151576 )
...
Fixes https://github.com/dart-lang/dartdoc/issues/3813 as 8.0.11
includes the fix in
346638efa8
2024-08-02 11:58:48 -07:00
Rexios
79d5ecc902
[wiki] Remove outdated warning about stale coverage data ( #152560 )
...
Remade https://github.com/flutter/flutter/pull/152529 because the GitHub editor was being dumb and adding trailing newlines without asking
2024-08-02 18:21:58 +00:00
engine-flutter-autoroll
6206d8d73e
Roll Packages from 27896d1c5aa8 to cc9ff470587b (8 revisions) ( #152754 )
...
27896d1c5a...cc9ff47058rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273 )
2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269 )
2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202 )
2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308 )
2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282 )
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51a3a34 to e2e43987c4fb (5 revisions) (flutter/packages#7276 )
2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272 )
2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 18:14:23 +00:00
auto-submit[bot]
f10a497e4a
Reverts "Shift Linux_build_test tests from MotoG4 to mokey ( #152750 )" ( #152755 )
...
Reverts: flutter/flutter#152750
Initiated by: zanderso
Reason for reverting: infra failure
Original PR Author: zanderso
Reviewed By: {jason-simmons}
This change reverts the following previous change:
For https://github.com/flutter/flutter/issues/148085
2024-08-02 17:38:46 +00:00
Zachary Anderson
9cc5d7f446
Shift Linux_build_test tests from MotoG4 to mokey ( #152750 )
...
For https://github.com/flutter/flutter/issues/148085
2024-08-02 16:59:07 +00:00
engine-flutter-autoroll
40e3f78a0b
Roll Flutter Engine from b408111b976c to 077b6f057b69 (1 revision) ( #152745 )
...
b408111b97...077b6f057bskia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from dUCMHqU6ihfIFKAw8... to oOZyP3ets0uHdEqWW... (flutter/engine#54308 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 16:59:03 +00:00
Valentin Vignal
8818e60a65
Add test for scaffold_state.show_bottom_sheet.0.dart ( #152731 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/scaffold/scaffold_state.show_bottom_sheet.0.dart`
2024-08-02 14:40:09 +00:00
engine-flutter-autoroll
a1a3b2ce3c
Roll Flutter Engine from fe39ed980e74 to b408111b976c (6 revisions) ( #152739 )
...
fe39ed980e...b408111b97skia-flutter-autoroll@skia.org Roll Skia from 069274b16635 to ad1e3d828960 (1 revision) (flutter/engine#54307 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from 77cfae25b51d to 069274b16635 (3 revisions) (flutter/engine#54306 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from 3b79cbb42bf6 to 77cfae25b51d (1 revision) (flutter/engine#54303 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 03efd390e475 to 8dc947153d60 (1 revision) (flutter/engine#54302 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from cfa1cda77b46 to 3b79cbb42bf6 (2 revisions) (flutter/engine#54301 )
2024-08-02 skia-flutter-autoroll@skia.org Roll Skia from 5c229d4d20bb to cfa1cda77b46 (3 revisions) (flutter/engine#54300 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 10:09:24 +00:00
engine-flutter-autoroll
dc99d2f692
Roll Flutter Engine from ab3f177fb61d to fe39ed980e74 (1 revision) ( #152721 )
...
ab3f177fb6...fe39ed980eskia-flutter-autoroll@skia.org Roll Dart SDK from acbbbe73b5eb to 03efd390e475 (1 revision) (flutter/engine#54298 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 01:40:10 +00:00
engine-flutter-autoroll
9ceb13aadc
Roll Flutter Engine from 1cbe88e8115e to ab3f177fb61d (4 revisions) ( #152718 )
...
1cbe88e811...ab3f177fb6skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295 )
2024-08-01 jacksongardner@google.com [skwasm] Implement platform view clipping. (flutter/engine#54201 )
2024-08-01 skia-flutter-autoroll@skia.org Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288 )
2024-08-01 matanlurey@users.noreply.github.com Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 00:32:23 +00:00
engine-flutter-autoroll
c03f9955fa
Roll Flutter Engine from 17e3c7d520e7 to 1cbe88e8115e (5 revisions) ( #152707 )
...
17e3c7d520...1cbe88e811jonahwilliams@google.com [iOS] Supported rendering platform views without merging the raster thread. (flutter/engine#53826 )
2024-08-01 jhy03261997@gmail.com Set deep linking flag to true by default (flutter/engine#52350 )
2024-08-01 leroux_bruno@yahoo.fr [Android] Revert "Reset IME state on clear text input client" (flutter/engine#54277 )
2024-08-01 skia-flutter-autoroll@skia.org Roll Skia from 03732b9f885e to ddb6901e6141 (5 revisions) (flutter/engine#54287 )
2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 5acd806b6dad to acbbbe73b5eb (1 revision) (flutter/engine#54286 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 23:14:10 +00:00
Nate Wilson
6ff806d74e
Use .fromMap() constructors in example code ( #152535 )
...
Currently, there are 21 `.resolveWith()` calls in example files.
This pull request changes 11 of them to use the new `.fromMap()` constructor. (Seven of them are now `const`!)
```dart
ListTile(
iconColor: WidgetStateColor.fromMap(<WidgetStatesConstraint, Color>{
WidgetState.disabled: Colors.red,
WidgetState.selected: Colors.green,
WidgetState.any: Colors.black,
}),
// The same can be achieved using the .resolveWith() constructor.
// The text color will be identical to the icon color above.
textColor: WidgetStateColor.resolveWith((Set<WidgetState> states) {
if (states.contains(WidgetState.disabled)) {
return Colors.red;
}
if (states.contains(WidgetState.selected)) {
return Colors.green;
}
return Colors.black;
}),
),
```
2024-08-01 22:28:22 +00:00
hangyu
8a4812a6da
Add more widgets to a11y assessment app ( #152662 )
...
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-08-01 15:06:28 -07:00
engine-flutter-autoroll
ac039025e7
Roll Flutter Engine from 230879c7936e to 17e3c7d520e7 (1 revision) ( #152703 )
...
230879c793...17e3c7d520kpsroka@users.noreply.github.com Properly calculate alwaysUse24HourFormat on MacOS (flutter/engine#53795 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 21:39:25 +00:00
Justin McCandless
4b74c1a8a6
Explain that predictive back doesn't work with WillPopScope ( #152116 )
...
Clearly explains that WillPopScope will break predictive back support.
Came up in https://github.com/flutter/flutter/pull/152057#pullrequestreview-2191560087 .
2024-08-01 21:33:16 +00:00
Justin McCandless
67a958568e
SearchBar.scrollPadding ( #152635 )
...
Pass through the missing scrollPadding parameter for SearchBar and SearchAnchor.bar.
2024-08-01 13:56:04 -07:00
Justin McCandless
e08b0a56f9
Quick docs grammar fixes ( #152700 )
...
Yes I spent my precious time on this.
2024-08-01 20:29:58 +00:00
engine-flutter-autoroll
df88595d19
Roll Flutter Engine from bbb2fcad4808 to 230879c7936e (1 revision) ( #152701 )
...
bbb2fcad48...230879c793jonahwilliams@google.com [Impeller] migrate more AIKS test to DL. (flutter/engine#54267 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 20:13:45 +00:00
Matan Lurey
e11abea9d4
Disable DDS and Dart profiling for Android driver tests. ( #152696 )
...
Work around https://github.com/flutter/flutter/issues/152684 , and probably indefinitely if we don't need it.
2024-08-01 20:13:42 +00:00
Sam Rawlins
7777d67a66
Remove one set of parens that wrap a single String literal ( #152031 )
...
In order to address https://github.com/dart-lang/linter/issues/4354 , we are reporting a few more cases in unnecessary_parenthesis. `('text') * 2` is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/+/376540 . (These are the only newly-reported unnecessary parentheses for this change.)
2024-08-01 19:13:13 +00:00
engine-flutter-autoroll
831cfd283a
Roll Flutter Engine from 7c4a44611abe to bbb2fcad4808 (3 revisions) ( #152694 )
...
7c4a44611a...bbb2fcad48skia-flutter-autoroll@skia.org Roll Skia from f89a9c1902d7 to 03732b9f885e (5 revisions) (flutter/engine#54283 )
2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 0486e486778a to 5acd806b6dad (1 revision) (flutter/engine#54281 )
2024-08-01 skia-flutter-autoroll@skia.org Roll Skia from 8db309541ad9 to f89a9c1902d7 (11 revisions) (flutter/engine#54279 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 19:00:40 +00:00
Ben Konyi
d55a0b38e3
Fix bad pattern matching in DDS exception parsing ( #152685 )
...
Nullable types for values in map patterns require the key to be present.
Since the 'uri' key is not always present in DDS exception responses,
this was causing us to fall back to throwing a StateError.
Fixes https://github.com/flutter/flutter/issues/152684
2024-08-01 14:38:22 -04:00
engine-flutter-autoroll
619961d96c
Roll Packages from 46a712f38301 to 27896d1c5aa8 (7 revisions) ( #152693 )
...
46a712f383...27896d1c5a160153899+alexrabin-sentracam@users.noreply.github.com [local_auth_darwin] macOS Support (flutter/packages#6267 )
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 4d12197ca68d to f817e51a3a34 (7 revisions) (flutter/packages#7270 )
2024-08-01 ditman@gmail.com [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266 )
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 031dc3d156b9 to 4d12197ca68d (12 revisions) (flutter/packages#7259 )
2024-07-31 louisehsu@google.com [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232 )
2024-07-31 rexios@rexios.dev [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077 )
2024-07-31 stuartmorgan@google.com [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 18:18:26 +00:00
Tong Mu
5edec61f0e
[CupertinoActionSheet & AlertDialog] Improve documentation and type for scrollController parameters ( #152647 )
...
This PR:
* Improves doc for `scrollController` parameters, replacing the unclear "typically unneeded" with better reasons.
* Makes `scrollController` non-nullable on private classes, since they're always provided by their parents.
* Remove a redundant parameter from a private class.
2024-08-01 17:46:40 +00:00
Kamil Kras
735958ef9a
Fix typo in CHANGELOG.md ( #152543 )
2024-08-01 17:20:05 +00:00
Matan Lurey
4ff9462be8
Fix local testing, gradle XML errors, and enable on CI. ( #152383 )
...
TIL you cannot have XML comments before the initial `<?xml` declaration.
Follow-up to https://github.com/flutter/flutter/pull/152326 .
2024-08-01 09:10:45 -07:00
Valentin Vignal
7f4f1a0a62
Fix formatting issues in search_anchor.0_test.dart ( #152669 )
...
Fix formatting issues in `examples/api/test/material/search_anchor/search_anchor.0_test.dart`
Comes from https://github.com/flutter/flutter/pull/152371
Linked to https://github.com/flutter/flutter/issues/130459
2024-08-01 08:59:17 +00:00
Valentin Vignal
e38f730335
Add tests for search anchor examples ( #152659 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/search_anchor/search_anchor.1.dart`
- `examples/api/lib/material/search_anchor/search_anchor.2.dart`
2024-08-01 08:51:23 +00:00
engine-flutter-autoroll
cd1aae1c47
Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) ( #152665 )
...
4dc94d6f88...7c4a44611askia-flutter-autoroll@skia.org Roll Dart SDK from 0b09d933cd1e to 0486e486778a (2 revisions) (flutter/engine#54273 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 07:33:26 +00:00
engine-flutter-autoroll
6db25c5fdf
Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) ( #152663 )
...
f546fef7d7...4dc94d6f88bdero@google.com [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-01 05:58:53 +00:00
