53 Commits

Author SHA1 Message Date
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory (#118577)" (#121215)
This reverts commit 298d8c76ba78007deb5b96f320a11ccefe97a794.
2023-02-27 09:26:43 -05:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory (#118577)" (#120929)
This reverts commit 2df140f40d8c771ecef4f21cbdf635ec1235b4ac.
2023-02-16 21:28:30 -08:00
Ben Konyi
2df140f40d
Remove references to Observatory (#118577)
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
2023-02-13 14:29:30 -05:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119737)
This reverts commit 254a796bc3f8a32d3e09c1416bce7b7b9f1ba33b.
2023-02-06 09:23:35 -05:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (#119729)
This reverts commit 7477d7ac79debc06e92a72cec3f59178c74bc44d.
2023-02-01 09:19:48 -08:00
Danny Tuppeny
67d07a6de4
[flutter_tools] Fix parsing of existing DDS URIs from exceptions (#119506)
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions

Fixes #118609.

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
2023-01-31 17:36:44 +00:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)
* Reland "Add --serve-observatory flag to run, attach, and test (#118402)"

This reverts commit 86ab01d2bd82333be7a0cd4957903f424de02104.

* Fix flaky failures

* Fix VM service disappearing failure
2023-01-30 21:00:18 +00:00
Zachary Anderson
86ab01d2bd
Revert "Add --serve-observatory flag to run, attach, and test (#118402)" (#119302)
This reverts commit 6cd4fa45e2680bba871a7d65ddce4a59f68f6d72.
2023-01-26 16:43:39 -08:00
Ben Konyi
6cd4fa45e2
Add --serve-observatory flag to run, attach, and test (#118402)
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
2023-01-25 12:46:08 -05:00
Christopher Fujino
6e95067273
[flutter_tools] Fix _CastError in HotRunner._resetDirtyAssets (#108771) 2022-08-24 23:40:19 +00:00
Helin Shiah
118248bcc5
Pass URI converter from context to DDS (#106840)
* Pass URI converter from context to DDS

* Match change that will be merged

* Revert SDK web change
2022-07-07 10:10:04 -07:00
Ben Konyi
75baed585e
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#100995) 2022-03-30 13:50:13 -07:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Zachary Anderson
54a9d65282
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803) 2022-02-19 10:09:26 -08:00
Ben Konyi
4add01ab68
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#98769)
This reverts commit ac3c44355ae035b1e7f67881d956bcdfb8223e6f.
2022-02-18 13:28:42 -08:00
Ben Konyi
ac3c44355a
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)" (#92235)
This reverts commit ba0321e95db8a166c854c4ace5546de35bcb75c5.
2021-10-20 22:05:49 -07:00
Ben Konyi
ba0321e95d
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)
This reverts commit dc7fea8d197c5ebf192e8e6dc2d8773556a3dd7b.
2021-10-20 19:20:17 -07:00
Ben Konyi
dc7fea8d19
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)" (#91754)
This reverts commit e89a885fabe19baf004869cdc9f155cc77593642.
2021-10-13 12:45:45 -04:00
Ben Konyi
e89a885fab
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)
This reverts commit 58944e6b88f9237f270b4134a4712d8c0f5e254a.
2021-10-13 10:13:30 -04:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup (#89600)" (#89704)
This reverts commit 619121b095d9b506451387bde027038e7a986ab8.
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup (#89600) 2021-09-08 17:22:04 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety (#88382) 2021-08-17 21:12:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety (#88015)" (#88367) 2021-08-17 11:52:05 -07:00
嘟囔
d2f9c6c752
feat: migrate base/dds.dart to null-safety (#88015) 2021-08-11 14:47:06 -07:00
Jonah Williams
6b3093b6af
[flutter_tools] remove globals from Device and separate FlutterDeviceManager (#79454) 2021-03-31 12:59:00 -07:00
Jia Hao
aa1df71c20
[flutter_tools] throwToolExit should return Never (#78954) 2021-03-24 10:40:03 -07:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Ben Konyi
92427f260a
Handle 'Existing VM service clients' error from old VM service instances (#74665) 2021-01-25 12:29:05 -08:00
Ben Konyi
620a8284f8
Catch StateError and output more useful error message when DDS fails to start (#72736) 2020-12-22 10:24:04 -08:00
Ben Konyi
89ef88c64f
Ensure attaching to an application with an existing DDS instance is not treated as a fatal error (#70847) 2020-12-04 17:16:30 -08:00
Ben Konyi
4cbafda853
Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart (#70712) 2020-11-17 16:03:18 -08:00
Ben Konyi
65a81c7cd3
Roll package:dds to 1.4.0 and update error handling (#66836) 2020-09-29 10:28:17 -07:00
Ben Konyi
a17b330980
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#65873)
This reverts commit 66b01c1f2905f6b4f845f7283abe3e458351fe2e.

* Add DDS ipv6 support

* Use --dds-port for DDS instead of hijacking --host-vmservice-port
2020-09-16 16:27:42 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Mehmet Fidanboylu
66b01c1f29
Revert "Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64847)" (#64981)
This reverts commit c8f234d365de6a7e9b7febfb5b1b01713b26bc44.
2020-08-31 16:09:02 -07:00
Ben Konyi
c8f234d365
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64847)
This reverts commit 2436de13914e5aecdc92fad8af4ba47fb1b67601.
2020-08-31 12:14:32 -07:00
Jonah Williams
2436de1391
Revert "Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64802)" (#64845)
This reverts commit eef0050d08e7b037b6b0c903ac79458b287ede94.
2020-08-28 18:02:15 -07:00
Ben Konyi
eef0050d08
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64802)
* Reland "Re-enable the Dart Development Service (DDS) (#64671)"

This reverts commit 2ae25cc2d725ff9875cfcfdc8ca3996eb39db13a.

* Fix MDNS building Observatory URI with port 0 instead of forwarding the device port

* Added MDNS test
2020-08-28 16:18:35 -07:00
Ben Konyi
2ae25cc2d7
Revert "Re-enable the Dart Development Service (DDS) (#64671)" (#64797)
This reverts commit d7d12412e5ba55ebbc508de983f731b28efaddb1.
2020-08-28 09:00:53 -07:00
Ben Konyi
d7d12412e5
Re-enable the Dart Development Service (DDS) (#64671)
This change re-enables DDS and outputs the DDS URI in place of the VM
service URI on the console. If --disable-dds is not provided,
--host-vmservice-port will be used to determine the port for DDS rather
than the host port for the VM service, which will instead be randomly
chosen.
2020-08-27 16:35:00 -07:00
Ben Konyi
d6a25ae699
Temporarily disable Dart Development Service in flutter_tools (#62508)
Devtools doesn't currently support connections to DDS. Disable DDS
temporarily while a solution is worked on. See https://github.com/flutter/flutter/issues/62507
2020-07-29 12:32:10 -07:00
Ben Konyi
3a5a3eaf68
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#62147)
This reverts commit adc9dde3ba8563eebb824feb689f95eb947ab745.

- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
2020-07-29 10:05:40 -07:00
Ben Konyi
adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)" (#61993)
This reverts commit f7a1c87ffdb9476c25cda487cb7232617be31b33.
2020-07-21 16:17:23 -07:00
Ben Konyi
f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)
This reverts commit 4867f5931ff87a88fd3e89e7cf1b3cd9bd427670.
2020-07-21 15:44:38 -07:00
Ben Konyi
4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)" (#61909)
This reverts commit 895b7ef6faf4e9c6ad641ad556855ff38fbd04bb.
2020-07-20 16:41:01 -07:00
Ben Konyi
895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)
This reverts commit 38fe887342f6c6bf40dd2c25442b892644e11a39.
2020-07-20 16:01:58 -07:00
Ben Konyi
38fe887342
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)" (#61641)
This reverts commit 594c3541aae145123f964a60f3c30beda4a889c3.
2020-07-16 11:43:54 -07:00
Ben Konyi
594c3541aa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)
This reverts commit a1a5a8f6357788a3f5e1c4e60a4ae9abf9e6aed2.
2020-07-16 11:38:17 -07:00
Ben Konyi
a1a5a8f635
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61395)" (#61498)
This reverts commit f98184e487b933ef415f1257940a9dd576e9f073.
2020-07-14 16:32:49 -07:00