Dawid Wenderski
84cff3166d
Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.onDrag for ScrollViewers with Drawer ( #148948 )
...
Fixes https://github.com/flutter/flutter/issues/141542
Fixes https://github.com/flutter/flutter/issues/103544
Fixes https://github.com/flutter/flutter/issues/54277
2024-05-31 20:30:09 +00:00
Kevin Moore
de26ec8360
DRY up FakeCodec ( #149381 )
...
- dedupe the same class in two places
- renamed it to not clash with `FakeCodec` defined somewhere else
2024-05-31 20:24:20 +00:00
Yegor
6193615f90
Wire up SemanticsAction.focus to the framework ( #149374 )
...
Wire up `SemanticsAction.focus` to `Semantics` and `CustomPaint`. Reenable respective tests, and add `focus` tests to them.
Contributes to a fix for https://github.com/flutter/flutter/issues/83809
2024-05-31 19:30:18 +00:00
engine-flutter-autoroll
8c38366979
Roll Packages from 910fabb4886b to d8e8e8cee712 (3 revisions) ( #149429 )
...
910fabb488...d8e8e8cee7linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678 )
2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838 )
2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 18:27:30 +00:00
Runar Heggset
b7169ed5be
Use correct type for abi version code ( #149087 )
...
After upgrading flutter to the latest version (3.22.1), I encountered an error when building with `--split-per-abi`:
```
[ +1 ms] FAILURE: Build failed with an exception.
[ ] * Where:
[ ] Script '/home/runar/snap/flutter/common/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 1182
[ ] * What went wrong:
[ ] A problem occurred evaluating root project 'android'.
[ ] > A problem occurred configuring project ':app'.
[ ] > org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'null' with class 'null' to class 'int'.
Try 'java.lang.Integer' instead
```
This PR changes the type used from `ìnt` to `Integer` which is what's used in the `ABI_VERSION` map.
2024-05-31 17:49:16 +00:00
engine-flutter-autoroll
bffd97be13
Roll Flutter Engine from f3d6fe51fbba to e19d7cde4686 (2 revisions) ( #149424 )
...
f3d6fe51fb...e19d7cde46skia-flutter-autoroll@skia.org Roll Skia from ddc7ed3f0767 to b1e59e25696a (1 revision) (flutter/engine#53146 )
2024-05-31 skia-flutter-autoroll@skia.org Roll Skia from 8cc93368482b to ddc7ed3f0767 (1 revision) (flutter/engine#53145 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 17:44:20 +00:00
engine-flutter-autoroll
80f2dd4431
Roll Flutter Engine from df719e66bd36 to f3d6fe51fbba (3 revisions) ( #149412 )
...
df719e66bd...f3d6fe51fbskia-flutter-autoroll@skia.org Roll Skia from 64aae6958cc9 to 8cc93368482b (1 revision) (flutter/engine#53144 )
2024-05-31 skia-flutter-autoroll@skia.org Roll Skia from 47bbc9c6d5f5 to 64aae6958cc9 (1 revision) (flutter/engine#53143 )
2024-05-31 skia-flutter-autoroll@skia.org Roll Skia from 9930cf1449fd to 47bbc9c6d5f5 (3 revisions) (flutter/engine#53142 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 14:38:22 +00:00
engine-flutter-autoroll
bc30104be0
Roll Flutter Engine from abb4c95e679c to df719e66bd36 (1 revision) ( #149389 )
...
abb4c95e67...df719e66bdskia-flutter-autoroll@skia.org Roll Skia from b34e5dd89e9d to 9930cf1449fd (1 revision) (flutter/engine#53141 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 07:45:23 +00:00
engine-flutter-autoroll
fd43c83790
Roll Flutter Engine from 2158748627c7 to abb4c95e679c (1 revision) ( #149385 )
...
2158748627...abb4c95e67jonahwilliams@google.com Remove assorted bad logs. (flutter/engine#53139 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 06:28:10 +00:00
Michael Goderbauer
8bed1cbe42
Switch to FilterQuality.medium for images ( #148799 )
...
https://github.com/flutter/flutter/issues/148253
2024-05-31 03:50:30 +00:00
engine-flutter-autoroll
1658e2af26
Roll Flutter Engine from 6ea4f6ec577c to 2158748627c7 (1 revision) ( #149377 )
...
6ea4f6ec57...2158748627skia-flutter-autoroll@skia.org Roll Skia from c6cf8be050c0 to b34e5dd89e9d (1 revision) (flutter/engine#53133 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 02:32:37 +00:00
Benji Farquhar
51168862fb
Add support for ExpansionPanel custom splash color ( #147126 )
...
Relates to https://github.com/flutter/flutter/pull/147098 and https://github.com/flutter/flutter/issues/147097
Aside from fixing the expland/collapse icon color in the other PR, I noticed the splash color on both the icon button and the full expansion panel (if ExpansionPanel.canTapOnHeader is set to true) is just `Theme.of(context).splashColor` on the `InkWell` and `Theme.of(context).highlightColor` on the `IconButton` which may not suit the color scheme of the `ExpansionPanel`, so I have added a custom field `splashColor`, which will effect both the `IconButton` and the full panel `Inkwell`.
2024-05-31 01:44:32 +00:00
engine-flutter-autoroll
cc783cf28a
Roll Flutter Engine from 4956e98ab4cc to 6ea4f6ec577c (1 revision) ( #149371 )
...
4956e98ab4...6ea4f6ec57skia-flutter-autoroll@skia.org Roll Skia from a058f601e1fb to c6cf8be050c0 (2 revisions) (flutter/engine#53132 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 01:21:26 +00:00
engine-flutter-autoroll
47091bfdde
Roll Flutter Engine from bf2e32dfd5a2 to 4956e98ab4cc (4 revisions) ( #149367 )
...
bf2e32dfd5...4956e98ab4yjbanov@google.com [semantics] fix dartdoc grammar (flutter/engine#53121 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 188ad395c3e7 to a058f601e1fb (1 revision) (flutter/engine#53131 )
2024-05-30 daniel.l@hpcnt.com Replace several NSAssert with FML_CHECK/DCHECK to unblock the build (flutter/engine#53048 )
2024-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] make sure buffers are 4 aligned for foreground color blending (flutter/engine#53077 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-31 00:36:27 +00:00
gaaclarke
a1423723ff
Rounded Rect Blur Benchmark: Made the number of circles a fixed number ( #149323 )
...
This will make the results more comparable across devices.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-30 16:37:47 -07:00
Gray Mackall
d89ae48520
Manual pub roll w/ gradle lockfile regeneration ( #149342 )
...
Manual recreation of https://github.com/flutter/flutter/pull/148911
Entire PR is just the output of
```
flutter update-packages --force-upgrade
```
followed by (run from the root of the flutter repo)
```
find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion
```
2024-05-30 23:04:08 +00:00
gaaclarke
c0c284c72b
Fixed typo in devicelab test name ( #149327 )
...
Should fix devicelab failures in dashboard.
2024-05-30 23:02:03 +00:00
Victor Sanni
3496b1d397
Add feedback for long press on iOS ( #148922 )
...
Adds the click system sound and heavy-impact haptic feedback to iOS on long presses.
Fixes #148391
2024-05-30 23:00:21 +00:00
engine-flutter-autoroll
53ced2a5fd
Roll Flutter Engine from de07179371f8 to bf2e32dfd5a2 (14 revisions) ( #149357 )
...
de07179371...bf2e32dfd5flar@google.com DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127 )
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119 )" (flutter/engine#53128 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126 )
2024-05-30 jonnywang@google.com Fuchsia api level 18 (flutter/engine#53115 )
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (#53099 )" (flutter/engine#53125 )
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (#53108 )" (flutter/engine#53124 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119 )
2024-05-30 yjbanov@google.com add SemanticsAction.focus (flutter/engine#53094 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117 )
2024-05-30 bdero@google.com [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107 )
2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114 )
2024-05-30 jiahaog@users.noreply.github.com Disable Impeller when the manifest explicitly disables it (flutter/engine#53108 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 22:48:34 +00:00
Lau Ching Jun
557a959547
Adding a default case to unblock engine roll. ( #149353 )
...
Similar to https://github.com/flutter/flutter/pull/149274
2024-05-30 15:01:56 -07:00
Kostia Sokolovskyi
488fb09582
Add tests for tween_animation_builder.0.dart API example. ( #148902 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/tween_animation_builder/tween_animation_builder.0.dart`
2024-05-30 20:17:04 +00:00
Ian Hickson
5933e99c6c
Remove hidden dependency on ABI. ( #148987 )
...
This is part 17 of a broken down version of the #140101 refactor (though this particular dependency didn't actually exist back then).
This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.
I also snuck in a minor stylistic change, using interpolation instead of explicit `toString`, to make the code more idiomatic. (I'm actually surprised that that didn't trigger a lint, I thought we had a lint to catch that. I must be thinking of something else though.)
This PR makes no effort to keep the order of parameters reasonable. There is an existing TODO to do a refactor sweep later that does nothing but reorder arguments/parameters/fields to be consistent.
2024-05-30 19:12:22 +00:00
hangyu
1aba3a66f5
[GAR] [a11y] Update text button page in a11y assessment app ( #148905 )
...
internal: b/317125569
If the text button label contains its role and state, it will be confusing for tester.
it will be announced like "xxx button button" :
<img src="https://github.com/flutter/flutter/assets/108393416/16f5a996-b0f1-4f04-bd99-caa3cacd4182 " width=50% height=50%>
updated screen and label:
<img src="https://github.com/flutter/flutter/assets/108393416/1de55cec-8a18-4c36-9dac-84ae7d151fd6 " width=50% height=50%>
2024-05-30 18:34:07 +00:00
Mitchell Goodwin
54573bc875
Have Material widgets in a Cupertino App partially use Cupertino theme ( #139253 )
...
Fixes #138621
Fixes and issue where if a Material widget is used in a Cupertino App, then some parts of it's default Material 3 theming would show up as purplish. This could be fixed by wrapping your app with a Material theme, but that's a little awkward.
Material and Cupertino themes interact with each other a little oddly. If a theme of either is searched for but does not exist, then a default one is generated. So if a Material widget is in a Cupertino app that does not already have a Material theme, then a fallback Material theme will be created. This PR makes it so that, in this case when that Material theme is created, it's default colors will be based on the Cupertino theme.
Another oddity is that a Material theme always wraps itself with a Cupertino theme that's values are based on the Material theme. So before this change, a Material widget would theoretically add a new Material based Cupertino theme to the tree. So I added logic that would have the Material theme check to see if a Cupertino theme exists, before it overwrites it.
Before:
After:
<img width="386" alt="Screenshot 2023-11-29 at 10 37 09â¯AM" src="https://github.com/flutter/flutter/assets/58190796/959ccfd9-3439-438e-ad36-20597334837a ">
Update:
I changed it to not rely on the Material 3 flag. Instead, if a Material theme is searched for and there is already a Cupertino theme in the tree, then it will use that Cupertino theme instead of generating a new. Also, if a Material theme is searched for, and it does not find one already in the tree, but does find a Cupertino theme, then it will generate one with a color palette based off of that Cupertino theme's colors.
After with this change:
<img width="390" alt="Screenshot 2024-05-09 at 10 16 22â¯AM" src="https://github.com/flutter/flutter/assets/58190796/79765d04-a7a3-4eb5-9477-11668ed138e5 ">
We should still probably suggest for developers to include a Material theme in their Cupertino app if they wish to use widgets from both packages.
2024-05-30 17:54:53 +00:00
Nate
ee3557afe0
Refactor Material build method ( #147430 )
...
Only a code quality change, improves readability using `switch`.
2024-05-30 10:54:17 -07:00
MajdSallora
df95cb2984
Add locale in DatePickerThemeData ( #148292 )
...
*This PR changes the date picker were add locale in DatePickerThemeData*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes #148202
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-05-30 17:53:03 +00:00
auto-submit[bot]
3d4fd550c2
Reverts "Enable explicitChildNodes for the AlertDialog content ( #149130 )" ( #149333 )
...
Reverts: flutter/flutter#149130
Initiated by: Piinks
Reason for reverting: Google testing did not run on this PR and multiple semantics screen shots from internal testing look incorrect.
Original PR Author: TahaTesser
Reviewed By: {goderbauer}
This change reverts the following previous change:
fixes [AlertDialog content semantics merged](https://github.com/flutter/flutter/issues/147574 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
// showSemanticsDebugger: true,
home: Scaffold(
body: SafeArea(
child: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDialog<void>(
context: context,
builder: (BuildContext context) {
return AlertDialog(
title: const Text('Dialog Title'),
content: const Column(
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
actions: <Widget>[
TextButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Close'),
),
],
);
},
);
},
child: const Text('Open Dialog'),
);
}),
],
),
),
),
),
);
}
}
```
</details>
### Before vs After
2024-05-30 17:43:26 +00:00
John Angelo Cordero
11cbe41555
allow changing textAlign of TextField in DropdownMenu ( #148074 )
...
PR for #147991
2024-05-30 16:57:00 +00:00
engine-flutter-autoroll
02739d737b
Roll Flutter Engine from 2fedfd3cc6e5 to de07179371f8 (1 revision) ( #149324 )
...
2fedfd3cc6...de07179371skia-flutter-autoroll@skia.org Roll Skia from 8da05c8d40af to 949b8cefbf87 (3 revisions) (flutter/engine#53113 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 16:52:03 +00:00
engine-flutter-autoroll
7eebe2992a
Roll Packages from 31d332900d98 to 910fabb4886b (11 revisions) ( #149321 )
...
31d332900d...910fabb48858529443+srujzs@users.noreply.github.com Amend package:web tweaks to allow package:web roll (flutter/packages#6793 )
2024-05-29 matanlurey@users.noreply.github.com Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456 )
2024-05-29 joonas.kerttula@codemate.com [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832 )
2024-05-29 matanlurey@users.noreply.github.com Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462 )
2024-05-29 matanlurey@users.noreply.github.com Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461 )
2024-05-29 katelovett@google.com [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830 )
2024-05-29 43054281+camsim99@users.noreply.github.com [camerax] Add notes about Android permissions (flutter/packages#6741 )
2024-05-29 43054281+camsim99@users.noreply.github.com [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742 )
2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter from a1a33e63b911 to c85fa6abf4ff (20 revisions) (flutter/packages#6829 )
2024-05-29 katelovett@google.com [rfw] Migrate deprecated doc references (flutter/packages#6744 )
2024-05-29 katelovett@google.com [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 16:39:06 +00:00
engine-flutter-autoroll
421c8c5ef5
Roll Flutter Engine from fb64b9a4e6f2 to 2fedfd3cc6e5 (2 revisions) ( #149320 )
...
fb64b9a4e6...2fedfd3cc6skia-flutter-autoroll@skia.org Roll Skia from e256482ed29c to 8da05c8d40af (1 revision) (flutter/engine#53112 )
2024-05-30 kjlubick@users.noreply.github.com Replace several calls to GrGLMakeNativeInterface with more direct APIs (flutter/engine#53064 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 15:45:24 +00:00
flyboy
db5c1434e6
Fix Slider throws an error when _labelPainter text is null ( #148462 )
...
*Fix #148159*
2024-05-30 14:49:13 +00:00
engine-flutter-autoroll
d4e9b78161
Roll Flutter Engine from 5500c1a3969a to fb64b9a4e6f2 (1 revision) ( #149307 )
...
5500c1a396...fb64b9a4e6skia-flutter-autoroll@skia.org Roll Skia from e63ddcabadc6 to e256482ed29c (1 revision) (flutter/engine#53110 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 11:17:37 +00:00
Taha Tesser
6a0e0bfdc5
Enable explicitChildNodes for the AlertDialog content ( #149130 )
...
fixes [AlertDialog content semantics merged](https://github.com/flutter/flutter/issues/147574 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
// showSemanticsDebugger: true,
home: Scaffold(
body: SafeArea(
child: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDialog<void>(
context: context,
builder: (BuildContext context) {
return AlertDialog(
title: const Text('Dialog Title'),
content: const Column(
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
actions: <Widget>[
TextButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Close'),
),
],
);
},
);
},
child: const Text('Open Dialog'),
);
}),
],
),
),
),
),
);
}
}
```
</details>
### Before vs After
2024-05-30 09:59:22 +00:00
engine-flutter-autoroll
d71f4eb685
Roll Flutter Engine from 0c95e85dfbf4 to 5500c1a3969a (1 revision) ( #149304 )
...
0c95e85dfb...5500c1a396skia-flutter-autoroll@skia.org Roll Skia from 59dc6975523c to e63ddcabadc6 (1 revision) (flutter/engine#53109 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 09:43:28 +00:00
engine-flutter-autoroll
d54d8ab10f
Roll Flutter Engine from 19707e811b60 to 0c95e85dfbf4 (1 revision) ( #149300 )
...
19707e811b...0c95e85dfbskia-flutter-autoroll@skia.org Roll Skia from f23183f041fe to 59dc6975523c (3 revisions) (flutter/engine#53106 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 08:33:22 +00:00
engine-flutter-autoroll
b295c86b2e
Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) ( #149291 )
...
4adf453b6d...19707e811bjonahwilliams@google.com [Impeller] enable Impeller by default on Android. (flutter/engine#53099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 04:29:41 +00:00
Jonah Williams
d3beaae07f
disable Impeller on external texture test. ( #149292 )
...
This is failing with Impeller:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android_emu%20external_textures_integration_test/1414/overview
Needs investigation.
2024-05-29 20:43:48 -07:00
engine-flutter-autoroll
c787dc99bd
Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) ( #149290 )
...
8d5d14a1db...4adf453b6dskia-flutter-autoroll@skia.org Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102 )
2024-05-29 john@mcdole.org Update CONTRIBUTING.md links (flutter/engine#53043 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097 )
2024-05-29 jonahwilliams@google.com [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096 )
2024-05-29 jonahwilliams@google.com [Impeller] fix barriers prior to mip generation. (flutter/engine#53082 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095 )
2024-05-29 goderbauer@google.com Switch to FilterQuality.medium for images (flutter/engine#52984 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091 )
2024-05-29 jonahwilliams@google.com [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 02:28:10 +00:00
Kevin Chisholm
07c256f026
Update 3.22.1 release notes to include missing fix. ( #148999 )
...
Update changelog to include
https://github.com/flutter/flutter/pull/148580 in the list of fixes.
2024-05-30 09:15:37 +07:00
engine-flutter-autoroll
697d99fae8
Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) ( #149263 )
...
Manual roll requested by jacksongardner@google.com
60968ee3bd...8d5d14a1dbskia-flutter-autoroll@skia.org Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) (flutter/engine#53089 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 00:53:23 +00:00
auto-submit[bot]
ebc414337d
Reverts "Prevent LayoutBuilder from rebuilding more than once ( #147856 )" ( #149279 )
...
Reverts: flutter/flutter#147856
Initiated by: loic-sharma
Reason for reverting: tree is closed with errors like:
```
test/integration.shard/break_on_framework_exceptions_test.dart: breaks when rebuilding dirty elements throws [E]
Expected: <45>
Actual: <2756>
package:matcher expect
test\integration.shard\break_on_framework_exceptions_test.dart 56:5 main.expectException
===== asynchronous gap ===
Original PR Author: LongCatIsLooong
Reviewed By: {goderbauer}
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/146379 : introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes.
This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less.
Caveats:
`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.
Tests:
Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893
2024-05-29 23:29:19 +00:00
Danny Tuppeny
182c1e6a36
Unskip expression evaluation test ( #149253 )
...
This test was skipped in https://github.com/flutter/flutter/pull/148737
because it had became flaky because instances created in expression
evaluation were being collected quickly. The change in
ffbbdb5a10https://github.com/flutter/flutter/issues/148704
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-29 23:24:36 +01:00
Yegor
35543e9117
temporarily disable SemanticsAction tests to unblock engine change ( #149274 )
...
These tests essentially count the number of values in the engine enums. https://github.com/flutter/engine/pull/53094 is adding a new value, which causes these tests to fail. Temporarily disabling these tests so that the engine change can proceed.
2024-05-29 22:22:25 +00:00
gaaclarke
ba5a4d8c09
Adds benchmark for rrect_blur. ( #149261 )
...
issue: https://github.com/flutter/flutter/issues/148496
(I slightly tweaked the animation to make sure the large radius blurs aren't always at the bottom of the screen).
2024-05-29 22:19:10 +00:00
LongCatIsLooong
bafdb124c7
Prevent LayoutBuilder from rebuilding more than once ( #147856 )
...
Fixes https://github.com/flutter/flutter/issues/146379 : introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes.
This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less.
Caveats:
`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.
Tests:
Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893
2024-05-29 22:03:20 +00:00
Valentin Vignal
bc097c619a
Add test for inherited_theme.0.dart ( #149120 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/inherited_theme/inherited_theme.0_test.dart`
2024-05-29 20:05:25 +00:00
Ellet
e553bbc2ba
Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS ( #145246 )
...
Since we are using The `CupertinoScrollBar` for both macOS and iOS, it's a good idea to update the description of the `adaptive` function to indicate it will be used for macOS and iOS
*Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS.*
2024-05-29 19:06:07 +00:00
LinXunFeng
d424b64229
_ModalScopeStatus as InheritedModel ( #149022 )
...
According to previous discussion at https://github.com/flutter/flutter/pull/145389#discussion_r1561564845 , this change makes `_ModalScopeStatus` an `InheritedModel` rather than an `InheritedWidget`, and provides the following methods.
- `isCurrentOf`
- `canPopOf`
- `settingsOf`
For example, `ModalRoute.of(context)!.settings` could become `ModalRoute.settingsOf(context)` as a performance optimization.
2024-05-29 18:46:04 +00:00
Valentin Vignal
2e275032d5
Add test for radio.toggleable.0.dart ( #149153 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/radio/radio.toggleable.0.dart`
2024-05-29 18:30:57 +00:00
