firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,265 Commits 1 Branch 0 Tags
Commit Graph

8265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Todd Volkert
ffdca6f7e8 Fix getDevicesById() (#9646) 
If the user specified a non-exact device id, it was producing
an exception whereby we were trying to listen to the
`getAllConnectedDevies()` stream twice.
 2017-04-27 13:12:59 -07:00
Adam Barth
744c91265b Add NestedScrollView (#9640) 
A NestedScrollView lets you implement patterns where you have a header, tabs,
and additional scrollers inside the tabs.

Fixes #8359
 2017-04-27 12:29:40 -07:00
Jason Simmons
834c142d04 Fix the sizing of the image in Gallery/Contacts (#9625) 2017-04-27 11:32:53 -07:00
Jason Simmons
0439bf25d9 Fix an analyzer warning (#9643) 2017-04-27 11:16:00 -07:00
Adam Barth
4bac259617 Shift more code to ScrollPosition (#9637) 
Previously, ScrollPosition did not know about ScrollActivities. However, all
the concrete subclasses of ScrollPosition that we know about need to use
ScrollActivities, so they ended up with a bunch of delegate boilerplate code.

This patch teaches ScrollPosition about ScrollActivities but doesn't have any
opinion about how to start or interact with those activities.

This patch is more refactoring to prepare for nested and linked scrolling.
 2017-04-27 10:30:53 -07:00
Michael Goderbauer
36f7a26641 Disable AAPT cruncher on Windows for channel integration test (#9639) 
It causes the test to be flaky, see https://github.com/flutter/flutter/issues/8986.
 2017-04-27 09:59:31 -07:00
Adam Barth
2891772846 Refactor ScrollDragActivity into two pieces (#9629) 
This will make it easier to implement nested scrolling.
 2017-04-27 09:39:12 -07:00
Devon Carew
9ac2e44ee7 add a regression test for daemon device notification (#9618) 
* add a regression test for daemon device notification

* revert event send simplification
 2017-04-27 09:30:47 -07:00
P.Y. Laligand
d2c6b0a637 Get rid of unnecessary flutter_root argument. (#9622) 2017-04-27 09:10:48 -07:00
Mikkel Nygaard Ravn
23b8e1f115 Make profile provisioning manual for channel_integration_test_ios (#9633) 2017-04-27 12:14:43 +02:00
Mikkel Nygaard Ravn
60bc1cfde7 Remove personal dev team from ios code sigining (#9631) 
* Mark channels_integration_test_ios flaky

* Removed personal dev team from ios code siging

* Removed provisioning profile diffs against other samples
 2017-04-27 11:07:52 +02:00
Mikkel Nygaard Ravn
70ff50f929 Integration test for channel communication (#9621) 2017-04-27 08:44:28 +02:00
Zachary Anderson
0770c3c14f [flutter_tools] Adds some support for '-d all' (#9585) 2017-04-26 21:49:38 -07:00
Todd Volkert
9558ac7d55 Assert that url is non-null in NetworkImage (#9626) 2017-04-26 21:35:58 -07:00
Ian Hickson
2e194d5b44 Allow ChangeNotifiers to be CustomPainters (#9584) 
Fixes https://github.com/flutter/flutter/issues/7648
 2017-04-26 14:30:20 -07:00
Mehmet Fidanboylu
4e7a38b118 Add a tile scrolling test to complex_layout app (#9537) 
* Add a tile scrolling test to complex_layout app

* - Review comments and fix analyzer failures.

* Use ListView.builder pattern.
 2017-04-26 14:22:11 -07:00
xster
f645245ffd Add a convenience test task for vscode (#9570) 2017-04-26 13:48:28 -07:00
Todd Volkert
e2cd78358f Fix missing await (#9617) 
Fixes #9612
 2017-04-26 13:14:31 -07:00
Adam Barth
0f900116f0 Rename Stack.sizing to Stack.fit (#9615) 
The enum is called StackFit, so the property name "fit" makes more sense.
 2017-04-26 11:12:38 -07:00
Hans Muller
3c3b003f8b Handle ListView item size changes that cause underflow (#9586) 2017-04-26 10:44:35 -07:00
Michael Goderbauer
b7ec82014d move collection to dev dependency (#9613) 2017-04-26 10:38:11 -07:00
Michael Goderbauer
460561bad8 Make Flutter plugins usable from a Windows host (#9599) 
Note: In a cross-platform context `Uri.path` is not a valid file path. Allways use `fs.path.fromUri` to convert.
 2017-04-26 10:02:22 -07:00
Todd Volkert
aaaae265ae Run async when calling adb shell getprop (#9611) 
Also, add a timeout so a hung `adb` will not cause the
tools process to hang.

Fixes #9567
 2017-04-26 09:58:20 -07:00
Todd Volkert
21f57a85e8 Wait for stderr in runCommandAndStreamOutput() (#9598) 2017-04-25 17:40:28 -07:00
Todd Volkert
60c5ffc1a9 Switch many Device methods to be async (#9587) 
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
 2017-04-25 17:23:00 -07:00
Ian Hickson
596eb033c7 Loosen the constraints for Stack non-positioned children. (#9581) 
Also:

 * Add three explicit sizing modes to Stack for non-positioned
   children: loose, expand, and passthrough. (All three are used.)

 * Fix a bug whereby layers would try to paint in the same frame as
   they were removed from layout (but not detached).

 * Fix a bug whereby Offstage wasn't properly marking the parent dirty
   when changing its sizedByParent flag.

 * Explicitly make Overlay expand non-positioned children.

 * Explicitly have InputDecoration pass through the constraints from
   its Row to its Stack children.
 2017-04-25 15:06:02 -07:00
Ian Hickson
24b40d87d6 Make getVelocity never return null (#9583) 
Fixes https://github.com/flutter/flutter/issues/8425
 2017-04-25 12:23:43 -07:00
Michael Goderbauer
ad1c497c03 Do not lower-case paths during canonicalization. (#9571) 
* Do not lower-case paths during canonicalization.

This breaks hot reload on some platfroms with case insensitive file systems.

* Add unit tests
 2017-04-25 10:34:43 -07:00
Alexandre Ardhuin
31828609dc add @required (#9579) 2017-04-25 08:59:43 +02:00
Adam Barth
c288c7064f Refactor scrolling code to prepare for nested scrolling (#9575) 
This patch reworks some of the guts of scrolling to make it easier to
implement nested scrolling effects. The actually nested scrolling effect
will be included in a later patch.
 2017-04-24 23:32:55 -07:00
Ian Hickson
57648ba0e4 New Placeholder widget. (#9565) 2017-04-24 14:06:07 -07:00
Ian Hickson
3492350653 Remove Placeholder. It has no clients. (#9563) 2017-04-24 12:40:27 -07:00
Adam Barth
55f334681b FocusNode.requestFocus should show the keyboard (#9558) 
This patch introduces the notion of a keyboard token, which generalizes the
logic in EditableText for distinguishing between gaining focus by default and
gaining focus because of an explicit use action.

Fixes #7985
 2017-04-24 09:46:49 -07:00
Michael Thomsen
1de15bbb00 Remove Pods dir from examples that have it (#9550) 
* Remove Pods dir from layers example

* Remove Pods dir from flutter_view example
 2017-04-24 18:38:44 +02:00
Todd Volkert
db82f9ea7d Make travis script more verbose upon error (#9545) 
This will help us know for sure exactly which sub-script erred.
 2017-04-24 09:14:44 -07:00
Todd Volkert
a3f0f6911b Remove replay test (#9542) 
It's going to be replaced by #8963

Fixes #8947
 2017-04-24 08:47:38 -07:00
Michael Thomsen
f10326d28e Add app id to build.gradle template (#9552) 2017-04-24 17:13:04 +02:00
Michael Thomsen
c313984409 Exclude generated PluginRegistry files from git (#9555) 2017-04-24 15:23:18 +02:00
Michael Thomsen
2e10f61c5c Upgrade node version (#9549) 
* Upgrade node version

* Upgrade node version, but no further than 6 which is in LTS
 2017-04-24 13:14:44 +02:00
Michael Thomsen
f6a7fe0925 Upgrade firebase tools version (#9548) 2017-04-24 11:14:54 +02:00
Alexandre Ardhuin
83fce211a3 More const immutable classes (#9544) 
* more widget const constructors

* prefer const constructors

* address review comments
 2017-04-23 22:37:29 +02:00
Brian Slesinsky
054c937917 don't use curl progress bar since it looks bad in IDEA console window (#9538) 
Without this flag, it shows progress via increasing numbers instead of a progress bar. For some reason, the IDEA console seems to be okay with that.
 2017-04-23 10:30:27 -07:00
Alexandre Ardhuin
26c7411d66 unnecessary_override (#9540) 2017-04-22 22:58:21 +02:00
Alexandre Ardhuin
ad496e142b enable lint overridden_fields (#9527) 
* enable lint overridden_fields

* address review comment
 2017-04-22 10:27:03 +02:00
Adam Barth
0d0861b3ee The const will continue until morale improves (#9536) 2017-04-21 14:59:24 -07:00
xster
76ecb0b9a1 Remove InputField (#9520) 2017-04-21 14:12:14 -07:00
Alexandre Ardhuin
10099db4e2 try lint prefer_expression_function_bodies (#9494) 2017-04-21 23:10:37 +02:00
Adam Barth
a57018a4bb Add GridView.builder (#9522) 
This constructor makes it easier to use a GridView with a builder
callback.

Fixes #8952
 2017-04-21 14:09:53 -07:00
Alexandre Ardhuin
9541848272 make @immutable const classes (#9532) 
* make @immutable const

* fix build
 2017-04-21 23:09:42 +02:00
Adam Barth
1abb6f5d74 Explain why the Padding widget exists (#9523) 
Fixes #5166
 2017-04-21 14:09:35 -07:00