8265 Commits

Author SHA1 Message Date
xster
7ce1cfd48d AppBar automatically show a close button for dialogs (#9268)
* Wiring fullscreen dialog

* Make fullscreen dialog use the new API. Add tests

* Review notes

* Move field back up

* final
2017-04-10 01:05:25 -07:00
Devon Carew
70e2acfb6c tweak the layout for the ios doctor checks (#9306) 2017-04-09 12:43:48 -07:00
Devon Carew
ca5f0c9a3e fix the return type on flutterPlatformOverride (#9269) 2017-04-09 11:08:32 -07:00
Kyle Bradshaw
55e51e798b Form.dart doc typo fixes (#9302)
Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.
2017-04-08 10:39:01 -07:00
Ian Hickson
9350f2875d Fix some error message text typos. (#9294)
Also, add a specific message for BuildContext.size for RenderSlivers.
2017-04-08 00:32:02 -07:00
Dariusz Baciński
d25981cfb3 generate_from_arb has been moved to intl_translantion library (#9255)
* generate_from_arb has been moved to intl_translantion library

* fixed typo

* added missing intl dependency

* Regenerated language files with latest intl script

* Added version to intl_translations

* added isolate min version constraint
2017-04-08 00:25:01 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
2017-04-08 08:43:19 +02:00
Yegor
361afef305 fix checkLockAcquired: support re-entrant locking (#9272)
* fix checkLockAcquired: support re-entrant locking

* add test; address comments

* add comment
2017-04-07 21:08:53 -07:00
xster
33997bb7bb Add some more details to implicit animation's dartdoc (#9292) 2017-04-07 18:40:06 -07:00
Ian Hickson
2a5810e36f Point from gallery's routing table to stocks'. (#9287)
The stocks routing table is a clearer example of how to do this.
People know to look at the gallery, but don't think to look at the
stocks version. This points them from the former to the latter.
2017-04-07 17:51:41 -07:00
Seth Ladd
c358ddbaf2 example of a package dependency asset (#9295) 2017-04-07 17:51:34 -07:00
Ian Hickson
a6eeaa5e34 Fix some typos in icon_theme.dart (#9296) 2017-04-07 17:24:50 -07:00
Ian Hickson
ebe6da5b17 Rename BlockBody to ListBody. (#9291)
Nobody knew what a Block was.
2017-04-07 17:14:54 -07:00
Adam Barth
f9ae22677a Improve cooperation between scale and drag gestures (#9298)
Now the scale gesture will accept if its focal point moves more than the pan
slop. This change lets it compete with a drag gesture (e.g., a containing scrol
view) in the same way that the pan gesture does.

Fixes #8735
2017-04-07 17:00:32 -07:00
Jason Simmons
8ee6525cc8 Remove the obsolete build apk --target-arch flag (#9239)
Gradle APK builds include engine binaries for all applicable architectures
2017-04-07 13:48:10 -07:00
Jason Simmons
67b3871e2a Filter Android logs by the pid of the remote process (#9293)
Fixes https://github.com/flutter/flutter/issues/6849
2017-04-07 13:41:29 -07:00
Alexandre Ardhuin
8bcf302e23 use conditional assignment (#9252) 2017-04-07 21:41:17 +02:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Ian Hickson
54bbb6fb4d SliverFill: s/size/extent/ as requested by abarth a while ago... (#9279) 2017-04-07 12:24:06 -07:00
Ian Hickson
6d5488ad3e Minor fixes to flutter packages. (#9278) 2017-04-07 12:23:57 -07:00
Chris Bracken
ecc590f958 Eliminate WidgetTester.idle() after enterText() (#9290)
enterText() now includes a call to idle().
2017-04-07 11:42:22 -07:00
Chris Bracken
a7a95daa52 Update TextEditingValue.selection on selection change (#9284)
Fixes a bug where tapping in the text under edit moved the cursor but
did not push the updated selection to the engine.

Adds a test for caret position updates.
2017-04-07 11:13:10 -07:00
Phil Quitslund
5b89c10105 Bump to Dart SDK 1.23.0-dev.11.6. (#9285)
Pulls in latest 1.23. cherry picks, including @abarth’s fix to restrict `@immutable` checks to instance fields.
2017-04-07 09:43:09 -07:00
Ian Hickson
c1bdf5e032 TextPainter control test (#9275) 2017-04-06 16:56:00 -07:00
Yegor
d538c11486 update devicelab docs (#9274) 2017-04-06 16:27:29 -07:00
Jason Simmons
bb0adcb873 Update version strings in Gallery (#9263)
Fixes https://github.com/flutter/flutter/issues/9259
2017-04-06 13:11:20 -07:00
Jason Simmons
e04376895d Handle tabs in rendering of licenses (#9264) 2017-04-06 13:11:06 -07:00
Adam Barth
470db7d96e TextField should update IME when controller changes (#9261)
Fixes #9246
2017-04-06 12:28:30 -07:00
Ryan Macnak
249bbac362 Support for placing an AOT dylib in the flx. Part of Fuchsia AOT sup… (#9240)
Support for placing an AOT dylib in the flx.  Part of Fuchsia AOT support.
2017-04-06 11:12:12 -07:00
Yegor
57ca2b5ce8 obey custom timeout supplied by cocoon (#9260) 2017-04-06 10:48:45 -07:00
David Yang
c96ab53b42 Allowing more flexibility to the active opacity of the Cupertino Button (#9071)
* Allowing overrides to the activeOpacity of the button

* adding tests

* fix

* fixing animation

* fixes

* moar fixes
2017-04-05 23:52:24 -07:00
Ian Hickson
9b5d1fbe1e Provide more widget const constructors. (#9247)
Still many more to go.
2017-04-05 23:39:07 -07:00
Adam Barth
93b90362fd Add more breadcrumbs in Notification docs (#9245)
Fixes #7519
2017-04-05 23:31:52 -07:00
Ian Hickson
2144a8964f Fill in the test for button color splash and highlights (#9224)
Fixes https://github.com/flutter/flutter/pull/8643

Fixes https://github.com/flutter/flutter/issues/8804 by adding a test
to verify that Material elevation changes animate.

Also tweak some dartdocs, add some trailing commas, improve some
toString output, make the inkwell test agnostic to the PhysicalModel
logic, and move the material buttons test to the material test
directory.
2017-04-05 22:46:58 -07:00
Adam Barth
954b35bf25 Add some more asserts to RenderFlex (#9209) 2017-04-05 22:46:43 -07:00
Ian Hickson
2f4835429b Better toStrings for Listenable subclasses (#9244) 2017-04-05 22:46:36 -07:00
Michael Goderbauer
18d69b1b3e Delete Color supported test :( (#9235) 2017-04-05 16:25:20 -07:00
Adam Barth
882c992b17 Add Wrap (#9225)
The Wrap widget is a layout that places children in a run in order along its
main axis until it runs out of space. At that point, starts placing children in
a new run that is adjacent in the cross axis.

Fixes #8831
2017-04-05 16:22:32 -07:00
Michael Goderbauer
a559b8df5c [Regression] Re-enable ANSI color support on Windows (#9232)
Also adds a test to make sure we don't break it again.
2017-04-05 15:44:22 -07:00
Yegor
03f5793cda increase driver timeouts; also unify the values (#9228) 2017-04-05 14:01:33 -07:00
Ian Hickson
1b948cbb85 Rename SliverFill to SliverFillViewport and add SliverFillRemaining (#9194) 2017-04-05 12:27:59 -07:00
Ian Hickson
e355c60124 Add a timeout to pumpAndSettle. (#9195) 2017-04-05 12:27:42 -07:00
Ian Hickson
86a490ffe8 Tracked skipped tests in technical debt benchmark (#9206) 2017-04-05 12:23:21 -07:00
Ian Hickson
a52c7b470d Update the examples/ README and associated fixes. (#9090)
This yak shave went as follows:

Fix https://github.com/flutter/flutter/issues/8795 by adding stocks to
the examples README.

Notice the layers entry in that README isn't quite right either.
Update that.

Check the layers/README file is worth pointing at.

Update the layers/README.

Let's run some of the layer tests to see if they still work.

Oops, need to update them to gradle.

Ok let's try running them again.

Oops, sector is broken.

Add a test for sector.

Fix sector. Find you need to add an assert to a const constructor.

Notice we need to turn const asserts on for the analyzer.

Notice the analysis_options files are out of sync with each other and
with the full list of lints.

Turn on the lints that should be on.

Fix the bugs that finds.
2017-04-05 11:28:33 -07:00
Michael Thomsen
c48f5f6d00 Remove title code as no title is shown (#9213) 2017-04-05 20:00:18 +02:00
Michael Goderbauer
d2abdf8e6b Roll Dart to 1.23.0-dev.11.5 (#9151)
* Roll Dart to 1.23.0-dev.11.3.

This is expected to fix the Windows crashes reported in https://github.com/flutter/flutter/issues/8912.

* fix tests

* Roll to 1.23.0-dev.11.5

* Fix tests
2017-04-05 09:47:02 -07:00
Collin Jackson
244a7a02b5 rename initWithFlutterView to initWithController (#9208) 2017-04-05 08:21:36 -07:00
Sarah Zakarias
4a4d100b91 Add battery charging status to Platform Channel example (#9147) 2017-04-05 09:40:35 +02:00
Adam Barth
af170c8e56 Add more dartdocs (#9183)
Mostly related to semantics and scrolling.
2017-04-04 22:41:24 -07:00
Ian Hickson
f46dd406c1 Add some breadcrumbs to RenderIgnorePointer/RenderAbsorbPointer (#9192) 2017-04-04 20:38:41 -07:00