skia-flutter-autoroll
31eb6227a2
Roll Skia from 31406e74142b to 20b3af58d4a5 (2 revisions) ( flutter/engine#54866 )
...
https://skia.googlesource.com/skia.git/+log/31406e74142b..20b3af58d4a5
2024-08-29 kjlubick@google.com Add moved mock Ganesh files to ganesh_mock target
2024-08-29 danieldilan@google.com GPU support for 101010x color type (RGB only) and fixed some tests.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 15:26:23 +00:00
skia-flutter-autoroll
bd3882b56e
Roll Dart SDK from 0caad7938587 to 3c1bb8338b79 (1 revision) ( flutter/engine#54864 )
...
https://dart.googlesource.com/sdk.git/+log/0caad7938587..3c1bb8338b79
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-195.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 13:30:37 +00:00
skia-flutter-autoroll
e74661e050
Roll Dart SDK from fed5ce7ea2ad to 0caad7938587 (1 revision) ( flutter/engine#54862 )
...
https://dart.googlesource.com/sdk.git/+log/fed5ce7ea2ad..0caad7938587
2024-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-194.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 09:10:23 +00:00
skia-flutter-autoroll
728e6a3682
Roll Skia from dac455fdf502 to 253b10915d32 (1 revision) ( flutter/engine#54860 )
...
https://skia.googlesource.com/skia.git/+log/dac455fdf502..253b10915d32
2024-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fb93bdd85957 to e04dcb74a523 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 07:45:26 +00:00
Jonah Williams
95d3280800
[engine] add an ios noop context. ( flutter/engine#54856 )
...
This is required to allow simulators to run without exiting when impeller is enabled and there is no available metal contxt.
2024-08-29 05:07:24 +00:00
Jonah Williams
4385a96ee1
[Impeller] Use multiple command buffers for blur submission. ( flutter/engine#54846 )
...
Fixes https://github.com/flutter/flutter/issues/154046
Use three different command buffers when it would be possible to combine the operations into a single buffer. From testing and user bug reports (see https://github.com/flutter/flutter/issues/154046 ), this sometimes causes deviceLost errors on older Adreno devices. Breaking the work up into three different command buffers seems to prevent this crash.
I suspect this is due to some internal timeouts we may be hitting in the adreno driver.
2024-08-29 01:23:31 +00:00
skia-flutter-autoroll
355475444a
Roll Skia from 0d8d9d2974fa to e37b6b198016 (1 revision) ( flutter/engine#54854 )
...
https://skia.googlesource.com/skia.git/+log/0d8d9d2974fa..e37b6b198016
2024-08-28 jlavrova@google.com Revert "Split FreeType & FontConfig, step #1 "
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 00:18:21 +00:00
Matan Lurey
87727168e8
Remove --disable-dart-dev across flutter/engine. ( flutter/engine#54845 )
...
As per the Dart CLI team and @bkonyi, this is no longer providing value and we shouldn't cargo-cult it.
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-08-29 00:12:32 +00:00
Jonah Williams
83e59dbe68
[Impeller] fix clip culling with exp canvas. ( flutter/engine#54701 )
...
Fixes performance problem where image filters break clip culling, and lack of clip culling stops the clear color optimization from firing.
on the current canvas the cull rect computation is slightly incorrect, as we drop it as soon as we get a image filter. With the new canvas, we have the actual render target sizes, so we can correctly cull without it.
After switching to experimental canvas, I will remove the cull rect field from the canvas stack entry - as the clip coverage stack already performs basically the same culling.
This fixes the performance issue on the uncached zoom page transition where we lose the clear color optimization too early.
2024-08-28 23:36:09 +00:00
skia-flutter-autoroll
fd64484d2c
Roll Dart SDK from bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) ( flutter/engine#54851 )
...
https://dart.googlesource.com/sdk.git/+log/bc3dad16b2d3..fed5ce7ea2ad
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-193.0.dev
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 22:51:20 +00:00
skia-flutter-autoroll
e7df189b08
Roll Skia from d55406ca32e9 to 0d8d9d2974fa (4 revisions) ( flutter/engine#54850 )
...
https://skia.googlesource.com/skia.git/+log/d55406ca32e9..0d8d9d2974fa
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 03b32d20940d to d90557b380fa (4 revisions)
2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1
2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType."
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 22:45:12 +00:00
Jackson Gardner
c518ebc094
[skwasm] Always do backdrop filter operation even if empty. ( flutter/engine#54844 )
...
This is a partial fix for https://github.com/flutter/flutter/issues/152026
We are still blocked on https://g-issues.skia.org/issues/362552959 for things to be completely working.
2024-08-28 21:19:54 +00:00
Matan Lurey
712e7b9a05
Migrateheader_guard_check to package:test. ( flutter/engine#54811 )
...
Work towards https://github.com/flutter/flutter/issues/133569 .
I also augmented the `run_tests.py` script to support an incremental migration to `package:test`, PTAL.
2024-08-28 21:12:12 +00:00
skia-flutter-autoroll
b8c02b83e3
Roll Skia from cd3d3daafe55 to d55406ca32e9 (10 revisions) ( flutter/engine#54847 )
...
https://skia.googlesource.com/skia.git/+log/cd3d3daafe55..d55406ca32e9
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 23ed8d76c58a to 804d105c7169 (4 revisions)
2024-08-28 brianosman@google.com Fix viewer scaling when changing displays on Mac
2024-08-28 jamesgk@google.com [ganesh] Fix NonAALatticeOp combine check
2024-08-28 jamesgk@google.com [ganesh] Avoid int overflow in PatternHelper
2024-08-28 bungeman@google.com [pdf] extract_cff_data doesn't need ownership
2024-08-28 robertphillips@google.com [graphite] Add example Chrome Precompilation
2024-08-28 lukasza@chromium.org [rust png] Inline `SkPngCodec::fBitDepth` field.
2024-08-28 lukasza@chromium.org [rust png] Use `this->` prefix for method calls (for consistent style).
2024-08-28 lukasza@chromium.org [rust png] Use `SkSpan` for `dst` manipulations in `onGetPixels`.
2024-08-28 robertphillips@google.com [graphite] Set up the FakeWGPU job just like the other Graphite_Dawn jobs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 19:51:48 +00:00
Jonah Williams
30eeaf6e98
[Impeller] ensure that srcOver to src conversion takes stroke coverage into account. ( flutter/engine#54817 )
...
When computing whether or not an entity can be coerced into src blend from srcOver, take into account that stroke geometries may modulate with alpha to emulate stroke widths less than 1.0.
While we're at it, update several computations to use max basis XY (from https://github.com/flutter/flutter/issues/153451 ) since that can lead to incorrect stroke width computations in the presence of canvas scaling.
Most of the changes update the APIs that used to take a ` const Entity& entity` to instead use the `const Matrix& transform`, since that is all we used the entity for.
See screeenshots in https://github.com/flutter/flutter/issues/154178#issuecomment-2313714407
Fixes https://github.com/flutter/flutter/issues/154178
2024-08-28 18:49:24 +00:00
Matan Lurey
8a7a89d6f0
Remove scorecards and other bading we are no longer tracking/links are borked ( flutter/engine#54839 )
...
Similar to the work in https://github.com/flutter/flutter/issues/153626 .
2024-08-28 18:14:04 +00:00
Ömer Sinan Ağacan
8da579925c
Compile dart2wasm modules using the JS runtime exported compileStreaming ( flutter/engine#51488 )
...
With [1] dart2wasm started using the new Wasm built-in string import
`wasm:js-string`.
With [2] dart2wasm started exporting `compile` and `compileStreaming`
from the generated JS runtime to compile dart2wasm-generated modules
with the `wasm:js-string` built-in, polyfilling it when not available.
Update Wasm compilation code in Flutter to use `compileStreaming` from
the JS runtime, enabling fast `jwasm:js-string` module when available.
[1]: 44c2e176004cd6096da4
2024-08-28 20:00:51 +02:00
skia-flutter-autoroll
d8dcc18756
Roll Dart SDK from 183b9e21b706 to bc3dad16b2d3 (1 revision) ( flutter/engine#54838 )
...
https://dart.googlesource.com/sdk.git/+log/183b9e21b706..bc3dad16b2d3
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-191.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 17:55:55 +00:00
Matan Lurey
5e2fa8b8cb
Ignore generated fixture .dill.deps files. ( flutter/engine#54836 )
...
After using `testing/run_tests.py`, these artifacts are left in the source tree.
It is probably better _not_ to do that (i.e. use sandboxing), but we don't sandbox across the engine today.
```txt
Untracked files:
(use "git add <file>..." to include in what will be committed)
tools/const_finder/test/fixtures/box_web.dill.deps
tools/const_finder/test/fixtures/consts_and_non_web.dill.deps
tools/const_finder/test/fixtures/consts_web.dill.deps
tools/const_finder/test/fixtures/static_icon_provider_web.dill.deps
```
2024-08-28 17:54:04 +00:00
zijiehe@
74850ce8c5
[fuchsia] use the api-level from gn-sdk ( flutter/engine#54740 )
...
https://crrev.com/c/5805927 provides the default api-level in gn-sdk, so
as long as we have the latest gn-sdk / skia setup, the api-level would
be updated automatically.
Bug: [347373793](http://b/347373793 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-28 09:39:22 -07:00
Jonah Williams
5ecc028848
[Impeller] port clip stack fixes to new canvas. ( flutter/engine#54727 )
...
From adbc360970
2024-08-28 16:35:37 +00:00
Jonah Williams
62541b1434
[Impeller] fall back to path rendering on thick paths. ( flutter/engine#54822 )
...
For very thin stroked text we switch to skia font rasterization for higher fidelity. However and very large stroke widths, the fidelity loss doesn't matter and may be much slower due to software rasterization.
As several users have noticed, there is a maximum size limit of skia stroked text that we hit as well. This only seems to happen on large stroke widths.
Fixes https://github.com/flutter/flutter/issues/153784
2024-08-28 16:13:22 +00:00
skia-flutter-autoroll
9fdff61f01
Roll Fuchsia Linux SDK from BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... ( flutter/engine#54834 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 15:16:05 +00:00
skia-flutter-autoroll
570b739b57
Roll Skia from ca108745b1de to cd3d3daafe55 (1 revision) ( flutter/engine#54832 )
...
https://skia.googlesource.com/skia.git/+log/ca108745b1de..cd3d3daafe55
2024-08-28 kjlubick@google.com Move remaining Ganesh files in include/gpu and add shims
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 14:57:12 +00:00
skia-flutter-autoroll
293cff7ed1
Roll Dart SDK from 42ddf2278114 to 183b9e21b706 (1 revision) ( flutter/engine#54830 )
...
https://dart.googlesource.com/sdk.git/+log/42ddf2278114..183b9e21b706
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-190.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 13:26:24 +00:00
skia-flutter-autoroll
18bc5f7bc9
Roll Dart SDK from b519f85c3076 to 42ddf2278114 (1 revision) ( flutter/engine#54829 )
...
https://dart.googlesource.com/sdk.git/+log/b519f85c3076..42ddf2278114
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-189.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 09:04:22 +00:00
skia-flutter-autoroll
b3ad21d5aa
Roll Skia from 259010335a55 to 41cb13f65fe6 (2 revisions) ( flutter/engine#54826 )
...
https://skia.googlesource.com/skia.git/+log/259010335a55..41cb13f65fe6
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b53c019191d9 to fb93bdd85957 (5 revisions)
2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8eb31304452a to 03b32d20940d (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 07:37:30 +00:00
skia-flutter-autoroll
e316908c9e
Roll Dart SDK from 8334290a421b to b519f85c3076 (1 revision) ( flutter/engine#54821 )
...
https://dart.googlesource.com/sdk.git/+log/8334290a421b..b519f85c3076
2024-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-188.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 01:55:22 +00:00
skia-flutter-autoroll
a7d194933a
Roll Skia from 84e4a69da303 to 505fb55cd044 (1 revision) ( flutter/engine#54819 )
...
https://skia.googlesource.com/skia.git/+log/84e4a69da303..505fb55cd044
2024-08-27 lukasza@chromium.org [rust png] Reuse `png_select_xform_format` from `SkPngRustCodec`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 00:21:25 +00:00
Jonah Williams
2e9cebebe1
[Impeller] Increase host buffer arena count to 4. ( flutter/engine#54808 )
...
It seems like on some ANdroid devices we can actually get 4 pending frames even with the 3 frame wait. I thought about this a lot but too hard. Lets bump it up one.
Also minor comment fixes in ahb swapchain.
2024-08-27 23:35:07 +00:00
Jim Graham
9f7b86f75a
Synchronize accounting for render op depths ( flutter/engine#54794 )
...
Experimental Canvas was getting depth assertion errors while trying to use the depth values supplied by DisplayList. This was mainly due to a difference in understanding as to how many depth values to allocate to a drawImageNine operation.
n case there are additional discrepancies, debugging code is added to assert the understanding of how many depth values the experimental canvas uses on each rendering operation. The depth debugging can be turned on and off with a #define
2024-08-27 23:31:00 +00:00
Gray Mackall
b01bfc77e5
Fix broken links in docs/ ( flutter/engine#54815 )
...
Fixes some links that were broken as a part of https://github.com/flutter/engine/pull/53595 , because it was pointed out on discord
Specifically, replaces `../../` with `https://github.com/flutter/flutter/blob/master/docs/ ` in the places that `grep` surfaced it.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-27 23:14:04 +00:00
Chinmay Garde
8856d9840c
[Impeller] Don't override user specification on Vulkan validation in unopt. ( flutter/engine#54816 )
...
This overrides the documented behavior silently but only in unopt. Make opt and unopt modes behave the same. Disabling validation is frequently necessary to test behavior on simulators or when connecting to Renderdoc.
2024-08-27 23:04:17 +00:00
skia-flutter-autoroll
17cb4979af
Manual roll Dart SDK from b81b344a194f to 8334290a421b (12 revisions) ( flutter/engine#54813 )
...
Manual roll requested by asiva@google.com
https://dart.googlesource.com/sdk.git/+log/b81b344a194f..8334290a421b
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-187.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-186.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-185.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-184.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-183.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-182.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-181.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-180.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-179.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-178.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-177.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-176.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com ,dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 22:45:08 +00:00
skia-flutter-autoroll
d24ac985b1
Roll Skia from 77017d30a455 to 84e4a69da303 (3 revisions) ( flutter/engine#54812 )
...
https://skia.googlesource.com/skia.git/+log/77017d30a455..84e4a69da303
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bd38c7e8de61 to cbe956ba1c0b
2024-08-27 lukasza@chromium.org [rust png] Create `ICCProfile` from `cHRM`, `gAMA`, `iCCP`, `sRGB`.
2024-08-27 kjlubick@google.com Fix IWYU on some Ganesh ops headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 22:45:05 +00:00
Chinmay Garde
476ac3393b
[Impeller] Clarify where to put the metadata in the manifest. ( flutter/engine#54814 )
...
I made the mistake of putting it under the activity tag and was surprised it didn't hold.
2024-08-27 22:45:04 +00:00
Chinmay Garde
d66cb0fb29
[Impeller] Use infinite swapchain present timeouts to avoid logspam. ( flutter/engine#54810 )
...
The initial timeout of 1 second was chosen to model the Metal backend where the [default drawable timeout is the same](https://developer.apple.com/documentation/quartzcore/cametallayer/2887086-allowsnextdrawabletimeout?language=objc ).
2024-08-27 21:42:44 +00:00
skia-flutter-autoroll
fd4475bf10
Roll Skia from 2e1eea538014 to 77017d30a455 (2 revisions) ( flutter/engine#54809 )
...
https://skia.googlesource.com/skia.git/+log/2e1eea538014..77017d30a455
2024-08-27 brianosman@google.com Avoid potential overflow when allocating 3D mask from emboss filter
2024-08-27 bungeman@google.com Reland "[pdf] Emit bare CFF instead of OpenType CFF"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 20:32:16 +00:00
skia-flutter-autoroll
1996910320
Roll Skia from a2e2eb292492 to 2e1eea538014 (4 revisions) ( flutter/engine#54806 )
...
https://skia.googlesource.com/skia.git/+log/a2e2eb292492..2e1eea538014
2024-08-27 luisgrimaldo@me.com fixes custom iOS simulator version builds
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7efe15073686 to 3546344d39d2 (1 revision)
2024-08-27 kjlubick@google.com Fix src/gpu/vk target
2024-08-27 jvanverth@google.com Reland "[graphite] Clean out unused Plot backing stores when purging DrawAtlas."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 18:53:50 +00:00
skia-flutter-autoroll
ce765b0e28
Roll Skia from 7d9054c4317d to a2e2eb292492 (2 revisions) ( flutter/engine#54804 )
...
https://skia.googlesource.com/skia.git/+log/7d9054c4317d..a2e2eb292492
2024-08-27 kjlubick@google.com Move and rename GR_MAKE_BITFIELD_CLASS_OPS
2024-08-27 robertphillips@google.com [graphite] Add RenderPassProperties SkSpan to Precompile API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 15:55:27 +00:00
skia-flutter-autoroll
0b33d88bcd
Roll Fuchsia Linux SDK from QqRZlA9wVbeg4WoPz... to BCqzoTS_Sz6-AaSii... ( flutter/engine#54802 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 13:57:23 +00:00
Robert Ancell
3fc9ab6c1a
Store a set of layers per view. ( flutter/engine#54793 )
...
This means when rendering the correct layers are rendered for a view.
2024-08-27 20:28:05 +12:00
skia-flutter-autoroll
1819a10a97
Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) ( flutter/engine#54798 )
...
https://skia.googlesource.com/skia.git/+log/56b353d1674a..9460a3136627
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1e4466d51783 to b53c019191d9 (8 revisions)
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc27069e5d04 to 3c4bdf66d81d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 07:24:23 +00:00
dependabot[bot]
754ff458f0
Bump google/osv-scanner-action from 1.8.3 to 1.8.4 ( flutter/engine#54797 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.8.3 to 1.8.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases ">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.8.4</h2>
<p>Bump OSV-Scanner version <a href="https://github.com/google/osv-scanner/releases/tag/v1.8.4 ">https://github.com/google/osv-scanner/releases/tag/v1.8.4 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="678a866dcbhttps://redirect.github.com/google/osv-scanner-action/issues/39 ">#39</a> from google/update-to-v1.8.4</li>
<li><a href="6a315dbacc712a57b5f0fa6b699964b756d11dcfhttps://redirect.github.com/google/osv-scanner-action/issues/30 ">#30</a> from google/update-script</li>
<li><a href="c63eeb74bcdd8ff8fe0e336764a25ahttps://redirect.github.com/google/osv-scanner-action/issues/38 ">#38</a> from google/renovate_ignore</li>
<li><a href="ff89c5797112abe438b3https://github.com/google/osv-scanner-action/compare/v1.8.3...v1.8.4 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-08-27 06:28:22 +00:00
Robert Ancell
4b992b898f
Use TRUE/FALSE consistently for gboolean values. ( flutter/engine#54768 )
...
Some code was using stbool true/false - use the gboolean values
consistently.
2024-08-27 15:43:13 +12:00
skia-flutter-autoroll
b48f2d30d3
Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) ( flutter/engine#54790 )
...
https://skia.googlesource.com/skia.git/+log/50378c58b60c..c9f157b2cc4c
2024-08-26 lukasza@chromium.org Reapply "[rust png] Extract minimal `SkPngCodecBase`."
2024-08-26 kjlubick@google.com Add shims for include/gpu/d3d, gl, mock, and vk headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 23:16:23 +00:00
Jim Graham
7f2d3e0cf5
Disable impeller cmake test until it is fixed ( flutter/engine#54788 )
...
This task is consistently failing (with 3 retries for every engine commit). There is an issue to fix the problem, but until that issue is addressed, the task is primarily wasting CI resources.
2024-08-26 23:08:06 +00:00
Chris Bracken
40ce12e1e1
macOS: Add @available check at macOS 12 workaround ( flutter/engine#54784 )
...
Use default mouse event handling behaviour on macOS 13.3.1 onwards. This has two positive effects:
* Avoids the workaround on newer macOS versions where it's unnecessary, thereby giving us confidence that the underlying AppKit issue is fixed and the whole method can later be removed.
* Will be caught by tooling when we drop support for versions of macOS prior to the fixed version.
Issue: https://github.com/flutter/flutter/issues/154063
Issue: https://github.com/flutter/flutter/issues/115015
No tests modified since there is no semantic change, either on versions of macOS where the issue is fixed (and thus the default event handler is correct) or on versions where it is not (and we still use the workaround).
Re-tested manually with the reduced transparency setting on macOS 14.6.1.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 22:04:24 +00:00
skia-flutter-autoroll
bd0e73d5b0
Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) ( flutter/engine#54789 )
...
https://skia.googlesource.com/skia.git/+log/a05dbd2a60f0..50378c58b60c
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1e4466d51783 to b53c019191d9
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from eba2fc680652 to 345313f563b8
2024-08-26 fmalita@google.com [bazel] Use platform fontmgrs in font_tool_utils
2024-08-26 michaelludwig@google.com [graphite] Split up universal blend shader snippet
2024-08-26 robertphillips@google.com [graphite] Remove static initializer in MtlCaps
2024-08-26 michaelludwig@google.com [ganesh] Fix signature of GrGLMemoryBarrierFn
2024-08-26 bungeman@google.com [pdf] Avoid known image/profile channel mismatch
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 21:56:05 +00:00
Chris Bracken
556b4ffc9c
macOS: Do not archive/upload FlutterMacOS.dSYM to cloud ( flutter/engine#54787 )
...
As of the following patches, we now bundle FlutterMacOS.framework.dSYM as part of FlutterMacOS.xcframework. The dSYM is automatically copied into the release build products directory, and bundled in the .xcarchive produced by Xcode's *Product > Archive* feature which produces bundles for upload to the App Store.
* https://github.com/flutter/engine/pull/54696
* https://github.com/flutter/flutter/pull/153975
The .dSYM bundle is now available both in the uploaded .xcarchive and in the xcframework in Flutter's internal artifact cache. For developers with CI toolchains that do additional manual handling or local archiving of .dSYMs, the dSYMs no longer need to be downloaded from cloud storage as previously detailed in `docs/Crashes.md`, but can instead be copied up from the appropriate dSYM subdirectory in the framework cache:
* `flutter/bin/cache/artifacts/engine/darwin-x64-release/FlutterMacOS.xcframework`
Also adds documentation for crash symbolication on macOS.
Issue: https://github.com/flutter/flutter/issues/153879
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 21:35:06 +00:00
