firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,368 Commits 1 Branch 0 Tags
Commit Graph

29424 Commits

Author SHA1 Message Date
skia-flutter-autoroll
01054ec5ff Roll Skia from 3750b8939c7f to ddbd8d1cb8d8 (1 revision) (flutter/engine#56562) 
https://skia.googlesource.com/skia.git/+log/3750b8939c7f..ddbd8d1cb8d8

2024-11-13 michaelludwig@google.com [graphite] Re-enable SSBOs for D3D11

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-14 02:18:03 +00:00
Robert Ancell
4026506519 Move FlMouseCursorHandler from FlView to FlEngine (flutter/engine#56026) 2024-11-14 15:15:43 +13:00
Jonah Williams
9442880f22 [Impeller] force software resize usage for GLES backend. (flutter/engine#56511) 
Should fix some of the wonderous bugs by avoiding the usage of gl blitframebuffer altogether.

Fixes https://github.com/flutter/flutter/issues/158391
 2024-11-14 02:10:54 +00:00
skia-flutter-autoroll
6c4ea42111 Roll Dart SDK from 66ab1774bfe9 to 3f05b3540cb2 (2 revisions) (flutter/engine#56564) 
https://dart.googlesource.com/sdk.git/+log/66ab1774bfe9..3f05b3540cb2

2024-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-142.0.dev
2024-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-14 02:10:51 +00:00
Chris Bracken
f01b0705eb Embedder: Refactor EmbedderTestContext creation (flutter/engine#56563) 
Extracts creation of graphics backend specfic EmbedderTestContext creation to their own translation units. In particular, this allows for less conditional header includes, and more specifically, for code relating to the Metal backend to include headers that include Objective-C types -- today we cast these all to void* to avoid declaring them in headers, which requires special handling for ARC.

An alternative approach would have been to extract backend-specific subclasses, but there are test suites such as `EmbedderTestMultiBackend` that are executed against multiple backends, which make that approach impractical.

No test changes since this patch makes no semantic changes.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-14 02:10:49 +00:00
Matan Lurey
bcfae15d0e Remove android_jit_release_x86. (flutter/engine#56548) 
Closes https://github.com/flutter/flutter/issues/151610.

While it appears unused in google3, cl/695899069 removes trace elements in the build configuration as well.

/cc @a-siva
 2024-11-14 02:09:06 +00:00
skia-flutter-autoroll
5215e05a4a Roll Fuchsia Linux SDK from z-cm2nR0aJ4lXfwZ0... to JkpuAsLzcmYLzf1iX... (flutter/engine#56570) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-14 02:09:04 +00:00
skia-flutter-autoroll
30d2d5c0d6 Roll Dart SDK from e5c2c502c890 to 66ab1774bfe9 (1 revision) (flutter/engine#56558) 
https://dart.googlesource.com/sdk.git/+log/e5c2c502c890..66ab1774bfe9

2024-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-140.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-13 11:50:15 +00:00
skia-flutter-autoroll
d65d855687 Roll Dart SDK from c7d140d18895 to e5c2c502c890 (1 revision) (flutter/engine#56555) 
https://dart.googlesource.com/sdk.git/+log/c7d140d18895..e5c2c502c890

2024-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-139.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-13 07:44:19 +00:00
skia-flutter-autoroll
c0556cf75c Roll Skia from 02dd72c2fbc2 to ca10bc19c67e (2 revisions) (flutter/engine#56554) 
https://skia.googlesource.com/skia.git/+log/02dd72c2fbc2..ca10bc19c67e

2024-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4448a7219f6d to 9fb4d8c44edc (9 revisions)
2024-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 04483c84503c to bac50766d19e (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-13 06:43:24 +00:00
skia-flutter-autoroll
6ee3367e28 Roll Dart SDK from 5f42ef8f15d5 to c7d140d18895 (2 revisions) (flutter/engine#56552) 
https://dart.googlesource.com/sdk.git/+log/5f42ef8f15d5..c7d140d18895

2024-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-138.0.dev
2024-11-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-137.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-13 03:07:26 +00:00
Jonah Williams
d838b4bd03 [engine] force semantics action to post a task. (flutter/engine#56514) 
Repro:

Testing WIP.

b/373761573

```dart

import 'package:flutter/material.dart';

void main() {
  runApp(const Example());
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  bool value = true;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Semantics(
            child: Text(
              value ? 'Hello, world!' : 'Goodbye, World!',
            ),
            button: true,
            onTap: () async {
              await null;
              setState(() {
                value = !value;
              });
            },
          ),
        ),
      ),
      );
  }
}

```
 2024-11-13 01:06:05 +00:00
Chinmay Garde
655a5d5947 [Impeller] Wrap provided FBO instead of defaulting to FBO0 and cleanup/document the texture API. (flutter/engine#56543) 
Previously, the FBO argument was dropped on the floor.

The API was also confusing as the Android subsystems were using the IsWrapped call to sidestep texture contents initialization without actually performing any wrapping.

Now, there are separate and documented calls to wrap a texture, wrap a framebuffer (as a texture), and to create a placeholder texture.

Callers can also mark any texture as being initialized out of band instead of depending on overloading the meaning of IsWrapped.

Fixes https://github.com/flutter/flutter/issues/158486
 2024-11-13 00:59:18 +00:00
skia-flutter-autoroll
1b485a3d6a Roll Skia from 7d5c206fc873 to 02dd72c2fbc2 (4 revisions) (flutter/engine#56547) 
https://skia.googlesource.com/skia.git/+log/7d5c206fc873..02dd72c2fbc2

2024-11-12 lukasza@chromium.org [rust png] Don't unnecessarily replicate decoding `options`.
2024-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa1dd6b24b8b to d2c4e780b012 (6 revisions)
2024-11-12 lukasza@chromium.org [rust png] Don't unnecessarily replicate `dstInfo` data.
2024-11-12 kjlubick@google.com Add notes about premultiplied color to docs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-13 00:16:04 +00:00
Jason Simmons
3af706d188 [Linux] Configure depth and stencil framebuffer attachments needed for Impeller (flutter/engine#56516) 2024-11-12 22:47:30 +00:00
Chris Bracken
3c27f944d9 macOS: ARC bridge casts for FlutterMetalTexture.user_data (flutter/engine#56518) 
In `[FlutterSurface asFlutterMetalTexture]` we return a `FlutterMetalTexture` whose `user_data` field holds a `void*` reference to the associated `FlutterSurface`.

For conistency with other parts of the codebase, this now uses ARC bridge casts to perform the additional retain and release of the associated surface rather than CoreFoundation functions `CFBridgingRetain` and `CFBridigingRelease`. In FlutterEngine, for example:
67eb4ae000/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm (L648-L664)

Also migrates the code to initialise and immediately return the struct using field designators, and reorders the assignments to be in the declaration order specified in embedder.h as required by the C++ spec.

No changes to tests since this introduces no semantic change.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-12 21:48:41 +00:00
Jonah Williams
0b9763cec5 [Impeller] prevent no-op backend from throwing exceptions during image decoding (flutter/engine#56522) 
This preveents errors reported in some g3 test cases.
 2024-11-12 21:44:51 +00:00
skia-flutter-autoroll
08b10398ec Roll Dart SDK from 69170fac244c to 5f42ef8f15d5 (4 revisions) (flutter/engine#56539) 
https://dart.googlesource.com/sdk.git/+log/69170fac244c..5f42ef8f15d5

2024-11-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-136.0.dev
2024-11-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-135.0.dev
2024-11-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-134.0.dev
2024-11-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-133.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 21:43:08 +00:00
skia-flutter-autoroll
aeaf5eb3a1 Roll Fuchsia Linux SDK from BajfrJuYeyWvnBhuM... to z-cm2nR0aJ4lXfwZ0... (flutter/engine#56538) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 21:41:33 +00:00
skia-flutter-autoroll
fb950d178f Roll Skia from aa099ff91e2f to 7d5c206fc873 (6 revisions) (flutter/engine#56541) 
https://skia.googlesource.com/skia.git/+log/aa099ff91e2f..7d5c206fc873

2024-11-12 borenet@google.com [infra] Remove Linux NUC9i7QN tasks
2024-11-12 nscobie@google.com Remove log spam about Perfetto being unavailable in Android host builds
2024-11-12 linxunfeng@yeah.net Revert "CoreText SkTypeface palette support"
2024-11-12 sharaks@google.com Merge 4 release notes into RELEASE_NOTES.md
2024-11-12 sharaks@google.com Update Skia milestone to 133
2024-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a2dfb2276ea5 to aa1dd6b24b8b (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 21:38:30 +00:00
Jason Simmons
f03f05b51a [Impeller] In canvas_unittests, only create an MSAA offscreen texture if the platform supports MSAA (flutter/engine#56542) 2024-11-12 21:09:50 +00:00
Bruno Leroux
157b28e3a9 [iOS] Fix slider semantics node answer to accessibility activate (flutter/engine#56427) 
## Description

iOS fix [[A11y] Double Tap brings the Slider thumb to the center of the widget.](https://github.com/flutter/flutter/issues/156427) per instruction from https://github.com/flutter/flutter/pull/157601#discussion_r1829992890

I don't have a physical iOS device to double check, but using the iOS Simulator and accessibility tools, the behavior seems ok. Without this PR, the slider thumb goes to the center when clicking 'Activate', with this PR it does not :

https://github.com/user-attachments/assets/697acadd-7fb1-40a5-ba5a-b549cac381a1

## Related Issue

iOS fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](https://github.com/flutter/flutter/issues/156427)

## Tests

Adds 1 test.
 2024-11-12 11:21:23 +00:00
skia-flutter-autoroll
34b684d470 Roll Skia from 75230dbc93e6 to aa099ff91e2f (3 revisions) (flutter/engine#56525) 
https://skia.googlesource.com/skia.git/+log/75230dbc93e6..aa099ff91e2f

2024-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from cf848e50c100 to 4448a7219f6d (7 revisions)
2024-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 76855a9baecc to d5c428477411 (1 revision)
2024-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2a86250e561c to 04483c84503c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 06:55:38 +00:00
Chinmay Garde
e6c61d2570 [Impeller] Add OpenGL debugging utilities. (flutter/engine#56515) 
* CheckFramebufferStatus needs to be called with the enum for the target type and not the target itself.
* Fix dumping the framebuffer type and object name.

The results should be the following for the default FBO0.
```
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] The default framebuffer (FBO0) was bound.
```

and the following for an offscreen framebuffer:
```
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] The default framebuffer (FBO0) was bound.
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] FBO 1: GL_FRAMEBUFFER_COMPLETE
Framebuffer is complete.
Description: 
Color Attachment: GL_TEXTURE(5)
Depth Attachment: GL_RENDERBUFFER(1)
Stencil Attachment: GL_RENDERBUFFER(1)

```

cc @lyceel
 2024-11-12 04:58:26 +00:00
Robert Ancell
99c0b7b50d Add FlPointerManager to process pointer events from GTK in a form suitable for Flutter. (flutter/engine#56443) 
This matches FlScrollingManager and FlKeyboardManager.

Add tests for this behaviour that was previously missing.
 2024-11-12 14:29:42 +13:00
skia-flutter-autoroll
336c6750ec Roll Skia from 11046fd10394 to 75230dbc93e6 (1 revision) (flutter/engine#56517) 
https://skia.googlesource.com/skia.git/+log/11046fd10394..75230dbc93e6

2024-11-11 lukasza@chromium.org [rust png] New API: `SkCodec::hasHighBitDepthEncodedData`.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 01:04:34 +00:00
Jenn Magder
67eb4ae000 Add dependabot github-actions group (flutter/engine#56468) 
`.github/dependabot.yml` configures dependabot to update the `uses` dependencies needed to run github actions.  

For example, dependabot opened https://github.com/flutter/engine/pull/56191 and updated all the `.github/workflows/` yaml files to point to the latest version of `actions/checkout`

Add a dependabot `group` so all github action dependencies are updated in the same PR, instead of one-per-dependency.  For example, if there were an update for `actions/checkout` and `actions/setup-python`, dependabot will send out one PR updating both instead of one PR per dependency.
0d965cb949/.github/workflows/third_party_scan.yml (L23-L28)

New PRs from dependenabot will look like:
__________

<img width="400" alt="Screenshot 2024-11-08 at 11 08 52 AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52">

__________

See also https://github.com/flutter/packages/pull/8044 and https://github.com/flutter/flutter/pull/158408

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-11 23:32:05 +00:00
skia-flutter-autoroll
0d965cb949 Roll Dart SDK from a393f3ed040a to 69170fac244c (1 revision) (flutter/engine#56513) 
https://dart.googlesource.com/sdk.git/+log/a393f3ed040a..69170fac244c

2024-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-132.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 22:38:08 +00:00
Chris Bracken
b773005a98 iOS,macOS: Refactor TestMetalContext for ARC (flutter/engine#56510) 
`TestMetalContext` cannot include any Objective-C types in its header file since that header is included in pure C++ translation units. Previously, we declared these fields as `void*`, which then requires manual `__bridge_retained` and `__bridge_transfer` casts to perform the necessary retain/relase manipulation while opting the object in and out of ARC management.

Instead, we extract these to a struct in the implementation file and allow the fields to be managed by ARC. This is an interim measure consistent with the approach we've taken [elsewhere][1] until we implement the proper long-term solution.

The proper long-term solution is to refactor `EmbedderTest` (see: https://github.com/flutter/flutter/issues/157942) and other related code to split out backends into separate translation units, with the Metal backend code in Objective-C++ implementation files, which would then mean the headers could include Objective-C ivars.

No changes to tests, since this change introduces no behaviour changes.

Issue: https://github.com/flutter/flutter/issues/157942

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-11 21:57:04 +00:00
Jonah Williams
6bef907a09 [Impeller] geometry changes to support line/point style. (flutter/engine#56340) 
Split off from https://github.com/flutter/engine/pull/55230 . Adds getter that tracks if a Path is a single contour.

################################

https://github.com/flutter/flutter/issues/152702
 2024-11-11 21:11:07 +00:00
skia-flutter-autoroll
4184445a91 Roll Skia from af6a4f9a85ee to 11046fd10394 (9 revisions) (flutter/engine#56508) 
https://skia.googlesource.com/skia.git/+log/af6a4f9a85ee..11046fd10394

2024-11-11 kjlubick@google.com Revert "Temporarily remove golo machines from CQ"
2024-11-11 lukasza@chromium.org [rust png] Fix memory safety issue by copying `iCCP` chunk data.
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from bb7983730f24 to a049ff55ff14
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from e6fc8c4f0ad2 to 99b73d05cdae
2024-11-11 jamesgk@google.com Use tiled draws to draw bitmaps in tall_streched_bitmaps
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from c6ebdc72f397 to 034839b9814b
2024-11-11 jlavrova@google.com Android typeface: small simplification
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from a168d86bd1fd to 931df19ec335
2024-11-11 jamesgk@google.com Don't assume command line flags in Android Viewer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 21:08:58 +00:00
Jonah Williams
c93a57dfd0 [Impeller] dont unnecessarily copy point data out of display list. (flutter/engine#56492) 
Display list now stores impeller::Point objects, so have the PointFieldGeometry reference these points directly. As the dispatching/recording is immediate, there is no need to copy to secondary storage.
 2024-11-11 21:07:11 +00:00
Jonah Williams
0489b6bbab [Impeller] fix line/polygon depth and GLES scissor state. (flutter/engine#56494) 
Two problems:

1. We were incorrectly clearing scissor state in the GLES render pass. I suspect this is the cause of all of the clipping problems in wonderous.

2. We were incrementing the depth value in drawPoints with line/polygon mode: these actually need to use the same depth values.

Fixed in the same PR because the golden actually demonstrates both problems with GLES, and luckily I found 2. when I noticed 1.

## Before

### Metal/Vulkan

![image](https://github.com/user-attachments/assets/a5541a51-bdf6-4a47-9638-610d9562df6f)

### GLES

![image](https://github.com/user-attachments/assets/9f3ad7e1-8193-405d-98c0-49141c8ab662)
 2024-11-11 19:59:53 +00:00
Jason Simmons
ef5c2fc014 Do not stop flutter_tester if microtasks are still pending (flutter/engine#56432) 
Flutter_tester has a task observer that checks whether the test's Dart code has finished execution.  If Dart no longer has live ports but does have pending microtasks, then flutter_tester should continue running and force a drain of the microtask queue.

Fixes https://github.com/flutter/flutter/issues/158129
 2024-11-11 19:22:07 +00:00
skia-flutter-autoroll
d83dc6bdae Roll Skia from 261316c10484 to af6a4f9a85ee (5 revisions) (flutter/engine#56505) 
https://skia.googlesource.com/skia.git/+log/261316c10484..af6a4f9a85ee

2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a049ff55ff14 to bb7983730f24
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 99b73d05cdae to e6fc8c4f0ad2
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 034839b9814b to c6ebdc72f397
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 931df19ec335 to a168d86bd1fd
2024-11-11 kjlubick@google.com Move SkPathEffect::Dash* out of public API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 19:20:08 +00:00
skia-flutter-autoroll
f5cda5a89a Roll Dart SDK from 4ea43aa234a4 to a393f3ed040a (1 revision) (flutter/engine#56506) 
https://dart.googlesource.com/sdk.git/+log/4ea43aa234a4..a393f3ed040a

2024-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-131.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 18:24:23 +00:00
Robert Ancell
e9012014c0 Remove unused FlMockTextInputHandler (flutter/engine#56495) 
This was the only thing that required FlTextInputHandler to be derivable, so also simplify the class.
 2024-11-11 17:47:05 +00:00
Mouad Debbar
a13bd21ce9 [web] Bump Firefox version to 132.0 (flutter/engine#56435) 
A firefox upgrade is long overdue. This upgrade fixes some failing tests in https://github.com/flutter/engine/pull/54786
 2024-11-11 15:14:06 +00:00
skia-flutter-autoroll
8a29542b73 Roll Dart SDK from cde0e0dc084a to 4ea43aa234a4 (1 revision) (flutter/engine#56502) 
https://dart.googlesource.com/sdk.git/+log/cde0e0dc084a..4ea43aa234a4

2024-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-130.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 14:12:15 +00:00
skia-flutter-autoroll
f3fc0a65f3 Roll Dart SDK from ed9a5b1110ae to cde0e0dc084a (6 revisions) (flutter/engine#56500) 
https://dart.googlesource.com/sdk.git/+log/ed9a5b1110ae..cde0e0dc084a

2024-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-129.0.dev
2024-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-128.0.dev
2024-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-127.0.dev
2024-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-126.0.dev
2024-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-125.0.dev
2024-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-124.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 09:52:22 +00:00
skia-flutter-autoroll
140366b6fc Roll Skia from 3333292a62c1 to 676b3b1a41be (2 revisions) (flutter/engine#56499) 
https://skia.googlesource.com/skia.git/+log/3333292a62c1..676b3b1a41be

2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 13a9bd9ccb6d to 2a86250e561c (1 revision)
2024-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6082ccfc822c to cf848e50c100 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 07:40:17 +00:00
skia-flutter-autoroll
286a2df0d6 Roll Fuchsia Linux SDK from TZVo85tD5mpzhcafg... to BajfrJuYeyWvnBhuM... (flutter/engine#56497) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 02:05:23 +00:00
skia-flutter-autoroll
a782136ddc Roll Skia from 778b21720a61 to 3333292a62c1 (7 revisions) (flutter/engine#56496) 
https://skia.googlesource.com/skia.git/+log/778b21720a61..3333292a62c1

2024-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 2a61126bb36c to 7fea539cc99b (6 revisions)
2024-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 1e8c53194ceb to 695916e164c9 (3 revisions)
2024-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b2edbc3e54d0 to 13a9bd9ccb6d (8 revisions)
2024-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 12e843b4aad1 to 1e8c53194ceb (1 revision)
2024-11-08 michaelludwig@google.com [skif] Check for failed blur algorithm output
2024-11-08 michaelludwig@google.com [skif] Check for empty srcRect in float coords
2024-11-08 michaelludwig@google.com [skif] Handle non-finite net downscale factors

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,brianosman@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 00:42:22 +00:00
Chris Bracken
aed9a9d3fa fml: Improve CFTest.SupportsCustomRetainRelease test (flutter/engine#56480) 
Eliminates the use of statics in CFTest.SupportsCustomRetainRelease (introduced in https://github.com/flutter/engine/pull/56463), "clever" as it was.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-10 19:59:27 +00:00
Jason Simmons
d4446c079b Remove the unsafe_html analysis rule (flutter/engine#56479) 
This rule was deleted from the Dart SDK.

See https://dart.googlesource.com/sdk/+/cb5c73e06fba5f9a795df532480e3d02028696bd
 2024-11-09 17:31:36 +00:00
skia-flutter-autoroll
64ef436b93 Roll Fuchsia Linux SDK from aLUsXLv5iMZFOgcAS... to TZVo85tD5mpzhcafg... (flutter/engine#56478) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 14:29:34 +00:00
Chris Bracken
b6b45b19a6 iOS: Use fml::CFRef in place of Scoped (flutter/engine#56463) 
`fml::CFRef` implements the bulk of the operations implemented in the one-off `Scoped` class except with better safety guarantees such as `[[nodiscard]]` on the `Release` method. It doesn't implement the `handle()` method that allows direct writing into the internal storage of the wrapper, but that method is effectively an escape hatch for all the safety guarantees provided by the wrapper, so it seems safer to avoid adding it.

No changes to tests since this includes no semantic changes.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-09 00:51:34 +00:00
skia-flutter-autoroll
d40731706f Roll Dart SDK from 307869c696e8 to ed9a5b1110ae (2 revisions) (flutter/engine#56465) 
https://dart.googlesource.com/sdk.git/+log/307869c696e8..ed9a5b1110ae

2024-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-123.0.dev
2024-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-122.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 00:20:19 +00:00
Chris Bracken
3b69a8add8 fml: delete unused scoped_policy (flutter/engine#56462) 
The last usage of this was in fml::ScopedBlock which was deleted in
flutter/engine#56410.

No test changes since this just deletes dead code.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-08 23:27:56 +00:00
Siva
5e7994be0c Manual roll Dart SDK from cfa1826c3df1 to 307869c696e8 (1 revision) (flutter/engine#56460) 
https://dart.googlesource.com/sdk.git/+log/cfa1826c3df1..307869c696e8

2024-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-121.0.dev

---------

Co-authored-by: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
 2024-11-08 13:57:39 -08:00