
Fixes (but I still need to write the draft of the blog section so don't autoclose github 🙏 ) https://github.com/flutter/flutter/issues/160372. -Module templates [already exclude the entire `.android` directory](d9b7e56646/packages/flutter_tools/templates/module/common/.gitignore.tmpl (L40)
). -Plugin templates [already exclude `.cxx`](d9b7e56646/packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore
). Modified the existing gitignores with ``` nl=$'\n' sed -i'' -e '/GeneratedPluginRegistrant.java/a\'$'\n''.cxx/'"\\${nl}"'' $(find . -path \*android/.gitignore) ``` (which was probably not the best way) Fun fact: apparently the `.gitignore` files (including the ones we copy to the template apps) aren't indexed for search (the `.gitignore.tmpl` are, but not the ones that we copy exactly [such as this one](27ba2f2790/packages/flutter_tools/templates/app/android.tmpl/.gitignore
)). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com> Co-authored-by: Greg Price <gnprice@gmail.com>
Tracing tests
"Application"
The lib/test.dart
and lib/control.dart
files in this directory are
used by dev/bots/test.dart
's runTracingTests
function to check
whether aspects of the tracing logic in the framework get compiled out
in profile and release builds. They're not meant to be run directly.
The strings in these files are used in dev/bots/test.dart
.
Tests
The tests in this folder must be run with flutter test --enable-vmservice
,
since they test that trace data is written to the timeline by connecting to
the observatory.
These tests will fail if run without this flag.