363543fc19
This test is sometimes flaky (#20822) because the two processes try to stop the same app. This fix changes to just gracefully terminate the attach process without explicitly trying to stop and then uses the original spawning process to stop the app. I can't repro the flake locally to be certain, but I've verified only one stop command is sent now so it *should* be good.
44 lines
1.5 KiB
Dart
44 lines
1.5 KiB
Dart
// Copyright 2018 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/file.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
|
|
import '../src/common.dart';
|
|
import '../src/context.dart';
|
|
import 'test_data/basic_project.dart';
|
|
import 'test_driver.dart';
|
|
|
|
void main() {
|
|
FlutterTestDriver _flutterRun, _flutterAttach;
|
|
final BasicProject _project = new BasicProject();
|
|
Directory tempDir;
|
|
|
|
setUp(() async {
|
|
tempDir = fs.systemTempDirectory.createTempSync('flutter_attach_test.');
|
|
await _project.setUpIn(tempDir);
|
|
_flutterRun = new FlutterTestDriver(tempDir);
|
|
_flutterAttach = new FlutterTestDriver(tempDir);
|
|
});
|
|
|
|
tearDown(() async {
|
|
// We can't call stop() on both of these because they'll both try to stop the
|
|
// same app. Just quit the attach process and then send a stop to the original
|
|
// process.
|
|
await _flutterAttach.quit();
|
|
await _flutterRun.stop();
|
|
tryToDelete(tempDir);
|
|
});
|
|
|
|
group('attached process', () {
|
|
testUsingContext('can hot reload', () async {
|
|
await _flutterRun.run(withDebugger: true);
|
|
await _flutterAttach.attach(_flutterRun.vmServicePort);
|
|
await _flutterAttach.hotReload();
|
|
});
|
|
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833.
|
|
}, timeout: const Timeout.factor(6), skip: platform.isWindows);
|
|
}
|