Jenn Magder
bb306c53a3
Suppress stderr during Xcode command line installation check (#163785)
Xcode is in some kind of half-installed state (missing a cert? unknown)
on some devicelab Macs https://github.com/flutter/flutter/issues/161655.
As of https://github.com/flutter/flutter/pull/163685 Xcode cipd
installation isn't requested as part of the builder configuration, so it
seems like Xcode is just hanging out on that devicelab bot
quasi-installed, unrelated to the recipe.
In any case, the tool is actually doing the right thing and detecting
that Xcode isn't in a good state and continuing as if it isn't
installed, but is logging a wall of error text about it to stderr, which
that Android test doesn't like. Instead of updating the test to allow
stderr, instead swap the Xcode installation path to `exitsHappySync` to
only check the exit code (or exception), which is the original intention
behind the Xcode command line checks.
e6730613c9/packages/flutter_tools/lib/src/base/process.dart (L596-L601)
Fixes https://github.com/flutter/flutter/issues/161655
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-21 18:36:35 +00:00
..
2025-02-10 16:54:02 +00:00
2025-02-10 16:54:02 +00:00
2025-02-19 20:37:35 +00:00
2025-02-12 21:52:02 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-01-28 17:32:27 +00:00
2025-02-14 19:57:53 +00:00
2024-12-19 20:06:21 +00:00
2025-02-10 16:54:02 +00:00
2025-01-23 09:22:36 +00:00
2024-12-19 20:06:21 +00:00
2025-02-21 18:36:35 +00:00
2025-01-09 00:30:06 +00:00
2024-12-19 20:06:21 +00:00
2025-02-12 21:52:02 +00:00
2025-02-20 18:00:48 +00:00
2025-02-12 02:40:18 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-20 22:26:57 +00:00
2025-02-21 17:41:02 +00:00
2025-01-30 17:51:07 +00:00
2024-12-19 20:06:21 +00:00
2024-12-24 00:02:29 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-13 20:53:37 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-03-21 22:37:08 +00:00
2025-02-10 16:54:02 +00:00
2024-12-19 20:06:21 +00:00
2025-02-13 21:19:14 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-10 16:54:02 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-01-28 17:32:27 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-10 16:54:02 +00:00
2025-02-04 21:24:44 +00:00
2024-12-19 20:06:21 +00:00
2025-02-10 16:54:02 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-01-09 00:30:06 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-21 17:41:02 +00:00
2025-02-10 16:54:02 +00:00
2024-12-24 00:02:29 +00:00
2025-01-07 00:52:45 +00:00
2024-12-19 20:06:21 +00:00
2025-02-12 22:20:50 +00:00
2024-12-19 20:06:21 +00:00
2025-02-21 17:41:02 +00:00
2025-01-30 18:09:19 +00:00
2025-02-10 16:54:02 +00:00
2024-12-19 20:06:21 +00:00
2025-01-30 18:09:19 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-21 00:07:48 +00:00
2024-12-19 20:06:21 +00:00
2025-02-21 03:35:14 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-01-21 10:47:16 +00:00
2025-02-21 17:41:02 +00:00
2025-02-14 19:57:53 +00:00
2025-02-14 19:57:53 +00:00
2025-02-21 17:41:02 +00:00
2025-01-30 18:09:19 +00:00
2024-12-24 00:02:29 +00:00
2025-02-14 19:57:53 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-08 01:03:25 +00:00
2024-12-19 20:06:21 +00:00
2024-12-19 20:06:21 +00:00
2025-02-20 16:31:29 +00:00
2025-02-10 16:54:02 +00:00
2024-12-19 20:06:21 +00:00
2025-02-06 18:40:25 +00:00
2025-02-19 20:37:35 +00:00
2025-02-19 20:37:35 +00:00