9adb4a78a6
The main purpose of this PR is to make it so that when you set the initial route and it's a hierarchical route (e.g. `/a/b/c`), it implies multiple pushes, one for each step of the route (so in that case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those routes don't exist, it falls back to '/'. As part of doing that, I: * Changed the default for MaterialApp.initialRoute to honor the actual initial route. * Added a MaterialApp.onUnknownRoute for handling bad routes. * Added a feature to flutter_driver that allows the host test script and the device test app to communicate. * Added a test to make sure `flutter drive --route` works. (Hopefully that will also prove `flutter run --route` works, though this isn't testing the `flutter` tool's side of that. My main concern is over whether the engine side works.) * Fixed `flutter drive` to output the right target file name. * Changed how the stocks app represents its data, so that we can show a page for a stock before we know if it exists. * Made it possible to show a stock page that doesn't exist. It shows a progress indicator if we're loading the data, or else shows a message saying it doesn't exist. * Changed the pathing structure of routes in stocks to work more sanely. * Made search in the stocks app actually work (before it only worked if we happened to accidentally trigger a rebuild). Added a test. * Replaced some custom code in the stocks app with a BackButton. * Added a "color" feature to BackButton to support the stocks use case. * Spaced out the ErrorWidget text a bit more. * Added `RouteSettings.copyWith`, which I ended up not using. * Improved the error messages around routing. While I was in some files I made a few formatting fixes, fixed some code health issues, and also removed `flaky: true` from some devicelab tests that have been stable for a while. Also added some documentation here and there.
86 lines
3.1 KiB
Dart
86 lines
3.1 KiB
Dart
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:convert';
|
|
import 'dart:io';
|
|
|
|
import 'package:path/path.dart' as path;
|
|
|
|
import 'package:flutter_devicelab/framework/adb.dart';
|
|
import 'package:flutter_devicelab/framework/framework.dart';
|
|
import 'package:flutter_devicelab/framework/utils.dart';
|
|
|
|
void main() {
|
|
task(() async {
|
|
final Device device = await devices.workingDevice;
|
|
await device.unlock();
|
|
final Directory appDir = dir(path.join(flutterDirectory.path, 'dev/integration_tests/ui'));
|
|
section('TEST WHETHER `flutter drive --route` WORKS');
|
|
await inDirectory(appDir, () async {
|
|
return await flutter(
|
|
'drive',
|
|
options: <String>['--verbose', '-d', device.deviceId, '--route', '/smuggle-it', 'lib/route.dart'],
|
|
canFail: false,
|
|
);
|
|
});
|
|
section('TEST WHETHER `flutter run --route` WORKS');
|
|
await inDirectory(appDir, () async {
|
|
final Completer<Null> ready = new Completer<Null>();
|
|
bool ok;
|
|
print('run: starting...');
|
|
final Process run = await startProcess(
|
|
path.join(flutterDirectory.path, 'bin', 'flutter'),
|
|
<String>['run', '--verbose', '--observatory-port=8888', '-d', device.deviceId, '--route', '/smuggle-it', 'lib/route.dart'],
|
|
);
|
|
run.stdout
|
|
.transform(UTF8.decoder)
|
|
.transform(const LineSplitter())
|
|
.listen((String line) {
|
|
print('run:stdout: $line');
|
|
if (line == '[ ] For a more detailed help message, press "h". To quit, press "q".') {
|
|
print('run: ready!');
|
|
ready.complete();
|
|
ok ??= true;
|
|
}
|
|
});
|
|
run.stderr
|
|
.transform(UTF8.decoder)
|
|
.transform(const LineSplitter())
|
|
.listen((String line) {
|
|
stderr.writeln('run:stderr: $line');
|
|
});
|
|
run.exitCode.then((int exitCode) { ok = false; });
|
|
await Future.any<dynamic>(<Future<dynamic>>[ ready.future, run.exitCode ]);
|
|
if (!ok)
|
|
throw 'Failed to run test app.';
|
|
print('drive: starting...');
|
|
final Process drive = await startProcess(
|
|
path.join(flutterDirectory.path, 'bin', 'flutter'),
|
|
<String>['drive', '--use-existing-app', 'http://127.0.0.1:8888/', '--no-keep-app-running', 'lib/route.dart'],
|
|
);
|
|
drive.stdout
|
|
.transform(UTF8.decoder)
|
|
.transform(const LineSplitter())
|
|
.listen((String line) {
|
|
print('drive:stdout: $line');
|
|
});
|
|
drive.stderr
|
|
.transform(UTF8.decoder)
|
|
.transform(const LineSplitter())
|
|
.listen((String line) {
|
|
stderr.writeln('drive:stderr: $line');
|
|
});
|
|
int result;
|
|
result = await drive.exitCode;
|
|
if (result != 0)
|
|
throw 'Failed to drive test app (exit code $result).';
|
|
result = await run.exitCode;
|
|
if (result != 0)
|
|
throw 'Received unexpected exit code $result from run process.';
|
|
});
|
|
return new TaskResult.success(null);
|
|
});
|
|
}
|