
Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125, https://github.com/flutter/flutter/pull/145261, and https://github.com/flutter/flutter/pull/145487. The errors were raised in post-submit tests on Windows. I have finally obtained a Windows machine to reproduce the errors locally and adjust the test (remove size expectation and rename output `.exe`). ## Original description Improves the build output: 1. Gives confirmation that the build succeeded, in green 1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open 1. Gives the size of the built executable (when the built executable is self contained) ### `apk`, `appbundle` <img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d"> <img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436"> ### `macos`, `ios`, `ipa` Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`. <img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257"> <img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50"> <img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698"> ### `windows`, `linux`, and `web` Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below). <img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b"> <img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2"> <img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5"> ### Size reporting When applicable, the printed size matches the OS reported size. - macOS <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce"> - Windows <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7"> - Linux <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b"> ## Related issues Part of #120127 Fixes https://github.com/flutter/flutter/issues/121401
220 lines
8.1 KiB
Dart
220 lines
8.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:unified_analytics/unified_analytics.dart';
|
|
|
|
import '../artifacts.dart';
|
|
import '../base/analyze_size.dart';
|
|
import '../base/common.dart';
|
|
import '../base/file_system.dart';
|
|
import '../base/logger.dart';
|
|
import '../base/project_migrator.dart';
|
|
import '../base/terminal.dart';
|
|
import '../base/utils.dart';
|
|
import '../build_info.dart';
|
|
import '../cache.dart';
|
|
import '../cmake.dart';
|
|
import '../cmake_project.dart';
|
|
import '../convert.dart';
|
|
import '../flutter_plugins.dart';
|
|
import '../globals.dart' as globals;
|
|
import '../migrations/cmake_custom_command_migration.dart';
|
|
import '../migrations/cmake_native_assets_migration.dart';
|
|
|
|
// Matches the following error and warning patterns:
|
|
// - <file path>:<line>:<column>: (fatal) error: <error...>
|
|
// - <file path>:<line>:<column>: warning: <warning...>
|
|
// - clang: error: <link error...>
|
|
// - Error: <tool error...>
|
|
final RegExp errorMatcher = RegExp(r'(?:(?:.*:\d+:\d+|clang):\s)?(fatal\s)?(?:error|warning):\s.*', caseSensitive: false);
|
|
|
|
/// Builds the Linux project through the Makefile.
|
|
Future<void> buildLinux(
|
|
LinuxProject linuxProject,
|
|
BuildInfo buildInfo, {
|
|
String? target,
|
|
SizeAnalyzer? sizeAnalyzer,
|
|
bool needCrossBuild = false,
|
|
required TargetPlatform targetPlatform,
|
|
String targetSysroot = '/',
|
|
required Logger logger,
|
|
}) async {
|
|
target ??= 'lib/main.dart';
|
|
if (!linuxProject.cmakeFile.existsSync()) {
|
|
throwToolExit('No Linux desktop project configured. See '
|
|
'https://docs.flutter.dev/desktop#add-desktop-support-to-an-existing-flutter-app '
|
|
'to learn about adding Linux support to a project.');
|
|
}
|
|
|
|
final List<ProjectMigrator> migrators = <ProjectMigrator>[
|
|
CmakeCustomCommandMigration(linuxProject, logger),
|
|
CmakeNativeAssetsMigration(linuxProject, 'linux', logger),
|
|
];
|
|
|
|
final ProjectMigration migration = ProjectMigration(migrators);
|
|
migration.run();
|
|
|
|
// Build the environment that needs to be set for the re-entrant flutter build
|
|
// step.
|
|
final Map<String, String> environmentConfig = buildInfo.toEnvironmentConfig();
|
|
environmentConfig['FLUTTER_TARGET'] = target;
|
|
final LocalEngineInfo? localEngineInfo = globals.artifacts?.localEngineInfo;
|
|
if (localEngineInfo != null) {
|
|
final String targetOutPath = localEngineInfo.targetOutPath;
|
|
// $ENGINE/src/out/foo_bar_baz -> $ENGINE/src
|
|
environmentConfig['FLUTTER_ENGINE'] = globals.fs.path.dirname(globals.fs.path.dirname(targetOutPath));
|
|
environmentConfig['LOCAL_ENGINE'] = localEngineInfo.localTargetName;
|
|
environmentConfig['LOCAL_ENGINE_HOST'] = localEngineInfo.localHostName;
|
|
}
|
|
writeGeneratedCmakeConfig(Cache.flutterRoot!, linuxProject, buildInfo, environmentConfig, logger);
|
|
|
|
createPluginSymlinks(linuxProject.parent);
|
|
|
|
final Status status = logger.startProgress(
|
|
'Building Linux application...',
|
|
);
|
|
final String buildModeName = buildInfo.mode.cliName;
|
|
final Directory platformBuildDirectory = globals.fs.directory(getLinuxBuildDirectory(targetPlatform));
|
|
final Directory buildDirectory = platformBuildDirectory.childDirectory(buildModeName);
|
|
try {
|
|
await _runCmake(buildModeName, linuxProject.cmakeFile.parent, buildDirectory,
|
|
needCrossBuild, targetPlatform, targetSysroot);
|
|
await _runBuild(buildDirectory);
|
|
} finally {
|
|
status.cancel();
|
|
}
|
|
|
|
final String? binaryName = getCmakeExecutableName(linuxProject);
|
|
final File binaryFile = buildDirectory
|
|
.childDirectory('bundle')
|
|
.childFile('$binaryName');
|
|
final FileSystemEntity buildOutput = binaryFile.existsSync() ? binaryFile : binaryFile.parent;
|
|
// We don't print a size because the output directory can contain
|
|
// optional files not needed by the user and because the binary is not
|
|
// self-contained.
|
|
globals.printStatus(
|
|
'${globals.terminal.successMark} '
|
|
'Built ${globals.fs.path.relative(buildOutput.path)}',
|
|
color: TerminalColor.green,
|
|
);
|
|
|
|
if (buildInfo.codeSizeDirectory != null && sizeAnalyzer != null) {
|
|
final String arch = getNameForTargetPlatform(targetPlatform);
|
|
final File codeSizeFile = globals.fs.directory(buildInfo.codeSizeDirectory)
|
|
.childFile('snapshot.$arch.json');
|
|
final File precompilerTrace = globals.fs.directory(buildInfo.codeSizeDirectory)
|
|
.childFile('trace.$arch.json');
|
|
final Map<String, Object?> output = await sizeAnalyzer.analyzeAotSnapshot(
|
|
aotSnapshot: codeSizeFile,
|
|
// This analysis is only supported for release builds.
|
|
outputDirectory: globals.fs.directory(
|
|
globals.fs.path.join(getLinuxBuildDirectory(targetPlatform), 'release', 'bundle'),
|
|
),
|
|
precompilerTrace: precompilerTrace,
|
|
type: 'linux',
|
|
);
|
|
final File outputFile = globals.fsUtils.getUniqueFile(
|
|
globals.fs
|
|
.directory(globals.fsUtils.homeDirPath)
|
|
.childDirectory('.flutter-devtools'), 'linux-code-size-analysis', 'json',
|
|
)..writeAsStringSync(jsonEncode(output));
|
|
// This message is used as a sentinel in analyze_apk_size_test.dart
|
|
logger.printStatus(
|
|
'A summary of your Linux bundle analysis can be found at: ${outputFile.path}',
|
|
);
|
|
|
|
// DevTools expects a file path relative to the .flutter-devtools/ dir.
|
|
final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim();
|
|
logger.printStatus(
|
|
'\nTo analyze your app size in Dart DevTools, run the following command:\n'
|
|
'dart devtools --appSizeBase=$relativeAppSizePath'
|
|
);
|
|
}
|
|
}
|
|
|
|
Future<void> _runCmake(String buildModeName, Directory sourceDir, Directory buildDir,
|
|
bool needCrossBuild, TargetPlatform targetPlatform, String targetSysroot) async {
|
|
final Stopwatch sw = Stopwatch()..start();
|
|
|
|
await buildDir.create(recursive: true);
|
|
|
|
final String buildFlag = sentenceCase(buildModeName);
|
|
final bool needCrossBuildOptionsForArm64 = needCrossBuild
|
|
&& targetPlatform == TargetPlatform.linux_arm64;
|
|
int result;
|
|
if (!globals.processManager.canRun('cmake')) {
|
|
throwToolExit(globals.userMessages.cmakeMissing);
|
|
}
|
|
result = await globals.processUtils.stream(
|
|
<String>[
|
|
'cmake',
|
|
'-G',
|
|
'Ninja',
|
|
'-DCMAKE_BUILD_TYPE=$buildFlag',
|
|
'-DFLUTTER_TARGET_PLATFORM=${getNameForTargetPlatform(targetPlatform)}',
|
|
// Support cross-building for arm64 targets on x64 hosts.
|
|
// (Cross-building for x64 on arm64 hosts isn't supported now.)
|
|
if (needCrossBuild)
|
|
'-DFLUTTER_TARGET_PLATFORM_SYSROOT=$targetSysroot',
|
|
if (needCrossBuildOptionsForArm64)
|
|
'-DCMAKE_C_COMPILER_TARGET=aarch64-linux-gnu',
|
|
if (needCrossBuildOptionsForArm64)
|
|
'-DCMAKE_CXX_COMPILER_TARGET=aarch64-linux-gnu',
|
|
sourceDir.path,
|
|
],
|
|
workingDirectory: buildDir.path,
|
|
environment: <String, String>{
|
|
'CC': 'clang',
|
|
'CXX': 'clang++',
|
|
},
|
|
trace: true,
|
|
);
|
|
if (result != 0) {
|
|
throwToolExit('Unable to generate build files');
|
|
}
|
|
final Duration elapsedDuration = sw.elapsed;
|
|
globals.flutterUsage.sendTiming('build', 'cmake-linux', elapsedDuration);
|
|
globals.analytics.send(Event.timing(
|
|
workflow: 'build',
|
|
variableName: 'cmake-linux',
|
|
elapsedMilliseconds: elapsedDuration.inMilliseconds,
|
|
));
|
|
}
|
|
|
|
Future<void> _runBuild(Directory buildDir) async {
|
|
final Stopwatch sw = Stopwatch()..start();
|
|
|
|
int result;
|
|
try {
|
|
result = await globals.processUtils.stream(
|
|
<String>[
|
|
'ninja',
|
|
'-C',
|
|
buildDir.path,
|
|
'install',
|
|
],
|
|
environment: <String, String>{
|
|
if (globals.logger.isVerbose)
|
|
'VERBOSE_SCRIPT_LOGGING': 'true',
|
|
if (!globals.logger.isVerbose)
|
|
'PREFIXED_ERROR_LOGGING': 'true',
|
|
},
|
|
trace: true,
|
|
stdoutErrorMatcher: errorMatcher,
|
|
);
|
|
} on ArgumentError {
|
|
throwToolExit("ninja not found. Run 'flutter doctor' for more information.");
|
|
}
|
|
if (result != 0) {
|
|
throwToolExit('Build process failed');
|
|
}
|
|
final Duration elapsedDuration = sw.elapsed;
|
|
globals.flutterUsage.sendTiming('build', 'linux-ninja', elapsedDuration);
|
|
globals.analytics.send(Event.timing(
|
|
workflow: 'build',
|
|
variableName: 'linux-ninja',
|
|
elapsedMilliseconds: elapsedDuration.inMilliseconds,
|
|
));
|
|
}
|