
This auto-formats all *.dart files in the repository outside of the `engine` subdirectory and enforces that these files stay formatted with a presubmit check. **Reviewers:** Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running `dev/tools/format.sh -a -f`. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR. --------- Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
128 lines
4.1 KiB
Dart
128 lines
4.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'base/logger.dart';
|
|
import 'convert.dart';
|
|
import 'dart/pub.dart';
|
|
import 'project.dart';
|
|
|
|
/// Returns dependencies of [project] that are _only_ used as `dev_dependency`.
|
|
///
|
|
/// That is, computes and returns a subset of dependencies, where the original
|
|
/// set is based on packages listed as [`dev_dependency`][dev_deps] in the
|
|
/// `pubspec.yaml` file, and removing packages from that set that appear as
|
|
/// dependencies (implicitly non-dev) in any non-dev package depended on.
|
|
Future<Set<String>> computeExclusiveDevDependencies(
|
|
Pub pub, {
|
|
required Logger logger,
|
|
required FlutterProject project,
|
|
}) async {
|
|
final Map<String, Object?> jsonResult = await pub.deps(project);
|
|
|
|
Never fail([String? reason]) {
|
|
logger.printTrace(const JsonEncoder.withIndent(' ').convert(jsonResult));
|
|
throw StateError(
|
|
'dart pub deps --json ${reason != null ? 'had unexpected output: $reason' : 'failed'}',
|
|
);
|
|
}
|
|
|
|
List<T> asListOrFail<T>(Object? value, String name) {
|
|
// Allow omitting a list as empty to default to an empty list
|
|
if (value == null) {
|
|
return <T>[];
|
|
}
|
|
if (value is! List<Object?>) {
|
|
fail('Expected field "$name" to be a list, got "$value"');
|
|
}
|
|
return <T>[
|
|
for (final Object? any in value)
|
|
if (any is T) any else fail('Expected element to be a $T, got "$any"'),
|
|
];
|
|
}
|
|
|
|
// Parse the JSON roughly in the following format:
|
|
//
|
|
// ```json
|
|
// {
|
|
// "root": "my_app",
|
|
// "packages": [
|
|
// {
|
|
// "name": "my_app",
|
|
// "kind": "root",
|
|
// "dependencies": [
|
|
// "foo_plugin",
|
|
// "bar_plugin"
|
|
// ],
|
|
// "directDependencies": [
|
|
// "foo_plugin"
|
|
// ],
|
|
// "devDependencies": [
|
|
// "bar_plugin"
|
|
// ]
|
|
// }
|
|
// ]
|
|
// }
|
|
// ```
|
|
final List<Map<String, Object?>> packages = asListOrFail(jsonResult['packages'], 'packages');
|
|
|
|
Map<String, Object?> packageWhere(
|
|
bool Function(Map<String, Object?>) test, {
|
|
required String reason,
|
|
}) {
|
|
return packages.firstWhere(test, orElse: () => fail(reason));
|
|
}
|
|
|
|
final Map<String, Object?> rootPackage = packageWhere(
|
|
(Map<String, Object?> package) => package['kind'] == 'root',
|
|
reason: 'A package with kind "root" was not found.',
|
|
);
|
|
|
|
// Start initially with every `devDependency` listed.
|
|
final Set<String> devDependencies =
|
|
asListOrFail<String>(rootPackage['devDependencies'] ?? <String>[], 'devDependencies').toSet();
|
|
|
|
// Then traverse and exclude non-dev dependencies that list that dependency.
|
|
//
|
|
// This avoids the pathalogical problem of using, say, `path_provider` in a
|
|
// package's dev_dependencies:, but a (non-dev) dependency using it as a
|
|
// standard dependency - in that case we would not want to report it is used
|
|
// as a dev dependency.
|
|
final Set<String> visited = <String>{};
|
|
void visitPackage(String packageName) {
|
|
final bool wasAlreadyVisited = !visited.add(packageName);
|
|
if (wasAlreadyVisited) {
|
|
return;
|
|
}
|
|
|
|
final Map<String, Object?> package = packageWhere(
|
|
(Map<String, Object?> package) => package['name'] == packageName,
|
|
reason: 'A package with name "$packageName" was not found',
|
|
);
|
|
|
|
// Do not traverse packages that themselves are dev dependencies.
|
|
if (package['kind'] == 'dev') {
|
|
return;
|
|
}
|
|
|
|
final List<String> directDependencies = asListOrFail(
|
|
package['directDependencies'],
|
|
'directDependencies',
|
|
);
|
|
|
|
// Remove any listed dependency from dev dependencies; it might have been
|
|
// a dev dependency for the app (root) package, but it is being used as a
|
|
// real dependency for a dependent on package, so we would not want to send
|
|
// a signal that the package can be ignored/removed.
|
|
devDependencies.removeAll(directDependencies);
|
|
|
|
// And continue visiting (visitPackage checks for circular loops).
|
|
directDependencies.forEach(visitPackage);
|
|
}
|
|
|
|
// Start with the root package.
|
|
visitPackage(rootPackage['name']! as String);
|
|
|
|
return devDependencies;
|
|
}
|