1f15e06e45
Previously, if a StatefulWidget was marked dirty, then removed from the build, then reinserted using the exact same widget under a widget under a LayoutBuilder, it wouldn't rebuild. This fixes that. It also introduces an assert that's supposed to catch SizeObserver-like behaviour. Rather than make this patch even bigger, I papered over two pre-existing bugs which this assert uncovered (and fixed the other problems it found): https://github.com/flutter/flutter/issues/5751 https://github.com/flutter/flutter/issues/5749 We should fix those before 1.0 though.
42 lines
1.4 KiB
Dart
42 lines
1.4 KiB
Dart
import 'dart:io';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:stocks/main.dart' as stocks;
|
|
import 'package:stocks/stock_data.dart' as stock_data;
|
|
|
|
const Duration kBenchmarkTime = const Duration(seconds: 15);
|
|
|
|
Future<Null> main() async {
|
|
assert(false); // don't run this in checked mode! Use --release.
|
|
stock_data.StockDataFetcher.actuallyFetchData = false;
|
|
|
|
final Stopwatch watch = new Stopwatch();
|
|
int iterations = 0;
|
|
|
|
await benchmarkWidgets((WidgetTester tester) async {
|
|
stocks.main();
|
|
await tester.pump(); // Start startup animation
|
|
await tester.pump(const Duration(seconds: 1)); // Complete startup animation
|
|
await tester.tapAt(new Point(20.0, 20.0)); // Open drawer
|
|
await tester.pump(); // Start drawer animation
|
|
await tester.pump(const Duration(seconds: 1)); // Complete drawer animation
|
|
|
|
|
|
final BuildableElement appState = tester.element(find.byType(stocks.StocksApp));
|
|
final BuildOwner buildOwner = WidgetsBinding.instance.buildOwner;
|
|
|
|
watch.start();
|
|
while (watch.elapsed < kBenchmarkTime) {
|
|
appState.markNeedsBuild();
|
|
buildOwner.buildScope(WidgetsBinding.instance.renderViewElement);
|
|
iterations += 1;
|
|
}
|
|
watch.stop();
|
|
});
|
|
|
|
print('Stock build: ${(watch.elapsedMicroseconds / iterations).toStringAsFixed(1)}µs per iteration');
|
|
exit(0);
|
|
}
|