
Towards https://github.com/flutter/flutter/issues/150575. Tries to remove as much `Usage` as possible while avoiding more complicated bits that require more scrutiny to make sure we aren't losing test coverage or otherwise regressing. Said another way, almost the entire diff is just deleting code to send GA3 events, and the corresponding GA4 code can be found right next to it—making it easy to verify we aren't losing events/tests. <details> <summary> Pre-launch checklist </summary> - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. </details> <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
215 lines
7.1 KiB
Dart
215 lines
7.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/src/base/logger.dart';
|
|
import 'package:flutter_tools/src/build_info.dart';
|
|
import 'package:flutter_tools/src/build_system/build_system.dart';
|
|
import 'package:flutter_tools/src/build_system/targets/web.dart';
|
|
import 'package:flutter_tools/src/dart/pub.dart';
|
|
import 'package:flutter_tools/src/features.dart';
|
|
import 'package:flutter_tools/src/project.dart';
|
|
import 'package:flutter_tools/src/reporting/reporting.dart';
|
|
import 'package:flutter_tools/src/web/compile.dart';
|
|
import 'package:flutter_tools/src/web/file_generators/flutter_service_worker_js.dart';
|
|
import 'package:unified_analytics/unified_analytics.dart';
|
|
|
|
import '../../src/common.dart';
|
|
import '../../src/context.dart';
|
|
import '../../src/fake_pub_deps.dart';
|
|
import '../../src/fakes.dart';
|
|
import '../../src/test_build_system.dart';
|
|
|
|
void main() {
|
|
late MemoryFileSystem fileSystem;
|
|
late TestUsage testUsage;
|
|
late FakeAnalytics fakeAnalytics;
|
|
late BufferLogger logger;
|
|
late FakeFlutterVersion flutterVersion;
|
|
late FlutterProject flutterProject;
|
|
|
|
// TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
|
|
// See https://github.com/flutter/flutter/issues/160257 for details.
|
|
FeatureFlags enableExplicitPackageDependencies() {
|
|
return TestFeatureFlags(
|
|
isExplicitPackageDependenciesEnabled: true,
|
|
// Assumed to be true below.
|
|
isWebEnabled: true,
|
|
);
|
|
}
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem.test();
|
|
testUsage = TestUsage();
|
|
logger = BufferLogger.test();
|
|
flutterVersion = FakeFlutterVersion(frameworkVersion: '1.0.0', engineRevision: '9.8.7');
|
|
fakeAnalytics = getInitializedFakeAnalyticsInstance(
|
|
fs: fileSystem,
|
|
fakeFlutterVersion: flutterVersion,
|
|
);
|
|
|
|
flutterProject = FlutterProject.fromDirectoryTest(fileSystem.currentDirectory);
|
|
|
|
fileSystem.directory('.dart_tool').childFile('package_config.json').createSync(recursive: true);
|
|
});
|
|
|
|
testUsingContext(
|
|
'WebBuilder sets environment on success',
|
|
() async {
|
|
final TestBuildSystem buildSystem = TestBuildSystem.all(BuildResult(success: true), (
|
|
Target target,
|
|
Environment environment,
|
|
) {
|
|
expect(target, isA<WebServiceWorker>());
|
|
expect(environment.defines, <String, String>{
|
|
'TargetFile': 'target',
|
|
'HasWebPlugins': 'false',
|
|
'ServiceWorkerStrategy': ServiceWorkerStrategy.offlineFirst.cliName,
|
|
'BuildMode': 'debug',
|
|
'DartObfuscation': 'false',
|
|
'TrackWidgetCreation': 'true',
|
|
'TreeShakeIcons': 'false',
|
|
});
|
|
|
|
expect(environment.engineVersion, '9.8.7');
|
|
expect(environment.generateDartPluginRegistry, isFalse);
|
|
});
|
|
|
|
final WebBuilder webBuilder = WebBuilder(
|
|
logger: logger,
|
|
processManager: FakeProcessManager.any(),
|
|
buildSystem: buildSystem,
|
|
flutterVersion: flutterVersion,
|
|
fileSystem: fileSystem,
|
|
analytics: fakeAnalytics,
|
|
);
|
|
await webBuilder.buildWeb(
|
|
flutterProject,
|
|
'target',
|
|
BuildInfo.debug,
|
|
ServiceWorkerStrategy.offlineFirst,
|
|
compilerConfigs: <WebCompilerConfig>[
|
|
const WasmCompilerConfig(optimizationLevel: 0, stripWasm: false),
|
|
const JsCompilerConfig.run(
|
|
nativeNullAssertions: true,
|
|
renderer: WebRendererMode.canvaskit,
|
|
),
|
|
],
|
|
);
|
|
|
|
expect(logger.statusText, contains('Compiling target for the Web...'));
|
|
expect(logger.errorText, isEmpty);
|
|
// Runs ScrubGeneratedPluginRegistrant migrator.
|
|
expect(logger.traceText, contains('generated_plugin_registrant.dart not found. Skipping.'));
|
|
|
|
expect(
|
|
fakeAnalytics.sentEvents,
|
|
containsAll(<Event>[
|
|
Event.flutterBuildInfo(
|
|
label: 'web-compile',
|
|
buildType: 'web',
|
|
settings: 'optimizationLevel: 0; web-renderer: skwasm,canvaskit; web-target: wasm,js;',
|
|
),
|
|
]),
|
|
);
|
|
|
|
expect(
|
|
analyticsTimingEventExists(
|
|
sentEvents: fakeAnalytics.sentEvents,
|
|
workflow: 'build',
|
|
variableName: 'dual-compile',
|
|
),
|
|
true,
|
|
);
|
|
},
|
|
overrides: <Type, Generator>{
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
FeatureFlags: enableExplicitPackageDependencies,
|
|
Pub: FakePubWithPrimedDeps.new,
|
|
},
|
|
);
|
|
|
|
testUsingContext(
|
|
'WebBuilder throws tool exit on failure',
|
|
() async {
|
|
final TestBuildSystem buildSystem = TestBuildSystem.all(
|
|
BuildResult(
|
|
success: false,
|
|
exceptions: <String, ExceptionMeasurement>{
|
|
'hello': ExceptionMeasurement(
|
|
'hello',
|
|
const FormatException('illegal character in input string'),
|
|
StackTrace.current,
|
|
),
|
|
},
|
|
),
|
|
);
|
|
|
|
final WebBuilder webBuilder = WebBuilder(
|
|
logger: logger,
|
|
processManager: FakeProcessManager.any(),
|
|
buildSystem: buildSystem,
|
|
flutterVersion: flutterVersion,
|
|
fileSystem: fileSystem,
|
|
analytics: fakeAnalytics,
|
|
);
|
|
await expectLater(
|
|
() async => webBuilder.buildWeb(
|
|
flutterProject,
|
|
'target',
|
|
BuildInfo.debug,
|
|
ServiceWorkerStrategy.offlineFirst,
|
|
compilerConfigs: <WebCompilerConfig>[
|
|
const JsCompilerConfig.run(
|
|
nativeNullAssertions: true,
|
|
renderer: WebRendererMode.canvaskit,
|
|
),
|
|
],
|
|
),
|
|
throwsToolExit(message: 'Failed to compile application for the Web.'),
|
|
);
|
|
|
|
expect(
|
|
logger.errorText,
|
|
contains('Target hello failed: FormatException: illegal character in input string'),
|
|
);
|
|
expect(testUsage.timings, isEmpty);
|
|
expect(fakeAnalytics.sentEvents, isEmpty);
|
|
},
|
|
overrides: <Type, Generator>{
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
FeatureFlags: enableExplicitPackageDependencies,
|
|
Pub: FakePubWithPrimedDeps.new,
|
|
},
|
|
);
|
|
|
|
Future<void> testRendererModeFromDartDefines(WebRendererMode webRenderer) async {
|
|
testUsingContext(
|
|
'WebRendererMode.${webRenderer.name} can be initialized from dart defines',
|
|
() {
|
|
final WebRendererMode computed = WebRendererMode.fromDartDefines(
|
|
webRenderer.dartDefines,
|
|
useWasm: true,
|
|
);
|
|
|
|
expect(computed, webRenderer);
|
|
},
|
|
overrides: <Type, Generator>{ProcessManager: () => FakeProcessManager.any()},
|
|
);
|
|
}
|
|
|
|
WebRendererMode.values.forEach(testRendererModeFromDartDefines);
|
|
|
|
testUsingContext(
|
|
'WebRendererMode.fromDartDefines sets a wasm-aware default for unknown dart defines.',
|
|
() async {
|
|
WebRendererMode computed = WebRendererMode.fromDartDefines(<String>{}, useWasm: false);
|
|
expect(computed, WebRendererMode.getDefault(useWasm: false));
|
|
|
|
computed = WebRendererMode.fromDartDefines(<String>{}, useWasm: true);
|
|
expect(computed, WebRendererMode.getDefault(useWasm: true));
|
|
},
|
|
);
|
|
}
|